[FFmpeg-devel] [PATCH] avcodec/bonk: check level value to not reach invalid values

2022-11-22 Thread Paul B Mahol
Patch attached. From 1b9204a39ea111f4fa34fe9cb4254dea2f20923d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 22 Nov 2022 11:27:39 +0100 Subject: [PATCH] avcodec/bonk: check level value to not reach invalid values Signed-off-by: Paul B Mahol --- libavcodec/bonk.c | 8 ++-- 1 file cha

[FFmpeg-devel] [PATCH 1/4] avutil/error: add a new error to signal processing got into an unrecoverable state

2022-11-22 Thread James Almer
Signed-off-by: James Almer --- libavutil/error.c | 1 + libavutil/error.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavutil/error.c b/libavutil/error.c index 938a8bc000..34970a42bc 100644 --- a/libavutil/error.c +++ b/libavutil/error.c @@ -48,6 +48,7 @@ static const struct error_ent

[FFmpeg-devel] [PATCH 2/4] avcodec/decode: allow the decoder to signal an unrecoverable error was found

2022-11-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 + libavcodec/decode.c | 17 - libavcodec/internal.h | 5 + 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index a85d3c2309..7818b6e33b 100644 --- a/libavco

[FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread James Almer
Based on a patch by Soft Works. Signed-off-by: James Almer --- libavutil/cuda_check.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/cuda_check.h b/libavutil/cuda_check.h index f5a9234eaf..33aaf9c098 100644 --- a/libavutil/cuda_check.h +++ b/libavutil/cuda_check.h @@ -49,6 +49

[FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: handle decoders returning AVERROR_UNRECOVERABLE

2022-11-22 Thread James Almer
Stop feeding them packets after this error is signaled but don't abort the process unless explicitly requested. For this, introduce a new abort_on flag. Signed-off-by: James Almer --- fftools/ffmpeg.c | 9 - fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_demux.c | 1 + fftools/ffmpe

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Timo Rothenpieler
On 22/11/2022 14:07, James Almer wrote: Based on a patch by Soft Works. Signed-off-by: James Almer --- libavutil/cuda_check.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/cuda_check.h b/libavutil/cuda_check.h index f5a9234eaf..33aaf9c098 100644 --- a/libavutil/cuda_check

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread James Almer
On 11/22/2022 10:21 AM, Timo Rothenpieler wrote: On 22/11/2022 14:07, James Almer wrote: Based on a patch by Soft Works. Signed-off-by: James Almer ---   libavutil/cuda_check.h | 4   1 file changed, 4 insertions(+) diff --git a/libavutil/cuda_check.h b/libavutil/cuda_check.h index f5a923

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, November 22, 2022 2:31 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > On 11/22/2022 10:21 AM, Timo Rothe

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread James Almer
On 11/22/2022 11:33 AM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, November 22, 2022 2:31 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed On 11/2

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Tuesday, November 22, 2022 2:31 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate >> AVERROR_UNRECOVERABLE when needed >> >> On 11/22/2

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, November 22, 2022 3:41 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > On 11/22/2022 11:33 AM, Soft Works

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Tuesday, November 22, 2022 3:48 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > Soft Works: > > > > > >> --

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Timo Rothenpieler
On 22/11/2022 14:31, James Almer wrote: On 11/22/2022 10:21 AM, Timo Rothenpieler wrote: On 22/11/2022 14:07, James Almer wrote: Based on a patch by Soft Works. Signed-off-by: James Almer ---   libavutil/cuda_check.h | 4   1 file changed, 4 insertions(+) diff --git a/libavutil/cuda_ch

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/flashsvenc: Fix packet size calculation

2022-11-22 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The earlier code did not account for the frame header as well > as the block headers; furthermore, in case a large part of > a block is unused (due to padding), the output size may > exceed 3 * width * height (where the dimensions correspond > to the visible pixels) due to the

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Timo Rothenpieler > Sent: Tuesday, November 22, 2022 4:16 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > > > On 22/11/2022 14:31, J

[FFmpeg-devel] [PATCH v4] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Ruijing Dong
Add flag AV_VAAPI_DRIVER_QUIRK_DIRCT_FILM_GRAIN_ATTRIBUTES to specify a direct film grain mode for AMD av1 decoder. issue: By using AMD av1 decoder via VAAPI, when used with film grain content, the output displays black screen with incorrect frame order. The issue being discussed in here: https:/

Re: [FFmpeg-devel] [PATCH] avcodec/pnm: avoid mirroring PFM images vertically

2022-11-22 Thread Leo Izen
On 11/16/22 06:43, Leo Izen wrote: PFM (aka Portable FloatMap) encodes its scanlines from bottom-to-top, not from top-to-bottom, unlike other NetPBM formats. Without this patch, FFmpeg ignores this exception and decodes/encodes PFM images mirrored vertically from their proper orientation. For re

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Tuesday, November 22, 2022 3:41 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > On 11/22/2022 11:33 AM, Soft Works

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Dong, Ruijing
[AMD Official Use Only - General] Hi Mark, Sorry for being late to reply to you. Your understanding is correct, and I have sent a new patch [v4] for addressing the current issue and to use driver quirk mechanism to specify only AMD VAAPI driver has this behavior, then this could be more specif

Re: [FFmpeg-devel] [PATCH] avcodec/bonk: check level value to not reach invalid values

2022-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2022 at 11:26:48AM +0100, Paul B Mahol wrote: > Patch attached. > bonk.c |8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > 84abac919e9c120e48bb1a3f84be0697f620b66a > 0001-avcodec-bonk-check-level-value-to-not-reach-invalid-.patch > From 1b9204a39ea111f4fa34fe9

Re: [FFmpeg-devel] [PATCH v4 1/4] swscale/input: add rgbaf32 input support

2022-11-22 Thread Michael Niedermayer
On Mon, Nov 21, 2022 at 02:11:43PM -0800, mindm...@gmail.com wrote: > From: Mark Reid > > --- > libswscale/input.c | 120 + > libswscale/utils.c | 6 +++ > 2 files changed, 126 insertions(+) > > diff --git a/libswscale/input.c b/libswscale/input.c >

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
On 22/11/2022 19:18, Dong, Ruijing wrote: [AMD Official Use Only - General] Hi Mark, Sorry for being late to reply to you. Your understanding is correct, and I have sent a new patch [v4] for addressing the current issue and to use driver quirk mechanism to specify only AMD VAAPI driver has th

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
On 22/11/2022 20:26, Mark Thompson wrote: On 22/11/2022 19:18, Dong, Ruijing wrote: [AMD Official Use Only - General] Hi Mark, Sorry for being late to reply to you. Your understanding is correct, and I have sent a new patch [v4] for addressing the current issue and to use driver quirk mechan

Re: [FFmpeg-devel] [PATCH v4 1/4] swscale/input: add rgbaf32 input support

2022-11-22 Thread Mark Reid
On Tue, Nov 22, 2022 at 11:43 AM Michael Niedermayer wrote: > On Mon, Nov 21, 2022 at 02:11:43PM -0800, mindm...@gmail.com wrote: > > From: Mark Reid > > > > --- > > libswscale/input.c | 120 + > > libswscale/utils.c | 6 +++ > > 2 files changed, 12

Re: [FFmpeg-devel] [PATCH 3/3] avformat/electronicarts: add option to return alpha channel in the main video stream in VP6A codec

2022-11-22 Thread Marton Balint
On Thu, 17 Nov 2022, Peter Ross wrote: On Mon, Nov 14, 2022 at 11:05:44PM +0100, Marton Balint wrote: On Mon, 14 Nov 2022, Anton Khirnov wrote: Quoting Marton Balint (2022-11-13 19:44:41) Signed-off-by: Marton Balint --- doc/demuxers.texi| 18 libavformat/

Re: [FFmpeg-devel] [PATCH v4 1/4] swscale/input: add rgbaf32 input support

2022-11-22 Thread Michael Niedermayer
On Tue, Nov 22, 2022 at 01:17:09PM -0800, Mark Reid wrote: > On Tue, Nov 22, 2022 at 11:43 AM Michael Niedermayer > wrote: > > > On Mon, Nov 21, 2022 at 02:11:43PM -0800, mindm...@gmail.com wrote: > > > From: Mark Reid > > > > > > --- > > > libswscale/input.c | 120 +

[FFmpeg-devel] [PATCH 1/2] avcodec/pictordec: Check that the image fits in the input

2022-11-22 Thread Michael Niedermayer
Fixes: Timeout Fixes: 53438/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PICTOR_fuzzer-5458939919859712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpe Signed-off-by: Michael Niedermayer --- libavcodec/pictordec.c | 3 +++ 1 file changed,

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1dec: restructure slice coordinate reading a bit

2022-11-22 Thread Michael Niedermayer
Fixes: signed integer overflow: -1094995528 * 8224 cannot be represented in type 'int' Fixes: 53508/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-474551033462784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Timo Rothenpieler
On 22.11.2022 17:02, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Timo Rothenpieler Sent: Tuesday, November 22, 2022 4:16 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed On

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Mark Thompson
On 22/11/2022 20:59, Mark Thompson wrote: On 22/11/2022 20:26, Mark Thompson wrote: On 22/11/2022 19:18, Dong, Ruijing wrote: [AMD Official Use Only - General] Hi Mark, Sorry for being late to reply to you. Your understanding is correct, and I have sent a new patch [v4] for addressing the c

Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate AVERROR_UNRECOVERABLE when needed

2022-11-22 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Timo Rothenpieler > Sent: Tuesday, November 22, 2022 11:59 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avutil/cuda_check: propagate > AVERROR_UNRECOVERABLE when needed > > On 22.11.2022 17:02, Soft W

Re: [FFmpeg-devel] [PATCH v4 1/4] swscale/input: add rgbaf32 input support

2022-11-22 Thread Mark Reid
On Tue, Nov 22, 2022 at 2:43 PM Michael Niedermayer wrote: > On Tue, Nov 22, 2022 at 01:17:09PM -0800, Mark Reid wrote: > > On Tue, Nov 22, 2022 at 11:43 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Mon, Nov 21, 2022 at 02:11:43PM -0800, mindm...@gmail.com wrote: > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/av1_vaapi: add direct film grain mode

2022-11-22 Thread Dong, Ruijing
[AMD Official Use Only - General] Hi Mark, Just got the ffmpeg email, please see my answer below in [rdong]. Thanks, Ruijing -Original Message- From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Tuesday, November 22, 2022 6:34 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

2022-11-22 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Sunday, July 3, 2022 12:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Andreas Rheinhardt >> Subject: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper >> type for NALU type >> >

Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

2022-11-22 Thread Soft Works
> -Original Message- > From: Andreas Rheinhardt > Sent: Wednesday, November 23, 2022 4:20 AM > To: Soft Works ; FFmpeg development > discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use > proper type for NALU type > > Soft Works: > > > > > >> -

Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

2022-11-22 Thread Soft Works
> -Original Message- > From: Andreas Rheinhardt > Sent: Wednesday, November 23, 2022 4:20 AM > To: Soft Works ; FFmpeg development > discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use > proper type for NALU type > > Soft Works: > > > > > >> -