Re: [FFmpeg-devel] Ffmpeg/ffprobe not work well with a DASH stream

2022-11-18 Thread Steven Liu
Chang, Xiangzhong 于2022年11月17日周四 22:00写道: > > Hi, > > Thank you so much for this amazing project. I’ve found this project has been > extremely useful for me. > I’ve found out that ffmpeg/ffplay does not work well with one of our DASH > streams. In comparison, I’ve tried the following players > >

Re: [FFmpeg-devel] Ffmpeg/ffprobe not work well with a DASH stream

2022-11-18 Thread Chang, Xiangzhong
Thank you, Steve, I’ve synced my code base to your commit#. I tried to configure the code as much like yours as possible. But mine is a Linux box on HP laptop. For me, the result remains the same �C ffprobe_g was unable to detect the stream type. chang@640g2:~/git-root/FFmpeg$ ./ffprobe_g --ve

[FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-18 Thread Ronald S. Bultje
From: Hirokazu Honda The check of vpx_rac_is_end check(s) are added originally from 1afd246960202917e244c844c534e9c1e3c323f5. It causes a regression of some vp8 stream. b6b9ac5698c8f911841b469af77199153278c55c fixes the regression by a sort of band-aid way. This fixes the wrongness of the origina

[FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-18 Thread Ronald S. Bultje
From: Hirokazu Honda The check of vpx_rac_is_end check(s) are added originally from 1afd246960202917e244c844c534e9c1e3c323f5. It causes a regression of some vp8 stream. b6b9ac5698c8f911841b469af77199153278c55c fixes the regression by a sort of band-aid way. This fixes the wrongness of the origina

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_libplacebo: default to normalize_sar=0

2022-11-18 Thread Niklas Haas
From: Niklas Haas As a result of a typo in the source code, this option was completely non-functional. In order to fix it, without breaking the current default (and, upon reconsideration, probably preferred) behavior, explicitly change this default to 0. --- doc/filters.texi| 7 -

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_libplacebo: fix normalize_sar calculation

2022-11-18 Thread Niklas Haas
From: Niklas Haas This previous expression multiplied a constant (outlink->h) that was guaranteed to be 0 at this point, thus making it always a no-op. Fix the calculation, and also properly reset the SAR to 1:1 as is now necessary (the failure to do so previously hid this bug's existence). ---

[FFmpeg-devel] [PATCH] avcodec/av1_vaapi: add direct film grain mode

2022-11-18 Thread Ruijing Dong
Adding direct film grain mode for av1 decoder, which outputs alongside film grain. AV_HWACCEL_FLAG_DIRECT_FILM_GRAIN is the new flag introduced to enable this path. issue: By using AMD av1 decoder via VAAPI, when used with film grain content, the output displays black screen with incorrect frame

[FFmpeg-devel] [PATCH] avformat/file: add fd protocol

2022-11-18 Thread Zhao Zhili
From: Zhao Zhili Unlike the pipe protocol, fd protocol has seek support if it corresponding to a regular file. --- Sometimes it's the only way to access files via file descriptor, e.g., requesting a shared file on Android: https://developer.android.com/training/secure-file-sharing/request-file

[FFmpeg-devel] hashing audio streams beyond pcm_s16le

2022-11-18 Thread Peter B.
Hello everyone :) I was wondering about the behavior of FFmpeg's hashing muxer for audio streams: For example: With a 32bit float (f32le) source, FFmpeg seems to be able to generate a hash for the f32le source - but only if I explicitly know (and then tell) FFmpeg to do so. By default, I ge

[FFmpeg-devel] [PATCH 1/4] avcodec/tiff: Ignore tile_count

2022-11-18 Thread Michael Niedermayer
Fixes: out of array access Fixes: 52427/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4849108968144896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 2/4] avformat/id3v2: Check taglen in read_uslt()

2022-11-18 Thread Michael Niedermayer
Fixes: Timeout (read mostly the same data repeatly) Fixes: 52457/clusterfuzz-testcase-minimized-ffmpeg_dem_ALP_fuzzer-6610706313379840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/id3v2.c

[FFmpeg-devel] [PATCH 3/4] avcodec/mobiclip: Check input size before (re)allocation

2022-11-18 Thread Michael Niedermayer
Fixes: Timeout Fixes: 52566/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-4913160050311168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mobiclip.c | 3 +++ 1 file change

[FFmpeg-devel] [PATCH 4/4] avcodec/vqcdec: Check for end of input in decode_vectors()

2022-11-18 Thread Michael Niedermayer
Fixes: Timeout Fixes: 52695/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQC_fuzzer-4882310386548736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vqcdec.c | 14 ++ 1 file c

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vqcdec: Check for end of input in decode_vectors()

2022-11-18 Thread Peter Ross
On Fri, Nov 18, 2022 at 10:09:18PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 52695/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQC_fuzzer-4882310386548736 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mobiclip: Check input size before (re)allocation

2022-11-18 Thread Shiyou Yin
Please ignore fail info form loongarch64 patchwork temporarily. I have stoped the service from Nov 16th, but there are still result post to patchwork. Have mailed to Andriy to help analyze this problem together. > 2022年11月19日 05:09,Michael Niedermayer 写道: > > Fixes: Timeout > Fixes: > 52566/cl

[FFmpeg-devel] [PATCH 1/7] avcodec/pnmenc: Check av_image_get_buffer_size()

2022-11-18 Thread Andreas Rheinhardt
Fixes the crash in ticket #10050. Also ensure that we don't overflow before ff_get_encode_buffer(). Signed-off-by: Andreas Rheinhardt --- libavcodec/pnmenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/pnmenc.c b/libavcodec/pnmenc.c index 9eb663306d..c998dd

[FFmpeg-devel] [PATCH 2/7] avcodec/flashsvenc: Account for header in packet size

2022-11-18 Thread Andreas Rheinhardt
Fixes ticket #10053. Signed-off-by: Andreas Rheinhardt --- libavcodec/flashsvenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index 35793400fa..9d065bb92d 100644 --- a/libavcodec/flashsvenc.c +++ b/libavcodec/flashsvenc

[FFmpeg-devel] [PATCH 3/7] avcodec/flashsvenc: Remove unused buffer

2022-11-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flashsvenc.c | 9 - 1 file changed, 9 deletions(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index 9d065bb92d..0618b2aa1b 100644 --- a/libavcodec/flashsvenc.c +++ b/libavcodec/flashsvenc.c @@ -60,7 +60,6 @@ typedef str

[FFmpeg-devel] [PATCH 4/7] avcodec/flashsvenc: Use const where appropriate

2022-11-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flashsvenc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index 0618b2aa1b..18dfde0e24 100644 --- a/libavcodec/flashsvenc.c +++ b/libavcodec/flashsvenc.c @@ -66,15 +6

[FFmpeg-devel] [PATCH 5/7] avcodec/flashsvenc: Change check for first frame

2022-11-18 Thread Andreas Rheinhardt
AVCodecContext.frame_number is actually only incremented in case encoding was successfull; if e.g. the ff_alloc_packet() below fails, it won't be incremented and therefore it is possible for the previous_frame buffer to be allocated for multiple first frames, leaking every one except the last. So c

[FFmpeg-devel] [PATCH 6/7] avcodec/flashsvenc: Avoid copying frame

2022-11-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flashsvenc.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index f42ef73b37..3c3d9c8813 100644 --- a/libavcodec/flashsvenc.c +++ b/libavc

[FFmpeg-devel] [PATCH 7/7] avcodec/flashsvenc: Avoid unnecessary variable

2022-11-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flashsvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index 3c3d9c8813..89119733df 100644 --- a/libavcodec/flashsvenc.c +++ b/libavcodec/flashsvenc.c @@ -195,7 +195,6