Re: [FFmpeg-devel] [PATCH] avcodec: Vorbis decode: don't use a flag to determine if frames have been output

2022-10-17 Thread Hendrik Leppkes
On Thu, Sep 8, 2022 at 10:26 AM wrote: > > From: Jyrki Vesterinen > > If a developer using FFmpeg libraries seeks into an earlier position and calls > avcodec_flush_buffers() afterwards as recommended, the Vorbis decoder will > drop > the next frame, since buffer flushing clears the first_frame

Re: [FFmpeg-devel] [PATCH] avcodec: Vorbis decode: don't use a flag to determine if frames have been output

2022-10-17 Thread Paul B Mahol
On 10/17/22, Hendrik Leppkes wrote: > On Thu, Sep 8, 2022 at 10:26 AM wrote: >> >> From: Jyrki Vesterinen >> >> If a developer using FFmpeg libraries seeks into an earlier position and >> calls >> avcodec_flush_buffers() afterwards as recommended, the Vorbis decoder will >> drop >> the next fram

Re: [FFmpeg-devel] [PATCH v5] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-10-17 Thread Wang, Bin
-Original Message- From: ffmpeg-devel On Behalf Of Wang, Bin Sent: Monday, September 26, 2022 4:56 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v5] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI -Original Messag

Re: [FFmpeg-devel] [PATCH] avcodec: Vorbis decode: don't use a flag to determine if frames have been output

2022-10-17 Thread Hendrik Leppkes
On Mon, Oct 17, 2022 at 10:18 AM Paul B Mahol wrote: > > On 10/17/22, Hendrik Leppkes wrote: > > On Thu, Sep 8, 2022 at 10:26 AM wrote: > >> > >> From: Jyrki Vesterinen > >> > >> If a developer using FFmpeg libraries seeks into an earlier position and > >> calls > >> avcodec_flush_buffers() aft

[FFmpeg-devel] [PATCH] avcodec/mpegaudiodec_common: fix values for 24k sample rate

2022-10-17 Thread Paul B Mahol
Patch attached. From 5a068e66a9666a0a1c22c68315ec116c04e9c129 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 17 Oct 2022 10:46:34 +0200 Subject: [PATCH] avcodec/mpegaudiodec_common: fix values for 24k sample rate Signed-off-by: Paul B Mahol --- libavcodec/mpegaudiodec_common.c | 2 +- 1

Re: [FFmpeg-devel] [PATCH v3 00/54] Various Doxygen fixes

2022-10-17 Thread Anton Khirnov
Set pushed (with some trailing whitespace fixes). -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with su

Re: [FFmpeg-devel] [PATCH 01/13] fftools/ffmpeg_mux: do not unref a NULL packet

2022-10-17 Thread Anton Khirnov
Will push the set tomorrow if nobody wants to comment. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wi

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-17 Thread Peter Ross
On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes ticket #128. > > > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > > in our SVQ1 implementation, resulting in visible artifacts for some videos. > > This patch unswaps the orde

Re: [FFmpeg-devel] [PATCH v6 1/2] ffmpeg: Add display_{rotation, hflip, vflip} options

2022-10-17 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-10-15 12:27:54) > > av_stream_new_side_data() returns uint8_t*. > > So it is either add a cast to if(...) or two casts to av_display_...(). Better to have one cast than two. (I also prefer to avoid assignments inside conditions, but not going to bitch about this very

[FFmpeg-devel] [PATCH 0/4] Provide neon implementations for hscale functions

2022-10-17 Thread Hubert Mazur
Provide arm64 neon optimized functions from swscale family. Hubert Mazur (4): sw_scale: Add specializations for hscale 8 to 19 tests/sw_scale: Add test cases for input sizes 16 sw_scale: Add specializations for hscale 16 to 15 sw_scale: Add specializations for hscale 16 to 19 libswscale/

[FFmpeg-devel] [PATCH 1/4] sw_scale: Add specializations for hscale 8 to 19

2022-10-17 Thread Hubert Mazur
Add arm64 neon implementations for hscale 8 to 19 with filter sizes 4, 4X and 8. Both implementations are based on very similar ones dedicated to hscale 8 to 15. The major changes refer to saving the data - instead of writing the result as int16_t it is done with int32_t. These functions are heavi

[FFmpeg-devel] [PATCH 2/4] tests/sw_scale: Add test cases for input sizes 16

2022-10-17 Thread Hubert Mazur
Previously test cases handled only input sizes equal to 8. Add support for input size 16 which is used by scaling routines hscale16To15 and hscale16To19. Pass SwsContext pointer to each function as some of them make use of it. Signed-off-by: Hubert Mazur --- tests/checkasm/sw_scale.c | 35 ++

[FFmpeg-devel] [PATCH 3/4] sw_scale: Add specializations for hscale 16 to 15

2022-10-17 Thread Hubert Mazur
Add arm64 neon implementations for hscale 16 to 15 with filter sizes 4, 8 and X4. The tests and benchmarks run on AWS Graviton 2 instances. The results from a checkasm tool are shown below. hscale_16_to_15__fs_4_dstW_512_c: 6703.5 hscale_16_to_15__fs_4_dstW_512_neon: 2298.0 hscale_16_to_15__fs_8_

[FFmpeg-devel] [PATCH 4/4] sw_scale: Add specializations for hscale 16 to 19

2022-10-17 Thread Hubert Mazur
Provide arm64 neon optimized implementations for hscale16To19 with filter sizes 4, 8 and X4. The tests and benchmarks run on AWS Graviton 2 instances. The results from a checkasm tool are shown below. hscale_16_to_19__fs_4_dstW_512_c: 6216.0 hscale_16_to_19__fs_4_dstW_512_neon: 2257.0 hscale_16_t

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpegtables: Mark jpegtables as hidden

2022-10-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > These tables are not exported as avpriv symbols, but instead > included into every library using them. Therefore they > can be mark with the hidden elf visibility. For certain arches > this is necessary in order to avoid building suboptimal code; > for other arches it just all

Re: [FFmpeg-devel] [PATCH v2] avcodec/startcode: Avoid unaligned accesses

2022-10-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, ff_startcode_find_candidate_c() simply casts > an uint8_t* to uint64_t*/uint32_t* to read 64/32 bits at a time > in case HAVE_FAST_UNALIGNED is true. Yet this ignores the > alignment requirement of these types as well as effective type > rules of the C standard.

Re: [FFmpeg-devel] [PATCHv2] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-17 Thread Andreas Rheinhardt
Peter Ross: > Duplicates of the standard JPEG quantization tables were found in the > AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, > placing a single copy in jpegquanttables.c. > --- > libavcodec/Makefile | 8 ++--- > libavcodec/agm.c | 27 -

[FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-10-17 Thread Eran Kornblau
Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI messages. The option name/implementation is aligned with the corresponding libx264 feature. Thanks Eran 0001-libx265-support-ATSC-A-53-captions.patch Description: 0001-libx265-support-ATSC-A-53-captions.patch ___

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2022 at 08:33:28PM +1100, Peter Ross wrote: > On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > > Peter Ross: > > > Fixes ticket #128. > > > > > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > > > in our SVQ1 implementation, resulti

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-17 Thread Peter Ross
On Mon, Oct 17, 2022 at 10:38:53PM +0200, Michael Niedermayer wrote: > On Mon, Oct 17, 2022 at 08:33:28PM +1100, Peter Ross wrote: > > On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > > > Peter Ross: > > > > Fixes ticket #128. > > > > > > > > The SVQ1 interframe mean VLC symbo

[FFmpeg-devel] [PATCH 1/3] lavc/qsvenc: fix check to avoid segfault

2022-10-17 Thread haihao . xiang-at-intel . com
From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 15e6936a65..19fe6e59a2 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -2093,8 +2093,8 @@

[FFmpeg-devel] [PATCH 2/3] lavc/qsvenc: enlarge the maximum number of ExtParam buffers on mfxEncodeCtrl

2022-10-17 Thread haihao . xiang-at-intel . com
From: Haihao Xiang The next commit and other commits in future will use more ExtParam buffers. And combine 2 free functions into single one Signed-off-by: Haihao Xiang --- libavcodec/qsv_internal.h | 2 +- libavcodec/qsvenc.c | 27 --- 2 files changed, 9 inserti

[FFmpeg-devel] [PATCH 3/3] lavc/qsvenc_hevc: accept HDR metadata if have

2022-10-17 Thread haihao . xiang-at-intel . com
From: Haihao Xiang The SDK may accept HDR metadata via mfxEncodeCtrl::ExtParam Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_hevc.c | 80 1 file changed, 80 insertions(+) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 2a3f34

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Differentiate unassigned and zero attributes

2022-10-17 Thread Gregor Riepl
+#include Not sure this header can be used every enveriment. Or what about use #define TRUE 1 #define FALSE 0 > ? You are right, this is C99. I'd rather not define a custom boolean type just for this, it would be better if FFmpeg had something like FF_TRUE/FF_FALSE. fftools/ffmpeg_opt.c se