Re: [FFmpeg-devel] [PATCH v6 1/2] ffmpeg: Add display_{rotation, hflip, vflip} options

2022-10-04 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-09-26 07:57:52) > From: Jan Ekström > > This enables overriding the rotation as well as horizontal/vertical > flip state of a specific video stream on the input side. > > Additionally, switch the singular test that was utilizing the rotation > metadata to instead ove

Re: [FFmpeg-devel] [PATCH v6 2/2] ffmpeg: Deprecate display rotation override with a metadata key

2022-10-04 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-09-26 07:57:53) > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index f07858333d..3f2409ee28 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -2859,16 +2859,26 @@ static void of_add_metadata(AVFormatContext *oc, > const OptionsContext

Re: [FFmpeg-devel] [PATCH] fixed_dsp: add missing av_restrict qualifiers

2022-10-04 Thread Anton Khirnov
Quoting Johannes Kauffmann (2022-09-25 00:41:18) > The butterflies_fixed function pointer declaration specifies av_restrict > for the first two pointer arguments. So the corresponding function > definitions should honor this declaration. > > MSVC emits warning C4113 for this. > --- > libavutil/fi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: remove a call to avio_tell()

2022-10-04 Thread Anton Khirnov
Quoting Zhao Zhili (2022-09-25 06:28:41) > From: Zhao Zhili > > --- > libavformat/mp3dec.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index a9e494452d..05c13228bc 100644 > --- a/libavformat/mp3dec.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890)

2022-10-04 Thread Anton Khirnov
Quoting Tristan Matthews (2022-09-30 15:53:48) > These shorter samples have been updated by James Almer, so this patch > is good to go Will push soonish. Thanks for the patches. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH 1/3] lavc/encode: make sure frame timebase matches encoder, when set

2022-10-04 Thread Anton Khirnov
Quoting Marton Balint (2022-09-28 21:54:11) > > > On Wed, 28 Sep 2022, Anton Khirnov wrote: > > > AVFrame.time_base has been added recently, but is currently not used for > > anything. Prepare for its use in encoders by rejecting frames where > > time_base is set, but differs from the AVCodecCon

Re: [FFmpeg-devel] Need to reduce size of ffmpeg.exe for version 5.0.1

2022-10-04 Thread Martijn van Beurden
Op ma 3 okt. 2022 om 22:14 schreef Kumar, Rahul : > Can somebody help me answering below questions : > > 1. Can we reduce the size of ffmpeg.exe ? Any idea how can we create a > smaller ffmpeg.exe which should be able to run only above command to convert > RTSP to HLS? (as its size is 110 mb+ so

Re: [FFmpeg-devel] [PATCH v2 0/7] arm64 neon implementation for 8bits functions

2022-10-04 Thread Martin Storsjö
On Mon, 3 Oct 2022, Grzegorz Bernacki wrote: Changes since v1: - changed tabs to spaces - modified branch instruction in vsse8 - apply Martin's patches with improved instructions scheduling Grzegorz Bernacki (4): lavc/aarch64: Add neon implementation for pix_abs8 functions. lavc/aarch64: P

[FFmpeg-devel] [PATCH 10/10] avcodec/opus, opus_celt: Fix header descriptions

2022-10-04 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h | 2 +- libavcodec/opus_celt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/opus.h b/libavcodec/opus.h index 80d685d47c..4d061cf5f8 100644 --- a/libavcodec/opus.h +++ b/libavcodec/opus.h @@ -1,5 +1,5

Re: [FFmpeg-devel] [PATCH v2 0/7] arm64 neon implementation for 8bits functions

2022-10-04 Thread Grzegorz Bernacki
Great!! Thanks a lot for your help and your review. thanks, greg wt., 4 paź 2022 o 12:57 Martin Storsjö napisał(a): > On Mon, 3 Oct 2022, Grzegorz Bernacki wrote: > > > Changes since v1: > > > > - changed tabs to spaces > > - modified branch instruction in vsse8 > > - apply Martin's patches with

Re: [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-10-04 Thread Anton Khirnov
Quoting Timo Rothenpieler (2022-10-01 13:24:26) > On 01.10.2022 08:13, OvchinnikovDmitrii wrote: > > --- > > libavcodec/avcodec.h | 8 > > libavcodec/codec_par.h | 8 > > 2 files changed, 16 insertions(+) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > >

Re: [FFmpeg-devel] [crop support for matroska demuxer 2/3] libavcodec: Public code to support container crop

2022-10-04 Thread Anton Khirnov
Quoting Hendrik Leppkes (2022-10-01 09:16:20) > Somehow I don't feel like adding the two crops together is really > going to do what most users would expect to happen. It just feels > weird. > It also changes the decoder crop information, and an API user does not > get the pure information from the

Re: [FFmpeg-devel] [crop support for matroska demuxer 1/3] libavcodec: Add crop related fields to structure AVCodecContext and AVCodecParameters.

2022-10-04 Thread James Almer
On 10/1/2022 4:06 AM, Hendrik Leppkes wrote: On Sat, Oct 1, 2022 at 8:14 AM OvchinnikovDmitrii wrote: --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 16 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 7365eb5cc0..

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/opustab: Avoid indirection to access ff_celt_window

2022-10-04 Thread Michael Niedermayer
On Tue, Oct 04, 2022 at 12:44:58AM +0200, Andreas Rheinhardt wrote: > Currently, it is accessed via a pointer (ff_celt_window) > exported from opustab.h which points inside a static array > (ff_celt_window_padded) in opustab.h. Instead export > ff_celt_window_padded directly and make opustab.h > a

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/opustab: Avoid indirection to access ff_celt_window

2022-10-04 Thread Andreas Rheinhardt
Michael Niedermayer: > On Tue, Oct 04, 2022 at 12:44:58AM +0200, Andreas Rheinhardt wrote: >> Currently, it is accessed via a pointer (ff_celt_window) >> exported from opustab.h which points inside a static array >> (ff_celt_window_padded) in opustab.h. Instead export >> ff_celt_window_padded direc

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Tomas Härdin
mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > Thanks, Pierre-Anthony. I've updated the patch to remove the > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > packet. > > Signed-off-by: Richard Ayres > --- >  libavformat/mxfdec.c | 4 ++-- >  1 file changed, 2 inse

[FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Use av_err2str

2022-10-04 Thread Marvin Scholz
av_err2str which is a wrapper for av_strerror already calls strerror_r if available and if not has a fallback for the other error codes that would be handled by that, so manually calling strerror again if it fails is not necessary. --- fftools/cmdutils.c | 7 +-- 1 file changed, 1 insertion(+)

[FFmpeg-devel] [PATCH 2/3] fftools/ffprobe: Use av_err2str

2022-10-04 Thread Marvin Scholz
av_err2str which is a wrapper for av_strerror already calls strerror_r if available and if not has a fallback for the other error codes that would be handled by that, so manually calling strerror again if it fails is not necessary. --- fftools/ffprobe.c | 8 +--- 1 file changed, 1 insertion(+)

[FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_opt: Use av_err2str

2022-10-04 Thread Marvin Scholz
This simplifies the code as there is no other place the error buffer is needed, so the av_err2str helper macro can be used. --- fftools/ffmpeg_opt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 8f57b699f1..272a772283 10064

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/sgidec: Avoid redundant private context

2022-10-04 Thread Tomas Härdin
fre 2022-09-30 klockan 19:05 +0200 skrev Andreas Rheinhardt: > SGI is intra-frame only; the decoder therefore does not > maintain any state between frames, so remove > the private context. > > Also rename depth to nb_components. > > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/sgidec.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] x86/lpc: implement a new Welch windowing function

2022-10-04 Thread Michael Niedermayer
On Wed, Sep 21, 2022 at 05:12:52AM +, Lynne wrote: > ffmpeg | branch: master | Lynne | Mon Sep 19 23:48:53 2022 > +0200| [3ade6a8644ab519fcd7caa7ef457dd406162bc14] | committer: Lynne > > x86/lpc: implement a new Welch windowing function > > Old one was written with the assumption only even

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > Thanks, Pierre-Anthony. I've updated the patch to remove the > > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > > packet. > > > > Signed-off-by: Richard Ayres

Re: [FFmpeg-devel] [PATCH v6 0/3] 32bps FLAC patches

2022-10-04 Thread Martijn van Beurden
Op vr 16 sep. 2022 om 22:14 schreef Martijn van Beurden : > > Recently libFLAC gained the ability (first released in FLAC 1.4.0) > to create FLAC files containing 32-bit int PCM samples. To > keep complexity reasonable, the choice was made to limit residuals > to 32-bit integers, which the encoder

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Tomas Härdin
tis 2022-10-04 klockan 07:50 -0700 skrev Pierre-Anthony Lemieux: > On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > > Thanks, Pierre-Anthony. I've updated the patch to remove the > > > unnecessary UL and it's now using mxf_matc

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:59 AM Tomas Härdin wrote: > > tis 2022-10-04 klockan 07:50 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > > > > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > > > Thanks, Pierre-Anthony. I've updated the patch

Re: [FFmpeg-devel] [PATCH v6 2/3] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-10-04 Thread Andreas Rheinhardt
Martijn van Beurden: > Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. > Coding to this format is at this point considered experimental and > -strict experimental is needed to get ffmpeg to encode such files. > --- > libavcodec/flacenc.c| 518

Re: [FFmpeg-devel] [PATCH v6 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-10-04 Thread Andreas Rheinhardt
Martijn van Beurden: > --- > tests/fate/flac.mak | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak > index 115cc965e1..3424b2bf82 100644 > --- a/tests/fate/flac.mak > +++ b/tests/fate/flac.mak > @@ -6,6 +6,7 @@ FATE_FLAC += fate-flac-16-chmode-

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: drop the -async option

2022-10-04 Thread Michael Niedermayer
On Tue, Oct 04, 2022 at 09:56:29AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Tue Aug 30 > 11:14:13 2022 +0200| [3d86a13b47b726e49c2d780c5f723c290e8a36b4] | committer: > Anton Khirnov > > fftools/ffmpeg: drop the -async option > > It has been deprecated in favor of

Re: [FFmpeg-devel] [PATCH] avcodec/asv: Split ASV1Context into decoder and encoder contexts

2022-10-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > A lot of the stuff in ASV1Context is actually only used > by decoders or encoders, but not both: Of the seven contexts > in ASV1Context, only the BswapDSPContext is used by both. > So splitting makes sense. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/asv.c|

[FFmpeg-devel] [PATCH 2/3] lavc/alacdsp: RISC-V V append_extra_bits[0]

2022-10-04 Thread remi
From: Rémi Denis-Courmont --- libavcodec/riscv/alacdsp_init.c | 8 +++- libavcodec/riscv/alacdsp_rvv.S | 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/riscv/alacdsp_init.c b/libavcodec/riscv/alacdsp_init.c index 9ddebaa60b..37688be67b 1006

[FFmpeg-devel] [PATCH 3/3] lavc/alacdsp: RISC-V V append_extra_bits[1]

2022-10-04 Thread remi
From: Rémi Denis-Courmont --- libavcodec/riscv/alacdsp_init.c | 5 + libavcodec/riscv/alacdsp_rvv.S | 27 +++ 2 files changed, 32 insertions(+) diff --git a/libavcodec/riscv/alacdsp_init.c b/libavcodec/riscv/alacdsp_init.c index 37688be67b..fa8a7c8129 100644 --- a/

[FFmpeg-devel] [PATCH 1/3] lavc/alacdsp: RISC-V V decorrelate_stereo

2022-10-04 Thread remi
From: Rémi Denis-Courmont To avoid data dependencies, this does the following unroll, which requires one extra but probably free addition: coeff = (b * left_weight) >> decorr_shift; b += a; a -= coeff; b -= coeff; swap(a, b); --- libavcodec/alacdsp.c| 4 ++- lib

[FFmpeg-devel] [PATCH] riscv: remove unnecessary #include's

2022-10-04 Thread Rémi Denis-Courmont
Pointed out by Andreas Rheinhardt. --- libavcodec/riscv/fmtconvert_rvv.S | 1 - libavcodec/riscv/idctdsp_rvv.S | 1 - libavcodec/riscv/pixblockdsp_rvi.S | 1 - libavcodec/riscv/pixblockdsp_rvv.S | 1 - libavcodec/riscv/vorbisdsp_rvv.S | 1 - libavutil/riscv/asm.S | 2 -- libavu

[FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma

2022-10-04 Thread Andreas Rheinhardt
GCC 4.0 not only added a visibility attribute, but also a pragma to set it for a whole region of code.* This commit exposes this via macros. *: See https://gcc.gnu.org/gcc-4.0/changes.html Signed-off-by: Andreas Rheinhardt --- libavutil/attributes_internal.h | 4 1 file changed, 4 insertio

Re: [FFmpeg-devel] [PATCH v6 3/3] fate/flac: Add test of 32 bps encoding/decoding

2022-10-04 Thread Martijn van Beurden
Op di 4 okt. 2022 om 17:14 schreef Andreas Rheinhardt : > Is the encoder bitexact, i.e. does it always produce the same output > regardless of plattform (this is different from the encoder's output > decoding exactly to the original input)? I don't know but it seems unlikely to me. Of libFLAC I'm

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/opus, opus_celt: Fix header descriptions

2022-10-04 Thread Lynne
Oct 4, 2022, 13:09 by andreas.rheinha...@outlook.com: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/opus.h | 2 +- > libavcodec/opus_celt.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/opus.h b/libavcodec/opus.h > index 80d685d47c..4d061cf5

Re: [FFmpeg-devel] [PATCH 1/3] avformat/vividas: Check packet size

2022-10-04 Thread Michael Niedermayer
On Fri, Sep 30, 2022 at 01:09:25AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 119760682 - -2084600173 cannot be represented > in type 'int' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-6745781167587328 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/3] lavc/opusdsp: RISC-V V postfilter

2022-10-04 Thread Lynne
Oct 1, 2022, 14:32 by r...@remlab.net: > From: Rémi Denis-Courmont > > This is optimised for a vector size of 128-bit. Or maybe it would be > more accurate to state that this is not properly optimised for larger > vector sizes, as they would work just fine with a smaller vector group > multiplier

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/opus, opus_celt: Fix header descriptions

2022-10-04 Thread Andreas Rheinhardt
Lynne: > Oct 4, 2022, 13:09 by andreas.rheinha...@outlook.com: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/opus.h | 2 +- >> libavcodec/opus_celt.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/opus.h b/libavcodec/opus.h >> index 8

[FFmpeg-devel] [PATCH 2/2] avcodec/asvenc: Remove unnecessary emms_c()

2022-10-04 Thread Andreas Rheinhardt
PixblockDSP does not use MMX functions any more since 92b58002776edd3a3df03c90e8a3ab24b8f987de and FDCTDSP since d402ec6be99dc82e263bad883e7c1c3d957343db. BswapDSP never used MMX, so that the emms_c() here is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/asvenc.c | 1 - 1 file ch

Re: [FFmpeg-devel] [PATCH v2] lavc/cbs_av1: restore CodedBitstreamAV1Context when AVERROR(ENOSPC)

2022-10-04 Thread Xiang, Haihao
On Wed, 2022-09-28 at 09:39 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The current pbc might be small for an obu frame, so a new pbc is > required then parse this obu frame again. Because > CodedBitstreamAV1Context has already been updated for this obu frame, we > need to restore CodedB

Re: [FFmpeg-devel] [PATCH] riscv: remove unnecessary #include's

2022-10-04 Thread Lynne
Oct 4, 2022, 19:49 by r...@remlab.net: > Pointed out by Andreas Rheinhardt. > --- > libavcodec/riscv/fmtconvert_rvv.S | 1 - > libavcodec/riscv/idctdsp_rvv.S | 1 - > libavcodec/riscv/pixblockdsp_rvi.S | 1 - > libavcodec/riscv/pixblockdsp_rvv.S | 1 - > libavcodec/riscv/vorbisdsp_rvv.S |

Re: [FFmpeg-devel] [FFmpeg-cvslog] riscv/alacdsp: drop config.h include

2022-10-04 Thread Rémi Denis-Courmont
Le 5 octobre 2022 08:00:00 GMT+03:00, Lynne a écrit : >ffmpeg | branch: master | Lynne | Wed Oct 5 06:58:26 2022 >+0200| [b25c6a5704ac114e825577209a610f5e95abe6c0] | committer: Lynne > >riscv/alacdsp: drop config.h include > >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b25c6a570

Re: [FFmpeg-devel] [PATCH 4/4] lavc/bswapdsp: RISC-V V bswap16_buf

2022-10-04 Thread Lynne
Oct 2, 2022, 13:55 by r...@remlab.net: > From: Rémi Denis-Courmont > > --- > libavcodec/riscv/bswapdsp_init.c | 5 - > libavcodec/riscv/bswapdsp_rvv.S | 17 + > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/riscv/bswapdsp_init.c > b/libavcode