Re: [FFmpeg-devel] [PATCH] arm: vc1dsp: Canonicalize the syntax for aligned NEON loads/stores

2022-09-29 Thread Martin Storsjö
On Wed, 28 Sep 2022, Martin Storsjö wrote: This hopefully should fix building with older toolchains, hopefully fixing the fate failures on http://fate.ffmpeg.org/history.cgi?slot=armel5tej-qemu-debian-gcc4.4. Signed-off-by: Martin Storsjö --- libavcodec/arm/vc1dsp_neon.S | 40 +

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse the last moof box when mp4 segment format

2022-09-29 Thread zhilizhao(赵志立)
> On Sep 1, 2022, at 18:22, 1035567...@qq.com wrote: > > From: Wang Yaqiang > > In the format of mp4 segment, the bitrate calculation of > stream depends on the sample_size in moof->traf->trun box. > In the original logic, when the last sidx box is read, > it is not parsed backwards, and the t

[FFmpeg-devel] [PATCH v2] avformat/mpegtsenc: add omit_rai flag

2022-09-29 Thread Zhao Zhili
From: Zhao Zhili Add PCR at keyframe can be undesirable when -pcr_period is specified. Add an flag to disable this behavior. Signed-off-by: Zhao Zhili --- v2: change pcr_at_keyframe to omit_rai doc/muxers.texi | 2 ++ libavformat/mpegtsenc.c | 6 +- 2 files changed, 7 insertions(+

Re: [FFmpeg-devel] [PATCH 1/2] avformat/vividas: Check packet size

2022-09-29 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-09-29 00:35:09) > On Wed, Sep 28, 2022 at 05:16:05PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2022-09-22 20:08:51) > > > Fixes: signed integer overflow: 119760682 - -2084600173 cannot be > > > represented in type 'int' > > > Fixes: > > > 50993

Re: [FFmpeg-devel] [PATCH 1/2] avformat/vividas: Check packet size

2022-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2022 at 04:10:22PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-09-29 00:35:09) > > On Wed, Sep 28, 2022 at 05:16:05PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2022-09-22 20:08:51) > > > > Fixes: signed integer overflow: 119760682 - -20846001

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpegvideo: Fix undefined left shift of negative numbers

2022-09-29 Thread Michael Niedermayer
On Wed, Sep 28, 2022 at 08:58:17PM +0200, Andreas Rheinhardt wrote: > Fixes the rv20-1239 FATE-test. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B1

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/jrevdct: Fix UB left shifts of negative numbers

2022-09-29 Thread Michael Niedermayer
On Wed, Sep 28, 2022 at 08:58:16PM +0200, Andreas Rheinhardt wrote: > Affected the rv20-1239 FATE test. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jrevdct.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) iam a bit surprised this wa

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/jrevdct: Fix UB left shifts of negative numbers

2022-09-29 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Sep 28, 2022 at 08:58:16PM +0200, Andreas Rheinhardt wrote: >> Affected the rv20-1239 FATE test. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/jrevdct.c | 38 +++--- >> 1 file changed, 19 insertions(+), 19 deletions(-)

[FFmpeg-devel] [PATCH 0/4] swscale rgbaf32 input/output support

2022-09-29 Thread mindmark
From: Mark Reid This patch series adds swscale input/output support for the packed rgb float formats. A few of the filters also needed support the larger 96/128 bit packed pixel sizes. I also plan to eventually add lossless unscaled conversions between the planer and packed formats. Mark Rei

[FFmpeg-devel] [PATCH 1/4] swscale/input: add rgbaf32 input support

2022-09-29 Thread mindmark
From: Mark Reid --- libswscale/input.c | 172 + libswscale/utils.c | 4 ++ 2 files changed, 176 insertions(+) diff --git a/libswscale/input.c b/libswscale/input.c index 7ff7bfaa01..4683284b0b 100644 --- a/libswscale/input.c +++ b/libswscale/input.c

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_hflip: add support for packed rgb float formats

2022-09-29 Thread mindmark
From: Mark Reid --- libavfilter/vf_hflip_init.h | 25 + 1 file changed, 25 insertions(+) diff --git a/libavfilter/vf_hflip_init.h b/libavfilter/vf_hflip_init.h index d0319f463d..31173f73fc 100644 --- a/libavfilter/vf_hflip_init.h +++ b/libavfilter/vf_hflip_init.h @@ -86,

[FFmpeg-devel] [PATCH 3/4] avfilter/vf_transpose: add support for packed rgb float formats

2022-09-29 Thread mindmark
From: Mark Reid --- libavfilter/vf_transpose.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c index 469e66729f..1023d6fe82 100644 --- a/libavfilter/vf_transpose.c +++ b/libavfilter/vf_transpose.c

[FFmpeg-devel] [PATCH 4/4] swscale/output: add rgbaf32 output support

2022-09-29 Thread mindmark
From: Mark Reid --- libswscale/output.c | 89 libswscale/swscale_unscaled.c| 4 +- libswscale/tests/floatimg_cmp.c | 4 +- libswscale/utils.c | 16 +++-- libswscale/yuv2rgb.c | 2 + te

[FFmpeg-devel] [PATCH v2] lavf/async: Fix ring_write return value

2022-09-29 Thread Guangyu Sun
his fixes a regression from commit 36117968ad. wrapped_url_read() used to be able to return positive number from ffurl_read(). It relies on the result to check if EOF is reached in async_buffer_task(). But FIFO callbacks must return 0 on success. This should be handled in ring_write() instead. T

Re: [FFmpeg-devel] [PATCH] lavf/async: Fix wrapped_url_read return value

2022-09-29 Thread Guangyu Sun
On Wed, Sep 28, 2022 at 7:08 AM Anton Khirnov wrote: > > Quoting Guangyu Sun (2022-09-19 07:22:39) > > This fixes a regression from commit 36117968ad. > > > > wrapped_url_read() used to be able to return positive number from > > ffurl_read(). It relies on the result to check if EOF is reached in >

[FFmpeg-devel] [PATCH] lavc/opusdsp: RISC-V F deemphasis

2022-09-29 Thread remi
From: Rémi Denis-Courmont This saves almost exactly 25% on SiFive U74. deemphasis_c: 11536.2 deemphasis_rvf: 8654.2 --- libavcodec/opusdsp.c| 2 ++ libavcodec/opusdsp.h| 1 + libavcodec/riscv/Makefile | 2 ++ libavcodec/riscv/opusdsp_init.c | 36

Re: [FFmpeg-devel] [PATCH] lavc/opusdsp: RISC-V F deemphasis

2022-09-29 Thread Rémi Denis-Courmont
Le torstaina 29. syyskuuta 2022, 22.51.59 EEST r...@remlab.net a écrit : > From: Rémi Denis-Courmont > > This saves almost exactly 25% on SiFive U74. > > deemphasis_c: 11536.2 > deemphasis_rvf: 8654.2 So well, if you trust godbolt.org, some better compiler is able to optimise the C version cor

Re: [FFmpeg-devel] [PATCH 1/5] avutil/pixdesc: Remove always-false checks

2022-09-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ff_check_pixfmt_descriptors() was added in commit > 20e99a9c10cdbe9ad659dce5bdec569d744f8219. At this time, > the values of enum AVPixelFormat were not contiguous; > instead there was a jump from 111 to 291 (or from 115 > to 295 depending upon AV_PIX_FMT_ABI_GIT_MASTER). > ff_

[FFmpeg-devel] [PATCH] avutil/channel_layout: Don't mention dead project

2022-09-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/channel_layout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index ff2b57bbe3..7808573118 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -27

[FFmpeg-devel] [PATCH] avcodec/vorbis: Split data declarations out into new header

2022-09-29 Thread Andreas Rheinhardt
vorbis.h currently contains stuff only used by the native Vorbis codecs and some Vorbis tables, which are also used by Opus and libvorbis. Therefore split the data out into a header of its own. Signed-off-by: Andreas Rheinhardt --- libavcodec/libopusdec.c | 2 +- libavcodec/libopusenc.c |

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking

2022-09-29 Thread Michael Niedermayer
On Sun, Sep 18, 2022 at 01:21:23PM +, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Sat Sep 17 > 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | committer: > Paul B Mahol > > avcodec/mlpdec: relax channels checking > > Internal TrueHD decoder channel rema

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking

2022-09-29 Thread Michael Niedermayer
On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote: > On Sun, Sep 18, 2022 at 01:21:23PM +, Paul B Mahol wrote: > > ffmpeg | branch: master | Paul B Mahol | Sat Sep 17 > > 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | > > committer: Paul B Mahol > > > >

[FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: add max channels check

2022-09-29 Thread Michael Niedermayer
Fixes: out of array access Fixes: 51648/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-4644322217164800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mlpdec.c | 3 +++ 1 fil

[FFmpeg-devel] [PATCH 1/3] avformat/vividas: Check packet size

2022-09-29 Thread Michael Niedermayer
Fixes: signed integer overflow: 119760682 - -2084600173 cannot be represented in type 'int' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-6745781167587328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: M

[FFmpeg-devel] [PATCH 2/3] avcodec/speexdec: Check channels > 2

2022-09-29 Thread Michael Niedermayer
More than 2 channels seems unsupported, the code seems to just output empty extra channels Fixes: Timeout Fixes: 51569/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEX_fuzzer-5511509165342720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ff

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking

2022-09-29 Thread Michael Niedermayer
On Fri, Sep 30, 2022 at 12:03:25AM +0200, Michael Niedermayer wrote: > On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote: > > On Sun, Sep 18, 2022 at 01:21:23PM +, Paul B Mahol wrote: > > > ffmpeg | branch: master | Paul B Mahol | Sat Sep 17 > > > 14:08:58 2022 +0200| [adaa0

[FFmpeg-devel] [PATCH 1/5] avcodec/mpeg12vlc: Move MPEG-1/2 RL VLCs to it

2022-09-29 Thread Andreas Rheinhardt
It is better place for these declarations than mpeg12data.h as RL VLC are just a variant of VLCs. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12data.c | 1 + libavcodec/mpeg12data.h | 4 libavcodec/mpeg12dec.h | 10 -- libavcodec/mpeg12enc.c | 1 + libavcodec/mpeg12enc

[FFmpeg-devel] [PATCH 2/5] avcodec/mpeg12dec: Don't call ff_mpeg12_common_init()

2022-09-29 Thread Andreas Rheinhardt
It only sets [yc]_dc_scale_table and these tables are only read in ff_set_qscale(); but the MPEG-1/2 decoders don't call ff_set_qscale() at all. (Furthermore, given that intra_dc_precision is always zero for a decoder at this point, ff_mpeg12_common_init() actually set these pointers to what ff_mpv

[FFmpeg-devel] [PATCH 3/5] avcodec/mpeg12: Inline ff_mpeg12_common_init() into mpeg12enc.c

2022-09-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12.c| 9 - libavcodec/mpeg12.h| 2 -- libavcodec/mpeg12enc.c | 4 +++- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c index d78e25a777..7f2aaea7c0 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 4/5] configure, avcodec/Makefile: Remove obsolete mpegvideo dependencies

2022-09-29 Thread Andreas Rheinhardt
As long as ff_mpeg12_common_init() existed in mpeg12.c, it added a dependency of mpeg12.o on mpegvideodata.o (which provides ff_mpeg2_dc_scale_table, which is used in ff_mpeg12_common_init()). mpegvideodata.o is normally provided by the mpegvideo subsystem and therefore several codecs and the MPEG-

[FFmpeg-devel] [PATCH 5/5] avcodec/mpeg12: Move ff_mpeg1_clean_buffers decl to a new header

2022-09-29 Thread Andreas Rheinhardt
It allows to avoid including mpegvideo.h when including mpeg12.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12.c| 1 + libavcodec/mpeg12.h| 10 +++--- libavcodec/mpeg12codecs.h | 29 + libavcodec/mpeg12dec.c