Re: [FFmpeg-devel] [PATCH v2 5/7] swresample/swresample: Fix mismatching argument names

2022-09-23 Thread Michael Niedermayer
On Thu, Sep 22, 2022 at 04:03:58AM +0200, Marvin Scholz wrote: > --- > libswresample/swresample.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize la

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil: Fix mismatching argument names

2022-09-23 Thread Michael Niedermayer
On Thu, Sep 22, 2022 at 04:03:57AM +0200, Marvin Scholz wrote: > --- > libavutil/hwcontext.h | 2 +- > libavutil/mathematics.h | 6 -- > libavutil/mem.h | 3 ++- > libavutil/rational.h| 3 ++- > 4 files changed, 9 insertions(+), 5 deletions(-) should be ok [...] -- Michael

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/avformat: Fix mismatching argument names

2022-09-23 Thread Michael Niedermayer
On Thu, Sep 22, 2022 at 04:03:56AM +0200, Marvin Scholz wrote: > --- > libavformat/avformat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Republics decline into democracies and de

Re: [FFmpeg-devel] [PATCH v2 1/7] avcodec: Fix Doxygen trailing brief comments

2022-09-23 Thread Michael Niedermayer
On Thu, Sep 22, 2022 at 04:03:54AM +0200, Marvin Scholz wrote: > The //< comment is not any magic comment supported by Doxygen, > instead use //!< to mark them as brief doc for the members. ///< is more commonly used in ffmpeg thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133

Re: [FFmpeg-devel] [PATCH v2 2/7] avdevice/avdevice: Fix mismatching argument name

2022-09-23 Thread Michael Niedermayer
On Thu, Sep 22, 2022 at 04:03:55AM +0200, Marvin Scholz wrote: > --- > libavdevice/avdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/mjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index c594950500..d77c644d3b 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2866,7 +2866,7 @

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Steven Liu
Zhao Zhili 于2022年9月23日周五 17:40写道: > > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > libavcodec/mjpegdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) lgtm > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index c594950500..d77c644d3b 100644 > --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] Media 100i decoder

2022-09-23 Thread Paul B Mahol
On 9/22/22, Andreas Rheinhardt wrote: > Paul B Mahol: >> On 9/22/22, Anton Khirnov wrote: >>> Should be straightforward to forward get_buffer2() and support >>> AV_CODEC_CAP_DR1. >> >> How ? >> > > You copy the get_buffer2 callback as well as AVCodecContext.opaque to > the subdecoder. Still tri

[FFmpeg-devel] [PATCH 1/1] opus_silk: reset midonly flag after skipping LBRR

2022-09-23 Thread Tristan Matthews
Fix suggested by Mark Harris. Fixes ticket #9890 Simplified after feedback from Anton Khirnov. --- libavcodec/opus_silk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/opus_silk.c b/libavcodec/opus_silk.c index 8523b55ada..f9d67f4fb3 100644 --- a/libavcodec/opus_silk.c +++ b/li

Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890)

2022-09-23 Thread Andreas Rheinhardt
Tristan Matthews: > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews wrote: > >> This adds a fate test for a sample with LBRR packets. >> >> It requires that these files be uploaded: >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka >> https://people.videolan.org/~tmatth/9890-fate/sil

Re: [FFmpeg-devel] [PATCH] avcodec: add a bsf to reorder DTS into PTS

2022-09-23 Thread Anton Khirnov
Quoting James Almer (2022-09-05 03:09:55) > +static int h264_init(AVBSFContext *ctx) > +{ > +DTS2PTSContext *s = ctx->priv_data; > +DTS2PTSH264Context *h264 = &s->u.h264; > + > +s->cbc->decompose_unit_types= h264_decompose_unit_types; > +s->cbc->nb_decompose_unit_types = > FF_A

Re: [FFmpeg-devel] [PATCH] avcodec: add a bsf to reorder DTS into PTS

2022-09-23 Thread James Almer
On 9/23/2022 10:06 AM, Anton Khirnov wrote: Quoting James Almer (2022-09-05 03:09:55) +static int h264_init(AVBSFContext *ctx) +{ +DTS2PTSContext *s = ctx->priv_data; +DTS2PTSH264Context *h264 = &s->u.h264; + +s->cbc->decompose_unit_types= h264_decompose_unit_types; +s->cbc->

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Rémi Denis-Courmont
Le perjantaina 23. syyskuuta 2022, 20.40.30 EEST Zhao Zhili a écrit : > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > libavcodec/mjpegdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index c594950500..d77c64

Re: [FFmpeg-devel] [PATCH 06/29] configure: probe RISC-V Vector extension

2022-09-23 Thread Rémi Denis-Courmont
Le torstaina 22. syyskuuta 2022, 21.37.03 EEST r...@remlab.net a écrit : > @@ -7596,6 +7608,9 @@ if enabled loongarch; then > echo "LSX enabled ${lsx-no}" > echo "LASX enabled ${lasx-no}" > fi > +if enabled riscv; then > +echo "RISC-V Vector enabled ${r

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- > libavcodec/mjpegdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index c594950500..d77c644d3b 100644 > --- a/libavcodec/mjpegdec.c > +++ b/libavcod

[FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Set sample aspect ratio before getting buffer

2022-09-23 Thread Andreas Rheinhardt
That way the SAR will be automatically set on the AVFrame. Signed-off-by: Andreas Rheinhardt --- If I am not mistaken, then the earlier code would set the sar with a delay of one frame on the returned frames in case there is a sar change mid-stream. But I don't have a sample for this. libavcode

[FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2022-09-23 Thread Andreas Rheinhardt
This could be improved further by not allocating the buffers that won't be needed lateron in the first place. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index c3f2a7a

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel-boun...@ffmpeg.org On > Behalf Of Andreas Rheinhardt > Sent: 2022年9月23日 23:11 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses > warning > > Zhao Zhili: > > From: Zhao Zhili > > > > Signe

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

2022-09-23 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel-boun...@ffmpeg.org On > Behalf Of Rémi Denis-Courmont > Sent: 2022年9月23日 22:35 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses > warning > > Le perjantaina 23. syyskuuta 2022, 20.40.30 EE

Re: [FFmpeg-devel] [PATCH] A-pac demuxer and decoder

2022-09-23 Thread Paul B Mahol
On 9/21/22, Paul B Mahol wrote: > Patches attached. > WIll apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH] doc/examples/extract_mvs: add motion information

2022-09-23 Thread Michael Niedermayer
On Mon, Sep 12, 2022 at 04:49:56PM -0700, Chema Gonzalez wrote: > Note that the motion information includes subpel motion information > > This was likely forgotten in 56bdf61baa04c4fd8d165f34499115ce0aa97c43. > > Tested: > ``` > $ make examples -j > ... > $ doc/examples/extract_mvs in.264 | head

Re: [FFmpeg-devel] [PATCH] float in tiff

2022-09-23 Thread Paul B Mahol
On 9/14/22, Paul B Mahol wrote: > Patches attached. > Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Set sample aspect ratio before getting buffer

2022-09-23 Thread Tomas Härdin
fre 2022-09-23 klockan 17:40 +0200 skrev Andreas Rheinhardt: > That way the SAR will be automatically set on the AVFrame. > > Signed-off-by: Andreas Rheinhardt > --- > If I am not mistaken, then the earlier code would set the sar > with a delay of one frame on the returned frames in case > there

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Implement FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

2022-09-23 Thread Tomas Härdin
fre 2022-09-23 klockan 17:41 +0200 skrev Andreas Rheinhardt: > This could be improved further by not allocating the buffers > that won't be needed lateron in the first place. My parallellization patches do this > > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/jpeg2000dec.c | 6 ++ >

Re: [FFmpeg-devel] [PATCH] A-pac demuxer and decoder

2022-09-23 Thread James Almer
On 9/21/2022 4:23 AM, Paul B Mahol wrote: Patches attached. [...] +static av_cold int apac_close(AVCodecContext *avctx) +{ +APACContext *s = avctx->priv_data; + +av_freep(&s->bitstream); +s->bitstream_size = 0; + +for (int ch = 0; ch < avctx->ch_layout.nb_channels; ch++) { f

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Set sample aspect ratio before getting buffer

2022-09-23 Thread Andreas Rheinhardt
Tomas Härdin: > fre 2022-09-23 klockan 17:40 +0200 skrev Andreas Rheinhardt: >> That way the SAR will be automatically set on the AVFrame. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> If I am not mistaken, then the earlier code would set the sar >> with a delay of one frame on the returned fr

Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890)

2022-09-23 Thread Tristan Matthews
On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt wrote: > > Tristan Matthews: > > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews wrote: > > > >> This adds a fate test for a sample with LBRR packets. > >> > >> It requires that these files be uploaded: > >> https://people.videolan.org/~tmatth/98

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Set sample aspect ratio before getting buffer

2022-09-23 Thread Tomas Härdin
fre 2022-09-23 klockan 20:48 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > fre 2022-09-23 klockan 17:40 +0200 skrev Andreas Rheinhardt: > > > That way the SAR will be automatically set on the AVFrame. > > > > > > Signed-off-by: Andreas Rheinhardt > > > > > > --- > > > If I am not mistaken,

[FFmpeg-devel] [PATCH] avcodec/opusdec: stop setting deprecated swr options

2022-09-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/opusdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index c04aa598b8..8b10bd1a25 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opusdec.c @@ -640,7 +640,7 @@ static av_c

Re: [FFmpeg-devel] [PATCH] avcodec/opusdec: stop setting deprecated swr options

2022-09-23 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/opusdec.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c > index c04aa598b8..8b10bd1a25 100644 > --- a/libavcodec/opusdec.c > +++ b/libavcodec/opusdec.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Set sample aspect ratio before getting buffer

2022-09-23 Thread Andreas Rheinhardt
Tomas Härdin: > fre 2022-09-23 klockan 20:48 +0200 skrev Andreas Rheinhardt: >> Tomas Härdin: >>> fre 2022-09-23 klockan 17:40 +0200 skrev Andreas Rheinhardt: That way the SAR will be automatically set on the AVFrame. Signed-off-by: Andreas Rheinhardt --- If I am not

Re: [FFmpeg-devel] [PATCH] avcodec/opusdec: stop setting deprecated swr options

2022-09-23 Thread James Almer
On 9/23/2022 4:55 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/opusdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index c04aa598b8..8b10bd1a25 100644 --- a/libavcodec/op

Re: [FFmpeg-devel] [PATCH] avcodec/opusdec: stop setting deprecated swr options

2022-09-23 Thread Andreas Rheinhardt
James Almer: > On 9/23/2022 4:55 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/opusdec.c | 11 +++ >>>   1 file changed, 7 insertions(+), 4 deletions(-) >>> >>> diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c >>> index c04aa59

[FFmpeg-devel] [PATCH] avcodec/parser: Remove declaration of inexistent function

2022-09-23 Thread Andreas Rheinhardt
Forgotten in e5af9203098a889f36b759652615046254d45102. Signed-off-by: Andreas Rheinhardt --- libavcodec/parser.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/parser.h b/libavcodec/parser.h index ef35547e9b..2cee5ae4ff 100644 --- a/libavcodec/parser.h +++ b/libavcodec/parser.h

Re: [FFmpeg-devel] [PATCH 01/13] avformat/flvdec: Use 64bit for sum_flv_tag_size

2022-09-23 Thread Michael Niedermayer
On Sun, Sep 18, 2022 at 07:13:58PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2138820085 + 16130322 cannot be represented > in type 'int' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_LIVE_FLV_fuzzer-6704728165187584 > > Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH] libavcodec/qsvenc: fixy typo for min/max qp reset

2022-09-23 Thread Dmitry Rogozhkin
Fixes: 005c7a4 ("libavcodec/qsvenc: Add max/min qp reset support in qsvenc") CC: Wenbin Chen Signed-off-by: Dmitry Rogozhkin --- libavcodec/qsvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 84c6e29..8bd9272 100644 ---

Re: [FFmpeg-devel] [PATCH 1/9] avformat/ape: Check frames size

2022-09-23 Thread Michael Niedermayer
On Sat, Sep 17, 2022 at 11:15:49PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775806 + 3 cannot be represented > in type 'long' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_APE_fuzzer-6389264140599296 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2] avformat/cafenc: derive Opus frame size from the relevant stream parameters

2022-09-23 Thread James Almer
On 9/22/2022 8:14 PM, James Almer wrote: Use the stream duration as last resort, as an off-by-one result of the "st->duration / (caf->packets - 1)" calculation can break playback on some devices. Also, don't write the sample_rate value propagated by encoders like libopus. The sample rate of the a

[FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-23 Thread Lynne
This commit changes both the encoder and decoder to use the new lavu/tx code, which has faster C transforms and more assembly optimizations. Patch attached. >From d4fdda5b57ab1e0f08eb3d78dac6b003060dfd41 Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 00:46:44 +0200 Subject: [PATCH 1

[FFmpeg-devel] [PATCH 2/6] atrac9dec: switch to lavu/tx

2022-09-23 Thread Lynne
Patch attached. >From 5a310246569e19efd50b37016a80fe6171df0329 Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 00:51:18 +0200 Subject: [PATCH 2/6] atrac9dec: switch to lavu/tx --- libavcodec/atrac9dec.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) di

[FFmpeg-devel] [PATCH 3/6] ac3: convert encoder and decoder to lavu/tx

2022-09-23 Thread Lynne
The fixed-point transforms are much better, faster, and more accurate. Patch attached. >From e54775cc93ceb27d9faabe1ddf9b1eacb269826b Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 01:05:19 +0200 Subject: [PATCH 3/6] ac3: convert encoder and decoder to lavu/tx The fixed-point trans

[FFmpeg-devel] [PATCH 4/6] vorbisdec: convert to lavu/tx

2022-09-23 Thread Lynne
Patch attached. >From 1334c8c26a8d1c3f8e2aa98b902b2dab6e524a84 Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 01:07:15 +0200 Subject: [PATCH 4/6] vorbisdec: convert to lavu/tx --- libavcodec/vorbisdec.c | 29 - 1 file changed, 20 insertions(+), 9 deletio

[FFmpeg-devel] [PATCH 5/6] twinvq: convert to lavu/tx

2022-09-23 Thread Lynne
Patch attached. >From 685ac65ce0f391fd1d3a06e191c9659dacd375be Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 01:07:44 +0200 Subject: [PATCH 5/6] twinvq: convert to lavu/tx --- libavcodec/twinvq.c | 12 +++- libavcodec/twinvq.h | 6 -- 2 files changed, 11 insertions(+)

[FFmpeg-devel] [PATCH 6/6] wmaprodec: convert to lavu/tx

2022-09-23 Thread Lynne
Patch attached. >From 4ad73f29065051c68991eb96aeae7f771039209a Mon Sep 17 00:00:00 2001 From: Lynne Date: Sat, 24 Sep 2022 01:08:00 +0200 Subject: [PATCH 6/6] wmaprodec: convert to lavu/tx --- libavcodec/wmaprodec.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-