will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
It only needs work_chunks from it, so pass that directly.
This is done in preparation to splitting DVVideoContext.
---
libavcodec/dv.c| 6 +++---
libavcodec/dv.h| 2 +-
libavcodec/dvdec.c | 2 +-
libavcodec/dvenc.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib
DVMuxContext is only used inside dvenc.c, there is no reason for it to
be visible outside of that file.
---
libavformat/dv.h| 4 +---
libavformat/dvenc.c | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/libavformat/dv.h b/libavformat/dv.h
index 160c6ab873..efced6ccf0 10
They are used from libavdevice.
---
configure| 1 +
libavformat/Makefile | 3 +--
libavformat/dv.c | 23 +++
3 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index ea50c94002..f4c4ab0484 100755
--- a/configure
+++ b/configu
The function gets the codec context parameter directly.
---
libavcodec/dvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c
index f7423580aa..bad8419925 100644
--- a/libavcodec/dvdec.c
+++ b/libavcodec/dvdec.c
@@ -393,7 +393,7 @@ stati
---
tests/fate/mov.mak | 3 +++
tests/ref/fate/mov-dvaudio | 31 +++
2 files changed, 34 insertions(+)
create mode 100644 tests/ref/fate/mov-dvaudio
diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak
index 8a7218a215..9e8bb729a6 100644
--- a/tests/fate/mov.
Move the parts of it used by the encoder into a new DVEncContext and
remove DVVideoContext.
---
libavcodec/dv.h| 23 ---
libavcodec/dvenc.c | 39 ---
2 files changed, 28 insertions(+), 34 deletions(-)
diff --git a/libavcodec/dv.h b/libav
The code will call avpriv_set_pts_info() for each video frame, possibly
setting a different timebase if the stream framerate changes. This
violates API conventions, as the timebase is supposed to stay constant
after stream creation.
Change the demuxer to set a single timebase that is granular enou
The mov demuxer only returns DV audio, video packets are discarded.
It first reads the data to be parsed into a packet. Then both this
packet and the pointer to its data are passed together to
avpriv_dv_produce_packet(), which parses the data and partially
overwrites the packet. This is confusing
Pass the two variables needed from it directly.
This is done in preparation to splitting DVVideoContext.
---
libavcodec/dv.h| 5 +++--
libavcodec/dvdec.c | 2 +-
libavcodec/dvenc.c | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/dv.h b/libavcodec/dv.h
index 2
CamelCase for enum tags, ALL_CAPS for enum values.
---
libavcodec/dv.h | 38 +++---
libavcodec/dvdec.c | 4 ++--
libavcodec/dvenc.c | 32
libavformat/dv.c| 18 +-
libavformat/dvenc.c | 34 +-
---
libavformat/dv.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/dv.c b/libavformat/dv.c
index c888111789..24d6897da5 100644
--- a/libavformat/dv.c
+++ b/libavformat/dv.c
@@ -268,11 +268,13 @@ static int dv_extract_audio_info(DVDemuxContext *c, const
u
---
libavformat/dv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/dv.c b/libavformat/dv.c
index 24d6897da5..f65c2d596f 100644
--- a/libavformat/dv.c
+++ b/libavformat/dv.c
@@ -278,6 +278,8 @@ static int dv_extract_audio_info(DVDemuxContext *c, const
uint8_t
The function contains only two assignments, which are simpler to
duplicate into decoder and encoder. Additionally, dvdec does not use
DVVideoContext.avctx at all.
---
libavcodec/dv.c| 10 --
libavcodec/dv.h| 2 --
libavcodec/dvdec.c | 4 +++-
libavcodec/dvenc.c | 5 -
4 file
The struct is quite small and the decoder and the encoder use different
fields from it, so benefits from reusing it are small.
This allows making the buf field const.
---
libavcodec/dvdec.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/libavcode
---
libavdevice/iec61883.c | 2 +-
libavformat/dv.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavdevice/iec61883.c b/libavdevice/iec61883.c
index 7223ba2e64..a4b4ce2ef8 100644
--- a/libavdevice/iec61883.c
+++ b/libavdevice/iec61883.c
@@ -209,7 +209,7 @@ static
Demuxers are not supposed to update AVCodecParameters after the stream
was seen by the caller. This value is not important enough to support
dynamic updates for.
---
libavformat/dv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dv.c b/libavformat/dv.c
index f65c2
Demuxers are not allowed to do this and few callers, if any, will handle
this correctly. Send the AV_SIDE_DATA_PARAM_CHANGE_SAMPLE_RATE side data
instead.
---
libavformat/dv.c | 49 +---
1 file changed, 34 insertions(+), 15 deletions(-)
diff --git a/lib
dv.h is also used by libavformat, so avoid exposing encoder/decoder code
to it.
---
libavcodec/dv.c | 8 --
libavcodec/dv.h | 34 --
libavcodec/dv_internal.h | 62
libavcodec/dvdec.c | 1 +
libavcodec/dvenc.
The frei0r API requires linesize to be width * 4.
Since the align property of ff_default_get_video_buffer2
specifies line alignment, not buffer alignment, the
previous value of 16 breaks this requirement for frames
whose width is a multiple of 8, but not a multiple of 16
as it adds extra padding to
Unfortunately the smallest sample I could come up with for this is 4MB,
it can be downloaded from [1] and is a cut version of [2]. Smaller
samples for this feature are very much welcome.
[1]
https://ups.khirnov.net/9c5dbaa0847185b81c62d48608eec60440b2cb016899a7d6214f5c30efc81934/qt_dv_pal_test_cu
Anton Khirnov:
> DVMuxContext is only used inside dvenc.c, there is no reason for it to
> be visible outside of that file.
> ---
> libavformat/dv.h| 4 +---
> libavformat/dvenc.c | 4 ++--
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/libavformat/dv.h b/libavformat/dv.h
Anton Khirnov:
> The function gets the codec context parameter directly.
> ---
> libavcodec/dvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c
> index f7423580aa..bad8419925 100644
> --- a/libavcodec/dvdec.c
> +++ b/libavcodec/
Anton Khirnov:
> The function contains only two assignments, which are simpler to
> duplicate into decoder and encoder. Additionally, dvdec does not use
> DVVideoContext.avctx at all.
> ---
> libavcodec/dv.c| 10 --
> libavcodec/dv.h| 2 --
> libavcodec/dvdec.c | 4 +++-
> libavc
Anton Khirnov:
> It only needs work_chunks from it, so pass that directly.
>
> This is done in preparation to splitting DVVideoContext.
> ---
> libavcodec/dv.c| 6 +++---
> libavcodec/dv.h| 2 +-
> libavcodec/dvdec.c | 2 +-
> libavcodec/dvenc.c | 2 +-
> 4 files changed, 6 insertions(+),
Anton Khirnov:
> The struct is quite small and the decoder and the encoder use different
> fields from it, so benefits from reusing it are small.
>
> This allows making the buf field const.
> ---
> libavcodec/dvdec.c | 28 +---
> 1 file changed, 21 insertions(+), 7 deletio
Anton Khirnov:
> Move the parts of it used by the encoder into a new DVEncContext and
> remove DVVideoContext.
> ---
> libavcodec/dv.h| 23 ---
> libavcodec/dvenc.c | 39 ---
> 2 files changed, 28 insertions(+), 34 deletions(-)
>
> diff
Anton Khirnov:
> CamelCase for enum tags, ALL_CAPS for enum values.
> ---
> libavcodec/dv.h | 38 +++---
> libavcodec/dvdec.c | 4 ++--
> libavcodec/dvenc.c | 32
> libavformat/dv.c| 18 +-
> libavformat/dv
Anton Khirnov:
> dv.h is also used by libavformat, so avoid exposing encoder/decoder code
> to it.
> ---
> libavcodec/dv.c | 8 --
> libavcodec/dv.h | 34 --
> libavcodec/dv_internal.h | 62
> libavcodec/dvdec.c
Anton Khirnov:
> Pass the two variables needed from it directly.
>
> This is done in preparation to splitting DVVideoContext.
> ---
> libavcodec/dv.h| 5 +++--
> libavcodec/dvdec.c | 2 +-
> libavcodec/dvenc.c | 2 +-
> 3 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/libavc
Anton Khirnov:
> ---
> libavdevice/iec61883.c | 2 +-
> libavformat/dv.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavdevice/iec61883.c b/libavdevice/iec61883.c
> index 7223ba2e64..a4b4ce2ef8 100644
> --- a/libavdevice/iec61883.c
> +++ b/libavdevice/iec61
Anton Khirnov:
> ---
> libavformat/dv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/dv.c b/libavformat/dv.c
> index 24d6897da5..f65c2d596f 100644
> --- a/libavformat/dv.c
> +++ b/libavformat/dv.c
> @@ -278,6 +278,8 @@ static int dv_extract_audio_info(D
Anton Khirnov:
> Demuxers are not supposed to update AVCodecParameters after the stream
> was seen by the caller. This value is not important enough to support
> dynamic updates for.
> ---
> libavformat/dv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dv.c
Hi,
I saw on the FFmpeg website that for some stable versions there is no
API documentation. The latest stable documentation (for version 4.1) is
four years old.
We managed to build the API documentation for 5.1
(https://ffmpeg-docs.tools.nativewaves.com/5.1/index.html) and other
stable versions
will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Anton Khirnov:
> Demuxers are not allowed to do this and few callers, if any, will handle
> this correctly. Send the AV_SIDE_DATA_PARAM_CHANGE_SAMPLE_RATE side data
> instead.
> ---
> libavformat/dv.c | 49 +---
> 1 file changed, 34 insertions(+), 15 del
Anton Khirnov:
> Demuxers are not supposed to update AVCodecParameters after the stream
> was seen by the caller. This value is not important enough to support
> dynamic updates for.
> ---
> libavformat/dv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/dv.c
Anton Khirnov:
> The code will call avpriv_set_pts_info() for each video frame, possibly
> setting a different timebase if the stream framerate changes. This
> violates API conventions, as the timebase is supposed to stay constant
> after stream creation.
>
> Change the demuxer to set a single tim
The actual implementation, tests and uses in the rest of
FFmpeg code will be committed separately once the API is
settled.
Signed-off-by: Nicolas George
---
doc/avwriter_intro.md | 109 ++
libavutil/writer.h| 484 ++
2 files changed, 593 insert
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Wednesday, August 24, 2022 5:18 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH] lavu: header and documentation for
> AVWriter
>
> The actual implementation, tests and uses in the rest of
>
Nicolas George:
> The actual implementation, tests and uses in the rest of
> FFmpeg code will be committed separately once the API is
> settled.
>
I think you misunderstood JB: He did not say that the headers are pushed
without the implementation, he just said that the headers should be
discussed
Andreas Rheinhardt (12022-08-24):
> Where is this header?
# Note: FF_NEW_SZ is a macro defined elsewhere; it is really part of the
# implementation more than the API.
This is all there is to it for this case. I can move it here for now.
Regards,
--
Nicolas George
signature.asc
Description:
Anton Khirnov:
> The mov demuxer only returns DV audio, video packets are discarded.
>
> It first reads the data to be parsed into a packet. Then both this
> packet and the pointer to its data are passed together to
> avpriv_dv_produce_packet(), which parses the data and partially
> overwrites the
tis 2022-08-23 klockan 14:18 +0200 skrev Andreas Rheinhardt:
> Paul B Mahol:
> > Hi,
> >
> > patch attached.
> >
> > return ret;
> > }
> >
> > + pkt->duration = av_rescale_q(pict->duration, (AVRational){ 1,
> > 100 },
> > + avctx->time_base);
On Wed, Aug 24, 2022 at 6:15 PM Tomas Härdin wrote:
> tis 2022-08-23 klockan 14:18 +0200 skrev Andreas Rheinhardt:
> > Paul B Mahol:
> > > Hi,
> > >
> > > patch attached.
> > >
> > > return ret;
> > > }
> > >
> > > +pkt->duration = av_rescale_q(pict->duration, (AVRational){
Anton Khirnov:
> They are used from libavdevice.
> ---
> configure| 1 +
> libavformat/Makefile | 3 +--
> libavformat/dv.c | 23 +++
> 3 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index ea50c94002..f4c4ab0484 100
mån 2022-08-22 klockan 14:52 +0200 skrev Nicolas George:
> Tomas Härdin (12022-08-22):
> > I'd actually argue that in that case we should link a library that
> > implements IPFS, not split developer effort by trying to implement
> > it
> > ourselves.
>
> Is FFmpeg meant to be just a convenient set
tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson :
> * Field Order
> * Chroma Location
> * Color Transfer Characteristics
> * Color Range
> * Color Primaries
> * Matrix Coefficients
>
> The existing TFF/BFF detection is retained as a fallback for
> older versions of AviSynth that can't access
On Tue, Aug 23, 2022 at 4:34 PM James Almer wrote:
>
> Signed-off-by: James Almer
> ---
> libavcodec/libvpxenc.c | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
lgtm.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
htt
On Tue, Aug 23, 2022 at 4:34 PM James Almer wrote:
>
> Signed-off-by: James Almer
> ---
> libavcodec/libaomenc.c | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
lgtm.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https
Hi
On Wed, Aug 24, 2022 at 03:15:45PM +0200, Michael Riedl wrote:
> Hi,
>
> I saw on the FFmpeg website that for some stable versions there is no
> API documentation. The latest stable documentation (for version 4.1) is
> four years old.
>
> We managed to build the API documentation for 5.1
> (h
This pathcset adds two logging flags: 'timing' and 'datetiming'.
Usage:
ffmpeg -loglevel +timing
or
ffmpeg -loglevel +datetiming
softworkz (3):
avutil/log: support logging of date and timing information
fftools/opt_common: add timing and datetiming log flags
doc/fftools-common-opts: docu
From: softworkz
Signed-off-by: softworkz
---
doc/APIchanges | 3 +++
libavutil/log.c | 32 +---
libavutil/log.h | 10 ++
libavutil/version.h | 4 ++--
4 files changed, 44 insertions(+), 5 deletions(-)
diff --git a/doc/APIchanges b/doc/APIchang
From: softworkz
This commit adds two logging flags: 'timing' and 'datetiming'.
Usage:
ffmpeg -loglevel +timing
or
ffmpeg -loglevel +datetiming
Signed-off-by: softworkz
---
fftools/opt_common.c | 12
1 file changed, 12 insertions(+)
diff --git a/fftools/opt_common.c b/fftools/
From: softworkz
Signed-off-by: softworkz
---
doc/fftools-common-opts.texi | 4
1 file changed, 4 insertions(+)
diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi
index d9145704d6..eee3b6ead0 100644
--- a/doc/fftools-common-opts.texi
+++ b/doc/fftools-common-opts.texi
On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote:
> mån 2022-08-22 klockan 14:52 +0200 skrev Nicolas George:
> > Tomas Härdin (12022-08-22):
> > > I'd actually argue that in that case we should link a library that
> > > implements IPFS, not split developer effort by trying to implement
On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote:
[...]
>
> This goes especially for formats like MXF, which I have made the case
> on here multiple times that we should not maintain our own decoder for,
> but rather pull in bmx. And everytime I have suggested this it has been
> made cl
>
> for libxml2 these problems are less likely to hit us as we likely never
> need a
> "new xml feature" but for a (de)muxer we quite likely will need the
> latests version on every platform.
> Also we have regression tests, external libs make that impossible
> as the version of external libs can c
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Jean-Baptiste Kempf
> Sent: Monday, August 22, 2022 4:39 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022
>
> On Mon, 22 Aug 2022, at 14:18, Anton Khirnov wrote:
> > Almost ex
Don't use an intermediary buffer. Achieve this by replacing FrameListData with
a PacketList, and by allocating and populating every packet's payload before
inserting them into the list.
Signed-off-by: James Almer
---
libavcodec/libaomenc.c | 195 +++--
1 file
On 8/24/22 1:04 PM, Steinar Apalnes wrote:
tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson :
* Field Order
* Chroma Location
* Color Transfer Characteristics
* Color Range
* Color Primaries
* Matrix Coefficients
The existing TFF/BFF detection is retained as a fallback for
older versions o
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> rcombs
> Sent: Thursday, August 25, 2022 1:52 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 3/3] lavf/id3v2dec: support multiple
> values and TIPL frames
>
> Fixes https://trac.ffmpeg.org/ticket/6949
>
> Ordi
Possible since c954cf1e1b766a0d1992d5be0a8be0055a8e1a6a.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/roqvideoenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c
index 0a418c3b89..9f03107d81 100644
--- a/libavcodec/roqvideoenc.c
+++ b/
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.h | 13 +
libavcodec/h263dec.c | 1 +
libavcodec/internal.h | 13 -
libavcodec/mediacodecdec_common.c | 1 +
libavcodec/pthread_frame.c| 1 +
libavcodec/utils.c
Only used by decoders.
Also clean up the headers a bit while removing now unnecessary
internal.h inclusions.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/aasc.c | 4 +---
libavcodec/anm.c | 2 +-
libavcodec/ansi.c | 1 +
libavcodec/argo.c | 5 +
liba
65 matches
Mail list logo
