Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-12 Thread PLT
If the only issue is about 'No newline at end of file', of course I will add it and provide new patches. -Original Message- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Thursday, August 11, 2022 11:06 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-d

[FFmpeg-devel] [PATCH] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-08-12 Thread bin . wang-at-intel . com
From: bwang30 This commit enabled assembly code with intel AVX512 VNNI and added unit test for sobel filter sobel_c: 4537 sobel_avx512icl 2470 Signed-off-by: bwang30 --- libavfilter/convolution.h | 2 + libavfilter/vf_convolution.c | 8 ++ libavfilter/x86/vf_convolut

Re: [FFmpeg-devel] [PATCH] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-08-12 Thread Andreas Rheinhardt
bin.wang-at-intel@ffmpeg.org: > From: bwang30 > > This commit enabled assembly code with intel AVX512 VNNI and added unit test > for sobel filter > > sobel_c: 4537 > sobel_avx512icl 2470 > > Signed-off-by: bwang30 > --- > libavfilter/convolution.h | 2 + > libavfilter/vf_co

[FFmpeg-devel] [PATCH 1/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-12 Thread Dawid Kozinski
- Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Changes in Changelog and MAINTAINERS files - Added xeve encoder wrapper - Added xevd dencoder wrapper - Added documentation for xeve and xevd wrappers - Added parser for EVC format

[FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-12 Thread Dawid Kozinski
- Added muxer for EVC format (MP4, raw) - Added demuxer for EVC format (MP4) - Added evc extension to the list of extensions for ff_mov_demuxer - Added information to moov atomi Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 + libavformat/Makefile | 4 +- libavformat/all

Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-12 Thread PLT
I've just added missing newline at end of file -Original Message- From: ffmpeg-devel On Behalf Of Michael Niedermayer Sent: Thursday, August 11, 2022 11:06 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essenti

[FFmpeg-devel] [PATCH] avcodec/mimic: Fix undefined pointer arithmetic

2022-08-12 Thread Andreas Rheinhardt
NULL + anything is UB. Signed-off-by: Andreas Rheinhardt --- libavcodec/mimic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mimic.c b/libavcodec/mimic.c index ce5c2afd19..bcf10b7ae1 100644 --- a/libavcodec/mimic.c +++ b/libavcodec/mimic.c @@ -268,8 +268,9 @@

[FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function

2022-08-12 Thread Fei Wang
From: Linjie Fu Wrap the procedure of getting the hardware config from a pixel format into a function. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/decode.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libavcodec/de

[FFmpeg-devel] [PATCH v1 2/3] lavc/decode: Add internal surface re-allocate method for hwaccel

2022-08-12 Thread Fei Wang
From: Linjie Fu Add HWACCEL_CAP_INTERNAL_ALLOC flag to indicate hwaccels are able to re-allocate surface internally through ff_decode_get_hw_frames_ctx. Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/decode.c | 36 libavcodec/hwconfig.h

[FFmpeg-devel] [PATCH v1 3/3] lavc/vaapi_vp9: add surface internal re-allocation capability

2022-08-12 Thread Fei Wang
From: Linjie Fu Signed-off-by: Linjie Fu Signed-off-by: Fei Wang --- libavcodec/vaapi_vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_vp9.c b/libavcodec/vaapi_vp9.c index 776382f683..fc6ff0a0f2 100644 --- a/libavcodec/vaapi_vp9.c +++ b/libavcodec/vaap

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Mark Gaiser
On Fri, Aug 12, 2022 at 12:51 AM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 8/11/2022 11:03 PM, Timo Rothenpieler wrote: > > Any kind of built in hardcoded server is not acceptable imo. > > Even with it pointing to our own infrastructure, we can't really > > guarantee its availabil

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Vittorio Giovara
On Fri, Aug 12, 2022 at 12:51 AM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > As it exists right now though, I don't really see why lavf needs what > amounts to a URL builder for a service as a "protocol" - this totally > the wrong layer to do that at... > Agreed, this protocol should

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Kieran Kunhya
On Fri, 12 Aug 2022 at 15:22, Vittorio Giovara wrote: > On Fri, Aug 12, 2022 at 12:51 AM Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > > > As it exists right now though, I don't really see why lavf needs what > > amounts to a URL builder for a service as a "protocol" - this totally >

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Mark Gaiser
On Fri, Aug 12, 2022 at 4:30 PM Kieran Kunhya wrote: > On Fri, 12 Aug 2022 at 15:22, Vittorio Giovara > > wrote: > > > On Fri, Aug 12, 2022 at 12:51 AM Derek Buitenhuis < > > derek.buitenh...@gmail.com> wrote: > > > > > As it exists right now though, I don't really see why lavf needs what > > >

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Kieran Kunhya
> > Great opinion you 2, 0 constructiveness. > That doesn't help at all. > > Please try again in a constructive manner that convinces me of your > undoubtedly great arguments! > Please let me know what IPFS has to do with Interplanetary Communications. (hint: none). Kieran __

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Derek Buitenhuis
On 8/12/2022 3:34 PM, Mark Gaiser wrote: > Great opinion you 2, 0 constructiveness. > That doesn't help at all. Your tone has been pretty rude in this whole thread. > Please try again in a constructive manner that convinces me of your > undoubtedly great arguments! You seem to be defining anythi

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Kieran Kunhya
On Fri, 12 Aug 2022 at 15:48, Derek Buitenhuis wrote: > On 8/12/2022 3:34 PM, Mark Gaiser wrote: > > Great opinion you 2, 0 constructiveness. > > That doesn't help at all. > > Your tone has been pretty rude in this whole thread. > > > Please try again in a constructive manner that convinces me of

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Nicolas George
Derek Buitenhuis (12022-08-11): > I agree... we should never send a users data through *any* service they > haven't explicitly asked for. Ever. Regardless of who runs it and who > is deemed "trustworthy". Absolutely. And Kieran's simile with DNS is very good. It is not just a question of whether t

Re: [FFmpeg-devel] [PATCH] track id could be zore

2022-08-12 Thread Derek Buitenhuis
On 8/12/2022 8:26 AM, 帝江-VII wrote: > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 6ee6ed0950..3b0c328e6a 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -4916,8 +4916,6 @@ static int mov_read_tfhd(MOVContext *c, AVIOContext > *pb, MOVAtom atom) >      flags = avio_rb

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Michael Niedermayer
On Fri, Aug 12, 2022 at 12:03:17AM +0200, Timo Rothenpieler wrote: > On 11.08.2022 22:18, Michael Niedermayer wrote: > > On Thu, Aug 11, 2022 at 07:56:04PM +0200, Mark Gaiser wrote: [...] > > > > > > This is just your - valued! - opinion, but still just 1. I insist on > > > waiting to hear from M

Re: [FFmpeg-devel] [PATCH v2] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-12 Thread Derek Buitenhuis
On 8/9/2022 10:38 AM, "zhilizhao(赵志立)" wrote: > It’s suspicious to return a timestamp with unknown timebase. Would you suggest erroring in the case where there's no frag_stream? That could make sense. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: move stream-dependent starttime correction to transcode_init()

2022-08-12 Thread Michael Niedermayer
On Thu, Aug 11, 2022 at 09:45:48AM +0200, Anton Khirnov wrote: > Currently this code is located in the discontinuity handling block, > where it does not belong. > --- > Now with previously missed 'is->start_time != AV_NOPTS_VALUE' check > --- > fftools/ffmpeg.c | 40 ++-

Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-12 Thread Michael Niedermayer
On Fri, Aug 12, 2022 at 09:12:30AM +0200, Dawid Kozinski/Robot SDK (PLT) /SRPOL/Staff Engineer/삼성전자 wrote: > If the only issue is about 'No newline at end of file', of course I will add > it and provide new patches. iam not sure what the issue was i just saw the error and didnt immedeatly see an

Re: [FFmpeg-devel] [PATCH v7 1/2] avformat: refactor ff_stream_encode_params_copy() to stream_params_copy()

2022-08-12 Thread Pierre-Anthony Lemieux
On Tue, Aug 9, 2022 at 6:05 PM Pierre-Anthony Lemieux wrote: > > On Mon, Aug 8, 2022 at 7:50 AM Pierre-Anthony Lemieux > wrote: > > > > On Mon, Aug 8, 2022 at 7:48 AM Andreas Rheinhardt > > wrote: > > > > > > p...@sandflow.com: > > > > From: Pierre-Anthony Lemieux > > > > > > > > Addresses >

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Nicolas George
Michael Niedermayer (12022-08-12): > Maybe thinking about http is the wrong mindset. Maybe DNS is a better analog > > to grab data from DNS you can implement a full DNS server which recursivly > resolves the request starting from the root name servers (which it needs to > have > hardcoded in some

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Michael Niedermayer
On Fri, Aug 12, 2022 at 07:01:49PM +0200, Nicolas George wrote: > Michael Niedermayer (12022-08-12): > > Maybe thinking about http is the wrong mindset. Maybe DNS is a better analog > > > > to grab data from DNS you can implement a full DNS server which recursivly > > resolves the request starting

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-12 Thread Timo Rothenpieler
On 12.08.2022 19:18, Michael Niedermayer wrote: And i dont think removing IPFS support entirely from FFmpeg is a smart choice. I wouldn't at all be upset about having proper IPFS support in FFmpeg, there's no argument there. The issue is that this has very little to do with actual/native IPF

Re: [FFmpeg-devel] [PATCH] avcodec/mimic: Fix undefined pointer arithmetic

2022-08-12 Thread Michael Niedermayer
On Fri, Aug 12, 2022 at 02:40:43PM +0200, Andreas Rheinhardt wrote: > NULL + anything is UB. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mimic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) if its NULL, LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6

Re: [FFmpeg-devel] [PATCH] avcodec/mimic: Fix undefined pointer arithmetic

2022-08-12 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Aug 12, 2022 at 02:40:43PM +0200, Andreas Rheinhardt wrote: >> NULL + anything is UB. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mimic.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > if its NULL, LGTM > It is (at least for the f

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avisynth: add missing avs_release_video_frame

2022-08-12 Thread Stephen Hutchinson
On 8/7/22 9:25 PM, Stephen Hutchinson wrote: The AviSynth C API requires using avs_release_video_frame whenever avs_get_frame has been used, but the recent addition of frameprop reading to the demuxer was missing this in avisynth_create_stream_video. --- libavformat/avisynth.c | 1 + 1 file c

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for NUV

2022-08-12 Thread Michael Niedermayer
Fixes: Timeout Fixes: 49286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5856252655173632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,