Re: [FFmpeg-devel] [PATCH] avcodec/alac: don't fail if channels aren't set during init() when extradata is valid

2022-07-30 Thread Jan Ekström
On Sat, Jul 30, 2022 at 12:09 AM James Almer wrote: > > The decoder is meant to use it as a fallback if the value in extradata is > invalid. > > Regression since d199099be. > Had the person doing API client usage who reported this to me test the patch, it fixes the issue. LGTM. Would probably b

Re: [FFmpeg-devel] [PATCH 34/39] avcodec/mpegvideoencdsp: Allow pointers to const where possible

2022-07-30 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Jul 27, 2022 at 12:08:09AM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- >> libavcodec/mips/h263dsp_mips.h | 2 +- >> libavcodec/mips/mpegvideoencdsp_msa.c | 4

Re: [FFmpeg-devel] [PATCH v4 0/7] ICC profile support in avcodec

2022-07-30 Thread Niklas Haas
Merged as 1001bdc504. On Thu, 28 Jul 2022 16:49:55 +0200 Niklas Haas wrote: > This tidies up the previous patchset slightly and adds the necessary > user-facing bits to make it actually usable, plus tests. > > Will merge this soon since there was no additional feedback on v3. > > Changes in v4:

Re: [FFmpeg-devel] [PATCH] avcodec/alac: don't fail if channels aren't set during init() when extradata is valid

2022-07-30 Thread Jean-Baptiste Kempf
On Sat, 30 Jul 2022, at 11:41, Jan Ekström wrote: > Had the person doing API client usage who reported this to me test the > patch, it fixes the issue. > > LGTM. > > Would probably be worth it to back-port this to release/5.1 . I agree. -- Jean-Baptiste Kempf - President +33 672 704 734 __

Re: [FFmpeg-devel] [PATCH v2 1/2] lavfi/edge_common: Add 16bit versions of gaussian_blur and sobel

2022-07-30 Thread Thilo Borgmann
Am 29.07.22 um 15:11 schrieb Thilo Borgmann: Hi, 1/2 adds 16 bit versions of ff_gaussian_blur and ff_sobel. 2/2 adds new mode to cropdetect. v3 does it the template way for 1/2 as requested on IRC. v4 fixed bug in gaussian_blur. Otherwise identical. v5 fixes minor things mentioned on IRC

[FFmpeg-devel] [PATCH 1/2] avcodec/aacdec_fixed: add missing priv_class

2022-07-30 Thread James Almer
This enables the same input options as the float decoder. Signed-off-by: James Almer --- libavcodec/aacdec_fixed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c index 392a85e46a..ddfa160adc 100644 --- a/libavcodec/aacdec_fixed.c +++ b/l

[FFmpeg-devel] [PATCH 2/2] avcodec/aacdec_fixed: also clip samples on the second channel for stereo HE-AAC

2022-07-30 Thread James Almer
Fixes outputting silence on the second channel when decoding Parametic Stereo HE-AAC. Closes ticekt #3361. Signed-off-by: James Almer --- libavcodec/aacdec_template.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.

Re: [FFmpeg-devel] [PATCH] avcodec/alac: don't fail if channels aren't set during init() when extradata is valid

2022-07-30 Thread James Almer
On 7/30/2022 7:40 AM, Jean-Baptiste Kempf wrote: On Sat, 30 Jul 2022, at 11:41, Jan Ekström wrote: Had the person doing API client usage who reported this to me test the patch, it fixes the issue. LGTM. Would probably be worth it to back-port this to release/5.1 . I agree. Applied and back

[FFmpeg-devel] [PATCH v2] avformat/mxfdec: SMPTE RDD 48:2018 Amd 1:2022 support

2022-07-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mxf.c| 3 +++ libavformat/mxf.h| 1 + libavformat/mxfdec.c | 48 3 files changed, 52 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 36d662b58c..8ef928b8fc 100644 ---

Re: [FFmpeg-devel] [PATCH 34/39] avcodec/mpegvideoencdsp: Allow pointers to const where possible

2022-07-30 Thread Michael Niedermayer
On Sat, Jul 30, 2022 at 11:55:45AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Jul 27, 2022 at 12:08:09AM +0200, Andreas Rheinhardt wrote: > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- > >> libavcodec/mips/h263ds

[FFmpeg-devel] [PATCH 1/2] avformat/mov: fix frag_index.current out of sync

2022-07-30 Thread Zhao Zhili
From: Zhao Zhili frag_index.current is used by cenc_filter, and is updated inside mov_read_moof. It can out of sync regarding to mov_read_packet. Partly fix ticket #9807. --- libavformat/mov.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavf

[FFmpeg-devel] [PATCH 2/2] avformat/mov: fix encryption index in the case of multiple trun

2022-07-30 Thread Zhao Zhili
From: Zhao Zhili frag_stream_info->index_entry isn't the first sample/trun index. cenc.frag_index_entry_base failed to catch the case since current_index > 0. Fix ticket #9807. --- libavformat/isom.h | 3 ++- libavformat/mov.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-)

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_cropdetect: Remove set-but-unused variable

2022-07-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Will apply this patchset soon. libavfilter/vf_cropdetect.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/vf_cropdetect.c b/libavfilter/vf_cropdetect.c index eec0c7ab68..7e985fb271 100644 --- a/libavfilter/vf_cropdetect.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 2/2] tests/ref/fate/filter-metadata-cropdetect[12]: Fix ref file

2022-07-30 Thread Andreas Rheinhardt
Necessitated by 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b and 425b309fa43236f4b7c098c7829b70a421fc1dd7. Signed-off-by: Andreas Rheinhardt --- Did someone ever look why 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b made these changes? tests/ref/fate/filter-metadata-cropdetect1 | 20 +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_cropdetect: Remove set-but-unused variable

2022-07-30 Thread Martin Storsjö
On Sat, 30 Jul 2022, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Will apply this patchset soon. Thanks - please do! // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 2/2] tests/ref/fate/filter-metadata-cropdetect[12]: Fix ref file

2022-07-30 Thread James Almer
On 7/30/2022 5:25 PM, Andreas Rheinhardt wrote: Necessitated by 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b and 425b309fa43236f4b7c098c7829b70a421fc1dd7. Signed-off-by: Andreas Rheinhardt --- Did someone ever look why 6ca43a9675d651d7ea47c7ba2fafb1bf831c4d0b made these changes? My guess (because

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: fix frag_index.current out of sync

2022-07-30 Thread Steven Liu
Zhao Zhili 于2022年7月31日 周日01:15写道: > From: Zhao Zhili > > frag_index.current is used by cenc_filter, and is updated inside > mov_read_moof. It can out of sync regarding to mov_read_packet. > > Partly fix ticket #9807. > --- > libavformat/mov.c | 27 ++- > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH] avformat/mov: get the correct fragment stream info when decrypting the sample

2022-07-30 Thread quinkbl...@foxmail.com
OK, I didn't see this one before working on ticket #9807. Comments inline. On 2022-07-22, 1035567130 wrote: >From: Wang Yaqiang > > When using mov_read_packet get a pkt, and the packet is encrypted, > it will invoke the cenc_filter func for process the decryption. > This function find the frag

[FFmpeg-devel] [PATCH] avcodec/ttmlenc: Use string literal macro for default namespacing

2022-07-30 Thread Andreas Rheinhardt
Fixes -Werror=format-security build failures when building with disabled optimizations and (according to fate.ffmpeg.org also with several other old GCC versions). Signed-off-by: Andreas Rheinhardt --- Will apply this soon to unbreak FATE. libavcodec/ttmlenc.c | 2 +- libavcodec/ttmlenc.h |

[FFmpeg-devel] [PATCH 1/2] avcodec/alpha/me_cmp_alpha: Use proper me_cmp_func type

2022-07-30 Thread Andreas Rheinhardt
ea41e6d6373063c3a2a9bf48ce8e1c2e6340b694 forgot the int->ptrdiff_t switch for the stride. Libav didn't do it because Libav had already dropped support for Alpha at that point. Only compilation has been tested for this commit. (It might be that the ASM-versions of me_cmp_func functions need to be u

[FFmpeg-devel] [PATCH 2/2] avcodec/alpha/me_cmp_alpha: Remove commented-out function

2022-07-30 Thread Andreas Rheinhardt
This function is bitrotten: It uses different parameters than the corresponding ASM functions which replaced it. Signed-off-by: Andreas Rheinhardt --- libavcodec/alpha/me_cmp_alpha.c | 43 - 1 file changed, 43 deletions(-) diff --git a/libavcodec/alpha/me_cmp_alp