Re: [FFmpeg-devel] [PATCH] WBMP (Wireless Application Protocol Bitmap) image format

2022-07-27 Thread Andreas Rheinhardt
Peter Ross: > --- > > example: > https://example-files.online-convert.com/raster%20image/wbmp/example.wbmp > > Changelog | 1 + > doc/general_contents.texi | 2 + > libavcodec/Makefile | 2 + > libavcodec/allcodecs.c| 2 + > libavcodec/codec_desc.c | 7 +++ > li

[FFmpeg-devel] [PATCH 12/39] avcodec/dvdec: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/dv.h| 4 ++-- libavcodec/dvdec.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletio

[FFmpeg-devel] [PATCH 03/39] avcodec/threadframe: Constify the frame in ff_thread_await_progress

2022-07-27 Thread Andreas Rheinhardt
It is safe to call it on a const ThreadFrame*. Signed-off-by: Andreas Rheinhardt --- libavcodec/pthread_frame.c | 2 +- libavcodec/threadframe.h | 2 +- libavcodec/utils.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pth

[FFmpeg-devel] [PATCH 04/39] avcodec: Constify ThreadFrames if possible

2022-07-27 Thread Andreas Rheinhardt
This is possible now that ff_thread_await_progress() accepts a const ThreadFrame*. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_slice.c | 2 +- libavcodec/hevc_mvs.c| 2 +- libavcodec/hevcdec.c | 4 ++-- libavcodec/rv34.c| 2 +- libavcodec/vp3.c

[FFmpeg-devel] [PATCH 02/39] avcodec/hevcdec: Constify src pointers of HEVC DSP functions

2022-07-27 Thread Andreas Rheinhardt
This is possible now that the HEVC DSP API treats them as const. Also constify the AVFrames whose data is used as source in such cases. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 06/39] avcodec/wavpack: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/wavpack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wav

[FFmpeg-devel] [PATCH 11/39] avcodec/dxv: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/dxv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxv.c b

[FFmpeg-devel] [PATCH 09/39] avcodec/magicyuv: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH 07/39] avcodec/vp8: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b

[FFmpeg-devel] [PATCH 08/39] avcodec/proresdec2: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/proresdec2.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 13/39] avcodec/diracdec: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/diracdec.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-)

[FFmpeg-devel] [PATCH 10/39] avcodec/jpeg2000dec: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[FFmpeg-devel] [PATCH 05/39] avcodec/vp9dec: Constify VP9TileData->VP9Context pointer target

2022-07-27 Thread Andreas Rheinhardt
This is possible now that ff_thread_await_progress() accepts a const ThreadFrame*. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp9_mc_template.c | 2 +- libavcodec/vp9block.c| 30 +++--- libavcodec/vp9dec.h | 4 +--- libavcodec/vp9mvs.c |

[FFmpeg-devel] [PATCH 14/39] avcodec/half2float: Constify arrays in half2float()

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/half2float.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/half2float.h b/libavcodec/half2float.h index fd11caffdf..7df6747e50 100644 --- a/libavcodec/half2float.h +++ b/libavcodec/half2float.h @@ -61,8 +61,8 @@

[FFmpeg-devel] [PATCH 35/39] avcodec/mpegvideodsp: Constify src pointers

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideodsp.c | 4 ++-- libavcodec/mpegvideodsp.h | 6 +++--- libavcodec/ppc/mpegvideodsp.c | 2 +- libavcodec/x86/mpegvideodsp.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideodsp.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/hq_hqa: Remove transient GetByteContext from context

2022-07-27 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/hq_hqa.c | 48 +++-- > libavcodec/hq_hqa.h | 2 -- > 2 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/libavcodec/hq_hqa.c b/libavcodec/hq_hqa.c > index 9a07d8311

[FFmpeg-devel] [PATCH 26/39] avcodec/pnmdec: Fix indentation

2022-07-27 Thread Andreas Rheinhardt
Forgotten after ff1450e449f848ad4b37b3cf448315ba4581364e. Signed-off-by: Andreas Rheinhardt --- libavcodec/pnmdec.c | 139 ++-- 1 file changed, 70 insertions(+), 69 deletions(-) diff --git a/libavcodec/pnmdec.c b/libavcodec/pnmdec.c index 7cf9886ce7..1304

[FFmpeg-devel] [PATCH 29/39] avcodec/pngenc: Don't cast const away unnecessarily

2022-07-27 Thread Andreas Rheinhardt
Possible since 529a9893d769f381b72785c500662be2020da5fe. Signed-off-by: Andreas Rheinhardt --- libavcodec/pngenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 25cf769931..c4742e293f 100644 --- a/libavcodec/pngenc.c +++ b/lib

[FFmpeg-devel] [PATCH 31/39] avcodec/me_cmp: Constify me_cmp_func buffer parameters

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/me_cmp_init_aarch64.c | 6 +- libavcodec/alpha/me_cmp_alpha.c | 12 ++-- libavcodec/alpha/me_cmp_mvi_asm.S| 2 +- libavcodec/arm/me_cmp_init_arm.c | 10 +-- libavcodec/me_cmp.c | 80 ++

[FFmpeg-devel] [PATCH 28/39] avcodec/snow: Remove unused halfpel_plane

2022-07-27 Thread Andreas Rheinhardt
Committed in 5be3a818719d613e2f225cf1532fda01ba106b04 in an unfinished state; never used or finished and always disabled. Signed-off-by: Andreas Rheinhardt --- libavcodec/snow.c | 67 +-- libavcodec/snow.h | 1 - 2 files changed, 1 insertion(+), 67 de

[FFmpeg-devel] [PATCH 30/39] avcodec/lossless_videoencdsp: Constify src sub_left_predict

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/lossless_videoencdsp.c | 2 +- libavcodec/lossless_videoencdsp.h | 2 +- libavcodec/x86/lossless_videoencdsp.asm| 2 +- libavcodec/x86/lossless_videoencdsp_init.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH 17/39] swscale/rgb2rgb: Don't cast const away

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libswscale/rgb2rgb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c index b8be76913b..4f1ac9c465 100644 --- a/libswscale/rgb2rgb.c +++ b/libswscale/rgb2rgb.c @@ -317,7 +317,7 @@ voi

[FFmpeg-devel] [PATCH 18/39] avcodec/gif: Remove redundant cast

2022-07-27 Thread Andreas Rheinhardt
Possible since 529a9893d769f381b72785c500662be2020da5fe. Signed-off-by: Andreas Rheinhardt --- libavcodec/gif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 4904f791ef..8e84b79b8c 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.

[FFmpeg-devel] [PATCH 20/39] avcodec/diracdsp: Don't cast const away unnecessarily

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/diracdsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/diracdsp.c b/libavcodec/diracdsp.c index aafdddcdc3..284f914f9d 100644 --- a/libavcodec/diracdsp.c +++ b/libavcodec/diracdsp.c @@ -139,7 +139,7 @@ ADD_OBM

[FFmpeg-devel] [PATCH 32/39] avcodec/h264chroma: Constify src in h264_chroma_mc_func

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/h264chroma_init_aarch64.c | 12 +- libavcodec/aarch64/h264cmc_neon.S| 4 +- libavcodec/aarch64/rv40dsp_init_aarch64.c| 8 +- libavcodec/aarch64/vc1dsp_init_aarch64.c | 8 +- libavcodec/arm/h264chroma_init_arm.c

[FFmpeg-devel] [PATCH 22/39] avcodec/cinepakenc: Avoid casting const away

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cinepakenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index 95af3cc7ef..1b7c901685 100644 --- a/libavcodec/cinepakenc.c +++ b/libavcodec/cinepakenc.c @@ -429,7 +429,7

[FFmpeg-devel] [PATCH 19/39] avcodec/fitsenc: Don't cast const away unnecessarily

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/fitsenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/fitsenc.c b/libavcodec/fitsenc.c index 5e9100be85..6e0597c8ca 100644 --- a/libavcodec/fitsenc.c +++ b/libavcodec/fitsenc.c @@ -36,9 +36,8 @@ #include "encod

[FFmpeg-devel] [PATCH 15/39] avcodec/exr: Constify slice threads' ptr to main context

2022-07-27 Thread Andreas Rheinhardt
Modifying the main context from a slice thread is (usually) a data race, so it must not happen. So only use a pointer to const to access the main context. Signed-off-by: Andreas Rheinhardt --- libavcodec/exr.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) di

[FFmpeg-devel] [PATCH 21/39] avcodec/dxv: Don't cast const away unnecessarily

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dxv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 2a055a3438..13c028d8ba 100644 --- a/libavcodec/dxv.c +++ b/libavcodec/dxv.c @@ -432,7 +432,7 @@ static int get_opcodes(GetByteContex

[FFmpeg-devel] [PATCH 24/39] avcodec/ilbcdec: Move transient GetBitContext from ctx to stack

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ilbcdec.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavcodec/ilbcdec.c b/libavcodec/ilbcdec.c index 4905ee4145..2bc559a3e8 100644 --- a/libavcodec/ilbcdec.c +++ b/libavcodec/ilbcdec.c @@ -91,7 +91,6

[FFmpeg-devel] [PATCH 23/39] avcodec/ilbcdec: Fix const correctness

2022-07-27 Thread Andreas Rheinhardt
Also constify everything that can be constified. Signed-off-by: Andreas Rheinhardt --- libavcodec/ilbcdec.c | 66 +--- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/libavcodec/ilbcdec.c b/libavcodec/ilbcdec.c index 4c82631c34..4905ee4145

[FFmpeg-devel] [PATCH 25/39] avcodec/pnmdec, pnm_parser: Improve const-correctness

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pnm.c| 2 +- libavcodec/pnm.h| 6 +++--- libavcodec/pnm_parser.c | 8 libavcodec/pnmdec.c | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/pnm.c b/libavcodec/pnm.c index 605a529622..

[FFmpeg-devel] [PATCH 16/39] avcodec/xwdenc: Don't modify input frame

2022-07-27 Thread Andreas Rheinhardt
These modifications were actually meant to be applied to the coded_frame, yet 08b31a72dbcf2935e871ef7c1ffa96ae200f78aa changed this and so this code has not been removed when coded_frame has been removed in 11bc79089378a5ec00547d0f85bc152afdf30dfa. Signed-off-by: Andreas Rheinhardt --- libavcode

[FFmpeg-devel] [PATCH 27/39] avcodec/videodsp: Constify buf in VideoDSPContext.prefetch

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/videodsp_init.c | 2 +- libavcodec/arm/videodsp_init_armv5te.c | 2 +- libavcodec/loongarch/videodsp_init.c | 2 +- libavcodec/mips/videodsp_init.c| 2 +- libavcodec/ppc/videodsp.c | 2 +- libavcodec/videodsp.c

[FFmpeg-devel] [PATCH 34/39] avcodec/mpegvideoencdsp: Allow pointers to const where possible

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- libavcodec/mips/h263dsp_mips.h | 2 +- libavcodec/mips/mpegvideoencdsp_msa.c | 4 ++-- libavcodec/mpegvideoencdsp.c | 10 +- libavcodec/mpegvideoencdsp.h

[FFmpeg-devel] [PATCH 33/39] avcodec/cfhdencdsp: Constify input pointers

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cfhdencdsp.c | 6 +++--- libavcodec/cfhdencdsp.h | 4 ++-- libavcodec/x86/cfhdencdsp_init.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/cfhdencdsp.c b/libavcodec/cfhdencdsp.c index 3a35522d6

[FFmpeg-devel] [PATCH 39/39] avcodec/mpegvideo: Inline values in ff_update_block_index()

2022-07-27 Thread Andreas Rheinhardt
This is possible for most of the callers, because e.g. only the MPEG-4 decoder can have bits_per_raw_sample > 8. Also most mpegvideo-based codecs are 420 only. Signed-off-by: Andreas Rheinhardt --- libavcodec/h261dec.c | 4 ++-- libavcodec/h261enc.c | 2 +- libavcodec/h263dec.c

[FFmpeg-devel] [PATCH 36/39] avcodec/motion_est: Constify pointers to frame data

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/motion_est.c | 31 +-- libavcodec/motion_est.h | 4 ++-- 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 0903536697..29ab41dc8c 100644 --- a/libav

[FFmpeg-devel] [PATCH 37/39] avcodec/mpegvideo_motion: Constify ff_mpv_motion

2022-07-27 Thread Andreas Rheinhardt
Also constify the corresponding code in mpegvideo.c that handles lowres. (Unfortunately, not everything that is const could be constified: ref_picture could be made const uint8_t* const* if C allowed the safe automatic conversion from uint8_t**; and pix_op, qpix_op could be made to point to const f

[FFmpeg-devel] [PATCH 38/39] avcodec: Constify frame->data pointers for encoders where possible

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c| 2 +- libavcodec/adpcmenc.c | 4 ++-- libavcodec/asvenc.c | 6 +++--- libavcodec/avuienc.c| 2 +- libavcodec/bmpenc.c | 3 ++- libavcodec/cfhdenc.c| 15 --

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat: refactor ff_stream_encode_params_copy() to ff_stream_params_copy()

2022-07-27 Thread Pierre-Anthony Lemieux
On Tue, Jul 26, 2022 at 8:17 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > As discussed at > > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298491.html. > > Note that ff_stream_params_copy() does not copy the index field, which is > > usually

Re: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP

2022-07-27 Thread Xiang, Haihao
On Mon, 2022-07-25 at 05:22 +, Xiang, Haihao wrote: > On Mon, 2022-07-18 at 09:09 +, Xiang, Haihao wrote: > > On Fri, 2022-07-15 at 13:06 +0800, Fei Wang wrote: > > > From: Xu Guangxin > > > > > > According to C.5.2.2, item 2. When we got an IRAP, and the > > > NoOutputOfPriorPicsFlag = 0

Re: [FFmpeg-devel] [PATCH 07/39] avcodec/vp8: Constify slice threads' ptr to main context

2022-07-27 Thread Ronald S. Bultje
Hi, On Wed, Jul 27, 2022 at 5:31 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Modifying the main context from a slice thread is (usually) > a data race, so it must not happen. So only use a pointer to const > to access the main context. > > Signed-off-by: Andreas Rheinhardt >

Re: [FFmpeg-devel] [PATCH 05/39] avcodec/vp9dec: Constify VP9TileData->VP9Context pointer target

2022-07-27 Thread Ronald S. Bultje
Hi, On Wed, Jul 27, 2022 at 5:32 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > This is possible now that ff_thread_await_progress() accepts > a const ThreadFrame*. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp9_mc_template.c | 2 +- > libavcodec/vp9block.c

[FFmpeg-devel] ffmpeg.org issue today

2022-07-27 Thread Michael Niedermayer
Hi all ffmpeg.org was down today, heres what I know & what happened i woke up, looked at IRC saw someone saying ffmpeg.org is down, tried loging in with ssh and that timed out (i kept trying to login while trying other things) i mailed the other root admins and started to look around what i foun

[FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0

2022-07-27 Thread Fei Wang
Previous default value 0.0 means 100% transparency for overlaid video, which make overlaid invisible. Change to 1.0 will let output video much more clear and less confuse if user doesn't specify alpha value. Signed-off-by: Fei Wang --- doc/filters.texi | 2 +- libavfilter/vf_overla

[FFmpeg-devel] [PATCH v1 1/2] doc/filters: correct description of overlay_vaapi

2022-07-27 Thread Fei Wang
Signed-off-by: Fei Wang --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 9c4dea9abc..47ac4dc7f4 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -26117,8 +26117,8 @@ Set the height of the overlaid video o

Re: [FFmpeg-devel] [PATCH v1 1/2] doc/filters: correct description of overlay_vaapi

2022-07-27 Thread Gyan Doshi
On 2022-07-27 06:06 pm, Fei Wang wrote: Signed-off-by: Fei Wang --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 9c4dea9abc..47ac4dc7f4 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -26117,8 +26

Re: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0

2022-07-27 Thread Gyan Doshi
Typo in title. On 2022-07-27 06:06 pm, Fei Wang wrote: Previous default value 0.0 means 100% transparency for overlaid video, which make overlaid invisible. Change to 1.0 will let output video much more clear and less confuse if user doesn't specify alpha value. " The present default value o

[FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
Replaced all abort() by av_abort() in the code. On production systems, when dealing with malformed data, avcodec was sometime aborting, with no core/memory dump available to troubleshoot after-the-fact. Adding av_abort_set_callback to register a custom function (instead of the default straight abor

[FFmpeg-devel] [PATCH] avfilter/vf_zscale: Add smpte240m transfer option and fix matrix option typo

2022-07-27 Thread Mattias Wadman
--- libavfilter/vf_zscale.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 91166dcbcb..999147b587 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -1033,6 +1033,7 @@ static const AVOption zscale_opt

[FFmpeg-devel] [PATCH] lavu/pixfmt: summarize yuv naming conventions

2022-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/pixfmt.h | 17 + 1 file changed, 17 insertions(+) Note: we have log2_chroma_h = 2 for yuv410p, meaning each chroma pixel is 4×4 luma pixels, but everywhere I look on the web, ilcuding: https://en.wikipedia.org/wiki/Chroma_subsampling I

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Nicolas George
Julien Vary (12022-07-27): > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to register a custom > functio

Re: [FFmpeg-devel] [PATCH] avfilter/vf_zscale: Add smpte240m transfer option and fix matrix option typo

2022-07-27 Thread Paul B Mahol
lgtm, please someone push this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavu/pixfmt: summarize yuv naming conventions

2022-07-27 Thread Hendrik Leppkes
On Wed, Jul 27, 2022 at 5:25 PM Nicolas George wrote: > > Signed-off-by: Nicolas George > --- > libavutil/pixfmt.h | 17 + > 1 file changed, 17 insertions(+) > > > Note: we have log2_chroma_h = 2 for yuv410p, meaning each chroma pixel > is 4×4 luma pixels, but everywhere I look o

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Hendrik Leppkes
On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: > > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread Vignesh Venkatasubramanian
Stores the item ids of all the items found in the file and processes the primary item at the end of the meta box. This patch does not change any behavior. It sets up the code for parsing alpha channel (and possibly images with 'grid') in follow up patches. Signed-off-by: Vignesh Venkatasubramanian

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread Vignesh Venkatasubramanian
On Tue, Jul 26, 2022 at 12:02 PM James Zern wrote: > > On Fri, Jul 22, 2022 at 11:21 AM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > > > wrote: > > > > > > > > On Thu, J

Re: [FFmpeg-devel] [PATCH] lavu/pixfmt: summarize yuv naming conventions

2022-07-27 Thread Nicolas George
Hendrik Leppkes (12022-07-27): > Following the actual naming convention, you would arrive at a 4x2 > grid, however even the Wikipedia article linked above is inconsistent > with that. In the first section describing how the naming convention > works, it lists an exception that 4:1:0 is supposedly r

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
> abort() should generally not be in a reachable part of the code - not inside > any of the libraries anyway, ffmpeg.c is a different topic. > If it is reachable with any input files, and not just present to shut up > compilers, this is a bug and should be addressed to return an error instead.

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Andreas Rheinhardt
Julien Vary: > >> abort() should generally not be in a reachable part of the code - not inside >> any of the libraries anyway, ffmpeg.c is a different topic. >> If it is reachable with any input files, and not just present to shut up >> compilers, this is a bug and should be addressed to return

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread James Almer
On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: I recognize that this patch is going to be somewhat controversial. I'm submitting it mostly to see what the opinions are and evaluate options. I am working on improving performance for aarch64. On that architecture, there are fewer hand written as

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Marton Balint
On Wed, 27 Jul 2022, Hendrik Leppkes wrote: On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: Replaced all abort() by av_abort() in the code. On production systems, when dealing with malformed data, avcodec was sometime aborting, with no core/memory dump available to troubleshoot after-th

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Andreas Rheinhardt
James Almer: > On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: >> I recognize that this patch is going to be somewhat controversial. I'm >> submitting it mostly to see what the opinions are and evaluate >> options. I am working on improving performance for aarch64. On that >> architecture, there are

Re: [FFmpeg-devel] [PATCH] checkasm: Silence warnings about unused return value from read()

2022-07-27 Thread Andreas Rheinhardt
Swinney, Jonathan: > This patch looks good to me. I would appreciate its merging. > Why do you use this extra variable instead of just casting the return value of read to void? - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
>> abort() should generally not be in a reachable part of the code - not >> inside any of the libraries anyway, ffmpeg.c is a different topic. >> If it is reachable with any input files, and not just present to shut >> up compilers, this is a bug and should be addressed to return an error >> i

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Nicolas George
Julien Vary (12022-07-27): > >Or maybe we could add av_abort() as an alias to av_assert0(0), which > >eventually just calls abort()... > > I agree that if the goal is to bail-out on 'should-not-be-reachable' > code, something that alias av_assert0(0) seems a great idea. > Shall we then give a more

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Swinney, Jonathan > Sent: Wednesday, July 27, 2022 7:35 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 > and higher > > I recognize that this patch is going to be somewhat c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread James Zern
On Wed, Jul 27, 2022 at 9:12 AM Vignesh Venkatasubramanian wrote: > > Stores the item ids of all the items found in the file and > processes the primary item at the end of the meta box. This patch > does not change any behavior. It sets up the code for parsing > alpha channel (and possibly images

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread Andreas Rheinhardt
Vignesh Venkatasubramanian: > Stores the item ids of all the items found in the file and > processes the primary item at the end of the meta box. This patch > does not change any behavior. It sets up the code for parsing > alpha channel (and possibly images with 'grid') in follow up > patches. > >

Re: [FFmpeg-devel] [PATCH v2 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm

2022-07-27 Thread Emil Velikov
On Thu, 21 Jul 2022 at 21:47, Mark Thompson wrote: > > On 20/07/2022 17:41, Emil Velikov wrote: > > On Tue, 19 Jul 2022 at 19:16, Nicolas George wrote: > >> > >> Emil Velikov (12022-07-19): > >>> As you may know the libva* set of libraries share an internal ABI > >>> between them. In a resent lib

Re: [FFmpeg-devel] [PATCH v2 0/3] hwcontext_vaapi: dlopen libva-x11 and libva-drm

2022-07-27 Thread Timo Rothenpieler
On 27/07/2022 21:51, Emil Velikov wrote: On Thu, 21 Jul 2022 at 21:47, Mark Thompson wrote: On 20/07/2022 17:41, Emil Velikov wrote: On Tue, 19 Jul 2022 at 19:16, Nicolas George wrote: Emil Velikov (12022-07-19): As you may know the libva* set of libraries share an internal ABI between th

[FFmpeg-devel] [PATCH v2 2/3] avcodec/videodsp: Constify buf in VideoDSPContext.prefetch

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/videodsp_init.c | 2 +- libavcodec/arm/videodsp_init_armv5te.c | 2 +- libavcodec/loongarch/videodsp_init.c | 2 +- libavcodec/mips/videodsp_init.c| 2 +- libavcodec/ppc/videodsp.c | 2 +- libavcodec/videodsp.c

[FFmpeg-devel] [PATCH v2 3/3] avcodec/h264chroma: Constify src in h264_chroma_mc_func

2022-07-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/h264chroma_init_aarch64.c | 12 +- libavcodec/aarch64/h264cmc_neon.S| 4 +- libavcodec/aarch64/rv40dsp_init_aarch64.c| 8 +- libavcodec/aarch64/vc1dsp_init_aarch64.c | 8 +- libavcodec/arm/h264chroma_init_arm.c

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Hendrik Leppkes
On Wed, Jul 27, 2022 at 7:39 PM James Almer wrote: > > On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: > > I recognize that this patch is going to be somewhat controversial. I'm > > submitting it mostly to see what the opinions are and evaluate options. I > > am working on improving performance f

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Martin Storsjö
On Wed, 27 Jul 2022, Hendrik Leppkes wrote: On Wed, Jul 27, 2022 at 7:39 PM James Almer wrote: On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: I recognize that this patch is going to be somewhat controversial. I'm submitting it mostly to see what the opinions are and evaluate options. I am

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Hendrik Leppkes
On Wed, Jul 27, 2022 at 11:02 PM Martin Storsjö wrote: > > On Wed, 27 Jul 2022, Hendrik Leppkes wrote: > > > On Wed, Jul 27, 2022 at 7:39 PM James Almer wrote: > >> > >> On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: > >>> I recognize that this patch is going to be somewhat controversial. I'm >

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Andreas Rheinhardt
Hendrik Leppkes: > On Wed, Jul 27, 2022 at 7:39 PM James Almer wrote: >> >> On 7/27/2022 2:34 PM, Swinney, Jonathan wrote: >>> I recognize that this patch is going to be somewhat controversial. I'm >>> submitting it mostly to see what the opinions are and evaluate options. I >>> am working on im

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: Continue if a block fails to decode correctly

2022-07-27 Thread Mohammad AlSaleh
Don't give up on the whole frame just because a block failed to decode correctly. Try to continue decoding if the AV_EF_EXPLODE flag is not set. Signed-off-by: Mohammad AlSaleh --- libavcodec/mjpegdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Wednesday, July 27, 2022 10:42 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc > 7 and higher > > On Wed, Jul

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread James Almer
On 7/27/2022 10:02 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Hendrik Leppkes Sent: Wednesday, July 27, 2022 10:42 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher On Wed

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Thursday, July 28, 2022 3:05 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc > 7 and higher > > On 7/27/2022 10:02 PM, Soft Works wrote: > > > >> -O

Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc 7 and higher

2022-07-27 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Thursday, July 28, 2022 3:11 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] enable auto vectorization for gcc > 7 and higher > > > > > -Origin

Re: [FFmpeg-devel] [PATCH] qsv: Update ffmpeg qsv_errors to recognize GPU hang and other statuses

2022-07-27 Thread Xiang, Haihao
On Mon, 2022-07-25 at 08:27 -0700, Dmitry Rogozhkin wrote: > GPU hang is one of the most typical errors on Intel GPUs in > case something goes wrong. It's important to recognize it > explicitly for easier bugs triage. Also, this error code > can be used to trigger GPU recovery path in self-written