James Almer:
> The doxy for av_channel_layout_describe() states that the user should look
> at the return value to check if the string was truncated. Returning an error
> code in this scenario goes against this and is an API break.
>
> This is a better fix than the one committed in 8154cb7c2f for
Hello Paul,
On Sat, 2 Jul 2022, at 22:40, Paul B Mahol wrote:
>> I am convinced that doing deduplication afterwards is a better order
>> for getting this done. I'm also convinced that my patchset is pretty
>> [...]
>
> AFAIK only NIcolas is for this merge of different types of filters into
> singl
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Thanks for the comments.
I'll update the patch set.
... and comment inline:
On 2022/07/02 1:08, Mao Hata wrote:
In aribcaption_close() (libaribcaption.c):
```
if (ctx->renderer) {
aribcc_renderer_free(ctx->renderer);
ctx->decoder = NULL;
}
```
This should be `ctx->renderer = NULL;`.
I
Andreas Rheinhardt (12022-07-03):
> > if (!av_bprint_is_complete(bp))
> > -return AVERROR(ENOMEM);
> > +break;
> >
> Isn't this actually still against the API? av_channel_layout_describe()
> will not return the correct number of bytes necessary to wri
To support bitmap type of subtitles, remove AV_CODEC_PROP_TEXT_SUB
property from codec descriptor for AV_CODEC_ID_ARIB_CAPTION.
It is similar way to `libavcodec/libzvbi-teletextdec.c`
(AV_CODEC_ID_DVB_TELETEXT).
Instead, each subtitle decoder has to specify subtitile format.
`libavcodec/libaribb24
This patch set add another ARIB caption decoder using libaribcaption
external library: https://github.com/xqq/libaribcaption
The library decodes subtitles of ISDB-based TV broadcasting.
It is not only for Japanese ARIB STD-B24 caption, but also for
Brazilian ABNT NBR 15606-1 and Philippines version
Some additional properties are set for ARIB caption.
* need_parsing = 0
ARIB caption doesn't require any parser.
This avoids "parser not found" warning message.
* need_context_update = 1
When any profiles are changed, set this flag to notify.
* codecpar->width / codecpar->height
Find best v
This patch add another ARIB caption decoder using libaribcaption
external library.
Unlike libaribb24, it supports 3 types of subtitle outputs:
* text: plain text
* ass: ASS formatted text
* bitmap: bitmap image
Default subtitle type is ass as same as libaribb24.
To compile with this feature:
* l
Signed-off-by: TADANO Tokumei
---
doc/decoders.texi | 99 +++
1 file changed, 99 insertions(+)
diff --git a/doc/decoders.texi b/doc/decoders.texi
index e2fcbf5dc9..c9d65e7dad 100644
--- a/doc/decoders.texi
+++ b/doc/decoders.texi
@@ -349,6 +349,105 @@
It is only used by mpegvideo-based decoders - specifically mpeg12, intelh263,
ituh263, mpeg4video.
---
libavcodec/get_bits.h | 11 ---
libavcodec/intelh263dec.c | 1 +
libavcodec/ituh263dec.c | 1 +
libavcodec/mpegvideodec.h | 10 ++
4 files changed, 12 insertions(+), 11 de
From: Alexandra Hájková
The cached bitstream reader was originally written by Alexandra Hájková
for Libav, with significant input from Kostya Shishkov and Luca Barbato.
It was then committed to FFmpeg in ca079b09549, by merging it with the
implementation of the current bitstream reader.
This mer
---
libavcodec/Makefile | 2 +
libavcodec/tests/bitstream_be.c | 19
libavcodec/tests/bitstream_le.c | 20
libavcodec/tests/bitstream_template.c | 153 ++
tests/fate/libavcodec.mak | 10 ++
5 files changed, 204 insert
On Sun, Jul 3, 2022 at 9:59 AM Jean-Baptiste Kempf wrote:
> Hello Paul,
>
> On Sat, 2 Jul 2022, at 22:40, Paul B Mahol wrote:
> >> I am convinced that doing deduplication afterwards is a better order
> >> for getting this done. I'm also convinced that my patchset is pretty
> >> [...]
> >
> > AFAI
> Quoting Wu, Tong1 (2022-07-01 08:51:28)
> > Plus, do you think adding a AV_PIX_FMT_FLAG_HWACCEL check for the
> > input pixel format and change the function name to
> > av_hwdevice_get_type_by_hwaccel_pix_fmt will help?
>
> I'd prefer not to, that name is way too long
>
> > Let users know only
On Sun, Jul 3, 2022 at 12:15 AM Vignesh Venkatasubramanian
wrote:
>
> On Sat, Jul 2, 2022 at 12:35 PM Jan Ekström wrote:
> >
> > On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian
> > wrote:
> > >
> > > On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote:
> > > >
> > > > Quoting Vignesh V
Add a function to get the corresponding AVHWDeviceType from a given
hardware pixel format.
Signed-off-by: Tong Wu
---
libavutil/hwcontext.c | 11 +++
libavutil/hwcontext.h | 12
2 files changed, 23 insertions(+)
diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c
ind
When a derive_device_type is not specified, the hwmap filter should be
able to retrieve AVHWDeviceType from outlink->format and create
corresponding hwdevice context.
Signed-off-by: Tong Wu
---
libavfilter/vf_hwmap.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --gi
When two formats lists cannot be merged, a scale filter is
auto-inserted. However, when it comes to hardware map, we have to
manually add a hwmap filter to do the conversion. This patch introduces
an auto hwmap filter to do the hwmap conversion automatically and
modifies the negotiation structures,
Anton Khirnov:
> From: Alexandra Hájková
>
> The cached bitstream reader was originally written by Alexandra Hájková
> for Libav, with significant input from Kostya Shishkov and Luca Barbato.
> It was then committed to FFmpeg in ca079b09549, by merging it with the
> implementation of the current
Timo Rothenpieler (12022-06-29):
> The lavfi avdevice as it is right now can't output "special frames"
> like hardware frames.
> This patch makes the lavfi avdevice output wrapped AVFrames instead
> of copying the actual data, greatly simplifying it in the process.
Thanks for the patch. I am not f
Tong Wu (12022-07-03):
> When two formats lists cannot be merged, a scale filter is
> auto-inserted. However, when it comes to hardware map, we have to
> manually add a hwmap filter to do the conversion. This patch introduces
> an auto hwmap filter to do the hwmap conversion automatically and
> mod
Anton Khirnov:
> It is only used by mpegvideo-based decoders - specifically mpeg12, intelh263,
> ituh263, mpeg4video.
> ---
> libavcodec/get_bits.h | 11 ---
> libavcodec/intelh263dec.c | 1 +
> libavcodec/ituh263dec.c | 1 +
> libavcodec/mpegvideodec.h | 10 ++
> 4 files c
On 03.07.2022 15:19, Nicolas George wrote:
Timo Rothenpieler (12022-06-29):
The lavfi avdevice as it is right now can't output "special frames"
like hardware frames.
This patch makes the lavfi avdevice output wrapped AVFrames instead
of copying the actual data, greatly simplifying it in the proc
Steven Hartland (12022-07-02):
> I'm using concat to join multiple files from a GoPro camera including the
> three metadata streams, with the early return it fails as the metadata
> stream information is missing so map fails.
> I believe the reason for the failure is that this early return prevent
Nicolas George:
> Steven Hartland (12022-07-02):
>> I'm using concat to join multiple files from a GoPro camera including the
>> three metadata streams, with the early return it fails as the metadata
>> stream information is missing so map fails.
>
>> I believe the reason for the failure is that t
Andreas Rheinhardt (12022-07-03):
> > For example, with your change, if you concatenate a file with metadata
> > "start_time=12:00" and another with "start_time=12:01", it will generate
> > a file with both metadata entries instead of just the first one as would
> > be desirable.
> Actually, the n
Signed-off-by: Michael Niedermayer
---
libavformat/avienc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/avienc.c b/libavformat/avienc.c
index 2264241d57..14115b3e2b 100644
--- a/libavformat/avienc.c
+++ b/libavformat/avienc.c
@@ -426,6 +426,10 @@ static int avi_write_heade
Signed-off-by: Michael Niedermayer
---
libavcodec/ffv1dec_template.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/ffv1dec_template.c b/libavcodec/ffv1dec_template.c
index 0b1d176ba1..9b1d65e825 100644
--- a/libavcodec/ffv1dec_template.c
+++ b/libavcode
Fixes: Timeout
Fixes:
48619/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-5793597923917824
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/ffv1dec.c | 8
1 file change
This limit is possibly not reachable due to other restrictions on buffers but
the decoder run table is too small beyond this, so explicitly check for it.
Signed-off-by: Michael Niedermayer
---
libavcodec/ffv1dec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/ffv1dec.c b/liba
On 30.06.2022 02:01, mohamed Elhadidy wrote:
GSoC'22 GPU accelerated video filters
Added CUDA chromakeyfilter
libavfilter/vf_chromakey_cuda.cu:the CUDA kernel for the filter
libavfilter/vf_chromakey_cuda.c: the C side that calls the kernel and gets user
input
libavfilter/allfilters.c: added the
On Sun, Jul 3, 2022 at 5:18 AM Jan Ekström wrote:
>
> On Sun, Jul 3, 2022 at 12:15 AM Vignesh Venkatasubramanian
> wrote:
> >
> > On Sat, Jul 2, 2022 at 12:35 PM Jan Ekström wrote:
> > >
> > > On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian
> > > wrote:
> > > >
> > > > On Sat, Jul 2,
On Sat, Jul 02, 2022 at 07:18:16PM +0200, Nicolas George wrote:
> Paul B Mahol (12022-07-02):
> > Can this be properly finally be fully reviewed and accepted?
>
> As long as the patch does not have a solution to have all the utility
> filters (setpts, trim, concat, etc.) working with subtitles too
On Sat, Jul 02, 2022 at 03:27:03PM +0200, Thilo Borgmann wrote:
> Am 02.07.22 um 14:22 schrieb Michael Niedermayer:
> > Fixes: out of array access
> > Fixes:
> > 48145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5054524173189120
> >
> > Found-by: continuous fuzzing process
> > h
On Sun, Jul 03, 2022 at 10:15:02AM +0200, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics i
On Sun, Jul 3, 2022 at 7:07 PM Michael Niedermayer
wrote:
> On Sat, Jul 02, 2022 at 07:18:16PM +0200, Nicolas George wrote:
> > Paul B Mahol (12022-07-02):
> > > Can this be properly finally be fully reviewed and accepted?
> >
> > As long as the patch does not have a solution to have all the util
From: Pierre-Anthony Lemieux
As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does not
currently preserve stream information such as language in the case of audio
streams. This patch is modeled on copy_stream_props() at avformat/concatdec.c.
---
libavformat/imfdec.c | 5
p...@sandflow.com:
> From: Pierre-Anthony Lemieux
>
> As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does not
> currently preserve stream information such as language in the case of audio
> streams. This patch is modeled on copy_stream_props() at avformat/concatdec.c.
>
> -
On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
wrote:
>
> p...@sandflow.com:
> > From: Pierre-Anthony Lemieux
> >
> > As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does
> > not
> > currently preserve stream information such as language in the case of audio
> > streams.
Pierre-Anthony Lemieux:
> On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
> wrote:
>>
>> p...@sandflow.com:
>>> From: Pierre-Anthony Lemieux
>>>
>>> As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does
>>> not
>>> currently preserve stream information such as language in
On Sun, Jul 3, 2022 at 12:15 PM Andreas Rheinhardt
wrote:
>
> Pierre-Anthony Lemieux:
> > On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
> > wrote:
> >>
> >> p...@sandflow.com:
> >>> From: Pierre-Anthony Lemieux
> >>>
> >>> As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer
Pierre-Anthony Lemieux:
> On Sun, Jul 3, 2022 at 12:15 PM Andreas Rheinhardt
> wrote:
>>
>> Pierre-Anthony Lemieux:
>>> On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt
>>> wrote:
p...@sandflow.com:
> From: Pierre-Anthony Lemieux
>
> As discussed at https://trac.ffmpeg.or
On 7/3/2022 7:00 AM, Nicolas George wrote:
Andreas Rheinhardt (12022-07-03):
if (!av_bprint_is_complete(bp))
-return AVERROR(ENOMEM);
+break;
Isn't this actually still against the API? av_channel_layout_describe()
will not return the correct nu
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Sunday, July 3, 2022 9:28 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Wu, Tong1
> Subject: Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an
> auto hwmap filt
> On Fri, Jul 01, 2022 at 01:34:34PM +0800, Wenbin Chen wrote:
> > For 422 frames we should not use hard coded 8 to calculate mb size for
> > uv plane. Chroma shift should be taken into consideration to be
> > compatiple with different sampling format.
> >
> > The error is reported by fate test whe
For 422 frames we should not use hard coded 8 to calculate mb size for
uv plane. Chroma shift should be taken into consideration to be
compatiple with different sampling format.
The error is reported by fate test when av_cpu_max_align() return 64
on the platform supporting AVX512. This is a hidden
Change whitespace and add newline to unify the code style.
Signed-off-by: Wenbin Chen
---
libavcodec/mpegvideo_enc.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 970f71fe37..c9d9e2a764 100644
---
On 2022-07-02 03:21 pm, Gyan Doshi wrote:
On 2022-07-02 02:12 pm, Anton Khirnov wrote:
Quoting Gyan Doshi (2022-07-01 13:03:04)
On 2022-07-01 03:33 pm, Anton Khirnov wrote:
Quoting Gyan Doshi (2022-06-25 10:29:51)
This is a per-file input option that adjusts an input's timestamps
with re
> On Jun 27, 2022, at 5:57 PM, Zhao Zhili wrote:
>
> davs2_decoder_close doesn't free those on the fly frames which
> don't get output yet. It's a design bug, but easy to workaround.
>
> Before the patch:
> Direct leak of 1198606 byte(s) in 2 object(s) allocated from:
>#0 0x563af5e1e5f0 i
Quoting Gyan Doshi (2022-07-02 11:51:49)
>
>
> On 2022-07-02 02:12 pm, Anton Khirnov wrote:
> > Quoting Gyan Doshi (2022-07-01 13:07:13)
> >>
> >> On 2022-07-01 03:20 pm, Anton Khirnov wrote:
> >>> Quoting Gyan Doshi (2022-06-28 08:40:58)
> On 2022-06-28 10:43 am, Anton Khirnov wrote:
>
On 2022-07-04 10:12 am, Anton Khirnov wrote:
Quoting Gyan Doshi (2022-07-02 11:51:49)
On 2022-07-02 02:12 pm, Anton Khirnov wrote:
Quoting Gyan Doshi (2022-07-01 13:07:13)
On 2022-07-01 03:20 pm, Anton Khirnov wrote:
Quoting Gyan Doshi (2022-06-28 08:40:58)
On 2022-06-28 10:43 am, Anton K
Quoting Gyan Doshi (2022-07-02 11:51:53)
>
>
> On 2022-07-02 02:12 pm, Anton Khirnov wrote:
> > Quoting Gyan Doshi (2022-07-01 13:03:04)
> >>
> >> On 2022-07-01 03:33 pm, Anton Khirnov wrote:
> >>> Quoting Gyan Doshi (2022-06-25 10:29:51)
> This is a per-file input option that adjusts an inp
Quoting Gyan Doshi (2022-07-04 05:47:31)
>
>
> On 2022-07-02 03:21 pm, Gyan Doshi wrote:
> >
> >
> > On 2022-07-02 02:12 pm, Anton Khirnov wrote:
> >> Quoting Gyan Doshi (2022-07-01 13:03:04)
> >>>
> >>> On 2022-07-01 03:33 pm, Anton Khirnov wrote:
> Quoting Gyan Doshi (2022-06-25 10:29:51)
> Quoting Wenbin Chen (2022-06-23 07:32:42)
> > From: Yue Heng
> >
> > Enable dynamic QP configuration in runtime on qsv encoder. Through
> > AVFrame->metadata, we can set key "qsv_config_qp" to change QP
> > configuration when we encode video in CQP mode.
> >
> > Signed-off-by: Yue Heng
> > Sign
Quoting Chen, Wenbin (2022-07-04 08:33:49)
> > Why is this using frame metadata rather than the AVVideoEncParams side
> > data?
>
> The usage of AVVideoEncParams relates to the "qp" variable in mfxEncodeCtrl
> which is passed
> to MFXVideoENCODE_encoderFrameAsync(). This variable in qsv is for pe
56 matches
Mail list logo
