[FFmpeg-devel] [PATCH v4 0/7] avformat/movenc: normalize on AC-3 parser usage

2022-06-23 Thread Jan Ekström
The simplified parsing currently in `mov_write_ac3_tag` trusts the content of the packets a bit too much (the AC-3 parser returns all data fed to it, including any possible data before the start code), while the existing E-AC-3 logic does proper header validation by utilizing the (E-)AC-3 parser.

[FFmpeg-devel] [PATCH v4 1/7] avcodec: make AC-3 bit rate table available in a separate header

2022-06-23 Thread Jan Ekström
From: Jan Ekström This makes it possible to include it from libavformat Signed-off-by: Jan Ekström --- libavcodec/Makefile | 8 +--- libavcodec/ac3_bitrate_tab.c | 22 ++ libavcodec/ac3_bitrate_tab.h | 33 + libavcodec/ac3tab.c

[FFmpeg-devel] [PATCH v4 2/7] {configure, avformat/movenc}: enable AC-3 parser for movenc

2022-06-23 Thread Jan Ekström
From: Jan Ekström This simplifies the code to no longer have #ifs in a manner which does not require handling avpriv_ac3_parse_header returning ENOSYS. As an existing example, the MPEG-TS muxer already requires the AC-3 parser, and in order to fix existing issues with the current AC-3 movenc cod

[FFmpeg-devel] [PATCH v4 3/7] avformat/movenc: enable handle_eac3 to handle AC-3 tracks

2022-06-23 Thread Jan Ekström
From: Jan Ekström Add the AC-3 frame type, as well as early exit from additional packet parsing in case of AC-3, as only a single packet is required to get the required information. Signed-off-by: Jan Ekström --- libavformat/movenc.c | 11 ++- 1 file changed, 10 insertions(+), 1 deleti

[FFmpeg-devel] [PATCH v4 4/7] avformat/movenc: move eac3_info definition so that it can be used for AC-3

2022-06-23 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavformat/movenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c24b11cf5f..103f958d75 100644 --- a/libavformat/movenc.c +++

[FFmpeg-devel] [PATCH v4 5/7] avformat/movenc: utilize existing AC-3 parsing workflow for AC-3

2022-06-23 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/Makefile | 1 + libavformat/Makefile | 1 + libavformat/ac3_bitrate_tab.c | 22 ++ libavformat/movenc.c | 55 +-- 4 files changed, 51 insertions(+), 28 deletions

[FFmpeg-devel] [PATCH v4 6/7] avformat/movenc: handle OOM situations when parsing AC-3 headers

2022-06-23 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavformat/movenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a071f1cdd5..58ba0bc545 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -420,7 +420,10 @

[FFmpeg-devel] [PATCH v4 7/7] avformat/movenc: limit ISOBMFF AC-3 mapping to bsids <=8

2022-06-23 Thread Jan Ekström
From: Jan Ekström This leaves out RealAudio DolbyNet, which utilizes bsids 9 and 10, It is not clear whether the interpreted bit rate value (divided by 2 or 4 depending on the variant), or the original bit rate value should be utilized to receive the bit_rate_code index. Signed-off-by: Jan Ekst

Re: [FFmpeg-devel] [PATCH v4 5/7] avformat/movenc: utilize existing AC-3 parsing workflow for AC-3

2022-06-23 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > Signed-off-by: Jan Ekström > --- > libavcodec/Makefile | 1 + > libavformat/Makefile | 1 + > libavformat/ac3_bitrate_tab.c | 22 ++ > libavformat/movenc.c | 55 +-- > 4 files changed,

[FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-23 Thread Zhao Zhili
From: Zhao Zhili Regression from 45e3b6a68. cuvidParseVideoData report unknown error with AV1CodecConfigurationRecord. --- libavcodec/cuviddec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index cb3cda7e24..584fff40ed 100644 ---

[FFmpeg-devel] [PATCH] fftools/ffmpeg: rework -shortest implementation

2022-06-23 Thread Anton Khirnov
The -shortest option (which finishes the output file at the time the shortest stream ends) is currently implemented by faking the -t option when an output stream ends. This approach is fragile, since it depends on the frames/packets being processed in a specific order. E.g. there are currently some

Re: [FFmpeg-devel] [PATCH v4 5/7] avformat/movenc: utilize existing AC-3 parsing workflow for AC-3

2022-06-23 Thread Jan Ekström
On Thu, Jun 23, 2022 at 11:57 AM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > Signed-off-by: Jan Ekström > > --- > > libavcodec/Makefile | 1 + > > libavformat/Makefile | 1 + > > libavformat/ac3_bitrate_tab.c | 22 ++ > > libavformat

[FFmpeg-devel] [PATCH] lavc/aarch64: add hevc chroma loop filter 8-12bit

2022-06-23 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_deblock_neon.S | 168 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 14 ++ 3 files changed, 184 insertions(+), 1 deletion(-) create mode 100644 libavcodec/aarch64/hev

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add hevc chroma loop filter 8-12bit

2022-06-23 Thread J. Dekker
On 23 Jun 2022, at 12:52, J. Dekker wrote: > Signed-off-by: J. Dekker > --- > libavcodec/aarch64/Makefile | 3 +- > libavcodec/aarch64/hevcdsp_deblock_neon.S | 168 ++ > libavcodec/aarch64/hevcdsp_init_aarch64.c | 14 ++ > 3 files changed, 184 insertions(+

Re: [FFmpeg-devel] [PATCH 5/5] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-23 Thread Anton Khirnov
Quoting Paul B Mahol (2022-06-17 17:26:23) > On Fri, Jun 17, 2022 at 5:01 PM James Almer wrote: > > And make sure changes are not making decoders slower than currently are. fraps * before: 2.07428 +- 0.00101 seconds time elapsed * after: 2.073444 +- 0.000678 seconds time elapsed * -> same withi

Re: [FFmpeg-devel] [PATCH 5/5] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-23 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2022-06-18 16:31:55) > On Fri, 17 Jun 2022, at 17:26, Paul B Mahol wrote: > > On Fri, Jun 17, 2022 at 5:01 PM James Almer wrote: > > > >> On 6/17/2022 12:00 PM, Paul B Mahol wrote: > >> > NAK > >> > >> You'll have to give a reason for your NAK.> > > > Remove Alexandra

[FFmpeg-devel] [PATCH] avformat: allow .ec3 as extension for raw E-AC-3 stream

2022-06-23 Thread Ruben Gonzalez
In addition to .eac3, .ec3 is also commonly used by people to name raw E-AC-3 streams. Enables automatic recognition of the eac3 format for the .ac3 extension. For instance Dolby Digital Plus software only support files with .ec3. Files with .eac3 are not supported. Check issue #18 in the public d

[FFmpeg-devel] [PATCH 1/2] lavc/aarch64: new 8-bit hevc 16x16 idct

2022-06-23 Thread J. Dekker
old: hevc_idct_16x16_8_c: 5366.2 hevc_idct_16x16_8_neon: 1493.2 new: hevc_idct_16x16_8_c: 5363.2 hevc_idct_16x16_8_neon: 943.5 Co-developed-by: Rafal Dabrowa Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S| 666 ++ libavcodec/aarch64/hevcdsp_init_aar

[FFmpeg-devel] [PATCH 2/2] lavc/aarch64: add 8-bit hevc 32x32 idct

2022-06-23 Thread J. Dekker
hevc_idct_32x32_8_c: 40128.5 hevc_idct_32x32_8_neon: 7102.0 Co-developed-by: Rafal Dabrowa Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S| 1265 + libavcodec/aarch64/hevcdsp_init_aarch64.c |2 + 2 files changed, 1267 insertions(+) Written by th

[FFmpeg-devel] [PATCH 1/4] get_bits: move check_marker() to mpegvideodec.h

2022-06-23 Thread Anton Khirnov
It is only used by mpegvideo-based decoders - specifically mpeg12, intelh263, ituh263, mpeg4video. --- Resending the set rebased against current master (there conflicts with 2d764069be3b4092dc986467660607d922023332) and with patch 04 skipped, as Andreas pointed out issues with it. It is not needed

[FFmpeg-devel] [PATCH 2/4] lavc: add standalone cached bitstream reader

2022-06-23 Thread Anton Khirnov
From: Alexandra Hájková The cached bitstream reader was originally written by Alexandra Hájková for Libav, with significant input from Kostya Shishkov and Luca Barbato. It was then committed to FFmpeg in ca079b09549, by merging it with the implementation of the current bitstream reader. This mer

[FFmpeg-devel] [PATCH 4/4] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-23 Thread Anton Khirnov
Use that instead of the merged version. --- libavcodec/get_bits.h | 297 +++--- 1 file changed, 50 insertions(+), 247 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index 9f2b1784d5..d9fc794c8c 100644 --- a/libavcodec/get_bits.h +++ b/l

[FFmpeg-devel] [PATCH 3/4] lavc/bitstream: templatize for BE/LE

2022-06-23 Thread Anton Khirnov
Allows using both BE and LE bitstream readers in the same file. --- libavcodec/bitstream.h | 379 ++ libavcodec/bitstream_template.h | 392 tests/ref/fate/source | 1 + 3 files changed, 415 insertions(+), 357 deletio

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2022-06-23 Thread Anton Khirnov
Quoting Carotti, Elias (2022-06-21 10:48:07) > Hi, > > extending AVVideoEncParams was the first hypothesis I made but it > didn't seem it was the proper place to add the mb_info flags. > > I may be wrong but my impression is that AVVideoEncParams is used to > carry encoding parameters read from t

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec/libjxldec: properly tag output colorspace

2022-06-23 Thread Anton Khirnov
Quoting Leo Izen (2022-06-02 04:14:11) > Whether an ICC profile is present or not, the decoder > should now properly tag the colorspace of pixel data > received by the decoder. > --- > libavcodec/libjxldec.c | 142 ++--- > 1 file changed, 133 insertions(+), 9 de

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-23 Thread Timo Rothenpieler
On 23/06/2022 11:10, Zhao Zhili wrote: From: Zhao Zhili Regression from 45e3b6a68. cuvidParseVideoData report unknown error with AV1CodecConfigurationRecord. --- libavcodec/cuviddec.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec

Re: [FFmpeg-devel] [PATCH v8 2/2] avcodec/libjxlenc: properly read input colorspace

2022-06-23 Thread Anton Khirnov
Quoting Leo Izen (2022-06-02 04:14:12) > Whether an ICC profile is present or not, the libjxl > encoder wrapper should now properly read colorspace tags > and forward them to libjxl appropriately, rather than just > assume sRGB as before. It will also print warnings when > colorimetric assumptions

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2022-06-23 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Carotti, Elias (2022-06-21 10:48:07) >> Hi, >> >> extending AVVideoEncParams was the first hypothesis I made but it >> didn't seem it was the proper place to add the mb_info flags. >> >> I may be wrong but my impression is that AVVideoEncParams is used to >> carry encoding

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe.c: Add new Function: The peak bit rate of video streams can be queried

2022-06-23 Thread Nicolas George
Wujian(Chin) (12022-06-23): > Code Process > - Calculate the frame rate first > - Obtain the maximum value of the total bytes of all packets according to the > number of frames per second > > Signed-off-by: wujian_nanjing > --- > fftools/ffprobe.c | 24 > ++

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2022-06-23 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-06-23 16:21:18) > Anton Khirnov: > > Quoting Carotti, Elias (2022-06-21 10:48:07) > >> Hi, > >> > >> extending AVVideoEncParams was the first hypothesis I made but it > >> didn't seem it was the proper place to add the mb_info flags. > >> > >> I may be wrong but my

[FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-23 Thread wolfleekay
From: Li Kai Refer to https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.5.2 Signed-off-by: Li Kai --- libavformat/hls.c | 68 ++- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 8204f

[FFmpeg-devel] [PATCH] fftools/ffmpeg: use last filter output pts to choose next output stream

2022-06-23 Thread Anton Khirnov
This will be needed in following commits that will add new buffering stages after encoding and bitstream filtering. --- also updated my branch ffmpeg_mt/mux --- fftools/ffmpeg.c | 22 +- fftools/ffmpeg.h | 2 ++ fftools/ffmpeg_opt.c | 1 + 3 files changed, 20 insertio

Re: [FFmpeg-devel] [PATCH v8 2/2] avcodec/libjxlenc: properly read input colorspace

2022-06-23 Thread Leo Izen
On 6/23/22 10:16, Anton Khirnov wrote: Quoting Leo Izen (2022-06-02 04:14:12) Whether an ICC profile is present or not, the libjxl encoder wrapper should now properly read colorspace tags and forward them to libjxl appropriately, rather than just assume sRGB as before. It will also print warning

Re: [FFmpeg-devel] [PATCH 1/4] get_bits: move check_marker() to mpegvideodec.h

2022-06-23 Thread Andreas Rheinhardt
Anton Khirnov: > It is only used by mpegvideo-based decoders - specifically mpeg12, intelh263, > ituh263, mpeg4video. > --- > Resending the set rebased against current master (there conflicts with > 2d764069be3b4092dc986467660607d922023332) and with patch 04 skipped, as > Andreas pointed out issues

Re: [FFmpeg-devel] [PATCH 3/4] lavc/bitstream: templatize for BE/LE

2022-06-23 Thread Andreas Rheinhardt
Anton Khirnov: > Allows using both BE and LE bitstream readers in the same file. > --- > libavcodec/bitstream.h | 379 ++ > libavcodec/bitstream_template.h | 392 > tests/ref/fate/source | 1 + > 3 files changed, 415

[FFmpeg-devel] [PATCH 1/3] checkasm/hevc_add_res: add 12bit test

2022-06-23 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/hevc_add_res.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/checkasm/hevc_add_res.c b/tests/checkasm/hevc_add_res.c index 0c896adaca..f17d121939 100644 --- a/tests/checkasm/hevc_add_res.c +++ b/tests/checkasm

[FFmpeg-devel] [PATCH 2/3] lavc/aarch64: reformat add_res funcs

2022-06-23 Thread J. Dekker
Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S | 216 - 1 file changed, 108 insertions(+), 108 deletions(-) diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S b/libavcodec/aarch64/hevcdsp_idct_neon.S index 0869431294..484eea8437 100644 --- a/libavco

[FFmpeg-devel] [PATCH 3/3] lavc/aarch64: hevc_add_res add 12bit variants

2022-06-23 Thread J. Dekker
hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-off-by: J. Dekker --- libavcodec/aarch64

Re: [FFmpeg-devel] [PATCH 4/4] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-23 Thread Andreas Rheinhardt
Anton Khirnov: > Use that instead of the merged version. > --- > libavcodec/get_bits.h | 297 +++--- > 1 file changed, 50 insertions(+), 247 deletions(-) > > diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h > index 9f2b1784d5..d9fc794c8c 100644 > ---

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add standalone cached bitstream reader

2022-06-23 Thread Andreas Rheinhardt
Anton Khirnov: > From: Alexandra Hájková > > The cached bitstream reader was originally written by Alexandra Hájková > for Libav, with significant input from Kostya Shishkov and Luca Barbato. > It was then committed to FFmpeg in ca079b09549, by merging it with the > implementation of the current

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Get number of operating points

2022-06-23 Thread James Zern
On Thu, Jun 16, 2022 at 10:36 AM James Zern wrote: > > On Thu, Jun 16, 2022 at 9:24 AM Wan-Teh Chang wrote: > > > > Use the new codec control AV1E_GET_NUM_OPERATING_POINTS to get the > > number of operating points. This is the size of the output arrays of > > AV1E_GET_SEQ_LEVEL_IDX and AV1E_GET_T

Re: [FFmpeg-devel] [PATCH v8 2/2] avcodec/libjxlenc: properly read input colorspace

2022-06-23 Thread Niklas Haas
On Wed, 01 Jun 2022 22:14:12 -0400 Leo Izen wrote: > Whether an ICC profile is present or not, the libjxl > encoder wrapper should now properly read colorspace tags > and forward them to libjxl appropriately, rather than just > assume sRGB as before. It will also print warnings when > colorimetric

Re: [FFmpeg-devel] [PATCH 24/35] fftools/ffmpeg: use the sync queues to handle -frames

2022-06-23 Thread Michael Niedermayer
On Thu, Jun 16, 2022 at 09:55:23PM +0200, Anton Khirnov wrote: > Same issues apply to it as to -shortest. > > Changes the results of the following tests: > - matroska-flac-extradata-update > The test reencodes two input FLAC streams into three output FLAC > streams. The last output stream is l

Re: [FFmpeg-devel] [PATCH] Use proper header for OpenBSD PPC CPU detection

2022-06-23 Thread Brad Smith
ping. On 3/2/2022 8:34 PM, Brad Smith wrote: Use the proper header for PPC CPU detection code. sys/param.h includes sys/types, but sys/types.h is the more appropriate header to be used here. diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index b022149fa0..96b491c716 100644 --- a/libavu

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correct timestamp overflow on multiple pcr loopback

2022-06-23 Thread Michael Niedermayer
On Thu, Jun 23, 2022 at 05:45:52PM +0200, Sébastien Rossi wrote: > - Detect and count PCR loopback > - Correct DTS and PTS with PCR loopback count to avoid timestamp overflow > and preserve timestamp continuity > libavformat/mpegts.c | 45 + > tests/ref/fate/ts-opus-demux | 1028 >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h2645_parse: Check HEVC NAL size

2022-06-23 Thread Michael Niedermayer
On Wed, Jun 22, 2022 at 01:05:22PM +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Michael Niedermayer: > >> Fixes: Assertion failure > >> Fixes: > >> 46662/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-4947860854013952 > >> > >> This also results in more frames to be de

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-23 Thread Steven Liu
于2022年6月23日周四 23:01写道: > > From: Li Kai Hi Li, > > Refer to https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.5.2 > > Signed-off-by: Li Kai > --- > libavformat/hls.c | 68 ++- > 1 file changed, 62 insertions(+), 6 deletions(-) > > diff --git a

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-23 Thread zhilizhao(赵志立)
> On Jun 23, 2022, at 10:14 PM, Timo Rothenpieler wrote: > > On 23/06/2022 11:10, Zhao Zhili wrote: >> From: Zhao Zhili >> Regression from 45e3b6a68. cuvidParseVideoData report unknown >> error with AV1CodecConfigurationRecord. >> --- >> libavcodec/cuviddec.c | 11 +++ >> 1 file chang

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxenc: return error value if encode failed

2022-06-23 Thread Steven Liu
because the AudioConverterFillComplexBuffer can return 0 or 1 if success. so set the ret to 0 it AudioConverterFillComplexBuffer success and return ret value for success or failed. Signed-off-by: Steven Liu --- libavcodec/audiotoolboxenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-23 Thread 少宇李
> > > Hi, Steven I got it. User could use "live_start_index" option even if #EXT-X-START in the playlist. I changed the priority about #EXT-X-START/live_start_index, this is new bellow: --- libavformat/hls.c | 69 +++ 1 file changed, 64 insertions(

[FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-23 Thread Zhao Zhili
From: Zhao Zhili cuvidParseVideoData only supports pure OBUs, it report unknown error with AV1CodecConfigurationRecord. Check whether extradata is AV1CodecConfigurationRecord and skip the first 4 bytes to fix the issue. The bug is revealed in ffmpeg cmd since 45e3b6a68 and ffd1316e. --- libavco

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: fix AV1 decoding error

2022-06-23 Thread zhilizhao(赵志立)
> On Jun 24, 2022, at 10:52 AM, zhilizhao(赵志立) wrote: > > > >> On Jun 23, 2022, at 10:14 PM, Timo Rothenpieler >> wrote: >> >> On 23/06/2022 11:10, Zhao Zhili wrote: >>> From: Zhao Zhili >>> Regression from 45e3b6a68. cuvidParseVideoData report unknown >>> error with AV1CodecConfiguration

Re: [FFmpeg-devel] [PATCH] avcodec/audiotoolboxenc: return error value if encode failed

2022-06-23 Thread zhilizhao(赵志立)
> On Jun 24, 2022, at 11:02 AM, Steven Liu wrote: > > because the AudioConverterFillComplexBuffer can return 0 or 1 if > success. > so set the ret to 0 it AudioConverterFillComplexBuffer success and > return ret value for success or failed. > > Signed-off-by: Steven Liu > --- > libavcodec/aud

Re: [FFmpeg-devel] [PATCH] avcodec/audiotoolboxenc: return error value if encode failed

2022-06-23 Thread Steven Liu
"zhilizhao(赵志立)" 于2022年6月24日周五 13:03写道: > > > > > On Jun 24, 2022, at 11:02 AM, Steven Liu wrote: > > > > because the AudioConverterFillComplexBuffer can return 0 or 1 if > > success. > > so set the ret to 0 it AudioConverterFillComplexBuffer success and > > return ret value for success or failed

[FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed

2022-06-23 Thread Steven Liu
because the AudioConverterFillComplexBuffer can return 0 or 1 if success. so set the ret to 0 it AudioConverterFillComplexBuffer success and return ret value for success or return AVERROR_EXTERNAL when AudioConverterFillComplexBuffer failed. BTW change the error message log level from warning to er

Re: [FFmpeg-devel] [PATCH] avformat/hls:use EXT-X-START instead of live_start_index if it's in playlist

2022-06-23 Thread Steven Liu
少宇李 于2022年6月24日周五 11:58写道: >> >> >> Hi, Steven > > > I got it. > > User could use "live_start_index" option even if #EXT-X-START in the playlist. > > I changed the priority about #EXT-X-START/live_start_index, > > this is new bellow: > > --- > libavformat/hls.c | 69 ++

Re: [FFmpeg-devel] [PATCH v2] avcodec/audiotoolboxenc: return external error if encode failed

2022-06-23 Thread zhilizhao(赵志立)
> On Jun 24, 2022, at 1:59 PM, Steven Liu wrote: > > because the AudioConverterFillComplexBuffer can return 0 or 1 if > success. > so set the ret to 0 it AudioConverterFillComplexBuffer success and > return ret value for success or return AVERROR_EXTERNAL when > AudioConverterFillComplexBuffer