Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

2022-06-18 Thread Gyan Doshi
On 2022-06-18 12:19 pm, Andreas Rheinhardt wrote: Gyan Doshi: Default avctx->frame_size is 0 which leads to init failure for audio MediaFoundation encoders. --- libavcodec/mfenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 13ed7b3e11

[FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Paolo Prete
Please review this. It's a code rewrite of doc/examples/muxing.c which improves readability and fixes issues. More specifically: *) Original functions of muxing.c have generic/unclear/ambiguous names and they don't group logically relatedblocks of code: this makes the code hard to read.See for e

Re: [FFmpeg-devel] [PATCH] avformat: add AVFormatContext.first_pts_wallclock

2022-06-18 Thread zhilizhao(赵志立)
> On Jun 18, 2022, at 12:01 PM, Gyan Doshi wrote: > > > On 2022-06-16 02:39 pm, Gyan Doshi wrote: >> Stores wallclock time for the first packet received with a pts. > > Comments? >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >> index f12fa7d904..56f9656a68 100644 >> --- a/l

Re: [FFmpeg-devel] [PATCH 5/5] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-18 Thread Jean-Baptiste Kempf
On Fri, 17 Jun 2022, at 17:26, Paul B Mahol wrote: > On Fri, Jun 17, 2022 at 5:01 PM James Almer wrote: > >> On 6/17/2022 12:00 PM, Paul B Mahol wrote: >> > NAK >> >> You'll have to give a reason for your NAK.> > Remove Alexandra from copyright from your refactoring of get_bits.h Copyright does

Re: [FFmpeg-devel] [PATCH] Make execute() and execute2() return FFMIN() of thread return codes

2022-06-18 Thread Anton Khirnov
Quoting Tomas Härdin (2022-06-17 11:42:25) > fre 2022-06-17 klockan 01:38 +0200 skrev Michael Niedermayer: > > On Thu, Jun 16, 2022 at 11:04:01PM +0200, Tomas Härdin wrote: > > > tor 2022-06-16 klockan 20:27 +0200 skrev Michael Niedermayer: > > > > > > > > >   > > > > >  void avpriv_slicethread_fr

Re: [FFmpeg-devel] [PATCH 01/13] lavc/jpeg2000dec: Finer granularity threading

2022-06-18 Thread Anton Khirnov
Quoting Tomas Härdin (2022-06-14 16:39:00) > Patch 12 in this series is optional since it's just me getting the > speed up on a specific machine > > /Tomas > > From 115aa26c343419e81c1b5ba0bfdb1615cbec27e9 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > Date: Fri, 10 Jun 2022

Re: [FFmpeg-devel] [PATCH 06/13] lavu/mem: Add ff_fast_recalloc()

2022-06-18 Thread Anton Khirnov
Quoting Tomas Härdin (2022-06-16 14:44:45) > ons 2022-06-15 klockan 09:15 -0300 skrev James Almer: > > On 6/15/2022 6:59 AM, Tomas Härdin wrote: > > > tis 2022-06-14 klockan 22:26 +0200 skrev Michael Niedermayer: > > > > On Tue, Jun 14, 2022 at 04:42:06PM +0200, Tomas Härdin wrote: > > > > > Left t

Re: [FFmpeg-devel] [PATCH 09/13] lavc/jpeg2000: Speed up ff_jpeg2000_tag_tree_init() using stereotypes for sizes <= 4x4

2022-06-18 Thread Anton Khirnov
Quoting Tomas Härdin (2022-06-14 16:43:38) > > > From 03b806f89453571310dcb14edbd9f51e059b7476 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > Date: Wed, 8 Jun 2022 10:08:15 +0200 > Subject: [PATCH 09/13] lavc/jpeg2000: Speed up ff_jpeg2000_tag_tree_init() > using stereotypes

Re: [FFmpeg-devel] [PATCH] avformat: add AVFormatContext.first_pts_wallclock

2022-06-18 Thread Anton Khirnov
Quoting Gyan Doshi (2022-06-18 06:01:21) > > > On 2022-06-16 02:39 pm, Gyan Doshi wrote: > > Stores wallclock time for the first packet received with a pts. > > Comments? This looks very ad-hoc and IMO does not belong in the library unless you have a very strong reason. -- Anton Khirnov _

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders.

2022-06-18 Thread Anton Khirnov
Quoting Gyan Doshi (2022-06-18 10:28:38) > > > On 2022-06-18 12:19 pm, Andreas Rheinhardt wrote: > > Gyan Doshi: > >> Default avctx->frame_size is 0 which leads to init failure for > >> audio MediaFoundation encoders. > >> --- > >> libavcodec/mfenc.c | 3 +++ > >> 1 file changed, 3 insertions(

Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO

2022-06-18 Thread Anton Khirnov
Quoting Carotti, Elias (2022-06-17 10:41:30) > Hi all, > any chance someone could possibly have a look at this patch, please? > Thanks in advance This looks like it belongs in AVVideoEncParams. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] avformat/librist: bump required version to 0.2.7

2022-06-18 Thread Marton Balint
On Fri, 10 Jun 2022, Marton Balint wrote: This is the first version for which fifo size setting actually works. Signed-off-by: Marton Balint --- configure | 2 +- libavformat/librist.c | 32 2 files changed, 1 insertion(+), 33 deletions(-) Pushe

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Leo Izen
On 6/18/22 08:06, Paolo Prete wrote: Please review this. It's a code rewrite of doc/examples/muxing.c which improves readability and fixes issues. From 8a4e942a001ae49dc052899f331ed43abf954dda Mon Sep 17 00:00:00 2001 From: paolo Date: Sat, 18 Jun 2022 13:53:55 +0200 Subject: [PATCH] doc/exampl

Re: [FFmpeg-devel] [PATCH 5/5] lavc/get_bits: add a compat wrapper for the cached bitstream reader

2022-06-18 Thread Paul B Mahol
On Sat, Jun 18, 2022 at 4:32 PM Jean-Baptiste Kempf wrote: > On Fri, 17 Jun 2022, at 17:26, Paul B Mahol wrote: > > On Fri, Jun 17, 2022 at 5:01 PM James Almer wrote: > > > >> On 6/17/2022 12:00 PM, Paul B Mahol wrote: > >> > NAK > >> > >> You'll have to give a reason for your NAK.> > > > Remove

Re: [FFmpeg-devel] [PATCH 2/2] avformat/demux: Count EAGAIN as 100 bytes in relation to read limit in avformat_find_stream_info()

2022-06-18 Thread Michael Niedermayer
On Fri, Jun 17, 2022 at 10:15:39PM +0200, Marton Balint wrote: > > > On Tue, 8 Feb 2022, Michael Niedermayer wrote: > > > Fixes: Timeout > > Fixes: > > 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5206008287330304 > > > > Found-by: continuous fuzzing process > > https://githu

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: Make read_frame_internal() return AVERREOR(EAGAIN) on stuck empty input parser

2022-06-18 Thread Michael Niedermayer
On Fri, Jun 17, 2022 at 09:53:13PM +0200, Marton Balint wrote: > > > On Tue, 8 Feb 2022, Michael Niedermayer wrote: > > > Fixes: read_frame_internal() which does not return even though both demuxer > > and parser do return > > Fixes: > > 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_f

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Andreas Rheinhardt
Paolo Prete: > Please review this. It's a code rewrite of doc/examples/muxing.c which > improves readability and fixes issues. > More specifically: > *) Original functions of muxing.c have generic/unclear/ambiguous names and > they don't group logically relatedblocks of code: this makes the code

[FFmpeg-devel] [PATCH 1/4] avformat/mov: Avoid cloning encryption info if its unchanged

2022-06-18 Thread Michael Niedermayer
Fixes: OOM Fixes: 45834/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5419540462305280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 11 --- 1 file changed, 8 inserti

[FFmpeg-devel] [PATCH 3/4] avcodec/aasc: Fix indention

2022-06-18 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/aasc.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/aasc.c b/libavcodec/aasc.c index d297cfad76..528ee58cdf 100644 --- a/libavcodec/aasc.c +++ b/libavcodec/aasc.c @@ -104,26 +1

[FFmpeg-devel] [PATCH 2/4] avformat/mov: Add special case for slow duplication loop in mov_read_trun()

2022-06-18 Thread Michael Niedermayer
This extra code is ugly, better solution is welcome Fixes: Timeout Fixes: 45700/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6141847792123904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- l

[FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust threshold for AASC

2022-06-18 Thread Michael Niedermayer
Fixes: Timeout Fixes: 47919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AASC_fuzzer-5176435830030336 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

[FFmpeg-devel] [PATCH 3/4] avcodec/aasc: Fix indention

2022-06-18 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/aasc.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/aasc.c b/libavcodec/aasc.c index d297cfad76..528ee58cdf 100644 --- a/libavcodec/aasc.c +++ b/libavcodec/aasc.c @@ -104,26 +1

[FFmpeg-devel] [PATCH 1/4] avformat/mov: Avoid cloning encryption info if its unchanged

2022-06-18 Thread Michael Niedermayer
Fixes: OOM Fixes: 45834/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5419540462305280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 11 --- 1 file changed, 8 inserti

[FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust threshold for AASC

2022-06-18 Thread Michael Niedermayer
Fixes: Timeout Fixes: 47919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AASC_fuzzer-5176435830030336 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

[FFmpeg-devel] [PATCH 2/4] avformat/mov: Add special case for slow duplication loop in mov_read_trun()

2022-06-18 Thread Michael Niedermayer
This extra code is ugly, better solution is welcome Fixes: Timeout Fixes: 45700/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-6141847792123904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- l

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: Avoid cloning encryption info if its unchanged

2022-06-18 Thread Michael Niedermayer
On Sat, Jun 18, 2022 at 10:03:00PM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 45834/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5419540462305280 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH] fftools/fopen_utf8: support long paths on Windows for fftools

2022-06-18 Thread Martin Storsjö
On Mon, 13 Jun 2022, softworkz wrote: From: softworkz Signed-off-by: softworkz --- fftools/fopen_utf8: support long paths on Windows for fftools After Nil's patchset, this is probably the final missing bit. Signed-off-by: softworkz softwo...@hotmail.com Published-As: https://gith

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_scale: Fix alignment for movdqa

2022-06-18 Thread Martin Storsjö
On Thu, 16 Jun 2022, Thilo Borgmann wrote: Hi, movdqa in ff_yuv2yuvX_sse3() expects a 16-byte alignment according to its documentation causing segfaults in fate-checkasm-sw_scale. LGTM, thanks! // Martin ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: Make read_frame_internal() return AVERREOR(EAGAIN) on stuck empty input parser

2022-06-18 Thread Marton Balint
On Sat, 18 Jun 2022, Michael Niedermayer wrote: On Fri, Jun 17, 2022 at 09:53:13PM +0200, Marton Balint wrote: On Tue, 8 Feb 2022, Michael Niedermayer wrote: Fixes: read_frame_internal() which does not return even though both demuxer and parser do return Fixes: 43717/clusterfuzz-testca

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mov: Add special case for slow duplication loop in mov_read_trun()

2022-06-18 Thread Marton Balint
On Sat, 18 Jun 2022, Michael Niedermayer wrote: This extra code is ugly, better solution is welcome If you work on fixing these issues, it is kind of your job to find an elegant and maintainable solution. If you can't find one with reasonable amount of work, then IMHO it is better to leav

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Martin Storsjö
On Fri, 17 Jun 2022, Nil Admirari wrote: wchartoutf8() converts strings returned by WinAPI into UTF-8, which is FFmpeg's preffered encoding. Some external dependencies, such as AviSynth, are still not Unicode-enabled. utf8toansi() converts UTF-8 strings into ANSI in two steps: UTF-8 -> wchar_t

Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-18 Thread Martin Storsjö
On Fri, 17 Jun 2022, Nil Admirari wrote: 1. getenv() is replaced with getenv_utf8() across libavformat. 2. New versions of AviSynth+ are now called with UTF-8 filenames. 3. Old versions of AviSynth are still using ANSI strings, but MAX_PATH limit on filename is removed. --- libavformat/avisynt

Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-18 Thread Martin Storsjö
On Sun, 19 Jun 2022, Martin Storsjö wrote: On Fri, 17 Jun 2022, Nil Admirari wrote: 1. getenv() is replaced with getenv_utf8() across libavformat. 2. New versions of AviSynth+ are now called with UTF-8 filenames. 3. Old versions of AviSynth are still using ANSI strings, but MAX_PATH limit on

Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-18 Thread Martin Storsjö
On Fri, 17 Jun 2022, Nil Admirari wrote: 1. getenv() is replaced with getenv_utf8() across libavformat. 2. New versions of AviSynth+ are now called with UTF-8 filenames. 3. Old versions of AviSynth are still using ANSI strings, but MAX_PATH limit on filename is removed. --- libavformat/avisynt

Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-18 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Martin Storsjö > Sent: Sunday, June 19, 2022 12:24 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v17 4/5] libavformat: Remove > MAX_PATH limit and use UTF-8 version of g

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Paolo Prete
Il sabato 18 giugno 2022, 17:18:18 CEST, Leo Izen ha scritto: >>On 6/18/22 08:06, Paolo Prete wrote:>> +{>> +    if (num)>> +        >>av_log(NULL, AV_LOG_ERROR, "%s (error '%s')\n", s, av_err2str(*num));>> +    >>else>> +        av_log(NULL, AV_LOG_ERROR, "%s\n", s);> +}>This does not need

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Paolo Prete
Il sabato 18 giugno 2022, 19:07:11 CEST, Andreas Rheinhardt ha scritto: >>Paolo Prete: >> Please review this. It's a code rewrite of doc/examples/muxing.c which >> improves readability and fixes issues. >> More specifically: >> *) Original functions of muxing.c have generic/unclear/a

Re: [FFmpeg-devel] [PATCH] doc/examples/muxing: code rewrite with improved readability and fixed issues

2022-06-18 Thread Paolo Prete
Sorry: I had problems with my email client in formatting the previous message. I just try to resend it. >> Il sabato 18 giugno 2022, 17:18:18 CEST, Leo Izen ha >> scritto: >>On 6/18/22 08:06, Paolo Prete wrote: >> +{ >> +    if (num) >> +        av_log(NULL, AV_LOG_ERROR, "%s (error '%s')\n", s

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Andreas Rheinhardt
Nil Admirari: > wchartoutf8() converts strings returned by WinAPI into UTF-8, > which is FFmpeg's preffered encoding. > > Some external dependencies, such as AviSynth, are still > not Unicode-enabled. utf8toansi() converts UTF-8 strings > into ANSI in two steps: UTF-8 -> wchar_t -> ANSI. > wcharto

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, June 19, 2022 6:59 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add > wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() > > Nil Admirari: >

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Andreas Rheinhardt
Soft Works: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Sunday, June 19, 2022 6:59 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add >> wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Martin Storsjö
On Sun, 19 Jun 2022, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Sunday, June 19, 2022 6:59 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and geten

Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-18 Thread Andreas Rheinhardt
Martin Storsjö: > On Sun, 19 Jun 2022, Soft Works wrote: > >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of >>> Andreas Rheinhardt >>> Sent: Sunday, June 19, 2022 6:59 AM >>> To: ffmpeg-devel@ffmpeg.org >>> Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add >>> wch