Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-06-13 Thread Paul B Mahol
Have you checked this with longer samples? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Paul B Mahol
On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer wrote: > On Sat, Jun 11, 2022 at 10:47:57AM +0200, Paul B Mahol wrote: > > Have you actually tested this "change" ? > > On every file i found > 6-methyl-5-hepten-2-one-CC-db_small.avi > fmvcVirtualDub_small.avi > skrzyzowanie4.avi > fmvc-poc.avi

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: make QSV encoder encode VAAPI and D3D11 frames directly

2022-06-13 Thread Anton Khirnov
Quoting Wu, Tong1 (2022-06-08 06:47:27) > > > > Quoting Tong Wu (2022-06-07 11:22:16) > > > QSV encoder is able to encode frames with VAAPI or D3D11 pixel format > > > directly. This patch adds support for qsv encoder to accept VAAPI and > > > D3D11 pixel formats as input. > > > > This looks like

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Anton Khirnov
Quoting Paul B Mahol (2022-06-13 10:04:04) > On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer > wrote: > > > On Sat, Jun 11, 2022 at 10:47:57AM +0200, Paul B Mahol wrote: > > > Have you actually tested this "change" ? > > > > On every file i found > > 6-methyl-5-hepten-2-one-CC-db_small.avi >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Paul B Mahol
On Mon, Jun 13, 2022 at 11:10 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-06-13 10:04:04) > > On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Sat, Jun 11, 2022 at 10:47:57AM +0200, Paul B Mahol wrote: > > > > Have you actually teste

Re: [FFmpeg-devel] [PATCH v9 08/10] qsv: support OPAQUE memory when MFX_VERSION < 2.0

2022-06-13 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-06-02 05:41:16) > From: Haihao Xiang > > OPAQUE memory isn't supported for MFX_VERSION >= 2.0[1][2]. This is in > preparation for oneVPL support > > [1] > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html#msdk-full-name-feature-re

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Anton Khirnov
Quoting Paul B Mahol (2022-06-13 11:34:44) > On Mon, Jun 13, 2022 at 11:10 AM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2022-06-13 10:04:04) > > > On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > > > > > > > On Sat, Jun 11, 2022 at 10:47:57AM

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Paul B Mahol
On Mon, Jun 13, 2022 at 11:48 AM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-06-13 11:34:44) > > On Mon, Jun 13, 2022 at 11:10 AM Anton Khirnov > wrote: > > > > > Quoting Paul B Mahol (2022-06-13 10:04:04) > > > > On Sat, Jun 11, 2022 at 4:55 PM Michael Niedermayer < > > > mich...@niederma

Re: [FFmpeg-devel] [PATCH v9 09/10] qsv: use a new method to create mfx session when using oneVPL

2022-06-13 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-06-02 05:41:17) > From: Haihao Xiang > > In oneVPL, MFXLoad() and MFXCreateSession() are required to create a > workable mfx session[1] > > Add config filters for D3D9/D3D11 session (galinart) > > The default device is changed to d3d11va for oneVPL when both d3d11va

Re: [FFmpeg-devel] Need info on how to run ffmpeg command using dll file

2022-06-13 Thread Martijn van Beurden
Op ma 13 jun. 2022 om 11:09 schreef Kumar, Rahul : > alternative instead of using "ffmpeg.exe" (as its size is 110 mb+ and we > want to avoid shipping it with our product). ? > Questions about use of ffmpeg are better posted at the user mailinglist, see https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: declare VLC table args as const

2022-06-13 Thread Leo Izen
On 6/12/22 16:01, Andreas Rheinhardt wrote: Leo Izen: Declaring the VLC table as const allows a caller to call get_vlc2() with a pre-generated static const table without generating warnings for -Wdiscarded-qualifiers. --- libavcodec/get_bits.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[FFmpeg-devel] [PATCH v14 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-13 Thread Nil Admirari
wchartoutf8() converts strings returned by WinAPI into UTF-8, which is FFmpeg's preffered encoding. Some external dependencies, such as AviSynth, are still not Unicode-enabled. utf8toansi() converts UTF-8 strings into ANSI in two steps: UTF-8 -> wchar_t -> ANSI. wchartoansi() is responsible for th

[FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread Nil Admirari
--- compat/w32dlfcn.h | 80 ++- libavcodec/mf_utils.h | 1 + 2 files changed, 65 insertions(+), 16 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94efafb..e49d3841aa 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -2

[FFmpeg-devel] [PATCH v14 5/5] libavfilter/vf_frei0r.c: Use UTF-8 version of getenv()

2022-06-13 Thread Nil Admirari
--- libavfilter/vf_frei0r.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index f11ae6e55c..727e96561a 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -31,6 +31,7 @@ #include "libavutil/a

[FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Nil Admirari
1. getenv() is replaced with getenv_utf8() across libavformat. 2. New versions of AviSynth+ are now called with UTF-8 filenames. 3. Old versions of AviSynth are still using ANSI strings, but MAX_PATH limit on filename is removed. --- libavformat/avisynth.c| 39 +++---

[FFmpeg-devel] [PATCH v14 3/5] fftools: Remove MAX_PATH limit and switch to UTF-8 versions of fopen() and getenv()

2022-06-13 Thread Nil Admirari
--- fftools/cmdutils.c | 53 +--- fftools/ffmpeg_opt.c | 9 ++-- 2 files changed, 47 insertions(+), 15 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3e10..5e7fbbe2ee 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmduti

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-13 Thread Vignesh Venkatasubramanian
On Mon, Jun 6, 2022 at 9:29 AM Vignesh Venkatasubramanian wrote: > > On Wed, Jun 1, 2022 at 12:47 PM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jun 1, 2022 at 11:52 AM xyesbee wrote: > > > > > > Why can it not accept it as one but two distinct streams? Why the extra > > > hurdle of alp

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-13 Thread Vignesh Venkatasubramanian
On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian wrote: > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh

Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-06-13 Thread nil-admirari
>> ... >> 1. fopen() is replaced with avpriv_fopen_utf8(), getenv() is made >> Unicode-aware >> on Windows, and wide version of get_module_filename() is used as it is now. > ... > For that, the first option sounds better - that sounds to me more like a > direction forward, not backwards. Done: h

Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nil > Admirari > Sent: Monday, June 13, 2022 6:26 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove > MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW > > --- > compa

Re: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows

2022-06-13 Thread nil-admirari
> ... > > - defining NO_DSHOW_STRSAFE in libavcodec/mf_utils.h > ... > Or if we'd add the define projectwide in e.g. configure it probably > wouldn't be that bad? Kinda like how we already add > "-D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS" in MSVC builds. > Then we wouldn't need to wor

Re: [FFmpeg-devel] [PATCH v13 3/4] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread nil-admirari
> src/libavutil/wchar_filename.h: In function ‘add_extended_prefix’: > src/libavutil/wchar_filename.h:211:9: error: > ‘wcscpy_instead_use_StringCbCopyW_or_StringCchCopyW’ > undeclared (first use in this function) > wcscpy(temp_w, unc_prefix); are fixed by defining NO_DSHOW_STRSAFE: https://ffmpeg

Re: [FFmpeg-devel] [PATCH v13 2/4] libavformat/avisynth.c: Remove MAX_PATH limit

2022-06-13 Thread nil-admirari
> Presumably, the original manifest idea, parsed down to only using it to > force FFmpeg into UTF-8, would be sufficient for this, right? UTF-8 in manifest was rejected as too far-reaching, and then longs paths were reimplemented with \\?\ prefixes, so now there is no manifest at all. > The Wind

Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread nil-admirari
> Why do you use a 'do' loop? Can't you use the normal 2-step > approach, i.e. call the winapi function with a NULL buffer, > and then use the returned size to allocate the buffer. > This way you always need a single allocation only. GetModuleFileNameW does not follow this convention: https://docs

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-13 Thread James Zern
On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian wrote: > > AVIF specification allows for alpha channel as an auxiliary item (in > case of still images) or as an auxiliary track (in case of animated > images). Add support for both of these. The AVIF muxer will take > exactly two streams

Re: [FFmpeg-devel] [PATCH] avcodec/exif: Move tag_list out of header

2022-06-13 Thread Thilo Borgmann
 > Am 12.06.2022 um 20:46 schrieb Andreas Rheinhardt > : > It is only used by exif.c (and e.g. EXIF_TAG_NAME_LENGTH > is an implementation detail anyway). > Also remove the sentinel, as it is used in conjunction > with FF_ARRAY_ELEMS. > > Signed-off-by: Andreas Rheinhardt > --- LGTM if test

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nil > Admirari > Sent: Monday, June 13, 2022 6:26 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH > limit and use UTF-8 version of getenv() > > 1. getenv() is replaced with ge

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Hendrik Leppkes
On Mon, Jun 13, 2022 at 7:47 PM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Nil > > Admirari > > Sent: Monday, June 13, 2022 6:26 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH > > limit an

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Monday, June 13, 2022 8:55 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove > MAX_PATH limit and use UTF-8 version of

Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > nil-admir...@mailo.com > Sent: Monday, June 13, 2022 7:03 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove > MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW >

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Stephen Hutchinson
On 6/13/22 2:55 PM, Hendrik Leppkes wrote: This seems unrelated to this patch, which is about removing the MAX_PATH limit. The code previously converted UTF-8 to ANSI, and still does so now, just without the MAX_PATH limit. Further improvements tangential to this topic can, and should, be applied

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-13 Thread Michael Niedermayer
On Mon, Jun 13, 2022 at 12:10:44PM +0200, Paul B Mahol wrote: > On Mon, Jun 13, 2022 at 11:48 AM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2022-06-13 11:34:44) > > > On Mon, Jun 13, 2022 at 11:10 AM Anton Khirnov > > wrote: > > > > > > > Quoting Paul B Mahol (2022-06-13 10:04:04) > > > >

Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nil > Admirari > Sent: Monday, June 13, 2022 6:26 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove > MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW > > --- > compa

Re: [FFmpeg-devel] [PATCH 2/2] ffprobe: add -o option

2022-06-13 Thread Marton Balint
On Sun, 12 Jun 2022, Stefano Sabatini wrote: On date Thursday 2022-06-09 21:09:02 +0200, Marton Balint wrote: On Sun, 3 Apr 2022, Stefano Sabatini wrote: [...] Updated again, now it's locally passing fate with FATE samples (don't remember if other issues were spotted the past time). This

Re: [FFmpeg-devel] [PATCH v14 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8()

2022-06-13 Thread Martin Storsjö
On Mon, 13 Jun 2022, Nil Admirari wrote: wchartoutf8() converts strings returned by WinAPI into UTF-8, which is FFmpeg's preffered encoding. Some external dependencies, such as AviSynth, are still not Unicode-enabled. utf8toansi() converts UTF-8 strings into ANSI in two steps: UTF-8 -> wchar_t

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread nil-admirari
> I like the version check. I don't know about all the derivatives > of AviSynth, but I assume you have checked that it's valid for > the common ones (or at least the original non-Plus variant)? Interface version was changed to 7 in 2020: https://github.com/AviSynth/AviSynthPlus/commit/40900dc1c54

[FFmpeg-devel] [PATCH] fftools/ffprobe: report avio errors

2022-06-13 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffprobe.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4e2fdbaec8..5020ba484c 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -545,12 +545,13 @@ static const AVClass

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > nil-admir...@mailo.com > Sent: Monday, June 13, 2022 10:53 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove > MAX_PATH limit and use UTF-8 version of getenv() > > > I like the ver

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-06-13 Thread Michael Niedermayer
On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote: > Have you checked this with longer samples? ive tested it with the files in the bink directory on samples anything else i should test it with ? thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB T

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-06-13 Thread Paul B Mahol
On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer wrote: > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote: > > Have you checked this with longer samples? > > ive tested it with the files in the bink directory on samples > anything else i should test it with ? > Something longer,

Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()

2022-06-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Monday, June 13, 2022 11:53 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove > MAX_PATH limit and use UTF-8 version of gete

[FFmpeg-devel] [PATCH] avcodec/vlc: Use structure instead of VLC_TYPE array as VLC element

2022-06-13 Thread Andreas Rheinhardt
In C, qualifiers for arrays are broken: const VLC_TYPE (*foo)[2] is a pointer to an array of two const VLC_TYPE elements and unfortunately this is not compatible with a pointer to a const array of two VLC_TYPE, because the latter does not exist as array types are never qualified (the qualifier appl

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-06-13 Thread Michael Niedermayer
On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote: > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer > wrote: > > > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote: > > > Have you checked this with longer samples? > > > > ive tested it with the files in the bink direc

Re: [FFmpeg-devel] [PATCH 1/2] avformat/ape: more bits in size for less overflows

2022-06-13 Thread Michael Niedermayer
On Sun, Apr 03, 2022 at 12:05:12AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 3 cannot be represented in type > 'int' > Fixes: > 46184/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-4678059519770624 > > Found-by: continuous fuzzing process > https:

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Non overflowing ambisonic order check

2022-06-13 Thread Michael Niedermayer
On Sat, Mar 26, 2022 at 12:06:49AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 536870913 * 536870913 cannot be represented > in type 'int' > Fixes: > 45862/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4730373768085504 > > Found-by: continuous fuzzing process > ht

[FFmpeg-devel] [PATCH 1/4] avformat/mxf: Use AVUUID for uids

2022-06-13 Thread Andreas Rheinhardt
This is in preparation for using av_uuid functions directly. Signed-off-by: Andreas Rheinhardt --- libavformat/mxf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index d53a16df51..4d9f5119a3 100644 --- a/libavformat/mxf.h +++ b/libav

[FFmpeg-devel] [PATCH 2/4] avformat/mxfdec: Don't duplicate av_uuid_unparse

2022-06-13 Thread Andreas Rheinhardt
Also don't allocate the string ourselves, let av_dict_set() do it. Signed-off-by: Andreas Rheinhardt --- libavformat/mxfdec.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 6a22c33995..392066b65a 100

[FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Use ff_data_to_hex() for data->hex conversion

2022-06-13 Thread Andreas Rheinhardt
In this case it also stops pretending that the length of the output string is somehow checked (which is currently being done by using snprintf that is called with the amount of space needed instead of the amount of space actually available). Signed-off-by: Andreas Rheinhardt --- libavformat/mxfd

[FFmpeg-devel] [PATCH 4/4] avformat/mxfdec: Offload allocating string to av_dict_set()

2022-06-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mxfdec.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 77bde7c3fe..ad8fb77f9b 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2118,16 +

[FFmpeg-devel] [PATCH] fftools/fopen_utf8: support long paths on Windows for fftools

2022-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/fopen_utf8: support long paths on Windows for fftools After Nil's patchset, this is probably the final missing bit. Signed-off-by: softworkz softwo...@hotmail.com Published-As: https://github.com/ffstaging/FFmpeg/releas

[FFmpeg-devel] [PATCH 1/2] avutil/version: 57.26.100 -> 57.27.100

2022-06-13 Thread Zane van Iperen
Forgot to bump after the uuid patches. Signed-off-by: Zane van Iperen --- libavutil/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/version.h b/libavutil/version.h index 2c7f4f6b37..2e9e02dda8 100644 --- a/libavutil/version.h +++ b/libavutil/version.h @@ -

[FFmpeg-devel] [PATCH 2/2] doc/APIchanges: add missing uuid and csp entries

2022-06-13 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- doc/APIchanges | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 4f7a19d176..3349e94a4f 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -18,6 +18,16 @@ API changes, most recent first: Add avio_vprintf(),

Re: [FFmpeg-devel] [PATCH 1/2] avutil/version: 57.26.100 -> 57.27.100

2022-06-13 Thread James Almer
On 6/13/2022 9:03 PM, Zane van Iperen wrote: Forgot to bump after the uuid patches. Signed-off-by: Zane van Iperen --- libavutil/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/version.h b/libavutil/version.h index 2c7f4f6b37..2e9e02dda8 100644 --- a/l

[FFmpeg-devel] [PATCH v2 1/4] lavc/hevc_refs: fix dpb logical for IRAP

2022-06-13 Thread Fei Wang
From: Xu Guangxin According to C.5.2.2, item 2. When we got an IRAP, and the NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. Tested-by: Fei Wang Signed-off-by: Xu Guangxin --- Update: 1. fixed segment fault for some special clip in 2nd patch. libavcodec/hevc_refs.c | 23

[FFmpeg-devel] [PATCH v2 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process

2022-06-13 Thread Fei Wang
From: Xu Guangxin We will generate a new frame for a missed reference. The frame can only be used for reference. We assign an invalid decode sequence to it, so it will not be involved in any dpb process. Tested-by: Fei Wang Signed-off-by: Xu Guangxin --- libavcodec/hevc_refs.c | 14 ++

[FFmpeg-devel] [PATCH v2 3/4] lavc/hevc_refs: exclude current frame from long term refs

2022-06-13 Thread Fei Wang
From: Xu Guangxin suppose a. You have 3 frames, 0, 1, 4096. b. The ltMask is 0xfff and use_msb is 0. c. The 0, 1 are lt refs for 4096. d. you are decoding frame 4096, and get the 0 frame. Since 4096 & ltMask is 0 too, even you want get 0, find_ref_idx may give you 4096. add_candidate_ref will re

[FFmpeg-devel] [PATCH v2 4/4] lavc/hevcdec: respect the value of no_output_of_prior_pics_flag

2022-06-13 Thread Fei Wang
From: Xu Guangxin Even resolution or number of picture stores changes, we still need follow no_output_of_prior_pics_flag in next IDR. Tested-by: Fei Wang Signed-off-by: Xu Guangxin --- libavcodec/hevcdec.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavc

Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing ref frames invovled in dpb process

2022-06-13 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Thursday, June 9, 2022 10:05 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1 2/4] lavc/hevcdec: do not let missing > ref > frames invovled in dpb process > >