[FFmpeg-devel] [PATCH v3 1/2] avformat/cafdec: Implement FLAC-in-CAF parsing

2022-06-11 Thread Martijn van Beurden
The afconvert utility shipped with MacOS supports muxing of FLAC in CAF, see afconvert help output on a recent Mac here: https://hydrogenaud.io/index.php?topic=122509.0 A file created with afconvert free of copyright (licensed CC0) can be found here: http://www.audiograaf.nl/misc_stuff/afconvert-FL

[FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-11 Thread Martijn van Beurden
--- libavformat/mov.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d7be593a86..51c0f6f9d8 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6772,7 +6772,10 @@ static int mov_read_dfla(MOVContext *c, AVIOContext *pb, M

Re: [FFmpeg-devel] [PATCH] avformat/os_support: use windows stat structs with 64bit time_t

2022-06-11 Thread Martin Storsjö
On Sat, 11 Jun 2022, Christopher Degawa wrote: On Thu, Jun 9, 2022 at 6:22 PM softworkz wrote: From: softworkz Signed-off-by: softworkz --- avformat/os_support: use windows stat structs with 64bit time_t Signed-off-by: softworkz softwo...@hotmail.com Ping on this patch, this f

Re: [FFmpeg-devel] Trivial codec based on QOI and zstd compresses better than all lossless ffmpeg codecs on my data from screen

2022-06-11 Thread Paul B Mahol
On Sat, Jun 11, 2022 at 1:37 AM Аскар Сафин wrote: > Hi. I use Debian Linux. I always capture my screen. I do this using my > own program, which takes rgb24 frames from X server and saves them > lossless in my own format. At fps 4 > (but duplicate frames are dropped). My codec is absolutely trivi

Re: [FFmpeg-devel] [PATCH] avcodec: Fix time reporting for DFPWM streams

2022-06-11 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-11 Thread Paul B Mahol
Have you actually tested this "change" ? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: add option fps_mode

2022-06-11 Thread Jie Zhang
Now the `vsync` function has a better name. On the other hand, I'm curious whether the `vsync`/`fps_mode` function is still valuable in the ffmpeg tool source since the `fps` filter does almost the same job, but may have less coupling? On Sat, Jun 11, 2022 at 12:24 PM Gyan Doshi wrote: > Pushed

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: prevent potential use of uninitialized value

2022-06-11 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Trivial codec based on QOI and zstd compresses better than all lossless ffmpeg codecs on my data from screen

2022-06-11 Thread Martijn van Beurden
Op za 11 jun. 2022 01:37 schreef Аскар Сафин : > ffv1 spec reads: "FFV1 is designed to support a wide range of lossless > video applications such as... screen recording..." Unfortunately, ffv1 > turned out to be bad compared to my codec > on screen recording data, so it is possible ffv1 could bene

Re: [FFmpeg-devel] Trivial codec based on QOI and zstd compresses better than all lossless ffmpeg codecs on my data from screen

2022-06-11 Thread Аскар Сафин
> What about different samples? Not just single big one. I tried to pick representative sample. Which contains all kind of activities I usually do on my computer. Again: if you want, I can spend some time finding smaller samples without personal info (such that I can publish them) _

Re: [FFmpeg-devel] [PATCH v7] libx264: Set min build version to 158

2022-06-11 Thread Marton Balint
On Thu, 9 Jun 2022, Matt Oliver wrote: From: Matt Oliver Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to static builds (although is required for shared builds). This flag is set by x264 in its pkgconfi

[FFmpeg-devel] [PATCH] avcodec/get_bits: declare VLC table args as const

2022-06-11 Thread Leo Izen
Declaring the VLC table as const allows a caller to call get_vlc2() with a pre-generated static const table without generating warnings for -Wdiscarded-qualifiers. --- libavcodec/get_bits.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/g

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/fmvc: buffer size is stride based not 4*width

2022-06-11 Thread Michael Niedermayer
On Sat, Jun 11, 2022 at 10:47:57AM +0200, Paul B Mahol wrote: > Have you actually tested this "change" ? On every file i found 6-methyl-5-hepten-2-one-CC-db_small.avi fmvcVirtualDub_small.avi skrzyzowanie4.avi fmvc-poc.avi are there any other files i should test it on ? thx [...] -- Michael

Re: [FFmpeg-devel] Trivial codec based on QOI and zstd compresses better than all lossless ffmpeg codecs on my data from screen

2022-06-11 Thread Michael Niedermayer
Hi On Sat, Jun 11, 2022 at 02:37:19AM +0300, Аскар Сафин wrote: > Hi. I use Debian Linux. I always capture my screen. I do this using my > own program, which takes rgb24 frames from X server and saves them > lossless in my own format. At fps 4 > (but duplicate frames are dropped). My codec is abso

Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output

2022-06-11 Thread Michael Niedermayer
On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote: > On Thu, Jun 2, 2022 at 9:13 PM Michael Niedermayer > wrote: > > > On Wed, Jun 01, 2022 at 10:33:37PM +0200, Matthieu Bouron wrote: > > > --- > > > libswscale/input.c | 1 + > > > libswscale/utils.c

[FFmpeg-devel] [PATCH 0/2] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-06-11 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. With the pivots parsed, the parsed values for num_{x,y}_partitions are correct and usually equal to 1. quietvoid (2): libavutil/dovi_meta: Add

[FFmpeg-devel] [PATCH 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-11 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Also implemented the parsing in libavcodec/dovi_rpu.c. And added the info to ffprobe and showinfo. --- fftools/ffprobe.c | 4 libav

[FFmpeg-devel] [PATCH 2/2] fate: Add test to parse profile 7 DOVI RPU

2022-06-11 Thread quietvoid
--- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-dovi-profile7-rpu | 296 ++ 2 files changed, 299 insertions(+) create mode 100644 tests/ref/fate/hevc-dovi-profile7-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 2f16e3a29f..549436cb

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-11 Thread Andreas Rheinhardt
quietvoid: > The NLQ pivots are not documented but should be present > in the header for profile 7 RPU format. > It has been verified using Dolby's verification toolkit. > > Also implemented the parsing in libavcodec/dovi_rpu.c. > And added the info to ffprobe and showinfo. > --- > fftools/ffprob

Re: [FFmpeg-devel] [PATCH v13 2/4] libavformat/avisynth.c: Remove MAX_PATH limit

2022-06-11 Thread nil-admirari
> Why not use the AviSynth mechanism that allows to supply a UTF-8 string? > > https://github.com/AviSynth/AviSynthPlus/blob/c377916aa4146d2f4386852d91dc177d49103c16/avs_core/core/parser/script.cpp#L477-L481 Was not aware such a mechanism exists. Commit dates back to 10 April 2017, first release

[FFmpeg-devel] [PATCH 1/3] Revert "avdevice/pulse_audio_dec: only set adjust latency flag if fragment_size is not set"

2022-06-11 Thread Marton Balint
This reverts commit 7f059a250bb7bcbf7bba537c1a059a5934413035. Apparently adjusting latency makes a difference even if fragment size is specifed. Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/pulse_

[FFmpeg-devel] [PATCH 2/3] avdevice/pulse_audio_dec: reduce default fragment size

2022-06-11 Thread Marton Balint
Reduces default fragment size from the pulse audio default of 2 sec to 50 ms. This also has an effect on the size of the returned frames, which will be around 50 ms as well, making timestamps more accurate. This should fix the regression in ticket #9776. Pulseaudio timestamps for monitor sources

[FFmpeg-devel] [PATCH 3/3] avdevice/pulse_audio_dec: deprecate frame_size option

2022-06-11 Thread Marton Balint
It does not do anything. Frame sizes can be controlled by using fragment_size. Signed-off-by: Marton Balint --- doc/indevs.texi | 2 +- libavdevice/pulse_audio_dec.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 1141

[FFmpeg-devel] [PATCH] doc/ffmpeg: fix typo in VCD creation example

2022-06-11 Thread Marton Balint
Fixes ticket #9753. Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 51515c2cb8..d943f4d6f5 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -624,21 +624,21 @@ The parameters se

Re: [FFmpeg-devel] [PATCH 00/41] Stop including superseded functions for x64

2022-06-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > x64 requires MMX, MMXEXT, SSE and SSE2; yet there is no shortage > of code like the following: > > if (EXTERNAL_MMX(cpu_flags)) { > c->ssd_int8_vs_int16 = ff_ssd_int8_vs_int16_mmx; > } > if (EXTERNAL_SSE2(cpu_flags)) { > c->ssd_int8_vs_int16 = ff_s

[FFmpeg-devel] [PATCH] swresample/resample: Properly empty MMX state

2022-06-11 Thread Andreas Rheinhardt
There is a x86-32 MMXEXT implementation for resampling planar 16bit data. multiple_resample() therefore calls emms_c() if it thinks that this needed. And this is bad: 1. It is a maintenance nightmare because changes to the x86 resample DSP code would necessitate changes to the check whether to cal

[FFmpeg-devel] [PATCH 2/5] swresample/x86/audio_convert: Remove obsolete MMX functions

2022-06-11 Thread Andreas Rheinhardt
x64 always has MMX, MMXEXT, SSE and SSE2 and this means that some functions for MMX, MMXEXT and 3dnow are always overridden by other functions (unless one e.g. explicitly disables SSE2) for x64. So given that the only systems that benefit from these functions are truely ancient 32bit x86s they are

[FFmpeg-devel] [PATCH 3/5] swresample/x86/rematrix: Remove obsolete MMX functions

2022-06-11 Thread Andreas Rheinhardt
x64 always has MMX, MMXEXT, SSE and SSE2 and this means that some functions for MMX, MMXEXT and 3dnow are always overridden by other functions (unless one e.g. explicitly disables SSE2) for x64. So given that the only systems that benefit from these functions are truely ancient 32bit x86s they are

[FFmpeg-devel] [PATCH 4/5] swresample/x86/resample: Remove obsolete MMXEXT functions

2022-06-11 Thread Andreas Rheinhardt
x64 always has MMX, MMXEXT, SSE and SSE2 and this means that some functions for MMX, MMXEXT, SSE and 3dnow are always overridden by other functions (unless one e.g. explicitly disables SSE2). So given that the only systems which benefit from the MMXEXT resamplers (which are overridden by SSE2) are

[FFmpeg-devel] [PATCH 5/5] swresample/resample: Remove unnecessary emms_c

2022-06-11 Thread Andreas Rheinhardt
The last MMX code in swresample has just been removed. Signed-off-by: Andreas Rheinhardt --- libswresample/resample.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libswresample/resample.c b/libswresample/resample.c index 9c5b7fee72..8f9efc3f21 100644 --- a/libswresample/resample.c +++ b/

Re: [FFmpeg-devel] [PATCH v13 2/4] libavformat/avisynth.c: Remove MAX_PATH limit

2022-06-11 Thread Stephen Hutchinson
On 6/11/22 1:01 PM, nil-admir...@mailo.com wrote: Why not use the AviSynth mechanism that allows to supply a UTF-8 string? https://github.com/AviSynth/AviSynthPlus/blob/c377916aa4146d2f4386852d91dc177d49103c16/avs_core/core/parser/script.cpp#L477-L481 Was not aware such a mechanism exists. Co

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: fix typo in VCD creation example

2022-06-11 Thread Gyan Doshi
On 2022-06-12 12:45 am, Marton Balint wrote: Fixes ticket #9753. Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 51515c2cb8..d943f4d6f5 100644 --- a/doc/ffmpeg.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH v13 2/4] libavformat/avisynth.c: Remove MAX_PATH limit

2022-06-11 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Stephen Hutchinson > Sent: Sunday, June 12, 2022 4:15 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v13 2/4] libavformat/avisynth.c: > Remove MAX_PATH limit > > On 6/11/22 1:01 PM, nil-admir...@mailo.com w

[FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-11 Thread Andreas Rheinhardt
This is more spec-compliant because it does not rely on dead-code elimination by the compiler. Especially MSVC has problems with this, as can be seen in https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296373.html or https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/297022.html This commit does