Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Anton Khirnov
Quoting Soft Works (2022-06-05 07:23:18) > This is causing a regression in ffprobe. > > The commit removes the special-case check for AVMEDIA_TYPE_ATTACHMENT which > was required for ffprobe and had been added with > e83c716e16c52fa56a78274408f7628e5dc719da. > > The demand from the commit mess

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 9:01 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022-

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Sunday, June 5, 2022 9:55 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > > > > -Original Message-

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Anton Khirnov
Quoting Soft Works (2022-06-05 09:54:51) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Sunday, June 5, 2022 9:01 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Paul B Mahol
On Sun, Jun 5, 2022 at 10:20 AM Anton Khirnov wrote: > Quoting Soft Works (2022-06-05 09:54:51) > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > Anton > > > Khirnov > > > Sent: Sunday, June 5, 2022 9:01 AM > > > To: FFmpeg development discussions and patches < > f

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 10:20 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 10:20 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Anton Khirnov
So much text, but no actual answer. Again: > I fail to see how calling avcodec_open2() with AVMEDIA_TYPE_ATTACHMENT > is valid API usage. What do you expect it to do? There are no > AVMEDIA_TYPE_ATTACHMENT decoders. -- Anton Khirnov ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 12:42 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > So much text, but no act

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 12:42 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > So much text, but no act

[FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-06-05 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c to remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 9

[FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-06-05 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c to remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 9

[FFmpeg-devel] [PATCH v12 3/4] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-05 Thread Nil Admirari
--- compat/w32dlfcn.h | 80 +-- 1 file changed, 64 insertions(+), 16 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94ef..6b0dd7d 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -22,9 +22,31 @@ #ifdef _WIN32 #includ

[FFmpeg-devel] [PATCH v12 2/4] libavformat/avisynth.c: Remove MAX_PATH limit

2022-06-05 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8ba2bde..f7bea8c 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives. */

[FFmpeg-devel] [PATCH v12 4/4] fftools/cmdutils.c: Remove MAX_PATH limit

2022-06-05 Thread Nil Admirari
--- fftools/cmdutils.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3..d42bb04 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -50,6 +50,7 @@ #include "opt_common.h" #ifdef _WI

[FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-06-05 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c to remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 9

Re: [FFmpeg-devel] [PATCH v11 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-06-05 Thread nil-admirari
#if (_WIN32_WINNT < 0x0602) || HAVE_WINRT #include "libavutil/wchar_filename.h" #endif caused build error due to utf8towchar being undefined. Made wchar_filename.h include unconditional. Also removed manifest changes since it was decided to adopt \\?\ prefixes instead. New version is at https:

Re: [FFmpeg-devel] [PATCH v2] tools/target_dec_fuzzer: add a custom get_buffer2() implementation

2022-06-05 Thread James Almer
On 5/31/2022 5:42 PM, James Almer wrote: Unlike avcodec_default_get_buffer2(), this version does not allocate more than what the normal image helper functions consider should be allocated for a given frame. Since the get_buffer2() documentation does not require any kind of buffer overallocation f

Re: [FFmpeg-devel] [PATCH] avcodec/remove_extradata_bsf: add a list of supported codec ids

2022-06-05 Thread James Almer
On 5/25/2022 7:52 PM, James Almer wrote: There's no point allowing the use of this filter for codecs where it will silently do nothing. Signed-off-by: James Almer --- libavcodec/remove_extradata_bsf.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/l

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Anton Khirnov
Quoting Soft Works (2022-06-05 13:10:49) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Sunday, June 5, 2022 12:42 PM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec i

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-06-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 3:21 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022-

[FFmpeg-devel] [PATCH] avutil/frame: add av_frame_replace

2022-06-05 Thread James Almer
Signed-off-by: James Almer --- Now taking into account the new channel layout API fields, supporting non refcouted src, plus changing the documentation to state that the dst frame properties will be replaced by those from src even if the data described by both frames is the same. Still missing AP

Re: [FFmpeg-devel] [PATCH] avutil/frame: add av_frame_replace

2022-06-05 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > Now taking into account the new channel layout API fields, supporting non > refcouted src, plus changing the documentation to state that the dst frame > properties will be replaced by those from src even if the data described > by both frames is th

Re: [FFmpeg-devel] [PATCH] avutil/frame: add av_frame_replace

2022-06-05 Thread James Almer
On 6/5/2022 12:42 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- Now taking into account the new channel layout API fields, supporting non refcouted src, plus changing the documentation to state that the dst frame properties will be replaced by those from src even

[FFmpeg-devel] [PATCH v2] avutil/frame: add av_frame_replace

2022-06-05 Thread James Almer
Signed-off-by: James Almer --- Now disallowing src == dst. libavutil/frame.c | 147 ++ libavutil/frame.h | 13 2 files changed, 160 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 4c16488c66..86f9dcb59a 100644 --- a/libavu

[FFmpeg-devel] Collective Ping

2022-06-05 Thread Soft Works
Hello, I’d like to kindly PING about the following submissions. libavformat/asf: fix handling of byte array length values https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=6653 => No pending questions or objections Add derive-device function which searches for existing devices in both

[FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: add ROI support to qsv encoder

2022-06-05 Thread Wenbin Chen
Use The mfxEncoderCtrl parameter to enable ROI. Get side data "AVRegionOfInterest" and use it to configure "mfxExtEncoderROI" which is the MediaSDK's ROI configuration. Signed-off-by: Wenbin Chen --- libavcodec/qsv_internal.h | 4 ++ libavcodec/qsvenc.c | 86 ++

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/vaapi_encode: add support for maxframesize

2022-06-05 Thread Xiang, Haihao
On Mon, 2022-05-30 at 01:27 +, Xiang, Haihao wrote: > On Mon, 2022-05-23 at 02:14 +, Wang, Fei W wrote: > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of Fei > > > Wang > > > Sent: Thursday, May 5, 2022 5:07 PM > > > To: ffmpeg-devel@ffmpeg.org > > > Cc: Wang, Fei W ;