Re: [FFmpeg-devel] [PATCH v4 0/2] use av_fopen_utf8() instead of plain fopen()

2022-05-18 Thread Tobias Rapp
On 17/05/2022 14:29, ffmpegagent wrote: Unify file access operations by replacing usages of direct calls to posix fopen() v2: Remove changes to fftools for now v3: Add some additional replacements v4: Fix and improve commit messages softworkz (2): avfilter: use av_fopen_utf8() instead of pla

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Gyan Doshi
On 2022-05-17 11:54 pm, Vignesh Venkatasubramanian wrote: libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomen

Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs

2022-05-18 Thread Niklas Haas
On Sun, 15 May 2022 18:32:36 +0200 Andreas Rheinhardt wrote: > Is there any scenario in which these structs might need to be extended? > This is something that we could no longer easily do if these structs > were public. This struct has existed in essentially this exact form for decades (before

[FFmpeg-devel] [PATCH 1/6] tests/Makefile: Remove FILTERDEMDECMUX

2022-05-18 Thread Andreas Rheinhardt
It is unused and given that one needs an encoder to produce packets from AVFrames (as output by filters) this is likely to remain so, because FILTERDEMDECENCMUX is better for these scenarios. The only case where one can use filters without encoders is with the lavfi input device: It outputs AVPacke

[FFmpeg-devel] [PATCH 2/6] tests/Makefile: Add FRAMECRC variants for filtering

2022-05-18 Thread Andreas Rheinhardt
Lots of tests use the framecrc command together with some filters, so adding a special function for it seems worthwhile. This commit adds one new one and modifies an already existing one: All users of FILTERDEMDEC already use framecrc and the more general FILTERDEMDECENCMUX can be used in scenarios

[FFmpeg-devel] [PATCH 3/6] fate/filter-video: Avoid duplication for fate-filter-stereo3d tests

2022-05-18 Thread Andreas Rheinhardt
Also fix the requirements of these tests: Only the anaglyph tests need a scale filter, yet it has been inserted for all tests without any check for its presence. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 81 ++--- 1 file changed, 13 inser

[FFmpeg-devel] [PATCH 4/6] fate/filter-video: Avoid duplication for filter-removegrain tests

2022-05-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Is there a simple way to create the 00 01 ... 24 pattern without recourse to the shell? tests/fate/filter-video.mak | 85 - 1 file changed, 8 insertions(+), 77 deletions(-) diff --git a/tests/fate/filter-video.mak b/tests

[FFmpeg-devel] [PATCH 5/6] fate/filter-video: Avoid duplication for fate-filter-overlay tests

2022-05-18 Thread Andreas Rheinhardt
Also add a fate-filter-overlays target containing all these tests and fix the requirements of the tests; furthermore, remove unnecessary scale filters from filter-overlay-rgba?_rgba. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 72 + 1 f

[FFmpeg-devel] [PATCH 6/6] fate/filter-video: Fix requirements of tests

2022-05-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/Makefile | 1 + tests/fate/filter-video.mak | 376 +--- 2 files changed, 179 insertions(+), 198 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 7622e5c984..5677364471 100644 --- a/tests/Mak

Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs

2022-05-18 Thread Niklas Haas
On Wed, 18 May 2022 14:21:41 +0200 Niklas Haas wrote: > On Sun, 15 May 2022 18:32:36 +0200 Andreas Rheinhardt > wrote: > > Is there any scenario in which these structs might need to be extended? > > This is something that we could no longer easily do if these structs > > were public. > > This s

Re: [FFmpeg-devel] [PATCH] avfilter: Add blockdetect filter

2022-05-18 Thread Thilo Borgmann
Am 09.05.22 um 14:24 schrieb Thilo Borgmann: Hi, $subject based on http://www.eurasip.org/Proceedings/Eusipco/Eusipco2005/defevent/papers/cr1042.pdf v2 with minimal changes from IRC. Applying soon. Thanks, Thilo ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/dvdsubenc: return error if canvas_size is too small for subtitle render

2022-05-18 Thread lance . lmwang
On Wed, May 11, 2022 at 10:48:18PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/dvdsubenc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/dvdsubenc.c b/libavcodec/dvdsubenc.c > index fc3b7d1816..d29db7d49c

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/src_movie: add dec_opts for the opened file

2022-05-18 Thread lance . lmwang
On Sun, May 08, 2022 at 03:17:00PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi| 9 + > libavfilter/src_movie.c | 5 - > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/do

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/src_movie: add dec_opts for the opened file

2022-05-18 Thread zhilizhao(赵志立)
> On May 8, 2022, at 3:17 PM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/filters.texi| 9 + > libavfilter/src_movie.c | 5 - > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.

[FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

2022-05-18 Thread Leo Izen
This commit moves some of the functionality from avfilter/colorspace into avutil/csp and exposes it as an avpriv API so it can be used by libavcodec and/or libavformat. --- libavfilter/colorspace.c| 94 +- libavfilter/colorspace.h| 31 ++ libavfilter/f

[FFmpeg-devel] [PATCH 7/7] tests/fate: Remove intermediate file of flv-add_keyframe_index test

2022-05-18 Thread Andreas Rheinhardt
Do this by making this test a transcode test. Also fix the test requirements and don't add this test to FATE_AFILTER; instead use a new variable and a new target for flvenc-tests. Signed-off-by: Andreas Rheinhardt --- tests/fate/flvenc.mak | 14 tests/ref/fate/flv-ad

[FFmpeg-devel] [PATCH 1/2] avformat/http: Remove always true non NULL check

2022-05-18 Thread Michael Niedermayer
Coverity uses the logic of "Comparing options to null implies that options might be null." But ffurl_connect() checks for NULL already and uses &tmp_opts Helps: CID1374122 Signed-off-by: Michael Niedermayer --- libavformat/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_signature: Fix integer overflow in filter_frame()

2022-05-18 Thread Michael Niedermayer
Fixes: CID1403233 The second of the 2 changes may be unneeded but will help coverity Signed-off-by: Michael Niedermayer --- libavfilter/vf_signature.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index 4ca57ebf1d

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 2:29 AM Gyan Doshi wrote: > > > > On 2022-05-17 11:54 pm, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > useful for encoding still AVIF images. > >

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread James Almer
On 5/18/2022 1:39 PM, Vignesh Venkatasubramanian wrote: libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 10:01 AM James Almer wrote: > > > > On 5/18/2022 1:39 PM, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > useful for encoding still AVIF images. > >

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcod

[FFmpeg-devel] [PATCH 1/2] ffmpeg: add display_{rotation, hflip, vflip} options

2022-05-18 Thread Jan Ekström
This enables overriding the rotation as well as horizontal/vertical flip state of a specific video stream on either the input or output side. Additionally, switch the singular test that was utilizing the rotation metadata to instead override the input display rotation, thus leading to the same res

[FFmpeg-devel] [PATCH 2/2] ffmpeg: deprecate display rotation override with a metadata key

2022-05-18 Thread Jan Ekström
Now that we have proper options for defining display matrix overrides, this should no longer be required. fftools does not have its own versioning, so for now the define is just set to 1 and disables the functionality if set to zero. --- fftools/ffmpeg.c | 2 ++ fftools/ffmpeg.h | 6 +++

Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

2022-05-18 Thread Michael Niedermayer
On Wed, May 18, 2022 at 11:18:17AM -0400, Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as an avpriv API so it can be used by > libavcodec and/or libavformat. [...] > +#ifndef AVUTIL_CSP_H > +#define AVUTIL_CSP_H > + > +#incl

Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

2022-05-18 Thread Michael Niedermayer
On Wed, May 18, 2022 at 08:23:38PM +0200, Michael Niedermayer wrote: > On Wed, May 18, 2022 at 11:18:17AM -0400, Leo Izen wrote: > > This commit moves some of the functionality from avfilter/colorspace > > into avutil/csp and exposes it as an avpriv API so it can be used by > > libavcodec and/or li

[FFmpeg-devel] Upgrade to latest bug fix releases for Ubuntu

2022-05-18 Thread Luís Cunha dos Reis Infante da Câmara
To whom it may concern, I am upgrading the versions in Ubuntu to the latest respective bug fix releases (3.4.11, 4.2.7 and 4.4.2). Bug report: https://bugs.launchpad.net/ubuntu/+source/ffmpeg/+bug/1970674 Kind regards, Luís Infante da Câmara ___ f

[FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-18 Thread Vignesh Venkatasubramanian
AVIF specification allows for alpha channel as an auxillary item (in case of still images) or as an auxillary track (in case of animated images). Add support for both of these. The AVIF muxer will take exactly two streams (when alpha is present) as input (first one being the YUV planes and the sec

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-18 Thread Bang He
some error happened: On Thu, May 19, 2022 at 5:56 AM Vignesh Venkatasubramanian < vigneshv-at-google@ffmpeg.org> wrote: > AVIF specification allows for alpha channel as an auxillary item (in > case of still images) or as an auxillary track (in case of animated > images). Add support for both

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-18 Thread Bang He
error happened: ./ffmpeg -i alpha.png -filter_complex [0:v]alphaextract[a] -map 0 -map [a] -still-picture 1 avif_with_alpha.avif ffmpeg version N-106936-gff5ea89da2 Copyright (c) 2000-2022 the FFmpeg developers built with gcc 11 (Ubuntu 11.2.0-19ubuntu1) configuration: --disable-ffplay --disab

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add display_{rotation, hflip, vflip} options

2022-05-18 Thread Gyan Doshi
On 2022-05-18 11:34 pm, Jan Ekström wrote: This enables overriding the rotation as well as horizontal/vertical flip state of a specific video stream on either the input or output side. Since rotation, flip and scale are stored in a single data structure, how about a single option i.e. -displ

Re: [FFmpeg-devel] [PATCH] avformat/img2: Add support for AVIF mux in image2

2022-05-18 Thread Gyan Doshi
On 2022-05-18 01:06 am, James Zern wrote: On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian wrote: Add support for AVIF muxing in the image2 muxer. Tested with this example: ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v libaom-av1 -f image2 img-%2d.

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add display_{rotation, hflip, vflip} options

2022-05-18 Thread Jan Ekström
On Thu, May 19, 2022, 07:21 Gyan Doshi wrote: > > > On 2022-05-18 11:34 pm, Jan Ekström wrote: > > This enables overriding the rotation as well as horizontal/vertical > > flip state of a specific video stream on either the input or output > > side. > > Since rotation, flip and scale are stored in