[FFmpeg-devel] [PATCH] avformat/dashdec: accept and relay CENC decryption key

2022-05-14 Thread Gyan Doshi
Allows to process CENC-encrypted media segments. Option arg syntax is same as that for option decryption_key in MOV demuxer --- doc/demuxers.texi | 11 +++ libavformat/dashdec.c | 5 + 2 files changed, 16 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 238b

[FFmpeg-devel] [PATCH] avfilter/af_afir: add support for double sample format

2022-05-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 16 ++ libavfilter/af_afir.c | 511 +++- libavfilter/af_afir.h | 99 +++ libavfilter/af_afirdsp.h| 20 ++ libavfilter/afir_template.c | 392 +++ 5 files cha

Re: [FFmpeg-devel] [PATCH 1/1] fix: use declared size for attribute of type string to ensure full value used and prevent parse failure for string lengths longer than 256

2022-05-14 Thread Paul B Mahol
On Thu, May 12, 2022 at 5:31 PM vectronic wrote: > Signed-off-by: vectronic > --- > libavcodec/exr.c | 32 +++- > 1 file changed, 23 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index 8cd867a32f..bc2afcee53 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: accept and relay CENC decryption key

2022-05-14 Thread Steven Liu
Gyan Doshi 于2022年5月14日周六 17:18写道: > > Allows to process CENC-encrypted media segments. > Option arg syntax is same as that for option decryption_key in MOV demuxer > --- > doc/demuxers.texi | 11 +++ > libavformat/dashdec.c | 5 + > 2 files changed, 16 insertions(+) > > diff --gi

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: accept and relay CENC decryption key

2022-05-14 Thread Gyan Doshi
On 2022-05-14 04:08 pm, Steven Liu wrote: Gyan Doshi 于2022年5月14日周六 17:18写道: Allows to process CENC-encrypted media segments. Option arg syntax is same as that for option decryption_key in MOV demuxer --- doc/demuxers.texi | 11 +++ libavformat/dashdec.c | 5 + 2 files cha

[FFmpeg-devel] [PATCH v2] fftools/opt_common: add missing include of avf/version.h

2022-05-14 Thread softworkz
From: softworkz required for PRINT_LIB_INFO(avfilter... Signed-off-by: softworkz --- fftools/opt_common: add missing include of avf/version.h MSVC compiler complains without this include v2: also include avfilter.h as suggested Published-As: https://github.com/ffstaging/

Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs

2022-05-14 Thread Niklas Haas
Hi, If you push the code somewhere I can take a stab at porting it to AVRational. On Fri, 13 May 2022 22:41:15 -0400 Leo Izen wrote: > On 5/13/22 17:22, Michael Niedermayer wrote: > > On Fri, May 13, 2022 at 11:42:08AM -0400, Leo Izen wrote: > >> + > >> +struct WhitepointCoefficients { > >> +

[FFmpeg-devel] [PATCH v4 00/10] libavformat/asf: fix handling of byte array length values

2022-05-14 Thread ffmpegagent
The spec allows attachment sizes of up to UINT32_MAX while we can handle only sizes up to INT32_MAX (in downstream code) The debug.assert in get_tag didn't really address this, and truncating the value_len in calling methods cannot be used because the length value is required in order to continue

[FFmpeg-devel] [PATCH v4 01/10] libavformat/asf: fix handling of byte array length values

2022-05-14 Thread softworkz
From: softworkz The spec allows attachment sizes of up to UINT32_MAX while we can handle only sizes up to INT32_MAX (in downstream code) The debug.assert in get_tag didn't really address this, and truncating the value_len in calling methods cannot be used because the length value is required in

[FFmpeg-devel] [PATCH v4 02/10] libavformat/asfdec: fix get_value return type and add checks for

2022-05-14 Thread softworkz
From: softworkz unsupported values get_value had a return type of int, which means that reading QWORDS (case 4) was broken due to truncation of the result from avio_rl64(). Signed-off-by: softworkz --- libavformat/asfdec_f.c | 57 +++--- 1 file changed, 43

[FFmpeg-devel] [PATCH v4 03/10] libavformat/asfdec: fix type of value_len

2022-05-14 Thread softworkz
From: softworkz The value_len is an uint32 not an int32 per spec. That value must not be truncated, neither by casting to int, nor by any conditional checks, because at the end of get_tag, this value is needed to move forward in parsing. When the len value gets modified, the parsing may break. S

[FFmpeg-devel] [PATCH v4 04/10] libavformat/asfdec: fixing get_tag

2022-05-14 Thread softworkz
From: softworkz These three are closely related and can't be separated easily: In get_tag, the code was adding 22 bytes (in order to allow it to hold 64bit numbers as string) to the value len for creating creating a buffer. This was unnecessarily imposing a size-constraint on the value_len param

[FFmpeg-devel] [PATCH v4 05/10] libavformat/asfdec: implement parsing of GUID values

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index cb7da2d679..81a29f99d5 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -281,

[FFmpeg-devel] [PATCH v4 10/10] libavformat/asfdec: fix variable types and add checks for unsupported values

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 168 ++--- 1 file changed, 108 insertions(+), 60 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 95cab8b960..d50682b901 100644 --- a/libavformat/asfdec_f.c

[FFmpeg-devel] [PATCH v4 06/10] libavformat/asfdec: fix macro definition and use

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 81a29f99d5..91c3874ac7 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/a

[FFmpeg-devel] [PATCH v4 07/10] libavformat/asfdec: remove variable redefinition in inner scope

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 91c3874ac7..fae15d9b05 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -1191,7 +119

[FFmpeg-devel] [PATCH v4 08/10] libavformat/asfdec: ensure variables are initialized

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index fae15d9b05..cb396cccfe 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -978,6 +978,7 @@ static int as

[FFmpeg-devel] [PATCH v4 09/10] libavformat/asfdec: fix parameter type in asf_read_stream_propertie()

2022-05-14 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/asfdec_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index cb396cccfe..95cab8b960 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -324,7 +324,7