On Fri, May 06, 2022 at 10:56:16AM -0700, Pierre-Anthony Lemieux wrote:
> LGTM
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote th
Hi
before applying this
Author: caleb
If you want your full name there please resend this with your full name
so its in git with your full name. It cannot be
changed later if its pushed like this
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The educ
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Saturday, May 7, 2022 10:31 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if
> HTJ2K codeblocks are present.
>
The spec allows attachment sizes of up to UINT32_MAX while we can handle
only sizes up to INT32_MAX (in downstream code)
The debug.assert in get_tag didn't really address this, and truncating the
value_len in calling methods cannot be used because the length value is
required in order to continue
From: softworkz
The spec allows attachment sizes of up to UINT32_MAX while
we can handle only sizes up to INT32_MAX (in downstream
code)
The debug.assert in get_tag didn't really address this,
and truncating the value_len in calling methods cannot
be used because the length value is required in
From: softworkz
unsupported values
get_value had a return type of int, which means that reading
QWORDS (case 4) was broken due to truncation of the result from
avio_rl64().
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 38 +-
1 file changed, 29 inse
From: softworkz
The value_len is an uint32 not an int32 per spec. That
value must not be truncated, neither by casting to int, nor by any
conditional checks, because at the end of get_tag, this value is
needed to move forward in parsing. When the len value gets
modified, the parsing may break.
S
From: softworkz
These three are closely related and can't be separated easily:
In get_tag, the code was adding 22 bytes (in order to allow
it to hold 64bit numbers as string) to the value len for creating
creating a buffer. This was unnecessarily imposing a
size-constraint on the value_len param
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 168 ++---
1 file changed, 108 insertions(+), 60 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index b8140a6d57..c7141f6da1 100644
--- a/libavformat/asfdec_f.c
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 58c424b565..4c898ab3f2 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -280,
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 024d77903b..b8140a6d57 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -323,7 +323,7
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 4c898ab3f2..e87c78cd6c 100644
--- a/libavformat/asfdec_f.c
+++ b/libavfo
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index e87c78cd6c..a7b5ffe465 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/a
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index a7b5ffe465..8283f245ab 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -1181,7 +118
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 8283f245ab..024d77903b 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -968,6 +968,7 @@ static int as
Also improve the size check a bit; given that av_realloc_array()
checks for overflow itself, we only have to check for
nb_side_data + 1 still being representable in an int.
But given that we can check for representability in size_t
at no additional cost we do so as it leads to a nicer error code.
Signed-off-by: Andreas Rheinhardt
---
libavdevice/alsa_enc.c | 1 +
libavdevice/opengl_enc.c | 1 +
libavdevice/pulse_audio_enc.c| 1 +
libavdevice/xv.c | 2 +-
libavformat/dashenc.c| 1 +
libavformat/gxfenc.c | 3 +-
libavformat
(This function does not seem to abide by its documentation.)
Signed-off-by: Andreas Rheinhardt
---
libavformat/internal.h | 9 -
libavformat/mux.c | 15 ---
libavformat/nutenc.c | 22 +-
3 files changed, 21 insertions(+), 25 deletions(-)
diff --gi
Signed-off-by: Andreas Rheinhardt
---
libavformat/internal.h | 5 -
libavformat/mux.c | 31 ---
libavformat/mxfenc.c | 31 ++-
3 files changed, 30 insertions(+), 37 deletions(-)
diff --git a/libavformat/internal.h b/libavformat/
It is muxing-only; in fact, it should be considered part of
the core muxing code.
Signed-off-by: Andreas Rheinhardt
---
libavformat/flvenc.c | 3 +--
libavformat/internal.h| 11 --
libavformat/ivfenc.c | 1 +
libavformat/latmenc.c | 1 +
libavformat/matroskaenc.c |
This is the appropriate place given that AVStream is about to
become an AVOpt-enabled struct.
Also move av_disposition_(to|from)_string, as these are tied
to the disposition stream option.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avidec.c | 2 +-
libavformat/internal.h | 12 +++-
l
It is only used by muxers. Given that it is not part of
the core muxing code and given that mux.c is already big enough,
it is moved to a new file for utility functions for muxing.
Signed-off-by: Andreas Rheinhardt
---
libavformat/Makefile | 1 +
libavformat/internal.h| 7
libavf
ff_get_packet_palette() and ff_reshuffle_raw_rgb() belong together:
E.g. the former takes the return value of the latter as argument.
So move ff_get_packet_palette() to rawutils.c (which consists solely
of ff_reshuffle_raw_rgb()).
Also add a separate header for these two functions.
Signed-off-by:
Only used by muxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/apetag.c| 2 +-
libavformat/asfenc.c| 1 +
libavformat/cafenc.c| 1 +
libavformat/dvenc.c | 3 +--
libavformat/id3v2enc.c | 1 +
libavformat/internal.h | 20
libavformat/lrcenc.c
It is obviously a muxing-only function.
Signed-off-by: Andreas Rheinhardt
---
libavformat/fifo.c | 1 +
libavformat/internal.h | 10 --
libavformat/mux.h | 10 ++
libavformat/mux_utils.c | 10 ++
libavformat/tee.c | 2 +-
libavformat/utils.c | 10 -
It is obviously muxer-only.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mux_utils.c | 18 ++
libavformat/utils.c | 18 --
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/libavformat/mux_utils.c b/libavformat/mux_utils.c
index 83c1482540.
It is only to be used with muxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mux_utils.c | 8
libavformat/utils.c | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavformat/mux_utils.c b/libavformat/mux_utils.c
index 5930a7911a..2fa2ab5b0f 10064
Only used by muxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/internal.h | 9 -
libavformat/mux.h| 9 +
libavformat/mux_utils.c | 28
libavformat/utils.c | 28
libavformat/webm_chunk.c | 1 +
5
And move those stuff already in demuxer-only files to it.
Signed-off-by: Andreas Rheinhardt
---
libavdevice/libcdio.c | 1 +
libavformat/aadec.c| 1 +
libavformat/asfdec_f.c | 1 +
libavformat/asfdec_o.c | 2 +-
libavformat/avidec.c | 1 +
It is only used by avformat_find_stream_info().
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.c| 45 +-
libavformat/demux.h| 29 +++
libavformat/internal.h | 30 +---
libavformat/utils.c
This file is both for the various public APIs that are demuxer-only
as well as for the demuxer-only internal functions.
Signed-off-by: Andreas Rheinhardt
---
libavdevice/v4l2.c| 1 +
libavformat/Makefile | 1 +
libavformat/demux.h | 2 ++
libavformat/demux_utils.c | 34
Signed-off-by: Andreas Rheinhardt
---
libavdevice/v4l2-common.h | 13 +++--
libavdevice/v4l2.c| 8
libavdevice/v4l2enc.c | 4 +++-
3 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/libavdevice/v4l2-common.h b/libavdevice/v4l2-common.h
index c7bed3e3b4
It is demuxer-only: Muxers deal only with chapters given to them;
they don't create any of their own.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.h | 14
libavformat/demux_utils.c| 41
libavformat/ffmetadec.c | 2 +-
This function is only intended for demuxers (as calling it doesn't
have any observable effect for a muxer).
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux_utils.c | 10 ++
libavformat/utils.c | 10 --
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a
AVStream.attached_pic is only used for demuxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux_utils.c | 24
libavformat/utils.c | 23 ---
2 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/libavformat/demux_utils.c b/lib
It is demuxer-only: It potentially adds an AVStream and it sets
AVStream.attached_pic.
Signed-off-by: Andreas Rheinhardt
---
libavformat/apetag.c | 1 +
libavformat/asf.c | 1 +
libavformat/demux.h| 16
libavformat/demux_utils.c | 36 +++
Only demuxers have a need to add side-data to a packet.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.h | 8 ++
libavformat/demux_utils.c | 54 +++
libavformat/flvdec.c | 1 +
libavformat/internal.h| 8 --
libavformat/ipmovi
These functions are for demuxers only.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux_utils.c | 18 ++
libavformat/utils.c | 18 --
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/libavformat/demux_utils.c b/libavformat/demux_utils.
Only used by demuxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.h | 6 ++
libavformat/demux_utils.c | 135 ++
libavformat/internal.h| 6 --
libavformat/utils.c | 135 --
4 files changed, 14
I.e. use void* instead of AVFormatContext*, because it is only used
for logging.
Signed-off-by: Andreas Rheinhardt
---
libavformat/internal.h | 2 +-
libavformat/utils.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/internal.h b/libavformat/internal.h
in
It is only used by demuxers (although it is hypothetically
possible that some day e.g. a protocol might need it, but
that is unlikely given that they don't deal with AVCodecParameters).
Signed-off-by: Andreas Rheinhardt
---
libavformat/aaxdec.c | 1 +
libavformat/acm.c | 1 +
li
This file will contain the AVFormatContext-specific parts
that are used by both demuxers and muxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/Makefile | 1 +
libavformat/avformat.c | 130 +
libavformat/utils.c| 104
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 68 ++
libavformat/utils.c| 68 --
2 files changed, 68 insertions(+), 68 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
in
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 58 ++
libavformat/utils.c| 58 --
2 files changed, 58 insertions(+), 58 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
in
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 66 ++
libavformat/utils.c| 65 -
2 files changed, 66 insertions(+), 65 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
ind
It is not to call this with a muxer, so move it to avformat.c
and not demux_utils.c.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 179 +
libavformat/utils.c| 179 -
2 files changed, 179 insertio
It is not explicitly forbidden to call these functions with muxers
(although it is probably intended to be only called by demuxers;
av_guess_sample_aspect_ratio even says that "the stream aspect ratio
is set by the demuxer").
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 45
It is potentially used with both demuxers and muxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 15 +++
libavformat/utils.c| 15 ---
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
i
While it is clearly written with demuxers in mind,
it is not forbidden to call it with muxers, hence avformat.c
and not demux_utils.c.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 36
libavformat/utils.c| 36 -
It is not forbidden to call this with a muxer, so it is moved to
avformat.c and not demux_utils.c. ff_find_decoder(), which is used
by av_find_best_stream() is also moved as well, despite being even
more geared towards demuxers.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 84 +
They are also needed by the MMSH and MMST protocols and therefore
the file they are in is pulled in when these protocols are enabled
and used. By moving them to a separate file, linking statically to
libavformat while only using AVIO no longer pulls in all the
muxers/demuxers (and also no longer an
It is only used by demuxers (and it is generally demuxers
who have to translate format-specific IDs to stream indices).
Signed-off-by: Andreas Rheinhardt
---
libavformat/demux.h | 6 ++
libavformat/demux_utils.c | 8
libavformat/gxf.c | 1 +
libavformat/internal.h|
It is an auxiliary function only used by the generic
muxing and demuxing code.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 12
libavformat/utils.c| 13 -
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/libavformat/avformat.c b/liba
An auxiliary function for AVFormatContexts (mainly muxers,
but potentially (e.g. rtsp) also demuxers).
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 7 +++
libavformat/utils.c| 7 ---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavformat/avformat
This is an auxiliary function for AVFormatContexts.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 20
libavformat/utils.c| 21 -
2 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avf
It is an essential auxiliary function for both demuxing and muxing.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 26 ++
libavformat/utils.c| 26 --
2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/libavformat/a
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 30 ++
libavformat/utils.c| 30 --
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/libavformat/avformat.c b/libavformat/avformat.c
index 2a919ad89f..3eae41d1
These are not pure avio-functions, but auxiliary AVFormatContext
functions.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avformat.c | 14 ++
libavformat/options.c | 5 +
libavformat/utils.c| 18 --
3 files changed, 19 insertions(+), 18 deletions(-)
dif
On Fri May 6 21:29:51 EEST 2022 Lynne dev at lynne.ee wrote:
> I disagree with this patch. The native decoder should be fixed instead,
> or if it's not able to be fixed, users should use specialized libraries.
> We're not adding a yet another decoding library to fix an issue on
> very old ARM chip
They are also needed by the MMSH and MMST protocols and therefore
the file they are in is pulled in when these protocols are enabled
and used. By moving them to a separate file, linking statically to
libavformat while only using AVIO no longer pulls in all the
muxers/demuxers (and also no longer an
d607af50fd broke alpha processing by always overwriting any supplied
alpha expression.
---
libavfilter/vf_geq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index fd9e0fd80b..2b53980278 100644
--- a/libavfilter/vf_geq.c
+++ b/libav
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: Saturday, May 7, 2022 1:59 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH v2 37/44] avformat/asf: Move ASF GUIDs
> to a new file
>
> They are also needed by
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of
>> Andreas Rheinhardt
>> Sent: Saturday, May 7, 2022 1:59 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Andreas Rheinhardt
>> Subject: [FFmpeg-devel] [PATCH v2 37/44] avformat/asf: Move ASF GUIDs
>> to a new file
>>
>>
> -Original Message-
> From: Andreas Rheinhardt
> Sent: Saturday, May 7, 2022 2:28 PM
> To: Soft Works ; FFmpeg development discussions
> and patches
> Subject: Re: [FFmpeg-devel] [PATCH v2 37/44] avformat/asf: Move ASF
> GUIDs to a new file
>
> Soft Works:
> >
> >
> >> -Original
You have completely ignored my question, haven't you? Here it is again:
>> Is there a Path struct, analogous to LLVM class, that all of FFmpeg is using?
>> Or FFmpeg isn't using any special structs and paths are indistinguishable
>> from ordinary strings?
> Read again. As each lib gets its own co
Unify file access operations by replacing usages of direct calls to posix
fopen()
softworkz (2):
fftools: use av_fopen_utf8() instead of plain fopen()
avfilter: use av_fopen_utf8() instead of plain fopen()
fftools/cmdutils.c| 6 +++---
fftools/ffmpeg.c | 4 ++--
ffto
From: softworkz
Signed-off-by: softworkz
---
fftools/cmdutils.c | 6 +++---
fftools/ffmpeg.c | 4 ++--
fftools/opt_common.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 5d7cdc3e10..ca3a4c267a 100644
--- a/fftools/cmdu
From: softworkz
Signed-off-by: softworkz
---
libavfilter/af_firequalizer.c | 2 +-
libavfilter/vf_deshake.c | 2 +-
libavfilter/vf_signature.c| 4 ++--
libavfilter/vf_ssim.c | 2 +-
libavfilter/vf_vmafmotion.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --g
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nil
> Admirari
> Sent: Saturday, April 23, 2022 10:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h:
> Add whcartoutf8, wchartoansi and utf8toansi
>
> These functions are goin
> -Original Message-
> From: ffmpeg-devel On Behalf Of nil-
> admir...@mailo.com
> Sent: Saturday, May 7, 2022 7:33 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v11 1/6]
> libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and
> utf8toansi
>
> You have co
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nil
> Admirari
> Sent: Saturday, April 23, 2022 10:56 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v11 2/6] libavformat/avisynth.c: Remove
> MAX_PATH limit
>
> ---
> libavformat/avisynth.c | 12 +++-
>
On Sat, May 07, 2022 at 09:36:34AM +, softworkz wrote:
> From: softworkz
>
> The spec allows attachment sizes of up to UINT32_MAX while
> we can handle only sizes up to INT32_MAX (in downstream
> code)
>
> The debug.assert in get_tag didn't really address this,
> and truncating the value_len
On Sat, May 07, 2022 at 09:36:35AM +, softworkz wrote:
> From: softworkz
>
> unsupported values
>
> get_value had a return type of int, which means that reading
> QWORDS (case 4) was broken due to truncation of the result from
> avio_rl64().
>
> Signed-off-by: softworkz
> ---
> libavforma
On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
> d607af50fd broke alpha processing by always overwriting any supplied
> alpha expression.
> ---
> libavfilter/vf_geq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B1
From: Steven Liu
ff_http_get_shutdown_status is unused after ticket 9010 fixed.
Signed-off-by: Steven Liu
---
libavformat/http.c | 15 ---
libavformat/http.h | 9 -
2 files changed, 24 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index c4eeb58cd0..c8f
fix ticket: 9238
There should check option flags with HLS_PROGRAM_DATE_TIME before
set discont_program_date_time.
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index d2b8215
because the flags in AVOption support i64.
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index d91c7ebcb7..8e91c7a980 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
In parse_playlist, the discont_program_date_time should be used after
EXT-X-PROGRAM-DATE-TIME tag parsed.
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index d2b8215dff..b9f
because the flags in AVOption support i64.
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index b9f79e30d8..00645ae74e 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Saturday, May 7, 2022 8:49 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 01/11] libavformat/asf: fix
> handling of byte array length valu
On Mon, May 2, 2022 at 1:15 PM "zhilizhao(赵志立)" wrote:
>
>
>
> > On May 2, 2022, at 11:36 AM, Jun Zhao wrote:
> >
> > From: Jun Zhao
> >
> > Enable the Guangdian profile support
> >
> > Signed-off-by: Jun Zhao
> > ---
> > libavformat/cavsvideodec.c | 5 +++--
> > 1 file changed, 3 insertions(+),
The spec allows attachment sizes of up to UINT32_MAX while we can handle
only sizes up to INT32_MAX (in downstream code)
The debug.assert in get_tag didn't really address this, and truncating the
value_len in calling methods cannot be used because the length value is
required in order to continue
From: softworkz
The spec allows attachment sizes of up to UINT32_MAX while
we can handle only sizes up to INT32_MAX (in downstream
code)
The debug.assert in get_tag didn't really address this,
and truncating the value_len in calling methods cannot
be used because the length value is required in
From: softworkz
unsupported values
get_value had a return type of int, which means that reading
QWORDS (case 4) was broken due to truncation of the result from
avio_rl64().
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 57 +++---
1 file changed, 43
From: softworkz
The value_len is an uint32 not an int32 per spec. That
value must not be truncated, neither by casting to int, nor by any
conditional checks, because at the end of get_tag, this value is
needed to move forward in parsing. When the len value gets
modified, the parsing may break.
S
From: softworkz
These three are closely related and can't be separated easily:
In get_tag, the code was adding 22 bytes (in order to allow
it to hold 64bit numbers as string) to the value len for creating
creating a buffer. This was unnecessarily imposing a
size-constraint on the value_len param
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 4af8200f89..3663f31330 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -323,7 +323,7
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 8071325a2f..9ad2ca946b 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -280,
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 9ad2ca946b..19b4a5fad1 100644
--- a/libavformat/asfdec_f.c
+++ b/libavfo
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 168 ++---
1 file changed, 108 insertions(+), 60 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 3663f31330..da43c2bc11 100644
--- a/libavformat/asfdec_f.c
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 19b4a5fad1..9a6f45d9a5 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/a
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 9a6f45d9a5..928e5717fc 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -1190,7 +119
From: softworkz
Signed-off-by: softworkz
---
libavformat/asfdec_f.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
index 928e5717fc..4af8200f89 100644
--- a/libavformat/asfdec_f.c
+++ b/libavformat/asfdec_f.c
@@ -977,6 +977,7 @@ static int as
On Wed, Apr 27, 2022 at 03:49:49PM +0700, Ivan Baykalov wrote:
> Some streams contain closed caption data embedded using several wrapping
> types. For example stream can contain CC wrapped as ATSC A53 packets +
> the same data wrapped as SCTE-20 packets. Prior to the patch CC data was
> extracted f
On 2022-05-08 12:40 am, Michael Niedermayer wrote:
On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
d607af50fd broke alpha processing by always overwriting any supplied
alpha expression.
---
libavfilter/vf_geq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
Pushe
95 matches
Mail list logo
