Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize

2022-03-30 Thread Wang, Fei W
> -Original Message- > From: Xiang, Haihao > Sent: Tuesday, March 29, 2022 8:07 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wang, Fei W ; linjie...@intel.com > Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for > maxframesize > > On Tue, 2022-03-22 at 22:11 +0800,

Re: [FFmpeg-devel] [PATCH v9 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Mark Gaiser
On Mon, Mar 28, 2022 at 7:00 PM Mark Gaiser wrote: > On Mon, Mar 28, 2022 at 6:44 PM Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Mon, Mar 28, 2022 at 06:34:33PM +0200, Mark Gaiser wrote: >> > On Mon, Mar 28, 2022 at 6:19 PM Michael Niedermayer < >> mich...@niedermayer.cc> >> >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: clean up unconditional override of avctx bit rate

2022-03-30 Thread Jan Ekström
On Wed, Mar 30, 2022 at 5:21 AM James Almer wrote: > > On 3/27/2022 3:02 PM, Jan Ekström wrote: > > This value is only documented to be utilized if rate control is > > set to one of the bit rate based modes. These modes are not the > > default and thus the wrapper itself configures a bit rate acco

Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-30 Thread Andreas Rheinhardt
Martijn van Beurden: > The size of residuals in a FLAC file coding for 24-bit PCM can > exceed the range of a 32-bit signed integer. One pathological > example with residuals exceeding [-2^33,2^33) can be found here: > http://www.audiograaf.nl/misc_stuff/Extreme%20residual%20LPC%20order%2014.flac

Re: [FFmpeg-devel] [PATCH] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in

2022-03-30 Thread Michael Niedermayer
On Tue, Mar 29, 2022 at 06:33:06PM -0300, James Almer wrote: > On 3/29/2022 6:24 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 45982/clusterfuzz-testcase-minimized-ffmpeg_BSF_PCM_RECHUNK_fuzzer-5562089618407424 > > > > Found-by: continuous fuzzing process > > https://github.co

Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-30 Thread Andreas Rheinhardt
Leo Izen: > On 3/23/22 11:08, Andreas Rheinhardt wrote: >>> +    temp = av_realloc(ctx->buffer, ctx->buffer_size); >>> +    if (!temp) { >>> +    av_freep(&ctx->buffer); >> If you free this, you will be in a scenario where ctx->buffer is NULL, >> yet ctx->buffer_size is

Re: [FFmpeg-devel] [PATCH v9 4/5] avformat/image2: add Jpeg XL as image2 format

2022-03-30 Thread Andreas Rheinhardt
Leo Izen: > On 3/24/22 14:38, Michael Niedermayer wrote: >> make -j32 tools/probetest && tools/probetest 256 4096 >> >> testing size=1 >> testing size=2 >> testing size=4 >> Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:549 >> Aborted (core dumped) > Not sure where this failure is coming

[FFmpeg-devel] [PATCH v10 0/1] Add IPFS protocol support.

2022-03-30 Thread Mark Gaiser
Hi, This patch series adds support for IPFS. V10: - Removed free on c->gateway in ipfs_close to fix a double free. V9: - dweb.link as fallback gateway. This is managed by Protocol Labs (like IPFS). - Change all errors to warnings as not having a gateway still gives you a working video playback.

[FFmpeg-devel] [PATCH v10 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Mark Gaiser
This patch adds support for: - ffplay ipfs:// - ffplay ipns:// IPFS data can be played from so called "ipfs gateways". A gateway is essentially a webserver that gives access to the distributed IPFS network. This protocol support (ipfs and ipns) therefore translates ipfs:// and ipns:// to a http:/

Re: [FFmpeg-devel] [PATCH] vc1dsp: Change remaining stride parameters to ptrdiff_t

2022-03-30 Thread Martin Storsjö
On Tue, 29 Mar 2022, Ben Avison wrote: On 29/03/2022 13:44, Martin Storsjö wrote: The existing x86 assembly for loop filters uses the stride as a full register without clearing/sign extending the upper half of the registers on x86_64. This avoids crashes if the caller would have passed nonzero

Re: [FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

2022-03-30 Thread Martin Storsjö
On Sun, 27 Mar 2022, Martin Storsjö wrote: tiny_ssim is built for the build host, not for the target platform. Therefore, it mustn't include the config.h header, which is set up specifically for the target platform and compiler. This fixes cross building for older WinStore platforms, where conf

[FFmpeg-devel] [PATCH v5 00/21] avdevice (mostly dshow) enhancements

2022-03-30 Thread Diederick Niehorster
This patch series implements a series of features, mostly enhancing the dshow avdevice, but also adding new functionality to avformat. This whole patchset enabled users of the FFmpeg API to fully query and control a dshow device, making FFmpeg a nice backend for any program that needs access to, e.

[FFmpeg-devel] [PATCH v5 01/21] avdevice: lock to minor version of avformat

2022-03-30 Thread Diederick Niehorster
As per discussion on the list ( https://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/281513.html, see especially https://ffmpeg.org/pipermail/ffmpeg-devel/2021-June/281586.html), to resolve the the unholy ABI-relationship between libavdevice and libavformat and allow easier working on the part of th

[FFmpeg-devel] [PATCH v5 02/21] avformat: add control_message function to AVInputFormat

2022-03-30 Thread Diederick Niehorster
Control messages are useful for programmatic control of not only outdevs but also indevs. Bumping avformat version. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 8 +--- libavformat/avformat.h | 6 ++ libavformat/version.h | 2 +- 3 files changed, 12 insertions(+), 4

[FFmpeg-devel] [PATCH v5 03/21] avdevice/dshow: implement control_message interface

2022-03-30 Thread Diederick Niehorster
This allows programmatic users of avdevice to start and stop the DirectShow Capture graph (i.e. receive frames or not). This is important because now the buffer fills up and starts dropping samples when enqueued packets are not read out immediately after the demuxer is opened. Bumping avdevice ver

[FFmpeg-devel] [PATCH v5 04/21] avdevice: add control message requesting to show config dialog

2022-03-30 Thread Diederick Niehorster
This control message can be used to programmatically ask a device to show one of its configuration dialogs. Adding documentation of this message's int argument. Bumping avdevice version. Signed-off-by: Diederick Niehorster --- doc/indevs.texi| 34 ++ lib

[FFmpeg-devel] [PATCH v5 05/21] avdevice/dshow: accept show config dialog control message

2022-03-30 Thread Diederick Niehorster
DirectShow source will pop up its configuration dialog when AV_APP_TO_DEV_CONFIG is received. Implementation for several other possible configuration dialogs is more involved and will be provided in the next commit. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 29 +++

[FFmpeg-devel] [PATCH v5 06/21] avdevice/dshow: add config dialog command for crossbar and tv tuner

2022-03-30 Thread Diederick Niehorster
The "show config dialog" command message can now also trigger dialog boxes for the crossbar connecting pins filter the analog tuner audio / analog tuner filters. Bumping avdevice version. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 51 ++-- libavdevice

[FFmpeg-devel] [PATCH v5 07/21] avdevice/avdevice: Revert "Deprecate AVDevice Capabilities API"

2022-03-30 Thread Diederick Niehorster
This reverts commit 4f49ca7bbc75a9db4cdf93f27f95a668c751f160. The next few patches clean up the API and implement this capability for avdevice/dshow. Bumping avformat and avdevice version. Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 71 ++

[FFmpeg-devel] [PATCH v5 08/21] avdevice/avdevice: clean up avdevice_capabilities_create

2022-03-30 Thread Diederick Niehorster
Draw implementation in line with that of avdevice_list_devices Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavdevice/avdevice.c b/libavdevice/avdevice.c index d367189532..2e8261e0d2 100644 --- a/libav

[FFmpeg-devel] [PATCH v5 09/21] avdevice: capabilities API details no longer public

2022-03-30 Thread Diederick Niehorster
Bumping avdevice major version (API removed, even if it cannot have been used by anyone) Signed-off-by: Diederick Niehorster --- libavdevice/avdevice.c | 2 +- libavdevice/avdevice.h | 28 +--- libavdevice/internal.h | 33 +

[FFmpeg-devel] [PATCH v5 10/21] avutil/opt: document AVOptionRange min_value > max_value

2022-03-30 Thread Diederick Niehorster
AVOptionRange needs a way to encode that an option is not set. Here i provide a documentation solution. When a range is invalid (value_min > value_max), it should be considered unset/value not available. When querying a range of formats of an avdevice, sometimes for a given format the queried opti

[FFmpeg-devel] [PATCH v5 11/21] avdevice: Add internal helpers for querying device capabilities

2022-03-30 Thread Diederick Niehorster
Signed-off-by: Diederick Niehorster --- libavdevice/internal.h | 31 +++ libavdevice/utils.c| 48 ++ 2 files changed, 79 insertions(+) diff --git a/libavdevice/internal.h b/libavdevice/internal.h index bef3a4bd2d..eee493a4c7 100

[FFmpeg-devel] [PATCH v5 12/21] avdevice: change device capabilities option type

2022-03-30 Thread Diederick Niehorster
Changes fps option from AVRational to double. This since any device capability query results are returned in AVOptionRanges, which hold the value as doubles, which can't contain AVRationals. Also updated documentation of other capabilities, some had the wrong option type listed. micro version bum

[FFmpeg-devel] [PATCH v5 13/21] avdevice: improve capabilities' option API

2022-03-30 Thread Diederick Niehorster
This adds avdevice_capabilities_get_class() to allow examining the capabilities that can be queried/set through the capabilities API, and avdevice_capabilities_bprint_num() which allows printing the value returned when querying a capability. These values (min_value and max_value of an AVOptionRange

[FFmpeg-devel] [PATCH v5 14/21] avdevice/dshow: move audio format helpers

2022-03-30 Thread Diederick Niehorster
Needs to be moved up in file for upcoming implementation of avdevice_capabilities_create. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/d

[FFmpeg-devel] [PATCH v5 15/21] avdevice/dshow: when closing, set context fields back to zero

2022-03-30 Thread Diederick Niehorster
After the avdevice capabilities API is implemented, the format context may be reused after querying device capabilities in a later avformat_open_input call. To enable this reuse, after releasing resources, make sure to also set the corresponding pointers back to NULL. This correctly indicates their

[FFmpeg-devel] [PATCH v5 16/21] avdevice/dshow: implement capabilities API

2022-03-30 Thread Diederick Niehorster
This implements avdevice_capabilities_create and avdevice_capabilities_free for the dshow device. This enables configuration discovery of DirectShow devices through the API, which is important for my use case. It enables making proper GUIs presenting users with options, instead of asking them to d

[FFmpeg-devel] [PATCH v5 17/21] avdevice/dshow: cosmetics

2022-03-30 Thread Diederick Niehorster
Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 58476a0f40..3cae7d265e 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -933,6

Re: [FFmpeg-devel] [PATCH v10 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Andreas Rheinhardt
Mark Gaiser: > This patch adds support for: > - ffplay ipfs:// > - ffplay ipns:// > > IPFS data can be played from so called "ipfs gateways". > A gateway is essentially a webserver that gives access to the > distributed IPFS network. > > This protocol support (ipfs and ipns) therefore translates

[FFmpeg-devel] [PATCH v5 18/21] avformat: add avformat_alloc_input_context()

2022-03-30 Thread Diederick Niehorster
avformat_alloc_input_context function analogous to avformat_alloc_output_context2, except that it does not take a filename argument as guessing the format by just the filename does not make sense. avformat_alloc_input_context can be used e.g. with the avdevice capabilities API, which needs an alloc

[FFmpeg-devel] [PATCH v5 19/21] doc/examples: adding device_get_capabilities example

2022-03-30 Thread Diederick Niehorster
This example also shows use of get_device_list API. Also improve capability API doc in avdevice.h: now point to this example instead of rough example code given in the header. Signed-off-by: Diederick Niehorster --- configure | 2 + doc/examples/.gitignore

[FFmpeg-devel] [PATCH v5 20/21] Makefile/examples: cosmetics

2022-03-30 Thread Diederick Niehorster
Signed-off-by: Diederick Niehorster --- doc/examples/Makefile | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/doc/examples/Makefile b/doc/examples/Makefile index de707bb3ca..7988ed4226 100644 --- a/doc/examples/Makefile +++ b/doc/e

[FFmpeg-devel] [PATCH v5 21/21] avdevice/dshow: capabilities query also works on opened device

2022-03-30 Thread Diederick Niehorster
While the capabilities API is in principle meant to be used with an allocated format context belonging to an unopened device, small changes make it work for an opened dshow device as well. So hereby done. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 110 +

Re: [FFmpeg-devel] [PATCH 05/10] avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the ti

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the ti

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as maintainer for libsrt protocol

2022-03-30 Thread lance . lmwang
On Fri, Mar 25, 2022 at 03:40:33PM +0800, Zhao Zhili wrote: > Signed-off-by: Zhao Zhili > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 931cf4bd2c..5daa6f8e03 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -516,6 +516,7 @@ Proto

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. Note that the C version can still outperform the NEON version in specific cases. The balance between different code paths is stream-dependent, but in practice the best case happens about 5% of the ti

Re: [FFmpeg-devel] [PATCH v10 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Mark Gaiser
On Wed, Mar 30, 2022 at 2:21 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mark Gaiser: > > This patch adds support for: > > - ffplay ipfs:// > > - ffplay ipns:// > > > > IPFS data can be played from so called "ipfs gateways". > > A gateway is essentially a webserver that gives

Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-30 Thread Leo Izen
On 3/30/22 07:12, Andreas Rheinhardt wrote: buffer_size is not used after libjxl_encode_close() at all, as this is the codec's close callback; libjxl_encode_frame() meanwhile may be called again after freeing and if it reaches JxlEncoderProcessOutput(), the latter would be called with next_out

Re: [FFmpeg-devel] [PATCH v9 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-30 Thread Andreas Rheinhardt
Leo Izen: > > On 3/30/22 07:12, Andreas Rheinhardt wrote: >> buffer_size is not used after libjxl_encode_close() at all, as this is >> the codec's close callback; libjxl_encode_frame() meanwhile may be >> called again after freeing and if it reaches JxlEncoderProcessOutput(), >> the latter would b

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_inv_trans_4x4_c: 158.2 vc1dsp.vc1_inv_trans_4x4_neon: 65.7 vc1dsp.vc1_inv_trans_4x4_dc_c: 86.5 vc1dsp.vc1_inv_trans_4x4_dc_neon: 26.5 vc1dsp.vc1_inv_trans_4x8_c: 335.2 vc1dsp.vc1_inv_tran

[FFmpeg-devel] [PATCH] doc/bitstream_filters: fix for the syntax of code

2022-03-30 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/bitstream_filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 0b354fd..fc2c71f 100644 --- a/doc/bitstream_filters.texi +++ b/doc/bitstream_filters.texi @

Re: [FFmpeg-devel] [PATCH v10 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Andreas Rheinhardt
Mark Gaiser: > On Wed, Mar 30, 2022 at 2:21 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Mark Gaiser: >>> This patch adds support for: >>> - ffplay ipfs:// >>> - ffplay ipns:// >>> >>> IPFS data can be played from so called "ipfs gateways". >>> A gateway is essentially a w

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-30 Thread Martin Storsjö
On Wed, 30 Mar 2022, Martin Storsjö wrote: On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_inv_trans_4x4_c: 158.2 vc1dsp.vc1_inv_trans_4x4_neon: 65.7 vc1dsp.vc1_inv_trans_4x4_dc_c: 86.5 vc1dsp.vc1_inv_trans_4x4_dc_neon: 26.5 vc1dsp.v

Re: [FFmpeg-devel] [PATCH 08/10] avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. idctdsp.add_pixels_clamped_c: 323.0 idctdsp.add_pixels_clamped_neon: 41.5 idctdsp.put_pixels_clamped_c: 243.0 idctdsp.put_pixels_clamped_neon: 30.0 idctdsp.put_signed_pixels_clamped_c: 225.7 idctdsp

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: fix for the syntax of code

2022-03-30 Thread Michael Niedermayer
On Wed, Mar 30, 2022 at 09:51:45PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/bitstream_filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7

Re: [FFmpeg-devel] [PATCH 09/10] avcodec/vc1: Arm 64-bit NEON unescape fast path

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_unescape_buffer_c: 655617.7 vc1dsp.vc1_unescape_buffer_neon: 118237.0 Signed-off-by: Ben Avison --- libavcodec/aarch64/vc1dsp_init_aarch64.c | 61 libavcodec/aarch64/vc1dsp_neo

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/vc1: Arm 32-bit NEON unescape fast path

2022-03-30 Thread Martin Storsjö
On Fri, 25 Mar 2022, Ben Avison wrote: checkasm benchmarks on 1.5 GHz Cortex-A72 are as follows. vc1dsp.vc1_unescape_buffer_c: 918624.7 vc1dsp.vc1_unescape_buffer_neon: 142958.0 Signed-off-by: Ben Avison --- libavcodec/arm/vc1dsp_init_neon.c | 61 +++ libavcodec/arm/vc1dsp_neon.S

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: fix for the syntax of code

2022-03-30 Thread Gyan Doshi
On 2022-03-30 07:21 pm, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/bitstream_filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 0b354fd..fc2c71f 100644 --- a/

[FFmpeg-devel] [PATCH v10 1/5] avcodec/jpegxl: add Jpeg XL image codec and parser

2022-03-30 Thread Leo Izen
This commit adds support to libavcodec to read and parse encoded Jpeg XL images. Jpeg XL is intended to be an extended-life replacement to legacy mjpeg. --- MAINTAINERS| 2 + libavcodec/Makefile| 1 + libavcodec/codec_desc.c| 9 + libavcodec/codec_id.h | 1

[FFmpeg-devel] [PATCH v10 2/5] avcodec/libjxl: add Jpeg XL decoding via libjxl

2022-03-30 Thread Leo Izen
This commit adds decoding support to libavcodec for Jpeg XL images via the external library libjxl. --- MAINTAINERS | 1 + configure | 5 + doc/general_contents.texi | 7 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/libjxl.c

[FFmpeg-devel] [PATCH v10 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

2022-03-30 Thread Leo Izen
This commit adds encoding support to libavcodec for Jpeg XL images via the external library libjxl. --- configure | 3 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libjxlenc.c | 379 + 4 files changed, 383 inse

[FFmpeg-devel] [PATCH v10 4/5] avformat/image2: add Jpeg XL as image2 format

2022-03-30 Thread Leo Izen
This commit adds support to libavformat for muxing and demuxing Jpeg XL images as image2 streams. --- libavformat/allformats.c | 1 + libavformat/img2.c | 1 + libavformat/img2dec.c| 21 + libavformat/img2enc.c| 6 +++--- libavformat/mov.c| 1 + libavf

[FFmpeg-devel] [PATCH v10 5/5] fate/jpegxl: add Jpeg XL demux and parse FATE test

2022-03-30 Thread Leo Izen
Add a fate test for the Jpeg XL parser in libavcodec and its image2 wrapper inside libavformat. --- tests/fate/image.mak| 10 ++ tests/ref/fate/jxl-parse-codestream | 6 ++ tests/ref/fate/jxl-parse-container | 6 ++ 3 files changed, 22 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: fix for the syntax of code

2022-03-30 Thread lance . lmwang
On Wed, Mar 30, 2022 at 08:11:11PM +0530, Gyan Doshi wrote: > > > On 2022-03-30 07:21 pm, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/bitstream_filters.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH v10 1/1] avformat: Add IPFS protocol support.

2022-03-30 Thread Mark Gaiser
On Wed, Mar 30, 2022 at 3:57 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mark Gaiser: > > On Wed, Mar 30, 2022 at 2:21 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Mark Gaiser: > >>> This patch adds support for: > >>> - ffplay ipfs:// > >>> - ffp

Re: [FFmpeg-devel] [PATCH] [PATCH] libavformat/mov: Expose Quicktime poster_time value as metadata TAG.

2022-03-30 Thread Bryce Newman
Hello, I was wondering if there are any comments on this patch request? Thank you in advance. Bryce Bryce Chester Newman | Principal Developer p: +12069255045 | ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mail

[FFmpeg-devel] minterpolate filter with Multi-Threading Support?

2022-03-30 Thread Thibault MORISSE
Hi FFMPEG Community, minterpolate filter gives really great results, however since it's single threaded, it's super duper slow. Is there a way to request for multi-thread support? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

[FFmpeg-devel] [PATCH 1/2] avfilter/src_movie: switch to activate()

2022-03-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/src_movie.c | 76 - 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 711854c23c..78b87cf444 100644 --- a/libavfilter/src_movie.c +++ b/libavfi

[FFmpeg-devel] [PATCH 2/2] avfilter/src_movie: add option to set decoding thread type

2022-03-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 3 +++ libavfilter/src_movie.c | 11 +-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1d56d24819..af332041e8 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -287

Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-30 Thread Martijn van Beurden
First of all, thanks for reviewing Op wo 30 mrt. 2022 om 12:42 schreef Andreas Rheinhardt : > Can this happen with real encoders or has this file been specifically > crafted? What is the performance impact of this patch on ordinary files? This file has been crafted. It seems unlikely to occur in

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-30 Thread Danil Chapovalov
--- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 4b8cc69c0d..a304f865a6 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1996,8 +1996,11 @@ kilobits/s. @item keyint_min (@emp

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as maintainer for libsrt protocol

2022-03-30 Thread Marton Balint
On Fri, 25 Mar 2022, Zhao Zhili wrote: Signed-off-by: Zhao Zhili --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 931cf4bd2c..5daa6f8e03 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -516,6 +516,7 @@ Protocols: bluray.c

[FFmpeg-devel] [PATCH 1/8] fate/filter-refcmp-*: make refcmp_metadata fail on empty input

2022-03-30 Thread Marton Balint
On empty input the awk script was always successful which caused the filter-refcmp tests to always succeed. Also fix the command lines for refcmp_metadata compare function because it needs auto conversion filters, and update reference of test filter-refcmp-psnr-rgb because it was missed in a7fc78c

[FFmpeg-devel] [PATCH 2/8] avcodec/texturedsp: add TextureDSPThreadContext for common decode/encode function

2022-03-30 Thread Marton Balint
This will allow using a common threaded decode or encode function from most codecs using texture DSP functions. Signed-off-by: Marton Balint --- libavcodec/texturedsp.c | 4 +++ libavcodec/texturedsp.h | 23 + libavcodec/texturedsp_template.c | 57 +

[FFmpeg-devel] [PATCH 3/8] avcodec/dds: use the common texture dsp decode function

2022-03-30 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/dds.c | 135 +-- 1 file changed, 48 insertions(+), 87 deletions(-) diff --git a/libavcodec/dds.c b/libavcodec/dds.c index 32690e1fd7..2254d18df8 100644 --- a/libavcodec/dds.c +++ b/libavcodec/dds.c @@ -106,12

[FFmpeg-devel] [PATCH 4/8] avcodec/hapdec: use the common texturedsp decode function

2022-03-30 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/hap.h| 11 ++--- libavcodec/hapdec.c | 110 ++-- 2 files changed, 28 insertions(+), 93 deletions(-) diff --git a/libavcodec/hap.h b/libavcodec/hap.h index 00c3dbb32d..7e065e4838 100644 --- a/libavcodec/hap.h

[FFmpeg-devel] [PATCH 6/8] avcodec/vbndec: add VBN decoder

2022-03-30 Thread Marton Balint
Add support for decoding Vizrt Binary Image (VBN) files. LZW-compressed data is not supported yet. Signed-off-by: Marton Balint --- Changelog| 1 + configure| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c |

[FFmpeg-devel] [PATCH 5/8] avcodec/hapenc: use the common texturedsp encode function

2022-03-30 Thread Marton Balint
And add slice thread capabilities. Signed-off-by: Marton Balint --- libavcodec/hap.h| 4 +--- libavcodec/hapenc.c | 34 -- 2 files changed, 17 insertions(+), 21 deletions(-) diff --git a/libavcodec/hap.h b/libavcodec/hap.h index 7e065e4838..fb5a4c4123 100644

[FFmpeg-devel] [PATCH 8/8] fate: add fate tests for VBN encoder and decoder

2022-03-30 Thread Marton Balint
Signed-off-by: Marton Balint --- tests/Makefile | 1 + tests/fate-run.sh| 11 +++ tests/fate/vbn.mak | 36 tests/ref/fate/vbn-dxt1 | 11 +++ tests/ref/fate/vbn-dxt5 | 11 +++ tests/ref/fate

[FFmpeg-devel] [PATCH 7/8] avcodec/vbnenc: add VBN encoder

2022-03-30 Thread Marton Balint
Signed-off-by: Marton Balint --- Changelog | 2 +- configure | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/vbnenc.c| 173 + libavcodec/version.h | 2 +- libavformat/img2enc.c | 2 +

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: stop the codec before releasing it

2022-03-30 Thread Matthieu Bouron
Fixes the following warnings/errors on codec release: E/BufferQueueProducer: [SurfaceTexture-0-31763-0](id:7c130001,api:3,p:31763,c:31763) detachBuffer: slot 0 is not owned by the producer (state = FREE) E/BufferQueueProducer: [SurfaceTexture-0-31763-0](id:7c130001,api:3,p:31763,c:31763

[FFmpeg-devel] [PATCH] avfilter/alimiter: Remove the delay introduced by lookahead buffer

2022-03-30 Thread Wang Cao
The change essentially removes the delay introduces by lookahead buffer. The valid audio data in the internal buffer is also flushed to ensure the integrity of output. Signed-off-by: Wang Cao --- doc/filters.texi | 2 - libavfilter/af_alimiter.c | 97 +- tests/ref/fate/

[FFmpeg-devel] [PATCH 1/7] avcodec/options: Fix AVClassCategory of decoders with .receive_frame

2022-03-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 91ab994994..2e05d29e1e 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -68,7 +68,7 @@ static const AVCla

[FFmpeg-devel] [PATCH 2/7] avcodec/codec_internal: Add FFCodec.decode_sub

2022-03-30 Thread Andreas Rheinhardt
This increases type-safety by avoiding conversions from/through void*. It also avoids the boilerplate "AVSubtitle *sub = data;" line for subtitle decoders. Its only downside is that it increases sizeof(FFCodec), yet this can be more than offset lateron. Signed-off-by: Andreas Rheinhardt --- liba

[FFmpeg-devel] [PATCH 5/7] avcodec/codec_internal: Constify AVPacket in decode_sub cb

2022-03-30 Thread Andreas Rheinhardt
No subtitle decoder ever modifies the AVPacket given to it. Signed-off-by: Andreas Rheinhardt --- libavcodec/assdec.c | 2 +- libavcodec/ccaption_dec.c| 2 +- libavcodec/codec_internal.h | 2 +- libavcodec/dvbsubdec.c | 2 +- libavcodec/dvdsubdec.c |

[FFmpeg-devel] [PATCH 6/7] avcodec: Make avcodec_decoder_subtitles2 accept a const AVPacket*

2022-03-30 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- doc/APIchanges| 3 +++ fftools/ffmpeg.c | 4 ++-- fftools/ffprobe.c | 2 +- libavcodec/avcodec.h | 3 +-- libavcodec/decode.c | 9 - libavcodec/version.h | 2 +- tools/target_dec_

[FFmpeg-devel] [PATCH 7/7] avformat/demux: Avoid stack packet when decoding frame

2022-03-30 Thread Andreas Rheinhardt
Possible now that avcodec_decode_subtitle2() accepts a const AVPacket*. Signed-off-by: Andreas Rheinhardt --- libavformat/demux.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index ef189d9d8e..ed5c811a01 100644 --- a

[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-03-30 Thread Mohammad Izadi
From: Gyan Doshi The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ --- libavcodec/dynamic_hdr10_plus.c | 269 +--- libavcodec/dynamic_hdr10_pl

Re: [FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_videotoolbox: create real buffer pool

2022-03-30 Thread zhilizhao(赵志立)
Ping for patch 1/2. rcombs has reviewed the patch on IRC. I decided to drop patch 2/2. > 11:05 rcombs: quink_: seems reasonable to me > 11:06 quink_: rcombs: thanks : ) > 11:06 rcombs: not entirely sure what the deal with the second commit is but > ¯\_(ツ)_/¯ it's harmless so w/e > On Mar 10, 2