>You mean an ever-growing buffer when talking about a "memory leak"?
>Because I actually don't see any ordinary memory leak.
>- Andreas
Yes, that's it, the fifo grows at every write. I will fix the commit msg in the
next version.
Nicolas
___
ffmpeg-dev
Am 18.03.22 um 15:04 schrieb Paul B Mahol:
On 3/18/22, Thilo Borgmann wrote:
On 12 Mar 2022, at 10:06, Thilo Borgmann wrote:
Am 09.03.22 um 18:31 schrieb Paul B Mahol:
On 3/8/22, Thilo Borgmann wrote:
Am 07.03.22 um 20:06 schrieb Paul B Mahol:
On 3/7/22, Thilo Borgmann wrote:
Am 06.03
Xiang, Haihao:
> From: Haihao Xiang
>
> It is possible that an IRAP frame in input AVPacket contains VPS, SPS
> and PPS, and these headers should take effect. However the prepended
> extradata might override these headers. This patch inserts extradata
> before non-AUD unit, hence VPS, SPS and PPS
will apply soon
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
probably ok
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 3/17/2022 11:13 PM, James Almer wrote:
And use av_image_copy_plane() while at it to simplify things for
version != 0x100.
Signed-off-by: James Almer
---
libavcodec/dfa.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/dfa.c b/libavcodec/dfa.c
Signed-off-by: Andreas Rheinhardt
---
libavcodec/internal.h | 2 --
libavfilter/qp_table.h | 4
2 files changed, 6 deletions(-)
diff --git a/libavcodec/internal.h b/libavcodec/internal.h
index badca4c9dd..f9809926b8 100644
--- a/libavcodec/internal.h
+++ b/libavcodec/internal.h
@@ -37,8 +3
From: Limin Wang
Signed-off-by: Limin Wang
---
libavfilter/vf_showinfo.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 12d3931..aa95341 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -812,6 +812,10
All FF_QSCALE_TYPE values used by libavfilter originate
from libavfilter (namely from ff_qp_table_extract());
no value is exchanged between libavcodec and libavutil.
The values that are exchanged (and used in libavfilter)
are of type enum AVVideoEncParamsType.
Therefore this patch stops using said
These values are only used by mpegvideo-based decoders.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263dec.c | 4 ++--
libavcodec/internal.h | 3 ---
libavcodec/mpeg12dec.c | 4 ++--
libavcodec/mpegvideo_dec.c | 2 +-
libavcodec/mpegvideodec.h | 3 +++
libavcodec/rv10.c
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_vpp_qsv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
index 5c96703fd3..cfe343822b 100644
--- a/libavfilter/vf_vpp_qsv.c
+++ b/libavfilter/vf_vpp_qsv.c
@@ -34,8 +34,6 @@
#include "in
Signed-off-by: Andreas Rheinhardt
---
libavcodec/parser.c | 1 -
libavcodec/v4l2_buffers.c | 1 -
libavcodec/v4l2_m2m.c | 1 -
libavformat/chromaprint.c | 1 -
libavformat/genh.c| 1 -
libavformat/tls_openssl.c | 1 -
6 files changed, 6 deletions(-)
diff --git a/libavcodec/pars
Also improve the other headers a bit while at it.
Signed-off-by: Andreas Rheinhardt
---
libavformat/a64.c | 2 +-
libavformat/act.c | 3 ++-
libavformat/apngenc.c | 2 --
libavformat/av1.c | 2 +-
libavformat/flacenc.h
On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote:
> lance.lmw...@gmail.com:
> > On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote:
> >> lance.lmw...@gmail.com:
> >>> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
lance.lmw...@gmail.com:
> On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote:
>> lance.lmw...@gmail.com:
>>> On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote:
lance.lmw...@gmail.com:
> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmw...@gmail.com wrote:
On Mon, Mar 21, 2022 at 06:03:12PM -0300, James Almer wrote:
> On 2/1/2022 3:52 PM, Michael Niedermayer wrote:
> > Fixes: division by zero
> > Fixes:
> > 43769/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5392562205097984
> >
> > Found-by: continuous fuzzing process
> > https://g
From: Romain Beauxis
This is a series of patches that fix and enhances libavdevice & have been
submitted multiple times in the past 6 months. In the series, the most
straightforward patches have been placed first in the list.
While I have a lot of appreciation for all the solid work done in th
From: Romain Beauxis
diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
index 6039578ff9..4ee3f6e194 100644
--- a/libavdevice/dshow.c
+++ b/libavdevice/dshow.c
@@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx, ICreateDevEnum
*devenum,
if (!device)
From: Romain Beauxis
diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
index c9de93f774..719276cabf 100644
--- a/libavdevice/avfoundation.m
+++ b/libavdevice/avfoundation.m
@@ -27,6 +27,7 @@
#import
#include
+#include
#include "libavutil/channel_layout.h"
#include "l
From: Romain Beauxis
diff --git a/doc/indevs.texi b/doc/indevs.texi
index 9d8020311a..858c0fa4e4 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -114,7 +114,7 @@ The input filename has to be given in the following syntax:
-i "[[VIDEO]:[AUDIO]]"
@end example
The first entry selects the vi
From: Romain Beauxis
Previous version of these changes used the AudioConverter API to perform audio
conversion explicitly however, it was found to be bug prone with issues
seemingly coming from the underlying OS.
This fixes: https://trac.ffmpeg.org/ticket/9502
---
libavdevice/avfoundation.m |
From: Romain Beauxis
This issue was particularly noticeable when working with audio input.
---
libavdevice/avfoundation.m | 232 -
1 file changed, 100 insertions(+), 132 deletions(-)
diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
index 0
From: Romain Beauxis
diff --git a/configure b/configure
index a7953ffc16..37f9f7b80a 100755
--- a/configure
+++ b/configure
@@ -203,6 +203,7 @@ External library support:
--disable-avfoundation disable Apple AVFoundation framework [autodetect]
--enable-avisynthenable reading of Avi
On Tue, Mar 22, 2022 at 7:40 AM wrote:
>
> From: Romain Beauxis
>
> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
> index 6039578ff9..4ee3f6e194 100644
> --- a/libavdevice/dshow.c
> +++ b/libavdevice/dshow.c
> @@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx,
> ICreateDevE
On Tue, Mar 22, 2022 at 7:40 AM wrote:
>
> From: Romain Beauxis
>
> This is a series of patches that fix and enhances libavdevice & have been
> submitted multiple times in the past 6 months. In the series, the most
> straightforward patches have been placed first in the list.
>
> While I have a
From: Linjie Fu
Add support for max frame size:
- max_frame_size (bytes) to indicate the max allowed size for frame.
If the frame size exceeds the limitation, encoder will to control the frame
size by adjusting QP value.
- MFS_NUM_PASSES to indicate number of passes for QP adjust.
-
From: Linjie Fu
Add docs for max_frame_size option.
Signed-off-by: Linjie Fu
Signed-off-by: Fei Wang
---
doc/encoders.texi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 1bd38671ca..93fb535e98 100644
--- a/doc/encoders.texi
+++ b/doc/enco
On Tue, Mar 22, 2022 at 02:28:10PM +0100, Andreas Rheinhardt wrote:
> lance.lmw...@gmail.com:
> > On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote:
> >> lance.lmw...@gmail.com:
> >>> On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote:
> lance.lmw...@gmail.com:
19 Mar 2022, 18:26 by leo.i...@gmail.com:
> This commit adds encoding support to libavcodec
> for Jpeg XL images via the external library libjxl.
> ---
> configure | 3 +-
> libavcodec/Makefile| 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/libjxlenc.c | 386 +++
On 22 Mar 2022, at 16:35, Lynne wrote:
> 19 Mar 2022, 18:26 by leo.i...@gmail.com:
>
>> This commit adds encoding support to libavcodec
>> for Jpeg XL images via the external library libjxl.
>> ---
>> configure | 3 +-
>> libavcodec/Makefile| 1 +
>> libavcodec/allcodecs.c
On Mon, Mar 14, 2022 at 20:06:39 +0100, Oneric wrote:
> Due to a quirk of the ASS format some tags depend on the exact storage
> resolution of the video, so tell libass via ass_set_storage_size.
> [...]
On Mon, Mar 14, 2022 at 20:21:47 +, Soft Works wrote:
> [...]
>
> Ah, alright, the blur set
The older av_fifo_realloc2 implemented an auto grow that
should be ported as such in the new API.
This patch introduces a limitation in the fifo buffer size.
The default is set to 128MB and may be overriden by a new user option.
The amount of memory allocated depends on multiple factors, including
Avoid an infinite 'retry' loop in output_packet when flushing.
A fatal error mentions the availability of fifo_size_limit option.
Signed-off-by: Nicolas Gaullier
---
libavformat/mpegenc.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/libavformat/mpegenc
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Oneric
> Sent: Tuesday, March 22, 2022 5:28 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: pass
> storage size to libass
>
> On Mon, Mar 14, 202
On 3/22/2022 1:42 PM, Soft Works wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of
Oneric
Sent: Tuesday, March 22, 2022 5:28 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: pass
storage size to libass
On Mon, Ma
On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt
wrote:
>
> Vignesh Venkatasubramanian:
> > Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
> >
> > AVIF Specifiation: https://aomediacodec.github.io/av1-avif
> >
> > Sample usage for still image:
> > ffmpeg -i image.png -c:v libaom-a
Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
AVIF Specifiation: https://aomediacodec.github.io/av1-avif
Sample usage for still image:
ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
Sample usage for animated AVIF image:
ffmpeg -i video.mp4 animated.avif
We can re-u
Nicolas Gaullier:
> The older av_fifo_realloc2 implemented an auto grow that
> should be ported as such in the new API.
>
> This patch introduces a limitation in the fifo buffer size.
> The default is set to 128MB and may be overriden by a new user option.
> The amount of memory allocated depends
Nicolas Gaullier:
> Avoid an infinite 'retry' loop in output_packet when flushing.
>
> A fatal error mentions the availability of fifo_size_limit option.
>
> Signed-off-by: Nicolas Gaullier
> ---
> libavformat/mpegenc.c | 18 +++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
The older av_fifo_realloc2 implemented an auto grow that
should be ported as such in the new API.
This patch introduces a limitation in the fifo buffer size.
The default is set to 128MB and may be overriden by a new user option.
The amount of memory allocated depends on multiple factors, including
Avoid an infinite 'retry' loop in output_packet when flushing.
Signed-off-by: Nicolas Gaullier
---
libavformat/mpegenc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
index e0955a7d33..91574ca95a 100644
--- a/libavformat
>1. Options of type AV_OPT_TYPE_INT need to have a target of type int.
>2. Setting UINT_MAX as maximum for such an option is nonsense; INT_MAX is the
>maximum for it. (FFMIN(INT_MAX, SIZE_MAX) would be even better.) 3. Allowing
>zero for fifo_size_limit makes no sense, as the above code allocates
>Could this infinite loop also happen before switching to the new API?
>Does it happen because avail_data is zero for all streams?
>
>- Andreas
I will take time to double-check this very carefully, but in my experience, if
I remember correctly, it is nothing easy and was already buggy before.
(bu
On Sun, 13 Mar 2022 at 18:34, wrote:
> Well, let's try to submit a patch and see how it fares.
>
>
> Add commandline options to v4l2_m2m_enc (h264_v4l2m2m only)
> and use those to configure options for the h264_v4l2m2m encoder.
> Uses AVOption options to filter for valid options per v4l2 spec.
>
Am 14.03.2022 um 07:41 schrieb Andreas Unterweger:
Am 02.03.2022 um 15:07 schrieb Paul B Mahol:
The patch on patchwork looks fine.
Good morning. Can this patch be merged? Thanks and best regards
Andreas
___
Since other commits have been merged in t
The last encoded frame is now fetched on EOF. It was previously left in the encoder and
caused a "1 frame left in queue" warning.
Signed-off-by: Andreas Unterweger
---
doc/examples/transcode_aac.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/doc/
Previously, the default timebase caused two warnings during decoding about not
being able to update timestamps for skipped and discarded samples, respectively.
Signed-off-by: Andreas Unterweger
---
doc/examples/transcode_aac.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --
From: Kevin Wang
7-bit PictureIDs are not supported by WebRTC:
https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
In practice, 15-bit PictureIDs offer better compatibility.
Signed-off-by: Kevin Wang
---
libavformat/rtpenc_vp8.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
On Tue, Mar 22, 2022 at 3:10 PM Roger Pack wrote:
>
> On Tue, Mar 22, 2022 at 7:40 AM wrote:
> >
> > From: Romain Beauxis
> >
> > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
> > index 6039578ff9..4ee3f6e194 100644
> > --- a/libavdevice/dshow.c
> > +++ b/libavdevice/dshow.c
> > @@ -552
Otherwise get_pixel_format() will not be called when parsing a subsequent
Sequence
Header in non hwaccel enabled scenarios, allowing frame parsing when it
shouldn't.
This prevents the scenario seqhdr -> frame_hdr/redundant_frame_hdr -> seqhdr ->
redundant_frame_hdr from having the latter redunda
This reverts commit 4fdfe430c12225e819f68993474bd2f473c7e8b1.
The previous commit ensures this field will never be zero.
---
libavcodec/av1dec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 727d829e5b..0543452b06 100644
--- a/libavcodec/av1
On 3/22/22 11:35, Lynne wrote:
19 Mar 2022, 18:26 by leo.i...@gmail.com:
This commit adds encoding support to libavcodec
for Jpeg XL images via the external library libjxl.
---
configure | 3 +-
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libjx
From: Christopher Degawa
Signed-off-by: Christopher Degawa
---
libavcodec/libsvtav1.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index f02e410f69..6cf280377e 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@
On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkatasubramanian
wrote:
>
> Add support for parsing AVIF still images. This patches supports
> AVIF still images that have exactly 1 item (i.e.) no alpha channel.
> Essentially, we will have to parse the "iloc" box and populate
> the mov index.
>
> With t
Signed-off-by: Andreas Rheinhardt
---
@michaelni: Please tell me the exact fuzzer issue id.
libavcodec/vp9_raw_reorder_bsf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/vp9_raw_reorder_bsf.c b/libavcodec/vp9_raw_reorder_bsf.c
index 6562399159..1608360fe1 100644
--- a/liba
Packets without data need to be handled specially in order to avoid
undefined reads. Pass these packets through unchanged in case there
are no cached packets* and error out in case there are cached packets:
Returning the packet would mess with the order of the packets;
if one returned the zero-size
They are invalid in VP9. If any of the frames inside a superframe
had a size of zero, the code would either read into the next frame
or into the superframe index; so check for the length to stop this.
Signed-off-by: Andreas Rheinhardt
---
Now split into a patch of its own.
libavcodec/vp9_superf
Fixes: Out of array read
Fixes:
45137/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_SUPERFRAME_SPLIT_fuzzer-4984270639202304
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vp9_superframe_spli
A fix attached.
```
==37349==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 153770 byte(s) in 1 object(s) allocated from:
#0 0x7fa249785330 in __interceptor_malloc
(/usr/lib/x86_64-linux-gnu/libasan.so.5+0xe9330)
#1 0x7fa245c41e59 in WebPMuxAssemble
/libwebp-0.6.1/src/mux/muxe
Signed-off-by: Andrey Volk
---
libavcodec/libwebpenc_animencoder.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libwebpenc_animencoder.c
b/libavcodec/libwebpenc_animencoder.c
index 0f5b524335..29c0d8bb0f 100644
--- a/libavcodec/libwebpenc_animencoder.c
+++ b
---
libavcodec/binkaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c
index 56b58b57c8..0b6888e3e3 100644
--- a/libavcodec/binkaudio.c
+++ b/libavcodec/binkaudio.c
@@ -264,7 +264,7 @@ static int decode_block(BinkAudioContext
on glibc memory.h drags in string.h, but codec2 does not use any
str* or mem* functions. additionally, memory.h is not part of the
C99 or POSIX standards.
---
libavformat/codec2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/codec2.c b/libavformat/codec2.c
index cd0521299c..400c5
62 matches
Mail list logo
