Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-03 Thread Paul B Mahol
On 3/2/22, Michael Niedermayer wrote: > On Wed, Mar 02, 2022 at 08:11:18PM +0100, Paul B Mahol wrote: >> On 3/2/22, Michael Niedermayer wrote: >> > On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: >> >> It seems it does not work properly. >> >> >> >> Signed-off-by: Paul B Mahol >> >

Re: [FFmpeg-devel] [RFC v2] avdevice: lock to minor version of avformat

2022-03-03 Thread Diederick C. Niehorster
Hi Andreas, On Mon, Jan 3, 2022 at 12:03 PM Diederick C. Niehorster wrote: > Hi Andreas, > > Thanks for the comments! > > On Mon, Jan 3, 2022 at 11:02 AM Andreas Rheinhardt > wrote: > > > > Diederick Niehorster: > > > As per discussion on the list ( > > > https://ffmpeg.org/pipermail/ffmpeg-dev

[FFmpeg-devel] [PATCH] libavfilter: vf_scale: Properly take in->color_range into account

2022-03-03 Thread Martin Storsjö
While swscale can be reconfigured with sws_setColorspaceDetails, the in/out ranges also need to be set before calling sws_init_context, otherwise the initialization might choose fastpaths that don't take the ranges into account. Therefore, look at in->color_range too, when deciding on whether the

Re: [FFmpeg-devel] [PATCH] libavfilter: vf_scale: Properly take in->color_range into account

2022-03-03 Thread Diederick C. Niehorster
On Thu, Mar 3, 2022 at 1:07 PM Martin Storsjö wrote: > While swscale can be reconfigured with sws_setColorspaceDetails, > the in/out ranges also need to be set before calling > sws_init_context, otherwise the initialization might choose > fastpaths that don't take the ranges into account. > > The

Re: [FFmpeg-devel] [PATCH v5 1/2] libavcodec: Added DFPWM1a codec

2022-03-03 Thread Paul B Mahol
On 2/27/22, Jack Bruienne wrote: > > From the wiki page (https://wiki.vexatos.com/dfpwm): >> DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec >> created by Ben “GreaseMonkey” Russell in 2012, originally to be used >> as a voice codec for asiekierka's pixmess, a C remake of 64pixels

Re: [FFmpeg-devel] [PATCH v5 1/2] libavcodec: Added DFPWM1a codec

2022-03-03 Thread Paul B Mahol
On 3/3/22, Paul B Mahol wrote: > On 2/27/22, Jack Bruienne wrote: >> >> From the wiki page (https://wiki.vexatos.com/dfpwm): >>> DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec >>> created by Ben “GreaseMonkey” Russell in 2012, originally to be used >>> as a voice codec for asiek

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-03-03 Thread Paul B Mahol
On 2/28/22, Thierry Foucu wrote: > On Sun, Feb 27, 2022 at 3:54 AM Paul B Mahol wrote: > >> On Fri, Feb 25, 2022 at 10:08 PM Thierry Foucu wrote: >> >> > On Thu, Feb 24, 2022 at 11:50 PM Paul B Mahol wrote: >> > >> > > On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu >> wrote: >> > > >> > > > On

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes

2022-03-03 Thread James Almer
On 3/1/2022 11:23 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/framepool.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c index 5b510c9af9..cf6a1d0ea0 100644 --- a/libavfilter/

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes

2022-03-03 Thread Paul B Mahol
On 3/3/22, James Almer wrote: > > > On 3/1/2022 11:23 AM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/framepool.c | 20 ++-- >> 1 file changed, 14 insertions(+), 6 deletions(-) >> >> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c >> in

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes

2022-03-03 Thread James Almer
On 3/3/2022 10:56 AM, Paul B Mahol wrote: On 3/3/22, James Almer wrote: On 3/1/2022 11:23 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/framepool.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavfilter/framepool.c b

Re: [FFmpeg-devel] [RFC v2] avdevice: lock to minor version of avformat

2022-03-03 Thread Andreas Rheinhardt
Diederick C. Niehorster: > Hi Andreas, > > On Mon, Jan 3, 2022 at 12:03 PM Diederick C. Niehorster > wrote: > >> Hi Andreas, >> >> Thanks for the comments! >> >> On Mon, Jan 3, 2022 at 11:02 AM Andreas Rheinhardt >> wrote: >>> >>> Diederick Niehorster: As per discussion on the list (

Re: [FFmpeg-devel] [PATCH v8 1/1] avformat: Add IPFS protocol support.

2022-03-03 Thread Mark Gaiser
On Tue, Mar 1, 2022 at 11:01 PM Michael Niedermayer wrote: > On Mon, Feb 28, 2022 at 02:09:15PM +0100, Tomas Härdin wrote: > > sön 2022-02-27 klockan 15:29 +0100 skrev Mark Gaiser: > > > Ping 2 > > > > > > I'd really like to get this merged! > > > This kinda blocks me right now from proceedin

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread James Almer
On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated

[FFmpeg-devel] [PATCH v6 1/2] libavcodec: Added DFPWM1a codec

2022-03-03 Thread Jack Bruienne
From the wiki page (https://wiki.vexatos.com/dfpwm): DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec created by Ben “GreaseMonkey” Russell in 2012, originally to be used as a voice codec for asiekierka's pixmess, a C remake of 64pixels. It is a 1-bit-per-sample codec which uses a

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes

2022-03-03 Thread Paul B Mahol
On 3/3/22, James Almer wrote: > > > On 3/3/2022 10:56 AM, Paul B Mahol wrote: >> On 3/3/22, James Almer wrote: >>> >>> >>> On 3/1/2022 11:23 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/framepool.c | 20 ++-- 1 file changed, 14 insert

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes

2022-03-03 Thread James Almer
On 3/3/2022 1:46 PM, Paul B Mahol wrote: On 3/3/22, James Almer wrote: On 3/3/2022 10:56 AM, Paul B Mahol wrote: On 3/3/22, James Almer wrote: On 3/1/2022 11:23 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/framepool.c | 20 ++-- 1 file cha

[FFmpeg-devel] [PATCH] avfilter/framepool: remove superfluous pallete buffer allocation

2022-03-03 Thread James Almer
av_image_fill_plane_sizes() already sets sizes[1] to AVPALETTE_SIZE. Should fix memory leaks. Signed-off-by: James Almer --- Sorry for not noticing this before. libavfilter/framepool.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool

Re: [FFmpeg-devel] [PATCH] avfilter/framepool: remove superfluous pallete buffer allocation

2022-03-03 Thread Paul B Mahol
On 3/3/22, James Almer wrote: > av_image_fill_plane_sizes() already sets sizes[1] to AVPALETTE_SIZE. > Should fix memory leaks. ok > > Signed-off-by: James Almer > --- > Sorry for not noticing this before. > > libavfilter/framepool.c | 10 -- > 1 file changed, 10 deletions(-) > > diff

[FFmpeg-devel] [PATCH] avfilter: add aspectraldn audio filter

2022-03-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/af_aspectraldn.c | 440 +++ libavfilter/allfilters.c | 1 + 3 files changed, 442 insertions(+) create mode 100644 libavfilter/af_aspectraldn.c diff --git a/libavfilter/Makefil

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Check expacc

2022-03-03 Thread Paul B Mahol
On 11/3/16, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ac3dec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index a95c204..499971a 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c >

Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-03 Thread Paul B Mahol
On 3/2/22, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > tests/Makefile | 1 + > tests/fate-run.sh| 4 > tests/fate/libavfilter.mak | 9 + > tests/ref/fate/libavfilter-negotiation-alpha |

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-03 Thread Nicolas George
Paul B Mahol (12022-03-01): > Signed-off-by: Paul B Mahol > --- > > Fix possible hangs if (a)split filter is used in graph and one of outputs ends > earlier than others. > Then filter may never receive EOF from input provided by (a)split filter. > > See ticket #9152 for commands how to reproduce

Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-03 Thread James Almer
On 3/2/2022 3:40 PM, Nicolas George wrote: diff --git a/tests/fate/libavfilter.mak b/tests/fate/libavfilter.mak new file mode 100644 index 00..692f1d4960 --- /dev/null +++ b/tests/fate/libavfilter.mak @@ -0,0 +1,9 @@ +# avfiltergraph.c : pick_format() : video / don't lose alpha +FATE_LIBA

Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-03 Thread Nicolas George
James Almer (12022-03-03): > No need to add a fate-libavfilter-negotiation target until there are more > such tests. Thanks for the review. I know these targets are not necessary, but I want them. I do intend to write more tests: >> This is not to be the only test, I intend to cover all the logic

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated AVIF image: ffmpeg -i video.mp4 animated.avif We can re-u

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
On Thu, Mar 3, 2022 at 7:36 AM James Almer wrote: > > On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image: > > ffmpeg -i ima

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread James Almer
On 3/3/2022 4:20 PM, Vignesh Venkatasubramanian wrote: On Thu, Mar 3, 2022 at 7:36 AM James Almer wrote: On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specifiation: https://aomediacodec.github.io/av1-avif Sample

Re: [FFmpeg-devel] Too many project ideas in GSOC 2022 FFmpeg

2022-03-03 Thread Paul B Mahol
On 3/1/22, Michael Koch wrote: >> We have 0 project ideas on our gsoc 2022 page >> well we have 2 now as i copied my two from last year >> If you have an idea, please add it! > > Might it be possible to integrate LibRaw into FFmpeg? > https://www.libraw.org/ > > This could also solve the problem t

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
On Thu, Mar 3, 2022 at 11:46 AM James Almer wrote: > > > > On 3/3/2022 4:20 PM, Vignesh Venkatasubramanian wrote: > > On Thu, Mar 3, 2022 at 7:36 AM James Almer wrote: > >> > >> On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: > >>> Add an AVIF muxer by re-using the existing the mov/mp4 mu

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-03 Thread Paul B Mahol
On 3/3/22, Nicolas George wrote: > Paul B Mahol (12022-03-01): >> Signed-off-by: Paul B Mahol >> --- >> >> Fix possible hangs if (a)split filter is used in graph and one of outputs >> ends >> earlier than others. >> Then filter may never receive EOF from input provided by (a)split filter. >> >> S

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-03 Thread Vignesh Venkatasubramanian
Add support for parsing AVIF still images. This patches supports AVIF still images that have exactly 1 item (i.e.) no alpha channel. Essentially, we will have to parse the "iloc" box and populate the mov index. With this patch, we can decode still AVIF images like so: ffmpeg -i image.avif image.pn

Re: [FFmpeg-devel] [PATCH v2] avcodec/ffv1dec: Don't set ThreadFrame properties, fix race

2022-03-03 Thread Michael Niedermayer
On Thu, Mar 03, 2022 at 08:55:08AM +0100, Andreas Rheinhardt wrote: > Each FFV1 slice has its own SAR and picture structure encoded; > when a slice header was parsed, the relevant fields of a ThreadFrame's > AVFrame were directly set based upon the parsed values. This is > a data race in case slice

Re: [FFmpeg-devel] [PATCH 1/5] lavfi/graphdump: add plain listing output

2022-03-03 Thread Andreas Rheinhardt
Nicolas George: > Signed-off-by: Nicolas George > --- > libavfilter/avfilter.h | 5 ++- > libavfilter/graphdump.c | 79 +++-- > 2 files changed, 80 insertions(+), 4 deletions(-) > > > Unchanged since last summer. > The last patch is what this is needed for.

[FFmpeg-devel] [PATCH v3] avcodec/ffv1dec: Don't set ThreadFrame properties, fix race

2022-03-03 Thread Andreas Rheinhardt
Each FFV1 slice has its own SAR and picture structure encoded; when a slice header was parsed, the relevant fields of a ThreadFrame's AVFrame were directly set based upon the parsed values. This is a data race in case slice threading is in use because of the concurrent writes. In case of frame thre