Re: [FFmpeg-devel] [PATCH 8/8] libavfilter: Remove DNNReturnType from DNN Module

2022-03-02 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: Thursday, February 24, 2022 4:23 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Shubhanshu Saxena > Subject: [FFmpeg-devel] [PATCH 8/8] libavfilter: Remove DNNReturnType from > DNN Module > > This patch removes

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-02 Thread Paul B Mahol
It seems it does not work properly. Signed-off-by: Paul B Mahol --- libavcodec/mpegvideo_enc.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index c69114ea15..fb36c8e2d8 100644 --- a/libavcodec

Re: [FFmpeg-devel] Too many project ideas in GSOC 2022 FFmpeg

2022-03-02 Thread Paul B Mahol
On Tue, Mar 1, 2022 at 6:49 PM Marvin Scholz wrote: > > > On 1 Mar 2022, at 9:09, Paul B Mahol wrote: > > > On Tue, Mar 1, 2022 at 8:46 AM Michael Koch > > > wrote: > > > >>> We have 0 project ideas on our gsoc 2022 page > >>> well we have 2 now as i copied my two from last year > >>> If you hav

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Paul B Mahol
On Wed, Mar 2, 2022 at 8:22 AM Andreas Unterweger wrote: > > On 23.02.2022 15:58 Andreas Unterweger wrote: > > > > > > The last encoded frame is now fetched on EOF. It was previously left in > the encoder and caused a "1 frame left in queue" warning. > > > > Signed-off-by: Andreas Unterweger >

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Andreas Unterweger
> On 02.03.2022 12:55 Paul B Mahol wrote: > > > do { > > > -data_written = 0; > > > > why this is removed ? > > > > > if (encode_audio_frame(NULL, output_format_context, > > > output_codec_context, > > &data_w

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Paul B Mahol
On Wed, Mar 2, 2022 at 1:18 PM Andreas Unterweger wrote: > > On 02.03.2022 12:55 Paul B Mahol wrote: > > > > do { > > > > -data_written = 0; > > > > > > > why this is removed ? > > > > > > > > if (encode_audio_frame(NULL, output_format_context, > >

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Andreas Unterweger
> On 02.03.2022 13:27 Paul B Mahol wrote: > > > On Wed, Mar 2, 2022 at 1:18 PM Andreas Unterweger > wrote: > > > > On 02.03.2022 12:55 Paul B Mahol wrote: > > > > > do { > > > > > -data_written = 0; > > > > > > > > > > why this is removed ? > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-02 Thread Michael Niedermayer
On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: > It seems it does not work properly. > > Signed-off-by: Paul B Mahol > --- > libavcodec/mpegvideo_enc.c | 23 +++ > 1 file changed, 3 insertions(+), 20 deletions(-) if iam not mistaken, that requires the whole im

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet

2022-03-02 Thread lance . lmwang
From: Limin Wang Fix below error message when timecode packet is written. "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" try to reproduce by: ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov N

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: use warning log level and small adjustment for the log

2022-03-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/movenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 74b94cd..8b038c1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5638,9 +5638,8 @@ stat

[FFmpeg-devel] [PATCH] avformat/mov: Disallow empty sidx

2022-03-02 Thread Michael Niedermayer
It appears this is not allowed "Each Segment Index box documents how a (sub)segment is divided into one or more subsegments (which may themselves be further subdivided using Segment Index boxes)." Fixes: Null pointer dereference Fixes: Ticket9517 Signed-off-by: Michael Niedermayer --- libavform

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Paul B Mahol
On Wed, Mar 2, 2022 at 1:53 PM Andreas Unterweger wrote: > > On 02.03.2022 13:27 Paul B Mahol wrote: > > > > > > On Wed, Mar 2, 2022 at 1:18 PM Andreas Unterweger > > wrote: > > > > > > On 02.03.2022 12:55 Paul B Mahol wrote: > > > > > > do { > > > > > > -data_wri

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow empty sidx

2022-03-02 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists

2022-03-02 Thread Nicolas George
It has been deprecated for nine years. Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) I want to share the delimiter-seeking function with vf_format and add support for '/'. diff --git a/libavfilter/af_aformat.c b/l

Re: [FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists

2022-03-02 Thread James Almer
On 3/2/2022 1:04 PM, Nicolas George wrote: It has been deprecated for nine years. We need to make sure to add FF_API_ defines when we introduce this kind of deprecation in the future, as it forces people to at least look at them at every major bump. Nine years is definitely overkill. Sign

Re: [FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists

2022-03-02 Thread Nicolas George
James Almer (12022-03-02): > We need to make sure to add FF_API_ defines when we introduce this kind of > deprecation in the future, as it forces people to at least look at them at > every major bump. Nine years is definitely overkill. That makes sense. I will try to remember it when reviewing in

[FFmpeg-devel] [PATCH 1/2] lavfi/(a)format: factor finding the delimiter

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 8 +--- libavfilter/internal.h | 9 + libavfilter/vf_format.c | 9 - 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c index d2599431dc..0cdea2220f

[FFmpeg-devel] [PATCH 2/2] lavfi/(a)format: support slash as a delimiter

2022-03-02 Thread Nicolas George
Unlike pipe, slash does not require escaping. Signed-off-by: Nicolas George --- doc/filters.texi | 8 libavfilter/internal.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Especially in makefiles, escaping is annoying. diff --git a/doc/filters.texi b/doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avformat/mov: Disallow empty sidx

2022-03-02 Thread Michael Niedermayer
On Wed, Mar 02, 2022 at 03:10:02PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiran

[FFmpeg-devel] [PATCH V2 1/8] libavfilter: Prepare to handle specific error codes in DNN Filters

2022-03-02 Thread Shubhanshu Saxena
This commit prepares the filter side to handle specific error codes from the DNN backends instead of current DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn_filter_common.c | 10 +- libavfilter/dnn_filter_common.h | 10 +- libavfilter/vf_derain.c | 4 ++--

[FFmpeg-devel] [PATCH V2 2/8] lavfi/dnn: Error Specificity in Native Backend Layers

2022-03-02 Thread Shubhanshu Saxena
This commit returns specific error codes from the execution functions in the Native Backend layers instead of DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native_layer_avgpool.c | 6 +++--- libavfilter/dnn/dnn_backend_native_layer_avgpool.h | 3 ++- libavfilter/d

[FFmpeg-devel] [PATCH V2 3/8] lavfi/dnn_io_proc: Return Specific Error Codes

2022-03-02 Thread Shubhanshu Saxena
This commit returns specific error codes from the functions in the dnn_io_proc instead of DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_io_proc.c | 48 +++ libavfilter/dnn/dnn_io_proc.h | 8 +++--- 2 files changed, 30 insertions(+), 26 delet

[FFmpeg-devel] [PATCH V2 4/8] lavfi/dnn_backend_openvino: Return Specific Error Codes

2022-03-02 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. For OpenVINO API errors, currently DNN_GENERIC_ERROR is returned. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_openvino.c | 138 +++-- libavfilter/dnn/dnn_backend_o

[FFmpeg-devel] [PATCH V2 5/8] lavfi/dnn_backend_tf: Return Specific Error Codes

2022-03-02 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. For TensorFlow C API errors, currently DNN_GENERIC_ERROR is returned. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 148 +-- libavfilter/dnn/dnn_backe

[FFmpeg-devel] [PATCH V2 6/8] lavfi/dnn_backend_native: Return Specific Error Codes

2022-03-02 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 82 +++- libavfilter/dnn/dnn_backend_native.h | 4 +- 2 files changed, 45 insertions(+), 41 deletions(-

[FFmpeg-devel] [PATCH V2 7/8] lavfi/dnn_backend_common: Return specific error codes

2022-03-02 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered in the common DNN backend functions. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 35 ++-- libavfilter/dnn/dnn_backend_common.h | 22 +++--

[FFmpeg-devel] [PATCH V2 8/8] libavfilter: Remove DNNReturnType from DNN Module

2022-03-02 Thread Shubhanshu Saxena
This patch removes all occurences of DNNReturnType from the DNN module. This commit replaces DNN_SUCCESS by 0 (essentially the same), so the functions with DNNReturnType now return 0 in case of success, the negative values otherwise. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backe

[FFmpeg-devel] [PATCH 2/5] fftools: add -lavfi_dump option

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 4 fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 14 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 22 insertions(+) Unchanged since last summer. diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi ind

[FFmpeg-devel] [PATCH 1/5] lavfi/graphdump: add plain listing output

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.h | 5 ++- libavfilter/graphdump.c | 79 +++-- 2 files changed, 80 insertions(+), 4 deletions(-) Unchanged since last summer. The last patch is what this is needed for. diff --git a/libavfilter/avfilt

[FFmpeg-devel] [PATCH 3/5] lavfi/(a)format: factor finding the delimiter

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 8 +--- libavfilter/internal.h | 9 + libavfilter/vf_format.c | 9 - 3 files changed, 18 insertions(+), 8 deletions(-) Same as sent earlier today. diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat

[FFmpeg-devel] [PATCH 4/5] lavfi/(a)format: support slash as a delimiter

2022-03-02 Thread Nicolas George
Unlike pipe, slash does not require escaping. Signed-off-by: Nicolas George --- doc/filters.texi | 8 libavfilter/internal.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Same as sent earlier today. diff --git a/doc/filters.texi b/doc/filters.texi index 8cba7f744d..

[FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- tests/Makefile | 1 + tests/fate-run.sh| 4 tests/fate/libavfilter.mak | 9 + tests/ref/fate/libavfilter-negotiation-alpha | 20 4 files changed, 34 i

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-02 Thread Paul B Mahol
On 3/2/22, Michael Niedermayer wrote: > On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: >> It seems it does not work properly. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/mpegvideo_enc.c | 23 +++ >> 1 file changed, 3 insertions(+), 20 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-02 Thread Michael Niedermayer
On Wed, Mar 02, 2022 at 08:11:18PM +0100, Paul B Mahol wrote: > On 3/2/22, Michael Niedermayer wrote: > > On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: > >> It seems it does not work properly. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/mpegvideo_enc.c | 23 +++

Re: [FFmpeg-devel] [PATCH] avformat/avisynth: fix fallbacks for four frameprops

2022-03-02 Thread Stephen Hutchinson
On 2/27/22 3:03 PM, Stephen Hutchinson wrote: If _FieldBased, _Matrix, _ColorRange, or _ChromaLocation haven't been set, that absence would be interpreted as 0, leading to those being set to case 0 instead of default. There is no case 0 for _Primaries and _Transfer, so those were correctly fallin

Re: [FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread James Almer
On 2/17/2022 2:51 AM, Vignesh Venkatasubramanian wrote: Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4 +++- liba

Re: [FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread Vignesh Venkatasubramanian
On Wed, Mar 2, 2022 at 2:57 PM James Almer wrote: > > On 2/17/2022 2:51 AM, Vignesh Venkatasubramanian wrote: > > Add a parameter to omit seq header when generating the av1C atom. > > > > For now, this does not change any behavior. This will be used by a > > follow-up patch to add AVIF support. >

Re: [FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread James Almer
On 3/2/2022 8:23 PM, Vignesh Venkatasubramanian wrote: On Wed, Mar 2, 2022 at 2:57 PM James Almer wrote: On 2/17/2022 2:51 AM, Vignesh Venkatasubramanian wrote: Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove direct=1 support

2022-03-02 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Mar 02, 2022 at 08:11:18PM +0100, Paul B Mahol wrote: >> On 3/2/22, Michael Niedermayer wrote: >>> On Wed, Mar 02, 2022 at 12:38:05PM +0100, Paul B Mahol wrote: It seems it does not work properly. Signed-off-by: Paul B Mahol --- libavcodec/

[FFmpeg-devel] [PATCH] Use proper header for OpenBSD PPC CPU detection

2022-03-02 Thread Brad Smith
Use the proper header for PPC CPU detection code. sys/param.h includes sys/types, but sys/types.h is the more appropriate header to be used here. diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index b022149fa0..96b491c716 100644 --- a/libavutil/ppc/cpu.c +++ b/libavutil/ppc/cpu.c @@ -28,7

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet

2022-03-02 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Fix below error message when timecode packet is written. > "Application provided duration: -9223372036854775808 / timestamp: > -9223372036854775808 is out of range for mov/mp4 format" > > try to reproduce by: > ffmpeg -y -f lavfi -i color -metadata

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet

2022-03-02 Thread lance . lmwang
On Thu, Mar 03, 2022 at 02:55:23AM +0100, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Fix below error message when timecode packet is written. > > "Application provided duration: -9223372036854775808 / timestamp: > > -9223372036854775808 is out of range for m

[FFmpeg-devel] [PATCH v2] avcodec/ffv1dec: Don't set ThreadFrame properties, fix race

2022-03-02 Thread Andreas Rheinhardt
Each FFV1 slice has its own SAR and picture structure encoded; when a slice header was parsed, the relevant fields of a ThreadFrame's AVFrame were directly set based upon the parsed values. This is a data race in case slice threading is in use because of the concurrent writes. In case of frame thre