[FFmpeg-devel] [PATCH 1/8] libavfilter: Prepare to handle specific error codes in DNN Filters

2022-02-24 Thread Shubhanshu Saxena
This commit prepares the filter side to handle specific error codes from the DNN backends instead of current DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn_filter_common.c | 10 +- libavfilter/dnn_filter_common.h | 10 +- libavfilter/vf_derain.c | 4 ++--

[FFmpeg-devel] [PATCH 2/8] lavfi/dnn: Error Specificity in Native Backend Layers

2022-02-24 Thread Shubhanshu Saxena
This commit returns specific error codes from the execution functions in the Native Backend layers instead of DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native_layer_avgpool.c | 6 +++--- libavfilter/dnn/dnn_backend_native_layer_avgpool.h | 3 ++- libavfilter/d

[FFmpeg-devel] [PATCH 3/8] lavfi/dnn_io_proc: Return Specific Error Codes

2022-02-24 Thread Shubhanshu Saxena
This commit returns specific error codes from the functions in the dnn_io_proc instead of DNN_ERROR. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_io_proc.c | 48 +++ libavfilter/dnn/dnn_io_proc.h | 8 +++--- 2 files changed, 30 insertions(+), 26 delet

[FFmpeg-devel] [PATCH 4/8] lavfi/dnn_backend_openvino: Return Specific Error Codes

2022-02-24 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. For OpenVINO API errors, currently DNN_GENERIC_ERROR is returned. --- libavfilter/dnn/dnn_backend_openvino.c | 138 +++-- libavfilter/dnn/dnn_backend_openvino.h | 4 +- libavfilter/dnn

[FFmpeg-devel] [PATCH 5/8] lavfi/dnn_backend_tf: Return Specific Error Codes

2022-02-24 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. For TensorFlow C API errors, currently DNN_GENERIC_ERROR is returned. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 147 +-- libavfilter/dnn/dnn_backe

[FFmpeg-devel] [PATCH 6/8] lavfi/dnn_backend_native: Return Specific Error Codes

2022-02-24 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 82 +++- libavfilter/dnn/dnn_backend_native.h | 4 +- 2 files changed, 45 insertions(+), 41 deletions(-

[FFmpeg-devel] [PATCH 7/8] lavfi/dnn_backend_common: Return specific error codes

2022-02-24 Thread Shubhanshu Saxena
Switch to returning specific error codes or DNN_GENERIC_ERROR when an error is encountered in the common DNN backend functions. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 35 ++-- libavfilter/dnn/dnn_backend_common.h | 22 +++--

[FFmpeg-devel] [PATCH 8/8] libavfilter: Remove DNNReturnType from DNN Module

2022-02-24 Thread Shubhanshu Saxena
This patch removes all occurences of DNNReturnType from the DNN module. This commit replaces DNN_SUCCESS by 0 (essentially the same), so the functions with DNNReturnType now return 0 in case of success, the negative values otherwise. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backe

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/libopenjpegenc: Don't clone AVFrame unnecessarily

2022-02-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libopenjpegenc.c | 83 +++-- > 1 file changed, 42 insertions(+), 41 deletions(-) > > diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c > index 3e52bcd4e9..08b7b6a152 10

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Avoid copying data when flipping image

2022-02-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h263dec.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c > index e940b7f7c7..423036e97b 100644 > --- a/libavcodec/h263dec.c > +++ b/lib

[FFmpeg-devel] [PATCH] Re-enable support for libva v1

2022-02-24 Thread Ingo Brückl
FFmpeg 4.4.1 still supported libva v1, FFmpeg 5.0 does not do that anymore. If dropping support for libva v1 wasn't an intentional decision, it's easy to re-enable it. Ingo >From f8cc63a789eabd8b7381e94767dff850977d0971 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ingo=20Br=C3=BCckl?= Date: Thu, 24

[FFmpeg-devel] HEVC open GOP support in MOV/MP4 (v2)

2022-02-24 Thread Clément Bœsch
The main patch is now less intrusive by having the index building related lists (sample_offsets and open_key_samples) and variable (min_sample_duration) computed in the same place. This is a better segmentation between pure parsing and the index logic. The patch should be easier to understand too.

[FFmpeg-devel] [PATCH v2 1/5] avformat/mov: prepare sbgp parsing for other grouping types

2022-02-24 Thread Clément Bœsch
--- libavformat/mov.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5e26267810..aade052b7a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3137,6 +3137,8 @@ static int mov_read_sbgp(MOVCon

[FFmpeg-devel] [PATCH v2 2/5] avformat/mov: add support for sync group in sbgp box

2022-02-24 Thread Clément Bœsch
--- libavformat/isom.h | 2 ++ libavformat/mov.c | 5 + 2 files changed, 7 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index 625dea8421..e326f4f27f 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -218,6 +218,8 @@ typedef struct MOVStreamContext { int s

[FFmpeg-devel] [PATCH v2 3/5] avformat/mov: add parsing for the sgpd sync box

2022-02-24 Thread Clément Bœsch
sgpd means Sample Group Description Box. For now, only the sync grouping type is parsed, but the function can easily be adjusted to support other flavours. The sbgp (Sample to Group Box) sync_group table built in previous commit contains references to this table through the group_description_inde

[FFmpeg-devel] [PATCH v2 4/5] avformat/mov: fix seeking with HEVC open GOP files

2022-02-24 Thread Clément Bœsch
This was tested with medias recorded from an iPhone XR and an iPhone 13. Here is how a typical stream looks like in coding order: ┌┬─┬─┬──┐ │ sample | PTS | DTS | keyframe | ├┼─┼─┼──┤ ┊┊ ┊ ┊ ┊ │ 53 │

[FFmpeg-devel] [PATCH v2 5/5] avformat/mov: reindent after previous commit

2022-02-24 Thread Clément Bœsch
--- libavformat/mov.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 573ee8bda3..86b0651697 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8573,12 +8573,12 @@ static int mov_seek_stream(AVFormatContext *s, AV

Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

2022-02-24 Thread Thilo Borgmann
Am 16.02.22 um 02:49 schrieb J. Dekker: This script generates the current general assembly voters according to the criteria of '20 commits in the last 36 months'. Signed-off-by: J. Dekker --- doc/dev_community/community.md | 3 +++ tools/general_assembly.pl | 40 +++

[FFmpeg-devel] [PATCH] libavcodec, libavdevice: Remove unnecessary includes of version.h

2022-02-24 Thread Martin Storsjö
xvmc.h used FF_API_* macros before, but they were removed in 1c63aed232febf4404659bf006237ee4f7f17c9c, leaving the include unused. The ones in android_camera.c and mediacodec_wrapper.c have been added due to a misunderstanding, fixed in c0bce367e4932f0fb09195e6978ac1a5a60480a4 and 13b77af2f0b56d6c

Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

2022-02-24 Thread Nicolas George
Thilo Borgman (12022-02-24): > Both LGTM. Does it? The way I remember it, this condition was for the initial assembly, as a temporary measure. I might have missed some steps, but I do not remember we adopted this as a constant rule. I see several flaws with it: - Documentation patches were not

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/libopenjpegenc: Don't clone AVFrame unnecessarily

2022-02-24 Thread Michael Bradshaw
On Thu, Feb 24, 2022 at 2:44 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Will apply this tomorrow unless there are objections. > No objections from me. Thanks for the improvement! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH] libavcodec, libavdevice: Remove unnecessary includes of version.h

2022-02-24 Thread Andreas Rheinhardt
Martin Storsjö: > xvmc.h used FF_API_* macros before, but they were removed in > 1c63aed232febf4404659bf006237ee4f7f17c9c, leaving the include > unused. > > The ones in android_camera.c and mediacodec_wrapper.c have been > added due to a misunderstanding, fixed in > c0bce367e4932f0fb09195e6978ac1a

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-24 Thread Vignesh Venkatasubramanian
On Tue, Feb 22, 2022 at 1:43 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > > Sa

Re: [FFmpeg-devel] [PATCH] lavu: add VKAPI hwcontext implementation

2022-02-24 Thread Dennis Mungai
On Wed, 17 Mar 2021 at 00:14, Suji Velupillai wrote: > Thank you Mark for your feedback. Please see inline > > On Fri, Mar 12, 2021 at 1:14 PM Mark Thompson wrote: > > > On 11/03/2021 22:09, suji.velupil...@broadcom.com wrote: > > > From: Suji Velupillai > > > > > > Initial commit to add VKAPI

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Thu Feb 24 > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9db2] | > committer: Paul B Mahol > > avfilter/vf_tpad: if there is no frame to clone return early > > > > http://git.videolan.or

Re: [FFmpeg-devel] [PATCH 13/13] configure: Use a separate config_components.h header for $ALL_COMPONENTS

2022-02-24 Thread Michael Niedermayer
On Wed, Feb 23, 2022 at 04:29:51PM +0200, Martin Storsjö wrote: > This avoids unnecessary rebuilds of most source files if only the > list of enabled components has changed, but not the other properties > of the build, set in config.h. > --- > configure | 17 ++

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Paul B Mahol
On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol wrote: > > > ffmpeg | branch: master | Paul B Mahol | Thu Feb 24 > > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9db2] | > > committer: Paul B Mahol > > > > avfilter/vf_tpad: if t

Re: [FFmpeg-devel] [PATCH 13/13] configure: Use a separate config_components.h header for $ALL_COMPONENTS

2022-02-24 Thread Martin Storsjö
On Thu, 24 Feb 2022, Michael Niedermayer wrote: On Wed, Feb 23, 2022 at 04:29:51PM +0200, Martin Storsjö wrote: This avoids unnecessary rebuilds of most source files if only the list of enabled components has changed, but not the other properties of the build, set in config.h. --- configure

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol wrote: > > > > > ffmpeg | branch: master | Paul B Mahol | Thu Feb 24 > > > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Paul B Mahol
On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > > > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol > wrote: > > > > > > > ffmpeg | branch: master | Paul B Mahol | Thu F

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > > > > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu > wrote: > > > > > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: >> >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: >> > >> > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu >> w

Re: [FFmpeg-devel] [PATCH v2] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-24 Thread Michael Niedermayer
On Wed, Feb 23, 2022 at 09:45:53PM +0200, Martin Storsjö wrote: > The range parameters need to be set up before calling > sws_init_context (which selects which fastpaths can be used; > this gets called by sws_getContext); solely passing them via > sws_setColorspaceDetails isn't enough. > > This fi

Re: [FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0

2022-02-24 Thread Hao Chen
Thanks for your advices. This file is used by many projects, including Google. In order to facilitate the merger of the Google community, this file is adopted to the Google coding style. It will be troublesome for us to modify and maintain it, if the community is very concerned about this co

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Paul B Mahol
On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > > > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > > > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu > wrote: > >> > >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mah

[FFmpeg-devel] [PATCH] libavcodec, libavformat: Added DFPWM1a codec and raw format

2022-02-24 Thread Jack Bruienne
From the wiki page (https://wiki.vexatos.com/dfpwm): DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec created by Ben “GreaseMonkey” Russell in 2012, originally to be used as a voice codec for asiekierka's pixmess, a C remake of 64pixels. It is a 1-bit-per-sample codec which uses a