On Tue, Feb 22, 2022 at 8:50 AM Jiasheng Jiang wrote:
> As the potential failure of the memory allocation, the ff_get_extradata()
> could return error if fails.
> Therefore, it should be better to deal with the return value of the
> ff_get_extradata() and return error if fails.
>
Not really nec
On Tue, Feb 22, 2022 at 6:25 AM Lynne wrote:
> 19 Feb 2022, 14:58 by niva...@gmail.com:
>
> > By ffmpeg threading support implementation via frame slicing and doing
> > zimg_filter_graph_build that used to take 30-60% of each frame processig
> > only if necessary (some parameters changed)
> > the
On Tue, Feb 22, 2022 at 9:15 AM Paul B Mahol wrote:
>
>
> On Tue, Feb 22, 2022 at 6:25 AM Lynne wrote:
>
>> 19 Feb 2022, 14:58 by niva...@gmail.com:
>>
>> > By ffmpeg threading support implementation via frame slicing and doing
>> > zimg_filter_graph_build that used to take 30-60% of each frame
On Tue, 2022-02-22 at 05:46 +, Xiang, Haihao wrote:
> On Mon, 2022-02-21 at 12:06 +, Mark Thompson wrote:
> > On 21/02/2022 02:13, Fei Wang wrote:
> > > From: Linjie Fu
> > >
> > > Use GPB frames to replace regular P frames if backend driver does
> > > not
> > > support it.
> > >
> > > -
On Tue, Feb 22, 2022 at 04:10:51PM +0800, Paul B Mahol wrote:
>> As the potential failure of the memory allocation, the ff_get_extradata()
>> could return error if fails.
>> Therefore, it should be better to deal with the return value of the
>> ff_get_extradata() and return error if fails.
>>
>
>
On Tue, Feb 22, 2022 at 10:14 AM Jiasheng Jiang
wrote:
> On Tue, Feb 22, 2022 at 04:10:51PM +0800, Paul B Mahol wrote:
>
> >> As the potential failure of the memory allocation, the
> ff_get_extradata()
> >> could return error if fails.
> >> Therefore, it should be better to deal with the return v
Paul, I've got exactly the same feelings on zing threading usage myself and
decided to go along the standard ffmpeg threading route.
It looks more consistent here.
Megathanks for reviewing my patch, I've fixed everything you've mentioned
and even more.
On Tue, Feb 22, 2022 at 11:15 AM Paul B Mahol
22 Feb 2022, 07:27 by jianhua.wu-at-intel@ffmpeg.org:
> Lynne:
>
>> Sent: Tuesday, February 22, 2022 1:38 PM
>> To: FFmpeg development discussions and patches > de...@ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV
>> option
>>
>> 18 Feb 2022, 16:24 by
Lynne:
> Sent: Tuesday, February 22, 2022 5:36 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_gblur_vulkan: add sizeV
> option
>
> 22 Feb 2022, 07:27 by jianhua.wu-at-intel@ffmpeg.org:
>
> > Lynne:
> >
> >> Sent: Tue
On Tue, Feb 22, 2022 at 9:55 AM Marton Balint wrote:
>
>
>
> On Mon, 21 Feb 2022, Eran Kornblau wrote:
>
> >>
> >> On Mon, Feb 21, 2022 at 5:07 PM Eran Kornblau
> >> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> We've recently upgraded our ffmpeg version, and we got a playback issue
> >>> on some Sony
Am 15.02.22 um 09:54 schrieb Anton Khirnov:
Quoting Thilo Borgmann (2022-02-12 11:55:39)
Am 31.01.22 um 12:55 schrieb James Almer:
+static int config_input(AVFilterLink *inlink)
+{
+// Video input data avilable
+AVFilterContext *ctx = inlink->dst;
+SiTiContext *s = ctx->priv;
+in
Am 18.02.22 um 17:08 schrieb Paul B Mahol:
On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann
wrote:
Am 31.01.22 um 12:55 schrieb James Almer:
On 1/31/2022 8:53 AM, Anton Khirnov wrote:
Quoting Thilo Borgmann (2022-01-18 14:58:07)
Violations of code style.
Enhanced.
Not enough. There are
Am 08.02.22 um 11:41 schrieb Thilo Borgmann:
Am 08.02.22 um 10:27 schrieb Andreas Rheinhardt:
Thilo Borgmann:
Am 01.02.22 um 00:40 schrieb Andreas Rheinhardt:
Thilo Borgmann:
Am 31.01.22 um 14:08 schrieb Nicolas George:
Thilo Borgman (12022-01-31):
v10 attached.
Also going to apply soon i
Am 19.02.22 um 09:45 schrieb "zhilizhao(赵志立)":
On Feb 8, 2022, at 9:05 PM, Andreas Rheinhardt
wrote:
Thilo Borgmann:
Am 08.02.22 um 13:50 schrieb Andreas Rheinhardt:
Thilo Borgmann:
Am 04.02.22 um 17:19 schrieb Zhao Zhili:
---
libavdevice/avfoundation.m | 10 ++
1 file ch
Am 04.02.22 um 17:19 schrieb Zhao Zhili:
---
libavdevice/avfoundation.m | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
Pushed, thanks!
-Thilo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/lis
This patchset adds functions for handling UUIDs to libavutil, under the
av_uuid_*
prefix, and refactors the various ad-hoc handling to use it. This was
proposed in [1].
This is _heavily_ based off libuuid with various parts of the code
simplified to remove unnecessary functionality (e.g. generati
Loosely based on libuuid
Co-authored-by: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 2 +
libavutil/uuid.c | 156 ++
libavutil/uuid.h | 167 +++
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 1 +
libavutil/tests/.gitignore | 1 +
libavutil/tests/uuid.c | 139 +
tests/fate/libavutil.mak | 5 ++
4 files cha
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/mov.c| 25 +
libavformat/movenc.c | 9 +
2 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/smoothstreamingenc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c
index a0ea5b8fa8
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavcodec/cbs_sei.h | 3 ++-
libavcodec/vaapi_encode_h264.c | 8
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavformat/imf.h | 18 -
libavformat/imf_cpl.c | 60 +++--
libavformat/imfdec.c| 34 +++
libavformat/tests/imf.
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavfilter/vf_showinfo.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 71728bced4..395e87c
On Mon, 14 Feb 2022, Andre Kempe wrote:
This patch adds optional support for Arm Pointer Authentication Codes.
PAC support is turned on or off at compile time using additional
compiler flags. Unless any of these is enabled explicitly, no additional
code will be emitted at all.
Signed-off-by: A
On 2/22/2022 10:01 AM, Zane van Iperen wrote:
Loosely based on libuuid
Co-authored-by: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
Signed-off-by: Zane van Iperen
---
libavutil/Makefile | 2 +
libavutil/uuid.c | 156 ++
libavu
On 22/2/22 23:01, Zane van Iperen wrote:
+int av_uuid_urn_parse(const char *in, AVUUID uu)
+{
+return av_uuid_parse(in + 9, uu);
Self-review: this should check if "strlen(in) == 45", then simply
return av_uuid_parse_range(in + 9).
___
ffmpeg-d
On Tue, Feb 22, 2022 at 10:41:51AM +0800, Jiasheng Jiang wrote:
> As the potential failure of the memory allocation,
> the avformat_new_stream() could return NULL pointer.
> Therefore, it should be better to check it and return
> error if fails.
> Also, the caller, nut_read_header(), needs to deal
Signed-off-by: Paul B Mahol
---
libavfilter/af_loudnorm.c | 62 ++-
1 file changed, 48 insertions(+), 14 deletions(-)
diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index dbe7fba986..5b4b6e8548 100644
--- a/libavfilter/af_loudnorm.c
+++ b/l
Signed-off-by: Paul B Mahol
---
libavfilter/af_loudnorm.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index 5b4b6e8548..7c8ac3a39d 100644
--- a/libavfilter/af_loudnorm.c
+++ b/libavfilter/af_lo
It can cause unpleasant artifacts.
Signed-off-by: Paul B Mahol
---
libavfilter/af_loudnorm.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index 7c8ac3a39d..9bb0c65bb7 100644
--- a/libavfilter/af_loudnorm.c
+++ b/li
On 2/14/2022 7:41 PM, James Almer wrote:
Signed-off-by: James Almer
---
Missing doc changes.
libavcodec/setts_bsf.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
Ping for set.
Original patches 2, 3 and 4 are withdrawn, so the set is:
[PATCH 1/6] ffmpeg: f
On Tue, Feb 22, 2022 at 5:50 PM James Almer wrote:
> On 2/14/2022 7:41 PM, James Almer wrote:
> > Signed-off-by: James Almer
> > ---
> > Missing doc changes.
> >
> > libavcodec/setts_bsf.c | 25 -
> > 1 file changed, 24 insertions(+), 1 deletion(-)
>
> Ping for set.
>
On 2/22/2022 3:27 AM, Anton Khirnov wrote:
Also, place the BSF api docs in their own doxygen group.
---
libavcodec/bsf.h | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/libavcodec/bsf.h b/libavcodec/bsf.h
index 8c5355d186..ba8b48f222 100644
--- a/
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263dec.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
index e940b7f7c7..423036e97b 100644
--- a/libavcodec/h263dec.c
+++ b/libavcodec/h263dec.c
@@ -703,17 +703,11 @
Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
AVIF Specifiation: https://aomediacodec.github.io/av1-avif
Sample usage for still image:
ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
Sample usage for animated AVIF image:
ffmpeg -i video.mp4 animated.avif
We can re-u
On 2/22/2022 3:40 PM, Vignesh Venkatasubramanian wrote:
Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
AVIF Specifiation: https://aomediacodec.github.io/av1-avif
Sample usage for still image:
ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
Sample usage for animat
Add a parameter to libaom-av1 encoder to enforce some of the single
image constraints in the AV1 encoder. Setting this flag will limit
the encoder to producing exactly one frame and the sequence header
that is produced by the encoder will be conformant to the AVIF
specification [1].
Part of Fixing
Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
AVIF Specifiation: https://aomediacodec.github.io/av1-avif
Sample usage for still image:
ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
Sample usage for animated AVIF image:
ffmpeg -i video.mp4 animated.avif
We can re-u
On Tue, Feb 22, 2022 at 12:03 PM James Almer wrote:
>
>
> On 2/22/2022 3:40 PM, Vignesh Venkatasubramanian wrote:
> > Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
> >
> > AVIF Specifiation: https://aomediacodec.github.io/av1-avif
> >
> > Sample usage for still image:
> > ffmpeg -
Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
AVIF Specifiation: https://aomediacodec.github.io/av1-avif
Sample usage for still image:
ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
Sample usage for animated AVIF image:
ffmpeg -i video.mp4 animated.avif
We can re-u
Andreas Rheinhardt:
> This is a prerequisite to continue using the decoder at all
> to decode the next interval (if any).
> This fixes a regression introduced in commit
> 2a88ebd096f3c748a2d99ed1b60b22879b3c567c and reported in ticket #8657.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> I wonder
It is unnecessary and unchecked; the intention seems to be to ensure
that the frame's data is writable, but it does not provide this.
This will be fixed in a latter commit.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/magicyuvenc.c | 26 --
1 file changed, 12 insertio
Signed-off-by: Andreas Rheinhardt
---
libavcodec/magicyuvenc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c
index 4440ab3ce2..ffb0be1d14 100644
--- a/libavcodec/magicyuvenc.c
+++ b/libavcodec/magicyuvenc.c
@@ -69,1
It need not be writable at all. Instead, use temporary buffers
for decorrelation.
Signed-off-by: Andreas Rheinhardt
---
The prediction functions could be rewritten to allow src and dst
to alias each other; yet LLVidEncDSPContext.diff_bytes has the
requirement that dst has an alignment of 16.
li
Signed-off-by: Andreas Rheinhardt
---
libavcodec/libopenjpegenc.c | 83 +++--
1 file changed, 42 insertions(+), 41 deletions(-)
diff --git a/libavcodec/libopenjpegenc.c b/libavcodec/libopenjpegenc.c
index 3e52bcd4e9..08b7b6a152 100644
--- a/libavcodec/libopenjpege
Signed-off-by: Andreas Rheinhardt
---
libavcodec/magicyuvenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c
index 5a37a49d63..7fb7578327 100644
--- a/libavcodec/magicyuvenc.c
+++ b/libavcodec/magicyuvenc.c
@@ -58,7 +58,6 @@ typedef struct
Fixes: Timeout
Fixes:
44829/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DSICINVIDEO_fuzzer-6190334340628480
Signed-off-by: Michael Niedermayer
---
tools/target_dec_fuzzer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
index 1376
Michael Niedermayer:
>> diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
>> index 0a8a700acf..32a4f6bbcb 100644
>> --- a/libavformat/nutdec.c
>> +++ b/libavformat/nutdec.c
>> @@ -351,8 +351,13 @@ static int decode_main_header(NUTContext *nut)
>> ret = AVERROR(ENOMEM);
>> g
As the potential failure of the memory allocation,
the avformat_new_stream() could return NULL pointer.
Therefore, it should be better to check it and return
error if fails.
Also, the caller, nut_read_header(), needs to deal with
the return value of the decode_main_header() and return
error if memo
22 Feb 2022, 14:01 by z...@zanevaniperen.com:
> Loosely based on libuuid
>
> Co-authored-by: Pierre-Anthony Lemieux
> Signed-off-by: Pierre-Anthony Lemieux
> Signed-off-by: Zane van Iperen
> ---
> +int av_uuid_parse(const char *in, AVUUID uu)
> +{
> +size_t len = strlen(in);
> +if (len
On 23/2/22 16:01, Lynne wrote:
Code style
Mostly fixed, do these changes look right?
https://github.com/vs49688/FFmpeg/commit/867fffe04ffedf0609260557d1db0ebbc519c4d2
Why the double header in the header file? It doesn't contain
any libuuid code.
It does, this was copy/pasted from libu
On 23/2/22 00:21, James Almer wrote:
+int av_uuid_equal(const AVUUID uu1, const AVUUID uu2)
+{
+ return memcmp(uu1, uu2, AV_UUID_LEN) == 0;
+}
+
+void av_uuid_copy(AVUUID dest, const AVUUID src)
+{
+ memcpy(dest, src, AV_UUID_LEN);
+}
+
+void av_uuid_nil_set(AVUUID uu)
+{
+ memset(uu,
On 23/2/22 16:48, Zane van Iperen wrote:
On 23/2/22 16:01, Lynne wrote:
Code style
Mostly fixed, do these changes look right?
https://github.com/vs49688/FFmpeg/commit/867fffe04ffedf0609260557d1db0ebbc519c4d2
Uhh, wrong one:
https://github.com/vs49688/FFmpeg/commit/58af67b9bee0b9b235b8
Quoting Andreas Rheinhardt (2022-02-02 03:13:12)
> Who sets invalid media types?
> (In case of fftools/*: If they don't set it themselves, they (and all
> our users) should be able to rely on our libraries to not set invalid
> values. The same goes for all demuxers (as they set this value
> themsel
54 matches
Mail list logo
