Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-02-15 Thread Anton Khirnov
Quoting Thilo Borgmann (2022-02-12 11:55:39) > Am 31.01.22 um 12:55 schrieb James Almer: > +static int config_input(AVFilterLink *inlink) > +{ > +// Video input data avilable > +AVFilterContext *ctx = inlink->dst; > +SiTiContext *s = ctx->priv; > +int max_pixsteps[4]; > +size_t

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-02-15 Thread Paul B Mahol
On Tue, Feb 15, 2022 at 9:55 AM Anton Khirnov wrote: > Quoting Thilo Borgmann (2022-02-12 11:55:39) > > Am 31.01.22 um 12:55 schrieb James Almer: > > +static int config_input(AVFilterLink *inlink) > > +{ > > +// Video input data avilable > > +AVFilterContext *ctx = inlink->dst; > > +S

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-02-15 Thread Anton Khirnov
Quoting Paul B Mahol (2022-02-15 10:10:17) > On Tue, Feb 15, 2022 at 9:55 AM Anton Khirnov wrote: > > > Quoting Thilo Borgmann (2022-02-12 11:55:39) > > > Am 31.01.22 um 12:55 schrieb James Almer: > > > +static int config_input(AVFilterLink *inlink) > > > +{ > > > +// Video input data avilabl

[FFmpeg-devel] [PATCH] avcodec/avcodec: Remove MpegEncContext forward declaration

2022-02-15 Thread Andreas Rheinhardt
Forgotten in be95df12bb06b183c8d2aea3b0831fdf05466cf3. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5362446092..79af8dcc05 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcod

[FFmpeg-devel] [PATCH] avcodec/error_resilience: Remove unused label

2022-02-15 Thread Andreas Rheinhardt
Forgotten in be95df12bb06b183c8d2aea3b0831fdf05466cf3. Signed-off-by: Andreas Rheinhardt --- libavcodec/error_resilience.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c index 91b7b277a3..e9764f8d96 100644 --- a/libavcodec/error_r

[FFmpeg-devel] [PATCH] avcodec/vp3: Add missing check for av_malloc

2022-02-15 Thread Jiasheng Jiang
Since the av_malloc() may fail and return NULL pointer, it is needed that the 's->edge_emu_buffer' should be checked whether the new allocation is success. Fixes: d14723861b ("VP3: fix decoding of videos with stride > 2048") Signed-off-by: Jiasheng Jiang --- libavcodec/vp3.c | 7 ++- 1 file

[FFmpeg-devel] [PATCH] swscale/utils: Add missing check for av_malloc

2022-02-15 Thread Jiasheng Jiang
As the potential failure of the memory allocation, the return value of the av_malloc() could be NULL and be dereferenced on. Therefore it should be better to check it and return error if fails. Also, the callers of the ff_shuffle_filter_coefficients() should deal with the return value. Fixes: f900

[FFmpeg-devel] [PATCH] avcodec/mlz: Add the check after calling av_mallocz

2022-02-15 Thread Jiasheng Jiang
Since the potential failure of memory allocation, the av_mallocz() may return NULL pointer if fails, which is assigned to 'mlz->dict'. And then 'mlz->dict' will be used in ff_mlz_flush_dict(). Therefore, it should be better to check it and return error if fails in order to prevent the dereference o

Re: [FFmpeg-devel] [PATCH] avcodec/mlz: Add the check after calling av_mallocz

2022-02-15 Thread Andreas Rheinhardt
Jiasheng Jiang: > Since the potential failure of memory allocation, the av_mallocz() > may return NULL pointer if fails, which is assigned to 'mlz->dict'. > And then 'mlz->dict' will be used in ff_mlz_flush_dict(). > Therefore, it should be better to check it and return error if fails > in order to

Re: [FFmpeg-devel] [PATCH 4/6] ffmpeg: don't skip packets before a keyframe was seen if a bsf with delay is used

2022-02-15 Thread Anton Khirnov
Quoting James Almer (2022-02-14 23:41:54) > A keyframe could be buffered in the bsf and not be output until more packets > had been fed to it. > > Signed-off-by: James Almer > --- > fftools/ffmpeg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg.c b/ff

Re: [FFmpeg-devel] [PATCH 4/6] ffmpeg: don't skip packets before a keyframe was seen if a bsf with delay is used

2022-02-15 Thread James Almer
On 2/15/2022 8:41 AM, Anton Khirnov wrote: Quoting James Almer (2022-02-14 23:41:54) A keyframe could be buffered in the bsf and not be output until more packets had been fed to it. Signed-off-by: James Almer --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API

2022-02-15 Thread Anton Khirnov
Quoting James Almer (2022-01-13 03:09:07) > diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c > index ed3c75311a..96704e041c 100644 > --- a/libavfilter/af_aformat.c > +++ b/libavfilter/af_aformat.c > @@ -104,9 +104,36 @@ static av_cold int init(AVFilterContext *ctx) >

[FFmpeg-devel] [PATCH] tools: add general_assembly.pl

2022-02-15 Thread J. Dekker
This script generates the current general assembly voters according to the criteria of '20 code commits in the last 36 months'. Signed-off-by: J. Dekker --- This was rejected last time but I would really like to get this in the tools or at least publicly recorded on mailing list since the scri

Re: [FFmpeg-devel] [PATCH 4/6] ffmpeg: don't skip packets before a keyframe was seen if a bsf with delay is used

2022-02-15 Thread Anton Khirnov
Quoting James Almer (2022-02-15 12:48:09) > > > On 2/15/2022 8:41 AM, Anton Khirnov wrote: > > Quoting James Almer (2022-02-14 23:41:54) > >> A keyframe could be buffered in the bsf and not be output until more > >> packets > >> had been fed to it. > >> > >> Signed-off-by: James Almer > >> ---

Re: [FFmpeg-devel] [PATCH 4/6] ffmpeg: don't skip packets before a keyframe was seen if a bsf with delay is used

2022-02-15 Thread James Almer
On 2/15/2022 9:03 AM, Anton Khirnov wrote: Quoting James Almer (2022-02-15 12:48:09) On 2/15/2022 8:41 AM, Anton Khirnov wrote: Quoting James Almer (2022-02-14 23:41:54) A keyframe could be buffered in the bsf and not be output until more packets had been fed to it. Signed-off-by: James Alm

Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API

2022-02-15 Thread James Almer
On 2/15/2022 8:50 AM, Anton Khirnov wrote: Quoting James Almer (2022-01-13 03:09:07) @@ -212,31 +212,31 @@ static int config_input(AVFilterLink *inlink) return AVERROR(ENOMEM); for (ch = 0; ch < s->nb_in_channels; ch++) s->input_levels[ch] = s->level_in; -ch = av_g

Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API

2022-02-15 Thread Anton Khirnov
Quoting James Almer (2022-02-15 13:27:37) > On 2/15/2022 8:50 AM, Anton Khirnov wrote: > > Quoting James Almer (2022-01-13 03:09:07) > >> @@ -212,31 +212,31 @@ static int config_input(AVFilterLink *inlink) > >> return AVERROR(ENOMEM); > >> for (ch = 0; ch < s->nb_in_channels; ch++)

[FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum

2022-02-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/argo_cvg.c | 15 +-- libavformat/version.h | 2 +- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c index c5da32536d..dfdf126c17 100644 --- a/libavformat/argo_cvg.c +++

Re: [FFmpeg-devel] [PATCH 4/4] avformat: add Argonaut Games CVG muxer

2022-02-15 Thread Michael Niedermayer
On Tue, Feb 15, 2022 at 10:09:50AM +1000, Zane van Iperen wrote: > > > On 15/2/22 05:32, Michael Niedermayer wrote: > > > > +static int argo_cvg_write_trailer(AVFormatContext *s) > > > +{ > > > +ArgoCVGMuxContext *ctx = s->priv_data; > > > +int64_t ret; > > > + > > > +av_log(s, AV_LO

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/movtextdec: add () to CMP() macro to avoid unexpected behavior

2022-02-15 Thread Michael Niedermayer
On Mon, Feb 14, 2022 at 08:52:52PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/movtextdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c >

Re: [FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum

2022-02-15 Thread Zane van Iperen
On 15/2/22 23:05, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavformat/argo_cvg.c | 15 +-- libavformat/version.h | 2 +- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c index c5da32536d

[FFmpeg-devel] [PATCH 2/4] ffmpeg: ensure a keyframe was not seen before skipping packets

2022-02-15 Thread James Almer
A keyframe could be buffered in the bsf and not be output until more packets had been fed to it. Signed-off-by: James Almer --- This replaces/supersedes [PATCH 2/6] avcodec/bsf: add a capabilities field to AVBitStreamFilter [PATCH 4/6] ffmpeg: don't skip packets before a keyframe was seen if a b

Re: [FFmpeg-devel] [PATCH] tools: add general_assembly.pl

2022-02-15 Thread Jean-Baptiste Kempf
Hello, On Tue, 15 Feb 2022, at 12:50, J. Dekker wrote: > This was rejected last time but I would really like to get this in the > tools or at least publicly recorded on mailing list since the script > was updated. Why was this rejected? > +foreach my $commit (@commits) { > +

[FFmpeg-devel] [PATCH 02/19] avdevice/decklink_(common_c|dec|enc).h: Fix checkheaders

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavdevice/decklink_common_c.h | 3 +++ libavdevice/decklink_dec.h | 2 ++ libavdevice/decklink_enc.h | 2 ++ 3 files changed, 7 insertions(+) diff --git a/libavdevice/decklink_common_c.h b/libavdevice/decklink_common_c.h index c2577210a6..75896ad

[FFmpeg-devel] [PATCH 03/19] avcodec/cabac_functions: Add missing headers

2022-02-15 Thread Andreas Rheinhardt
Fixes make checkheaders on PPC, for which no arch-specific header exists that indirectly includes attributes.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/cabac_functions.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cabac_functions.h b/libavcodec/cabac_functions.h ind

[FFmpeg-devel] [PATCH 04/19] avcodec/aarch64/idct: Add missing stddef

2022-02-15 Thread Andreas Rheinhardt
Fixes checkheaders on aarch64. Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/idct.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aarch64/idct.h b/libavcodec/aarch64/idct.h index 5c49046148..97ee0a64af 100644 --- a/libavcodec/aarch64/idct.h +++ b/libavcodec/aarch64/id

[FFmpeg-devel] [PATCH 05/19] avcodec/mips: Fix checkheaders

2022-02-15 Thread Andreas Rheinhardt
mips has several headers that are only meant for inclusion in another non-arch specific file; they do not even try to be standalone. So don't test them in checkheaders. Also fix vp9dsp_mips.h, an ordinary header missing some includes. Signed-off-by: Andreas Rheinhardt --- libavcodec/mips/Makefi

[FFmpeg-devel] [PATCH 06/19] avformat/avio: Don't include common.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avio.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index cd63322a62..ca970b1ce3 100644 --- a/libavformat/avio.h +++ b/libavformat/avio.h @@ -27,8 +27,9 @@ */ #include +#includ

[FFmpeg-devel] [PATCH 07/19] avutil/log: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
It has been included since af5f434f8c0fb3b4ee3b206ebc1946ca660a8abe for deprecation reasons, but removing it has been forgotten after it had served is purpose. So remove it. For convenience, include version.h instead as LIBAVUTIL_VERSION_INT is supposed to be used when creating AVClasses. Signed-

[FFmpeg-devel] [PATCH 08/19] avutil/audio_fifo: Avoid avutil.h inclusion

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/audio_fifo.c | 7 +-- libavutil/audio_fifo.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/audio_fifo.c b/libavutil/audio_fifo.c index b1355e55a0..f4103178ba 100644 --- a/libavutil/audio_fifo.c +++ b/libavutil/

[FFmpeg-devel] [PATCH 12/19] avutil/imgutils: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
It is a remnant of an FF_API_* inclusion (back from when they were in avutil.h and not in version.h). Signed-off-by: Andreas Rheinhardt --- libavutil/imgutils.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h index cb2d74728e..be

[FFmpeg-devel] [PATCH 09/19] avutil/fifo: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/fifo.c | 5 - libavutil/fifo.h | 4 +++- libavutil/threadmessage.c | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 09c984143f..51a5af6f39 100644 --- a/libavutil/f

[FFmpeg-devel] [PATCH 10/19] avutil/file: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/file.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/file.h b/libavutil/file.h index 3ef4a6022c..8ec210e783 100644 --- a/libavutil/file.h +++ b/libavutil/file.h @@ -19,9 +19,10 @@ #ifndef AVUTIL_FILE_H #define AVU

[FFmpeg-devel] [PATCH 11/19] avutil/eval: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
It has been added for an FF_API_* at a time when these were in avutil.h. Signed-off-by: Andreas Rheinhardt --- libavutil/eval.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavutil/eval.h b/libavutil/eval.h index 068c62cdab..57afc2d562 100644 --- a/libavutil/eval.h +++ b/libavutil/eval

[FFmpeg-devel] [PATCH 13/19] avutil/samplefmt: Don't include attributes.h, avutil.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/samplefmt.c | 6 -- libavutil/samplefmt.h | 3 --- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c index c7428940e1..6d3ec34dab 100644 --- a/libavutil/samplefmt.c +++ b/libavutil/sampl

[FFmpeg-devel] [PATCH 14/19] avutil/pixelutils: Don't include common.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/pixelutils.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/pixelutils.h b/libavutil/pixelutils.h index a8dbc157e1..7a997cde1c 100644 --- a/libavutil/pixelutils.h +++ b/libavutil/pixelutils.h @@ -21,7 +21,6 @@ #include #include -

[FFmpeg-devel] [PATCH 15/19] avutil/integer: Don't include common.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/integer.c | 4 +++- libavutil/integer.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavutil/integer.c b/libavutil/integer.c index 78e252fbde..b709c6d487 100644 --- a/libavutil/integer.c +++ b/libavutil/integer.c @@ -25,9

[FFmpeg-devel] [PATCH 16/19] avutil/display: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/display.c | 1 + libavutil/display.h | 1 - libavutil/tests/display.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/display.c b/libavutil/display.c index a0076e067b..d31061283c 100644 --- a/libavutil/disp

[FFmpeg-devel] [PATCH 17/19] Remove obsolete version.h inclusions

2022-02-15 Thread Andreas Rheinhardt
Forgotten in e7bd47e657bbf9e1ce9915e93bc80cb1a29fb7f3. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc.c| 2 +- libavcodec/x86/blockdsp_init.c | 2 -- libavfilter/internal.h | 1 - libavfilter/vf_swapuv.c| 1 - libavformat/url.h | 1 - libavutil/c

[FFmpeg-devel] [PATCH 18/19] avutil/avassert: Don't include avutil.h

2022-02-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dct.c | 2 ++ libavcodec/mpegaudiodec_common.c | 1 + libavcodec/mqcenc.c | 2 ++ libavcodec/put_bits.h | 1 + libavcodec/rdft.c | 1 + libavcodec/tests/fft.c| 1 + libavcodec/

[FFmpeg-devel] [PATCH 19/19] Remove unnecessary libavutil/(avutil|common|internal).h inclusions

2022-02-15 Thread Andreas Rheinhardt
Some of these were made possible by moving several common macros to libavutil/macros.h. While just at it, also improve the other headers a bit. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.c | 3 ++- libavcodec/ac3.h | 1 + libavcodec/

Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API

2022-02-15 Thread James Almer
On 2/15/2022 8:50 AM, Anton Khirnov wrote: Quoting James Almer (2022-01-13 03:09:07) diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c index ed3c75311a..96704e041c 100644 --- a/libavfilter/af_aformat.c +++ b/libavfilter/af_aformat.c @@ -104,9 +104,36 @@ static av_cold int init(

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Corner case encryption error cleanup in mov_read_senc()

2022-02-15 Thread Michael Niedermayer
On Thu, Feb 10, 2022 at 12:34:40PM +0100, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 42341/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4566632823914496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeglsdec: Check get_ur_golomb_jpegls() for error

2022-02-15 Thread Michael Niedermayer
On Sat, Feb 12, 2022 at 10:27:13PM +0100, Paul B Mahol wrote: > Please follow code style. ill add the space between if and ( before applying also, ill fix the other similar issues in the file in a seperate commit thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

Re: [FFmpeg-devel] [PATCH] avformat/argo_cvg: Fix checksum

2022-02-15 Thread Michael Niedermayer
On Wed, Feb 16, 2022 at 12:25:52AM +1000, Zane van Iperen wrote: > > > On 15/2/22 23:05, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/argo_cvg.c | 15 +-- > > libavformat/version.h | 2 +- > > 2 files changed, 6 insertions(+), 11 del

[FFmpeg-devel] [PATCH 2/3] avcodec/speexdec: Use correct doxygen comments

2022-02-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/speexdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index dcbdf5e010..7c61c9b0e0 100644 --- a/libavcodec/speexdec.c +++ b/libavcodec/speexdec.c @@ -164,7 +164,7 @@

[FFmpeg-devel] [PATCH 3/3] avcodec/speexdec: Align some comments

2022-02-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/speexdec.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index 7c61c9b0e0..ee95417deb 100644 --- a/libavcodec/speexdec.c +++ b/libavcode

[FFmpeg-devel] [PATCH 1/3] avfilter: Rename blend_modes.c -> blend_modes_template.c

2022-02-15 Thread Michael Niedermayer
This is more consistent with similar usage Signed-off-by: Michael Niedermayer --- .../{blend_modes.c => blend_modes_template.c} | 0 libavfilter/vf_blend.c | 14 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) rename libavfilter/{blend_modes.c =

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2022-02-14 17:03, Stephen Hutchinson wrote: > Should be fixed in > https://github.com/AviSynth/AviSynthPlus/commit/0e583378116c857372232e9886c5 99df2fb8da85 > > with the caveat (noted in AviSynth+'s README.md) that the `make install` step > n

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Stephen Hutchinson
On 2/15/22 5:02 PM, Helmut K. C. Tessarek wrote: What is the solution? I am compiling ffmpeg with AviSynthPlus-3.5.1 and my configure just errored out with ERROR: avisynth/avisynth_c.h avisynth/avs/version.h not found Which makes sense because I don't have a version.h Do I have to use the la

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2022-02-15 18:55, Stephen Hutchinson wrote: > > git clone --recursive -b 3.7 https://github.com/AviSynth/AviSynthPlus > [build/install as usual] > > -b 3.7 is equal to the tarball for 3.7.1a (which has the fix for the case > of building the e

Re: [FFmpeg-devel] [PATCH] tools: add general_assembly.pl

2022-02-15 Thread J, Dekker
On 15/02/2022 17:46, Jean-Baptiste Kempf wrote: Hello, On Tue, 15 Feb 2022, at 12:50, J. Dekker wrote: This was rejected last time but I would really like to get this in the tools or at least publicly recorded on mailing list since the script was updated. Why was this rejected? It was

[FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

2022-02-15 Thread J. Dekker
This script generates the current general assembly voters according to the criteria of '20 commits in the last 36 months'. Signed-off-by: J. Dekker --- doc/dev_community/community.md | 3 +++ tools/general_assembly.pl | 40 ++ 2 files changed, 43 insertions(

[FFmpeg-devel] [PATCH 2/2] mailmap: update entry

2022-02-15 Thread J. Dekker
Signed-off-by: J. Dekker --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index ba072f38c8..5544fc5b5c 100644 --- a/.mailmap +++ b/.mailmap @@ -8,7 +8,8 @@ - + +J. Dekker -- 2.32.0 (Apple Git-132) __

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Stephen Hutchinson
On 2/15/22 8:33 PM, Helmut K. C. Tessarek wrote: Unfortunately this didn't work. Building the new AviSynthPlus results in the following errors: Those errors would indicate you're not on the 3.7 branch, because if the filesystem submodule isn't present, it doesn't emit those errors, it stops

Re: [FFmpeg-devel] [PATCH 1/3] avfilter: Rename blend_modes.c -> blend_modes_template.c

2022-02-15 Thread Andreas Rheinhardt
Michael Niedermayer: > This is more consistent with similar usage > > Signed-off-by: Michael Niedermayer > --- > .../{blend_modes.c => blend_modes_template.c} | 0 > libavfilter/vf_blend.c | 14 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) >

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2022-02-15 22:50, Stephen Hutchinson wrote: > Those errors would indicate you're not on the 3.7 branch, because if the > filesystem submodule isn't present, it doesn't emit those errors, it > stops dead because of the missing header. If the > s

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec: use the parameter from decodeHeader to configure surface

2022-02-15 Thread Xiang, Haihao
On Fri, 2022-02-11 at 10:37 +0800, Wenbin Chen wrote: > MSDK recognizes both yuv420p10 and yuv420p9 as MFX_FOURCC_P010, but > parameters are different. When decode yuv420p9 video, ffmpeg-qsv will use > yuv420p10le to configure surface which is different with param from > DecoderHeader and this will

[FFmpeg-devel] [PATCH] avfilter/fifo: Remove unused buffer frame

2022-02-15 Thread Andreas Rheinhardt
Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. Signed-off-by: Andreas Rheinhardt --- What is actually the use-case of these filters? The documentation states that they are auto-inserted, yet this is no longer true any more since 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. libavfilter/fifo

[FFmpeg-devel] [PATCH] avformat/nutdec: Add check for avformat_new_stream

2022-02-15 Thread Jiasheng Jiang
As the potential failure of the memory allocation, the avformat_new_stream() could return NULL pointer. Therefore, it should be better to check it and return error if fails. Fixes: 84ad31ff18 ("lavf: replace av_new_stream->avformat_new_stream part II.") Signed-off-by: Jiasheng Jiang --- libavfor

Re: [FFmpeg-devel] [PATCH] avformat/nutdec: Add check for avformat_new_stream

2022-02-15 Thread Andreas Rheinhardt
Jiasheng Jiang: > As the potential failure of the memory allocation, > the avformat_new_stream() could return NULL pointer. > Therefore, it should be better to check it and return > error if fails. > > Fixes: 84ad31ff18 ("lavf: replace av_new_stream->avformat_new_stream part > II.") This commit

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Add missing check for av_malloc

2022-02-15 Thread Peter Ross
On Tue, Feb 15, 2022 at 05:58:08PM +0800, Jiasheng Jiang wrote: > Since the av_malloc() may fail and return NULL pointer, > it is needed that the 's->edge_emu_buffer' should be checked > whether the new allocation is success. > > Fixes: d14723861b ("VP3: fix decoding of videos with stride > 2048")

Re: [FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

2022-02-15 Thread Stephen Hutchinson
On 2/16/22 12:10 AM, Helmut K. C. Tessarek wrote: On 2022-02-15 22:50, Stephen Hutchinson wrote: Those errors would indicate you're not on the 3.7 branch, because if the filesystem submodule isn't present, it doesn't emit those errors, it stops dead because of the missing header. If the submod