Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

Am 01.02.22 um 00:40 schrieb Andreas Rheinhardt: Thilo Borgmann: Am 31.01.22 um 14:08 schrieb Nicolas George: Thilo Borgman (12022-01-31): v10 attached. Also going to apply soon if there are no more comments. I think you neglected to attach the file. omg stupid me. Here it is... -Thilo

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

Thilo Borgmann: > Am 01.02.22 um 00:40 schrieb Andreas Rheinhardt: >> Thilo Borgmann: >>> Am 31.01.22 um 14:08 schrieb Nicolas George: Thilo Borgman (12022-01-31): >> v10 attached. > > Also going to apply soon if there are no more comments. I think you neglected to attach

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

Quoting Soft Works (2022-02-07 03:18:54) > I sometimes wonder whether there exists a single API user who > really understands this (very special) kind of logic and > would make decisions based on that understanding. > > When it's not even fully understood internally, how should it > be understood

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

Quoting Andreas Rheinhardt (2022-02-07 02:46:08) > I thought that removing components is only possible at a major version > bump. Am I wrong? AFAIK we provide no API guarantees for specific components being available. -- Anton Khirnov ___ ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/cbs_jpeg: Fix size of huffman symbol table array

L[i] can be in the range of 0-255, see table B.5 of ITU T.81. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_jpeg.h | 2 +- libavcodec/cbs_jpeg_syntax_template.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_jpeg.h b/libavcodec/cbs_

Re: [FFmpeg-devel] [PATCH] libavutil: include assembly with full path from source root

Quoting Alexander Kanavin (2022-02-07 12:24:58) > On Mon, 31 Jan 2022 at 14:29, Alexander Kanavin > wrote: > > > On Mon, 31 Jan 2022 at 13:52, Anton Khirnov wrote: > > > >> With a separate build directory, I'm getting > >> $ strings libavutil/x86/tx_float.o |grep asm > >> src/libavutil/x86/tx_fl

[FFmpeg-devel] [PATCH] avcodec/pngdec: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- I did not add these codecs the last time I searched for codecs to add the FF_CODEC_CAP_INIT_CLEANUP because I was unsure whether calling ff_thread_release_buffer() on a NULL frame was safe (it is). libavcodec/pngdec.c | 9 +++-- 1 file changed, 3 inserti

[FFmpeg-devel] [PATCH 1/2] avcodec/proresenc_kostya: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_kostya.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 85651fce2a..08a874dd4e 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libav

[FFmpeg-devel] [PATCH 2/2] avcodec/proresenc_kostya: Use av_calloc/av_malloc_array()

Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_kostya.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 08a874dd4e..beceee621d 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

Am 08.02.22 um 10:27 schrieb Andreas Rheinhardt: Thilo Borgmann: Am 01.02.22 um 00:40 schrieb Andreas Rheinhardt: Thilo Borgmann: Am 31.01.22 um 14:08 schrieb Nicolas George: Thilo Borgman (12022-01-31): v10 attached. Also going to apply soon if there are no more comments. I think you ne

[FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc_dwt: Avoid NULL - 0

It is sane, but UB. It could happen in case of allocation errors in vc2_encode_init(). Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc_dwt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc2enc_dwt.c b/libavcodec/vc2enc_dwt.c index a8d3f1c669..441af

[FFmpeg-devel] [PATCH 2/2] avcodec/vc2enc: Cleanup generically on allocation failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/vc2enc.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c index f0d2cdf62d..ccca78d281 100644 --- a/libavcodec/vc2enc.c +++ b/libavcodec/vc2enc.c @@ -1135,7 +1135,7 @@ stati

[FFmpeg-devel] [PATCH] avcodec/ralf: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/ralf.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c index bb80119b0c..0c51f49939 100644 --- a/libavcodec/ralf.c +++ b/libavcodec/ralf.c @@ -163,47 +163,35 @@ s

[FFmpeg-devel] [PATCH] avcodec/tta: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/tta.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/tta.c b/libavcodec/tta.c index 17b4ca9032..accac38893 100644 --- a/libavcodec/tta.c +++ b/libavcodec/tta.c @@ -114,10 +114,8 @@ static int allocate_buffers(A

[FFmpeg-devel] [PATCH 0/3] avformat/avisynth: support frame properties

AviSynth+ 3.6.0 introduced support for frame properties, allowing various metadata to be passed between filters or read out by client programs. Using this, FFmpeg can read Color Range, Transfer Characteristics, Matrix, Color Primaries, Chroma Location, and Field Order information from AviSynth scr

[FFmpeg-devel] [PATCH 1/3] avisynth: corrected interlace detection

From: emcodem AviSynth works on frame-based video by default, which can be either progressive or interlaced. Some filters can break frames into half-height fields, at which point it considers the clip to be field-based (avs_is_field_based can be used to check for this situation). To properly det

[FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields

* Field Order * Chroma Location * Color Transfer Characteristics * Color Range * Color Primaries * Matrix Coefficients The existing TFF/BFF detection is retained as a fallback for older versions of AviSynth that can't access frame properties. The other properties have no legacy equivalent to detec

[FFmpeg-devel] [PATCH 3/3] configure: check avisynth header version

The headers from version 3.7.1 are needed in order to support parsing of frame properties. avs/version.h has been generated as part of the AviSynth+ build process for a long time, but was never installed with the includes until version 3.7.1a. Checking for the presence of avs/version.h might have b

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: initialize max_packet_size when sub-demuxer

On 2022-02-07 09:34 am, Gyan Doshi wrote: On 2022-02-07 03:59 am, Marton Balint wrote: On Sat, 5 Feb 2022, Gyan Doshi wrote: bca30570d2 added a user option to set max_packet_size replacing a hardcoded value. This had a side-effect of leaving the field set to 0 when packet demuxing is ca

[FFmpeg-devel] [PATCH] avcodec/cavsdec: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/cavs.c| 4 +--- libavcodec/cavsdec.c | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/cavs.c b/libavcodec/cavs.c index e29d9c659b..5367c44248 100644 --- a/libavcodec/cavs.c +++ b/libavcodec/cavs.c @@ -812,10 +812

[FFmpeg-devel] [PATCH 2/3] avcodec/cavsdec: Mark decoder as init-threadsafe

It does not initialize any static data in its .init. Signed-off-by: Andreas Rheinhardt --- libavcodec/cavsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cavsdec.c b/libavcodec/cavsdec.c index 54e1877bbd..da9aa94deb 100644 --- a/libavcodec/cavsdec.c +++ b/lib

[FFmpeg-devel] [PATCH 3/3] avcodec/cavsdec: Fix error message

Signed-off-by: Andreas Rheinhardt --- libavcodec/cavsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cavsdec.c b/libavcodec/cavsdec.c index da9aa94deb..6f4856ce97 100644 --- a/libavcodec/cavsdec.c +++ b/libavcodec/cavsdec.c @@ -505,7 +505,7 @@ static inline in

[FFmpeg-devel] [PATCH] avcodec/g2meet: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/g2meet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index 4c53838af5..8628016ef4 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -1592,7 +1592,6 @@ static av_cold in

[FFmpeg-devel] [PATCH] avcodec/4xm: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/4xm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c index cb315cd7e4..cb361772d2 100644 --- a/libavcodec/4xm.c +++ b/libavcodec/4xm.c @@ -1008,10 +1008,8 @@ static av_cold int decode_i

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

Am 04.02.22 um 17:19 schrieb Zhao Zhili: --- libavdevice/avfoundation.m | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 0cd6e646d5..2078c4879c 100644 --- a/libavdevice/avfoundation.m +++ b/libavdevice/

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

Thilo Borgmann: > Am 04.02.22 um 17:19 schrieb Zhao Zhili: >> --- >>   libavdevice/avfoundation.m | 10 ++ >>   1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m >> index 0cd6e646d5..2078c4879c 100644 >> --- a/libavdevi

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

Am 08.02.22 um 13:50 schrieb Andreas Rheinhardt: Thilo Borgmann: Am 04.02.22 um 17:19 schrieb Zhao Zhili: ---   libavdevice/avfoundation.m | 10 ++   1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 0cd6e646d5..

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

Thilo Borgmann: > Am 08.02.22 um 13:50 schrieb Andreas Rheinhardt: >> Thilo Borgmann: >>> Am 04.02.22 um 17:19 schrieb Zhao Zhili: ---    libavdevice/avfoundation.m | 10 ++    1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavdevice/avfoundation.m b/

[FFmpeg-devel] [PATCH 1/2] avformat/hls: Use unsigned for iv computation

Fixes: signed integer overflow: 9223372036854775748 + 60 cannot be represented in type 'long' Fixes: 44417/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-5802443881971712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 2/2] avcodec/sonic: Use unsigned for predictor_k to avoid undefined behavior

Fixes: signed integer overflow: -1094995529 * 24 cannot be represented in type 'int' Fixes: 44436/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-4874459459223552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] [PATCH] avcodec/metasound, twinvqdec: Cleanup generically upon init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/metasound.c | 2 +- libavcodec/twinvq.c| 5 + libavcodec/twinvq.h| 1 + libavcodec/twinvqdec.c | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/metasound.c b/libavcodec/metasound.c index 57851a43c5..f066

[FFmpeg-devel] [PATCH] avcodec/g2meet: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/g2meet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/g2meet.c b/libavcodec/g2meet.c index 4c53838af5..8628016ef4 100644 --- a/libavcodec/g2meet.c +++ b/libavcodec/g2meet.c @@ -1592,7 +1592,6 @@ static av_cold in

[FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close function is never ever called for a codec whose init function has not been called; in particular, it is never ever called if the AVCodecContext's private data has not been allocated. Signed-off-by: Andreas Rheinhardt --- libavcodec/v

[FFmpeg-devel] [PATCH] avutil/tx: Fix documentation of av_tx_uninit()

Adapt it to the actual (sane) behaviour. Signed-off-by: Andreas Rheinhardt --- libavutil/tx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tx.h b/libavutil/tx.h index 087355f10d..3de2f7231b 100644 --- a/libavutil/tx.h +++ b/libavutil/tx.h @@ -154,7 +154,7 @@ int

[FFmpeg-devel] [PATCH 1/2] avcodec/hcadec: Fix memleak upon allocation error

An AVFloatDSPContext would leak upon av_tx_init() failure. Signed-off-by: Andreas Rheinhardt --- libavcodec/hcadec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c index c98f8eb379..ef3af08c4c 100644 --- a/libavcodec/hcadec.c +++ b/libavcodec/hcadec

[FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/hcadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hcadec.c b/libavcodec/hcadec.c index ef3af08c4c..f5e23efc5b 100644 --- a/libavcodec/hcadec.c +++ b/libavcodec/hcadec.c @@ -455,7 +455,7 @@ const AVCodec ff_hca_

Re: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression

> -Original Message- > From: ffmpeg-devel On Behalf Of Xiang, > Haihao > Sent: Monday, February 7, 2022 9:48 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Xiang, Haihao > Subject: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression > > From: Haihao Xiang > > offset_w might be updated after grow

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Mark decoder as init-threadsafe

set lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] lavu/fifo: fix a corner case in av_fifo_grow2()

When the fifo is grown by exactly the current write offset, it would end up with offset_w = nb_elems. If av_fifo_write_from_cb() is called in such a state, the user callback would get callled with *nb_elems=0, which will then cause the write to return without writing anything. --- libavutil/fifo.c

[FFmpeg-devel] [PATCH 2/2] lavu/fifo: add a test for _cb functions

Makes an auto-growing FIFO and performs a sequence of randomly-sized writes/peeks/reads. --- libavutil/tests/fifo.c | 101 + 1 file changed, 101 insertions(+) diff --git a/libavutil/tests/fifo.c b/libavutil/tests/fifo.c index 579602ccf3..bfcdfeebfb 100644 -

[FFmpeg-devel] [PATCH 1/2] lavfi/qsvpp: fix after 85c938fa28

--- libavfilter/qsvvpp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 35769dfd60..954f882637 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -796,7 +796,7 @@ int ff_qsvvpp_filter_frame(QSVVPPContext

[FFmpeg-devel] [PATCH 2/2] lavu/hwcontext_qsv: fix a potential infinite loop

Current code will loop forever if MFXVideoVPP_Init() fails. Also, simplify the code. --- libavutil/hwcontext_qsv.c | 80 +++ 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index d3d8f42c99..9

Re: [FFmpeg-devel] [PATCH 2/2] lavu/hwcontext_qsv: fix a potential infinite loop

On 2/8/2022 3:26 PM, Anton Khirnov wrote: Current code will loop forever if MFXVideoVPP_Init() fails. Also, simplify the code. --- libavutil/hwcontext_qsv.c | 80 +++ 1 file changed, 31 insertions(+), 49 deletions(-) diff --git a/libavutil/hwcontext_qsv.

[FFmpeg-devel] [PATCH 2/2] avformat/demux: Count EAGAIN as 100 bytes in relation to read limit in avformat_find_stream_info()

Fixes: Timeout Fixes: 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5206008287330304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/demux.c | 4 +++- 1 file changed, 3 insert

[FFmpeg-devel] [PATCH 1/2] avformat/demux: Make read_frame_internal() return AVERREOR(EAGAIN) on stuck empty input parser

Fixes: read_frame_internal() which does not return even though both demuxer and parser do return Fixes: 43717/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5206008287330304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH] cbs_mpeg2_split_fragment(): cache the buffer end

Also add a few clarifying comments. --- libavcodec/cbs_mpeg2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c index 33bd3e0998..47732562d1 100644 --- a/libavcodec/cbs_mpeg2.c +++ b/libavcodec/cbs_mpeg2.c @@ -144,

[FFmpeg-devel] [PATCH] avcodec/motion_est: Fix xy indexing on range violation in ff_get_best_fcode()

This codepath seems untested, no testcases change Found-by: Signed-off-by: Michael Niedermayer --- libavcodec/motion_est.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index 9c548c1567..4cf1afe888 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Tuesday, February 8, 2022 10:37 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC > hwaccel code > > Quoting Soft Work

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/qsvpp: fix after 85c938fa28

> -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Tuesday, February 8, 2022 10:27 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 1/2] lavfi/qsvpp: fix after 85c938fa28 > > --- > libavfilter/qsvvpp.c | 10 +- > 1 file changed, 5 ins

Re: [FFmpeg-devel] [PATCH v2] avfilter/adelay: Add command support

Yes, during development I tested it streaming to rtmp and to file with a python client sending zmq requests. I Also tried changing the delay multiple times while running a single ffmpeg instance. Seemed to be working fine. so 5. 2. 2022 o 15:05 Paul B Mahol napísal(a): > Have this been tested? >

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mov: fix udta reading in trak box

On Tue, Feb 8, 2022 at 9:48 AM Wang Chuan wrote: > > Any news？ > Sorry, was not able to get to this according to the time line I expected. Will see if I can find some time for this soon. The attempt I had done in October was quite similar now that I look at it again (https://github.com/jeeb/ffm

Re: [FFmpeg-devel] [PATCH 1/2] http: Improve handling of Content-Range with Transfer-Encoding:chunked

On Thu, Feb 3, 2022 at 3:12 PM Derek Buitenhuis wrote: > On 2/3/2022 1:26 AM, Aman Karmani wrote: > > The size part of the range header is optional, and can be '*' as well. > > > > See also > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211005233244.37582-1-ffm...@tmm1.net/ > > Isn't t

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: Fix xy indexing on range violation in ff_get_best_fcode()

Michael Niedermayer: > This codepath seems untested, no testcases change > > Found-by: > Signed-off-by: Michael Niedermayer > --- > libavcodec/motion_est.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c > index

[FFmpeg-devel] [PATCH v3 0/8] rewrite avpriv_find_start_code() for clarity

I have removed most of my added comments. Rebased to account for Andreas Rheinhardt moving the prototype to startcode.h. Per his suggestion, the function signature is now unmodified. (ff_)mpeg1_find_frame_end() now has a wrapper function preserving the original behavior allowing start codes acros

[FFmpeg-devel] [PATCH v3 1/8] avcodec/startcode.h: create start_code_is_valid()

This slightly changes what is considered valid in the following cases: cavsdec.c: 0x00XX is now considered invalid. mpeg12dec.c: 0x00XX is now considered invalid. (where X is any value) IS_MARKER is equivalent since VC1_CODE_RES0 = 0x0100 --- libavcodec/cavsdec.c | 2

[FFmpeg-devel] [PATCH v3 2/8] avpriv_find_start_code(): readability enhancement part 1

No functional change. --- libavcodec/utils.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index c7c7323351..42a1885d61 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -963,10 +963,11 @@ const uint8_t *avpriv_find_s

[FFmpeg-devel] [PATCH v3 3/8] avpriv_find_start_code(): rewrite while loop

The expected number of iterations may increase by one for an input of alternating 0 and 1 bytes. Instead of incrementing by 2 everytime, it now alternates between incrementing by 1 and by 3. For the check p[-2] != 0: This slightly reduces the number of iterations by starting with three new bytes

[FFmpeg-devel] [PATCH v3 4/8] avpriv_find_start_code(): rewrite for loop for clarity

--- libavcodec/utils.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 5b49657b44..bdafdaa355 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -940,18 +940,20 @@ const uint8_t *avpriv_find_start_code(const

[FFmpeg-devel] [PATCH v3 5/8] avpriv_find_start_code(): add doxygen comment and rename a parameter

--- libavcodec/startcode.h | 26 +- libavcodec/utils.c | 10 +- 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/libavcodec/startcode.h b/libavcodec/startcode.h index 833754af09..69389c729c 100644 --- a/libavcodec/startcode.h +++ b/libavcodec/star

[FFmpeg-devel] [PATCH v3 6/8] avpriv_find_start_code(): correct type of start_code parameter

--- libavcodec/mpeg12dec.c | 2 +- libavformat/rtpenc_mpv.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 27fd61e848..24cd6aac77 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1768,7 +1768,7 @@

[FFmpeg-devel] [PATCH v3 7/8] avpriv_find_start_code(): constify pointer parameters

Have the compiler enforce not changing the addresses these parameters point to. No functional change. --- libavcodec/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 68d126acd8..d11d92d21e 100644 --- a/libavcodec/utils.c

[FFmpeg-devel] [PATCH v3 8/8] avpriv_find_start_code(): make start_code output only

The input/output functionality was used by only (ff_)mpeg1_find_frame_end(). If the state/start_code input is a local variable and only one buffer is used, then no history is needed. In loops and inline functions: if ignoring history, don't initialize start_code, so it isn't reset twice each time

Re: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression

On Tue, 2022-02-08 at 17:48 +, Eoff, Ullysses A wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Xiang, > > Haihao > > Sent: Monday, February 7, 2022 9:48 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Xiang, Haihao > > Subject: [FFmpeg-devel] [PATCH] lavu/fifo: fix regre

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

On Tue, Feb 08, 2022 at 04:39:27PM +0100, Andreas Rheinhardt wrote: > Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close > function is never ever called for a codec whose init function has not > been called; in particular, it is never ever called if the > AVCodecContext's private data h

Re: [FFmpeg-devel] [PATCH] avcodec/vp6: return value check for av_mallocz

On Mon, Feb 07, 2022 at 11:44:53AM +0800, Jiasheng Jiang wrote: > As the potential failure of the av_mallocz(), the 's->alpha_context' > could be NULL and be dereferenced later. > Therefore, it should be better to check it and deal with it if fails > in order to prevent memory leak, same as the av_

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

Quoting Soft Works (2022-02-08 22:34:42) > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Tuesday, February 8, 2022 10:37 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hls: Use unsigned for iv computation

Michael Niedermayer 于2022年2月8日周二 22:59写道： > > Fixes: signed integer overflow: 9223372036854775748 + 60 cannot be > represented in type 'long' > Fixes: > 44417/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-5802443881971712 > > Found-by: continuous fuzzing process > https://github.com/goog

Re: [FFmpeg-devel] [PATCH v4] avformat/hls: Implement support for using AVSEEK_FLAG_BACKWARD when seeking

Steven Liu 于2022年2月3日周四 18:22写道： > > > > > 2022年1月29日 上午4:23，Gustav Grusell 写道： > > > > Before, seeking in hls streams would always seek to the next keyframe > > after the given timestamp. With this fix, if seeking in videostream and > > AVSEEK_FLAG_BACKWARD is set, seeking will be to the first k

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

> -Original Message- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, February 9, 2022 6:49 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC > hwaccel code > > Quoting Soft Wor

Re: [FFmpeg-devel] [PATCH V3 3/3] libavcodec/vaapi_encode: Add async_depth to vaapi_encoder to increase performance

> Add async_depth to increase encoder's performance. Reuse encode_fifo as > async buffer. Encoder puts all reordered frame to HW and then check > fifo size. If fifo < async_depth and the top frame is not ready, it will > return AVERROR(EAGAIN) to require more frames. > > 1080p transcoding (no B fr

Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code

Quoting Soft Works (2022-02-09 07:19:23) > > Sure. Don't understand my reply as an objection I don't even know what > xvmc is (or was). I rather see the burden and effort that it takes > to retain all those compatibility paths and at the same time how it > is blocking innovation and progress. >