Bump, could this get another review?
On 11-01-2022 16:07, Gijs Peskens wrote:
Introduce fifo_size and overrun_nonfatal params to configure fifo buffer
behavior.
Use newly introduced RIST_DATA_FLAGS_OVERFLOW flag to check for overrun
and error out in that case.
---
doc/protocols.texi| 9 +
Hi,
Am 30.01.22 um 18:30 schrieb to...@rastageeks.org:
From: Romain Beauxis
This updates the code for avfoundation to use modern device lookup APIs and
also adds a check to avoid querying the video devices array beyound its maximum
size.
---
libavdevice/avfoundation.m | 71 +++
Am 24.01.22 um 12:10 schrieb Thilo Borgmann:
Am 18.01.22 um 14:58 schrieb Thilo Borgmann:
Am 15.01.22 um 09:27 schrieb Paul B Mahol:
On Sat, Jan 15, 2022 at 9:25 AM Paul B Mahol wrote:
On Fri, Jan 14, 2022 at 5:22 PM Thilo Borgmann
wrote:
Hi,
Am 19.01.21 um 05:49 schrieb Lynne:
Jan 19
Am 20.01.22 um 16:32 schrieb Thilo Borgmann:
Am 20.01.22 um 16:03 schrieb Andreas Rheinhardt:
Thilo Borgmann:
Am 20.01.22 um 13:04 schrieb Thilo Borgmann:
Am 19.01.22 um 04:16 schrieb "zhilizhao(赵志立)":
On Jan 18, 2022, at 8:52 PM, Thilo Borgmann
wrote:
Am 16.01.22 um 12:06 schrieb Nicola
Quoting Thilo Borgmann (2022-01-18 14:58:07)
> >> Violations of code style.
>
> Enhanced.
Not enough. There are still many remaining, e.g.
* opening brace of a function definition should be on its own line
* the context should generally be the first argument
* unsigned char* should be uint8_t*
*
On 1/31/2022 8:53 AM, Anton Khirnov wrote:
Quoting Thilo Borgmann (2022-01-18 14:58:07)
Violations of code style.
Enhanced.
Not enough. There are still many remaining, e.g.
* opening brace of a function definition should be on its own line
* the context should generally be the first argum
Quoting Alexander Kanavin (2022-01-18 23:38:59)
> On Tue, 18 Jan 2022 at 23:32, Lynne wrote:
>
> >
> > Not what I'm seeing here in the binaries: "libavutil/x86/tx_float.asm",
> > rather than a full path.
> >
>
> Are you using a separate build directory? This is a sample reproducibility
> failure
On Mon, 31 Jan 2022 at 13:52, Anton Khirnov wrote:
> > Are you using a separate build directory? This is a sample
> reproducibility
> > failure we've observed:
> >
> https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20220118-y69m0ean/packages/diff-html/
>
> With a separate build directo
Thilo Borgman (12022-01-31):
> > v10 attached.
>
> Also going to apply soon if there are no more comments.
I think you neglected to attach the file.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
Quoting Nicolas George (2022-01-27 16:08:10)
> > + * be checked)
> > + *
> > + * No new fields may be added to it without a major version bump, except
> > for
> > + * new elements of the union fitting in sizeof(uint64_t).
> > + */
> > +typedef struct AVChannelLayout {
> > +/**
> > + * Chan
On Mon, 31 Jan 2022 at 13:52, Anton Khirnov wrote:
> With a separate build directory, I'm getting
> $ strings libavutil/x86/tx_float.o |grep asm
> src/libavutil/x86/tx_float.asm
>
The key piece is
../configure --disable-stripping
With stripping disabled and without the patch, you should see:
a
Hi,
This patch series adds support for IPFS.
I've been adviced to keep the patches as they are (split). If needed, I can
squash them to a single patch.
The following is a short summary. In the IPFS ecosystem you access it's content
by a "Content IDentifier" (CID). This CID is, in simplified ter
Signed-off-by: Mark Gaiser
---
configure | 1 +
doc/protocols.texi | 30 ++
libavformat/Makefile| 1 +
libavformat/ipfs.c | 202
libavformat/protocols.c | 2 +
5 files changed, 236 insertions(+)
create mode 100644 li
Signed-off-by: Mark Gaiser
---
configure| 1 +
libavformat/Makefile | 1 +
libavformat/ipfs.c | 12 ++--
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index e466f924a3..6ff09e7974 100755
--- a/configure
+++ b/configure
@@ -3586,6 +358
Only the open function needs to detect which one is used.
Signed-off-by: Mark Gaiser
---
libavformat/ipfs.c | 99 +++---
1 file changed, 22 insertions(+), 77 deletions(-)
diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c
index 8daf032dd2..22487c6cc8 10
Inform the user about how to set a gateway if none could be found.
Signed-off-by: Mark Gaiser
---
libavformat/ipfs.c | 159 +
1 file changed, 147 insertions(+), 12 deletions(-)
diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c
index 22487c6cc8..8f6
Little bit of consistency in punctuations.
Signed-off-by: Mark Gaiser
---
libavformat/ipfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavformat/ipfs.c b/libavformat/ipfs.c
index 8f6f91d85d..1644c74eac 100644
--- a/libavformat/ipfs.c
+++ b/libavformat/ipf
Le lun. 31 janv. 2022 à 04:11, Thilo Borgmann a
écrit :
>
> Hi,
>
> Am 30.01.22 um 18:30 schrieb to...@rastageeks.org:
> > From: Romain Beauxis
> >
> > This updates the code for avfoundation to use modern device lookup APIs
and also adds a check to avoid querying the video devices array beyound i
Hi,
On Sun, Jan 30, 2022 at 1:15 AM Eran Kornblau
wrote:
> >
> > -Original Message-
> > From: Eran Kornblau
> > Sent: Wednesday, 19 January 2022 9:14
> > To: FFmpeg development discussions and patches
> > Subject: RE: [FFmpeg-devel] http: honor response headers in redirect
> caching
> >
On Mon, Jan 31, 2022 at 12:05:11AM +0100, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > On Sun, Jan 30, 2022 at 07:27:24AM +0100, Andreas Rheinhardt wrote:
> >> This is in preparation for actually adding such contexts
> >> and e.g. moving fields only used by the main thread to
> >> the corre
On Mon, Jan 31, 2022 at 02:51:16PM +0100, Mark Gaiser wrote:
> Little bit of consistency in punctuations.
>
> Signed-off-by: Mark Gaiser
> ---
> libavformat/ipfs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Review fixes should be integrated into the patches when they a
mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
>
> There are multiple ways to access files on the IPFS network. This
> patch series
> uses the gateway driven way. An IPFS node - by default - exposes a
> local
> gateway (say http://localhost:8080) which is then used to get content
> from IP
On Mon, Jan 31, 2022 at 02:51:12PM +0100, Mark Gaiser wrote:
> Signed-off-by: Mark Gaiser
> ---
> configure | 1 +
> doc/protocols.texi | 30 ++
> libavformat/Makefile| 1 +
> libavformat/ipfs.c | 202
> libavformat/pro
On Mon, Jan 31, 2022 at 02:51:13PM +0100, Mark Gaiser wrote:
> Signed-off-by: Mark Gaiser
> ---
> configure| 1 +
> libavformat/Makefile | 1 +
> libavformat/ipfs.c | 12 ++--
> 3 files changed, 8 insertions(+), 6 deletions(-)
as with other fixes they should be stashed in
On 1/31/2022 10:51 AM, Mark Gaiser wrote:
Signed-off-by: Mark Gaiser
---
configure | 1 +
doc/protocols.texi | 30 ++
libavformat/Makefile| 1 +
libavformat/ipfs.c | 202
libavformat/protocols.c | 2 +
5 fi
On Mon, Jan 31, 2022 at 4:52 PM Tomas Härdin wrote:
> mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
> >
> > There are multiple ways to access files on the IPFS network. This
> > patch series
> > uses the gateway driven way. An IPFS node - by default - exposes a
> > local
> > gateway (say
On Mon, Jan 31, 2022 at 4:46 PM Michael Niedermayer
wrote:
> On Mon, Jan 31, 2022 at 02:51:16PM +0100, Mark Gaiser wrote:
> > Little bit of consistency in punctuations.
> >
> > Signed-off-by: Mark Gaiser
> > ---
> > libavformat/ipfs.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 de
On Mon, Jan 31, 2022 at 5:06 PM James Almer wrote:
>
>
> On 1/31/2022 10:51 AM, Mark Gaiser wrote:
> > Signed-off-by: Mark Gaiser
> > ---
> > configure | 1 +
> > doc/protocols.texi | 30 ++
> > libavformat/Makefile| 1 +
> > libavformat/ipfs.c | 202 +++
Hi,
On Mon, Jan 31, 2022 at 9:37 AM Ronald S. Bultje wrote:
> Hi,
>
> On Sun, Jan 30, 2022 at 1:15 AM Eran Kornblau
> wrote:
>
>> >
>> > -Original Message-
>> > From: Eran Kornblau
>> > Sent: Wednesday, 19 January 2022 9:14
>> > To: FFmpeg development discussions and patches > >
>> > Su
mån 2022-01-31 klockan 17:31 +0100 skrev Mark Gaiser:
> On Mon, Jan 31, 2022 at 4:52 PM Tomas Härdin
> wrote:
>
> > mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
> > >
> > > There are multiple ways to access files on the IPFS network. This
> > > patch series
> > > uses the gateway driven
Jan 31, 2022, 14:51 by mark...@gmail.com:
> Signed-off-by: Mark Gaiser
> ---
> configure | 1 +
> doc/protocols.texi | 30 ++
> libavformat/Makefile| 1 +
> libavformat/ipfs.c | 202
> libavformat/protocols.c | 2 +
>
Am 31.01.22 um 14:08 schrieb Nicolas George:
Thilo Borgman (12022-01-31):
v10 attached.
Also going to apply soon if there are no more comments.
I think you neglected to attach the file.
omg stupid me. Here it is...
-ThiloFrom 56e3af9f9039aa09b9daea3a47dea9fb24b19cec Mon Sep 17 00:00:00 20
On Mon, Jan 31, 2022 at 9:23 PM Tomas Härdin wrote:
> mån 2022-01-31 klockan 17:31 +0100 skrev Mark Gaiser:
> > On Mon, Jan 31, 2022 at 4:52 PM Tomas Härdin
> > wrote:
> >
> > > mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
> > > >
> > > > There are multiple ways to access files on the I
On Mon, Jan 31, 2022 at 9:26 PM Lynne wrote:
> Jan 31, 2022, 14:51 by mark...@gmail.com:
>
> > Signed-off-by: Mark Gaiser
> > ---
> > configure | 1 +
> > doc/protocols.texi | 30 ++
> > libavformat/Makefile| 1 +
> > libavformat/ipfs.c | 202 +++
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman
---
libavformat/mov.c | 12 +++-
1
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman
---
libavformat/mov.c | 12 +++-
1
On Tue, 11 Jan 2022, Gijs Peskens wrote:
Introduce fifo_size and overrun_nonfatal params to configure fifo buffer
behavior.
Use newly introduced RIST_DATA_FLAGS_OVERFLOW flag to check for overrun
and error out in that case.
---
doc/protocols.texi| 9 +
libavformat/librist.c | 37
Thilo Borgmann:
> Am 31.01.22 um 14:08 schrieb Nicolas George:
>> Thilo Borgman (12022-01-31):
v10 attached.
>>>
>>> Also going to apply soon if there are no more comments.
>>
>> I think you neglected to attach the file.
>
> omg stupid me. Here it is...
>
> -Thilo
>
>
> +
> +i
Similar to the earlier patch applied to imfdec.
Signed-off-by: Marton Balint
---
libavformat/imf_cpl.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
index f2ad9c05d6..102a6b4549 100644
--- a/libavformat/imf_cpl.c
+
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman
---
libavformat/mov.c | 12 +++-
1
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman
---
libavformat/mov.c | 12 +++-
1
Thilo Borgmann:
> Am 31.01.22 um 14:08 schrieb Nicolas George:
>> Thilo Borgman (12022-01-31):
v10 attached.
>>>
>>> Also going to apply soon if there are no more comments.
>>
>> I think you neglected to attach the file.
>
> omg stupid me. Here it is...
>
> -Thilo
>
Seems like I misunderst
Should fix ticket #9622
Signed-off-by: James Almer
---
I'm not sure if this is ok or not. The AV_PKT_DATA_SKIP_SAMPLES doxy states
the skip samples value is a little endian uint32 value, so even if the mov
demuxer wrote a truncated int64_t value in sti->skip_samples (which, being an
int, can be n
Same as in the AV_FRAME_FLAG_DISCARD codepath, ensure avci->skip_samples is not
negative.
Signed-off-by: James Almer
---
libavcodec/decode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 0912f86a14..4f9b949926 100644
--- a/libavcodec/decode.c
It's the type they should be interpreted as in the AV_PKT_DATA_SKIP_SAMPLES side
data.
Signed-off-by: James Almer
---
libavformat/demux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/demux.c b/libavformat/demux.c
index 09d539af68..4509015847 100644
--- a/liba
Signed-off-by: James Almer
---
libavformat/demux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/demux.c b/libavformat/demux.c
index 4509015847..ec34b65288 100644
--- a/libavformat/demux.c
+++ b/libavformat/demux.c
@@ -1346,7 +1346,7 @@ static int read_frame_inte
>From babcceafbd30eff677b2366a0c470d31c503bed1 Mon Sep 17 00:00:00 2001
From: TianBo Zheng
Date: Mon, 10 Jan 2022 11:18:56 +
Subject: [PATCH] avformat/mkv: add mkv tags for AVS2 and AVS3 codecs.
MKV codec mappings:
V_AVS2 and V_AVS3
(https://github.com/ietf-wg-cellar/matroska-specification
Ze Yuan:
> From babcceafbd30eff677b2366a0c470d31c503bed1 Mon Sep 17 00:00:00 2001
> From: TianBo Zheng
> Date: Mon, 10 Jan 2022 11:18:56 +
> Subject: [PATCH] avformat/mkv: add mkv tags for AVS2 and AVS3 codecs.
>
> MKV codec mappings:
> V_AVS2 and V_AVS3
> (https://github.com/ietf-wg-cella
Pierre-Anthony Lemieux:
> On Sun, Jan 30, 2022 at 2:16 PM Andreas Rheinhardt
> wrote:
>>
>> p...@sandflow.com:
>>> From: Pierre-Anthony Lemieux
>>>
>>> The IMF demuxer does not set the DTS and PTS of packets accurately in all
>>> scenarios. Moreover, audio packets are not trimmed when they exceed
From: Andreas Rheinhardt
Sent: Tuesday, February 1, 2022 12:43 PM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] avformat/mkv: add mkv tags for AVS2 and AVS3 codecs.
>Ze Yuan:
>> From babcceafbd30eff677b2366a0c470d31c503bed1 Mon Sep 17 00:00:00 2001
>> From: TianBo Zheng
>> Date: Mon, 10
50 matches
Mail list logo
