As we know, in-loop filters in HEVC are applied by the following
ordered steps: firstly deblocking filter, then sample adaptive offset
filter if enabled. However, in the current version of FFmpeg, pixels
without being deblocking-filtered could be used by SAO filter when CTU
size is 16 and chroma fo
On Thu, 16 Dec 2021, Aman Karmani wrote:
From: Aman Karmani
Signed-off-by: Aman Karmani
---
.gitignore | 3 +++
configure | 8 +++-
ffbuild/common.mak | 9 +
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 9ed24b542e..1a5b
To verify if this problem has been fixed, the following bitstream can
be used:
https://streams.videolan.org/ffmpeg/incoming/BlowingBubbles_ctu16.265
This bitstream is encoded by the following command line:
x265 --input BlowingBubbles_416x240_50.yuv --input-res 416x240 --fps 50 -s
16 -o bs.265
The M
Quoting Andreas Rheinhardt (2021-12-17 02:55:43)
> Anton Khirnov:
> > This is a first step towards making muxers more independent from the
> > rest of the code.
> > ---
> > fftools/Makefile | 11 +-
> > fftools/ffmpeg.c | 273 ++--
> > fftools/ffmpeg.h
Quoting Andreas Rheinhardt (2021-12-16 22:40:31)
> Anton Khirnov:
> > Allows making the variable local to ffmpeg_mux.
> > ---
> > fftools/ffmpeg.c | 9 +
> > fftools/ffmpeg.h | 1 -
> > fftools/ffmpeg_mux.c | 5 +
> > 3 files changed, 6 insertions(+), 9 deletions(-)
> >
> > di
When editlist is disabled, the workaournd method of shift dts to
zero and increase the first sample duration doesn't work if the
timestamp is larger than mp4 spec restriction (e.g., sample_delta
in stts entry). Further more, it triggers get_cluster_duration()
assert failure. This patch will drop la
Quoting Andreas Rheinhardt (2021-12-17 00:08:07)
> Anton Khirnov:
> > Avoid accessing the muxer context directly, as this will become
> > forbidden in future commits.
> > ---
> > fftools/ffmpeg.c | 15 +--
> > fftools/ffmpeg.h | 2 ++
> > fftools/ffmpeg_mux.c | 7 +++
> >
Quoting Andreas Rheinhardt (2021-12-17 00:42:25)
> Anton Khirnov:
> > diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c
> > index d4b674c9e2..e97ec8ab93 100644
> > --- a/fftools/ffmpeg_mux.c
> > +++ b/fftools/ffmpeg_mux.c
> > @@ -102,39 +102,12 @@ static int queue_packet(OutputFile *of, Outp
On Fri, Dec 17, 2021 at 01:04:19AM +0100, Marton Balint wrote:
>
>
> On Thu, 16 Dec 2021, James Almer wrote:
>
> > Resending the first two patches only, since this is meant to
> > show the implementation of one of the several suggestions made
> > in the previous set that need to be discussed and
Will apply tomorrow unless there are objections.
On 15/12/21 10:35, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
Signed-off-by: Pierre-Anthony Lemieux
---
Notes:
Refactors save_avio_options() from dashdec.c and hls.c
into a common ffio_copy_url_options() in libavformat/a
On Thu, Dec 16, 2021 at 10:09:13PM +0100, Paul B Mahol wrote:
> use wavpack, this is bad patch.
the flac specification supports 32bit
"FLAC supports from 4 to 32 bits per sample"
so theres nothing fundamental wrong with adding 32bit support
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B14
Anton Khirnov:
> Quoting Andreas Rheinhardt (2021-12-17 02:55:43)
>> Anton Khirnov:
>>> This is a first step towards making muxers more independent from the
>>> rest of the code.
>>> ---
>>> fftools/Makefile | 11 +-
>>> fftools/ffmpeg.c | 273 ++--
>>>
On Thu, Dec 16, 2021 at 08:43:21PM +0100, Martijn van Beurden wrote:
[...]
> @@ -972,7 +1007,25 @@ static int encode_residual_ch(FlacEncodeContext *s, int
> ch)
> for (i = 0; i < sub->order; i++)
> sub->coefs[i] = coefs[sub->order-1][i];
>
> -if (s->bps_code * 4 + s->options.
Anton Khirnov:
> Quoting Andreas Rheinhardt (2021-12-17 00:42:25)
>> Anton Khirnov:
>>> diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c
>>> index d4b674c9e2..e97ec8ab93 100644
>>> --- a/fftools/ffmpeg_mux.c
>>> +++ b/fftools/ffmpeg_mux.c
>>> @@ -102,39 +102,12 @@ static int queue_packet(Ou
On 12/16/2021 8:27 PM, Marton Balint wrote:
On Thu, 16 Dec 2021, James Almer wrote:
- Added a 16 byte fixed array to AVChannelCustom to give custom
labels to channels in Custom order layouts. These labes will
be used by the helpers when querying channels by name or
describing the layout.
It's the duration of this media, should not take account of
editlist.
---
libavformat/movenc.c | 9 +++--
tests/ref/fate/movenc | 2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0f912dd012..643beac6f2 100644
--- a/libavfor
On Fri, 17 Dec 2021, Zhao Zhili wrote:
It's the duration of this media, should not take account of
editlist.
---
libavformat/movenc.c | 9 +++--
tests/ref/fate/movenc | 2 +-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0f912
It's the duration of this media, should not take account of
editlist.
---
libavformat/movenc.c | 2 +-
tests/ref/fate/movenc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0f912dd012..f76ef430cf 100644
--- a/libavformat/mov
mvhd and tkhd present the post-editlist duration, while mdhd should
have the pre-editlist duration. Regression since c2424b1f3.
---
libavformat/movenc.c | 2 +-
tests/ref/fate/movenc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
Quoting Pierre-Anthony Lemieux (2021-12-15 21:41:25)
> On Wed, Dec 15, 2021 at 12:20 PM Anton Khirnov wrote:
> >
> > Quoting Pierre-Anthony Lemieux (2021-12-15 01:17:26)
> > > >
> > > > Now the question is whether a malicious attacker can craft those two
> > > > files to get access to anything the
This is the first patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
* v2: None
* v3: None
* v4: None
* Implement support for AudioConverter
* Switch to AudioConverter's API to convert unsupported PCM
formats (non-interleaved, non-packed)
This is the second patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
v2: None
v3: Switched queue implementation to CMSimpleQueue
v4: None
This patch fixes the concurrency model. Avfoundation runs its own
producing thread to send produced fr
This is the third patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
v2: None
v3:
* Switched unique ID to use system-prodvided unique ID
* Implemented unique IDs for screen capture
v4: Cleanup
This patch adds a unique ID to avfoundatio
On Fri, Dec 03, 2021 at 06:19:55PM +0100, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -16777216 * 131 cannot be represented in type
> 'int'
> Fixes:
> 23835/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5669943160078336
> Fixes:
> 41101/clusterfuzz-testcase-minim
(Apologies for the previously mangled message, I’m still honing my tools here!)
This is the first patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
* v2: None
* v3: None
* v4: None
* v5: Fix indentation/wrapping
* Implement support for Audi
(Apologies for the previously mangled message, I’m still honing my tools here!)
This is the second patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
v2: None
v3: Switched queue implementation to CMSimpleQueue
v4: None
v5: Fix indentation/wra
(Apologies for the previously mangled message, I’m still honing my tools here!)
This is the third patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
v2: None
v3:
* Switched unique ID to use system-prodvided unique ID
* Implemented unique
Romain Beauxis:
> (Apologies for the previously mangled message, I’m still honing my tools
> here!)
>
Things like this and the changelog do not really belong into a commit
message to be committed; the proper place for such comments is between
the "---" and the "libavdevice/avfoundation.m | 250
+
Hi all,
Can I have an update on this patch submission ?
Is something required to be done before it can be merged ?
Thanks you,
Marc-Antoine
Le ven. 3 déc. 2021 à 10:57, Marc-Antoine Arnaud
a écrit :
>
> ---
> doc/demuxers.texi | 10 ++
> libavformat/mxf.h | 3 +
> libavformat/mxfde
On Fri, 17 Dec 2021, Michael Niedermayer wrote:
On Fri, Dec 17, 2021 at 01:04:19AM +0100, Marton Balint wrote:
On Thu, 16 Dec 2021, James Almer wrote:
Resending the first two patches only, since this is meant to
show the implementation of one of the several suggestions made
in the previo
On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote:
Hi all,
Can I have an update on this patch submission ?
Is something required to be done before it can be merged ?
New channel layout API is on its way, which makes in-demuxer channel
reordering uneeded. Therefore the reordering option should
On Fri, 17 Dec 2021, Zhao Zhili wrote:
mvhd and tkhd present the post-editlist duration, while mdhd should
have the pre-editlist duration. Regression since c2424b1f3.
---
libavformat/movenc.c | 2 +-
tests/ref/fate/movenc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Thanks, this loo
On Thu, 16 Dec 2021, James Almer wrote:
On 12/16/2021 9:04 PM, Marton Balint wrote:
On Thu, 16 Dec 2021, James Almer wrote:
Resending the first two patches only, since this is meant to
show the implementation of one of the several suggestions made
in the previous set that need to b
On 12/17/2021 4:20 PM, Marton Balint wrote:
On Thu, 16 Dec 2021, James Almer wrote:
On 12/16/2021 9:04 PM, Marton Balint wrote:
On Thu, 16 Dec 2021, James Almer wrote:
Resending the first two patches only, since this is meant to
show the implementation of one of the several sugges
On Fri, Dec 17, 2021 at 12:54 AM Martin Storsjö wrote:
> On Thu, 16 Dec 2021, Aman Karmani wrote:
>
> > From: Aman Karmani
> >
> > Signed-off-by: Aman Karmani
> > ---
> > .gitignore | 3 +++
> > configure | 8 +++-
> > ffbuild/common.mak | 9 +
> > 3 files changed, 19
From: Aman Karmani
Signed-off-by: Aman Karmani
Signed-off-by: Philip Langdale
---
libavfilter/vf_yadif_cuda.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/libavfilter/vf_yadif_cuda.c b/libavfilter/vf_yadif_cuda.c
index da1ab5a8ff..685b8a2035 100644
--
From: Aman Karmani
Reviewed-by: Ridley Combs
Signed-off-by: Aman Karmani
---
.gitignore | 3 +++
configure | 12 +++-
ffbuild/common.mak | 9 +
3 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 9ed24b542e..1a5bb29ad5
From: Aman Karmani
Reviewed-by: Ridley Combs
Signed-off-by: Aman Karmani
---
libavutil/objc.h | 32
1 file changed, 32 insertions(+)
create mode 100644 libavutil/objc.h
diff --git a/libavutil/objc.h b/libavutil/objc.h
new file mode 100644
index 00..0d
From: Aman Karmani
Reviewed-by: Ridley Combs
Signed-off-by: Aman Karmani
---
libavfilter/metal/utils.h | 35 +++
libavfilter/metal/utils.m | 73 +++
2 files changed, 108 insertions(+)
create mode 100644 libavfilter/metal/utils.h
create mode
From: Aman Karmani
deinterlaces CVPixelBuffers, i.e. AV_PIX_FMT_VIDEOTOOLBOX frames
for example, an interlaced mpeg2 video can be decoded by avcodec,
uploaded into a CVPixelBuffer, deinterlaced by Metal, and then
encoded to h264 by VideoToolbox as follows:
ffmpeg \
-init_hw_devic
Op vr 17 dec. 2021 om 12:43 schreef Michael Niedermayer
:
> > +sub->coefs[i] = sub->coefs[i]*0.98;
>
> This is ugly, the amount of actual overflow should be known at this point
> so no arbitrary downscale should be needed here
Dec 17, 2021, 3:25 PM by an...@khirnov.net:
> Quoting Pierre-Anthony Lemieux (2021-12-15 21:41:25)
>
>> On Wed, Dec 15, 2021 at 12:20 PM Anton Khirnov wrote:
>> >
>> > Quoting Pierre-Anthony Lemieux (2021-12-15 01:17:26)
>> > > >
>> > > > Now the question is whether a malicious attacker can craft
On Fri, Dec 17, 2021 at 12:54 PM Lynne wrote:
>
> Dec 17, 2021, 3:25 PM by an...@khirnov.net:
>
> > Quoting Pierre-Anthony Lemieux (2021-12-15 21:41:25)
> >
> >> On Wed, Dec 15, 2021 at 12:20 PM Anton Khirnov wrote:
> >> >
> >> > Quoting Pierre-Anthony Lemieux (2021-12-15 01:17:26)
> >> > > >
> >
p...@sandflow.com:
> From: Pierre-Anthony Lemieux
>
> Signed-off-by: Pierre-Anthony Lemieux
> ---
>
> Notes:
> The IMF demuxer accepts as input an IMF CPL. The assets referenced by the
> CPL can be
> contained in multiple deliveries, each defined by an ASSETMAP file:
>
> ffmpe
On 17 Dec 2021, at 16:12, Romain Beauxis wrote:
This is the third patch of a series of 3 that cleanup and enhance the
avfoundation implementation for libavdevice.
Changes:
v2: None
v3:
* Switched unique ID to use system-prodvided unique ID
* Implemented unique IDs for screen capture
v4:
Signed-off-by: Michael Niedermayer
---
libavcodec/tiff.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index 870e0666aa3..9af602eef70 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -2155,6 +2155,7 @@ static av_cold int tiff_init(AVCodecContex
Fixes: OOM
Fixes:
42263/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-565619113984
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/tiff.c | 15 ---
1 file chang
Fixes: Timeout
Fixes:
42258/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5540144118104064
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/ccaption_dec.c | 3 ++-
1 file ch
Signed-off-by: Michael Niedermayer
---
libavcodec/ass.c | 32 ++--
libavcodec/ass.h | 7 +++
2 files changed, 33 insertions(+), 6 deletions(-)
diff --git a/libavcodec/ass.c b/libavcodec/ass.c
index 725e4d42ba1..d0a4d678bb4 100644
--- a/libavcodec/ass.c
+++ b/liba
Michael Niedermayer:
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/ass.c | 32 ++--
> libavcodec/ass.h | 7 +++
> 2 files changed, 33 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/ass.c b/libavcodec/ass.c
> index 725e4d42ba1..d0a4d678bb4 100
Andreas Rheinhardt:
> They test libavfilter internal API, so they should be libavfilter
> test programs (which implies: linked statically to libavfilter
> to access internal APIs and linked normally (statically or dynamically
> depending upon the build configuration) against all the other libs).
>
Andreas Rheinhardt:
> There is no mxfenc dependency any more since commit
> b9a26b9d55f77ebbff3596e46be54bb5fed469d3.
> Also remove a dnxhddata.h inclusion in mxfenc that was forgotten
> in the very same commit.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/Makefile | 2 --
> libavfo
Sebastian Kirmayer:
> The previous implementation swapped the two halves of the plaintext. The
> existing tests only decrypted data with a plaintext of all zeroes, which is
> not affected by swapping the halves. Tests which detect the old buggy behavior
> have been added.
>
> Signed-off-by: Sebast
53 matches
Mail list logo
