> -Original Message-
> From: ffmpeg-devel On Behalf Of Andreas
> Rheinhardt
> Sent: Friday, November 26, 2021 2:16 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 09/16] avfilter/overlaytextsubs: Add
> overlaytextsubs and textsubs2video filters
>
> Changes to
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Andreas
>> Rheinhardt
>> Sent: Friday, November 26, 2021 11:35 AM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
>> subtitle handling
>
> Hi Andreas,
>
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Andreas
>> Rheinhardt
>> Sent: Friday, November 26, 2021 2:16 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH v16 09/16] avfilter/overlaytextsubs: Add
>> overlaytextsubs and textsubs2video fi
Quoting Soft Works (2021-11-26 23:29:54)
>
> > This is breaking ABI.
>
> From earlier discussions, I think it's clear that the whole patchset cannot
> go without breakage.
Can you point me at the relevant arguments or restate them here?
So far I see no fundamental reason why this needs to break
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 9:45 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Soft Works (2
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 9:45 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Soft Works (2
Quoting Soft Works (2021-11-25 18:53:24)
> @@ -759,9 +802,39 @@ void av_frame_move_ref(AVFrame *dst, AVFrame *src);
> * recommended to pass 0 here unless you know what you are
> doing.
> *
> * @return 0 on success, a negative AVERROR on error.
> + *
> + * @deprecated Use @ref av
Quoting Soft Works (2021-11-26 19:25:17)
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Anton
> > Khirnov
> > Sent: Friday, November 26, 2021 5:21 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
> > subtitle
Quoting Soft Works (2021-11-27 08:18:37)
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Andreas
> > Rheinhardt
> > Sent: Friday, November 26, 2021 2:02 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v16 08/16] fftools/ffmpeg: Replace
> > sub2video wit
Quoting Soft Works (2021-11-27 09:49:56)
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Anton
> > Khirnov
> > Sent: Saturday, November 27, 2021 9:45 AM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AV
Anton Khirnov:
> Quoting Soft Works (2021-11-25 18:53:24)
>> @@ -759,9 +802,39 @@ void av_frame_move_ref(AVFrame *dst, AVFrame *src);
>> * recommended to pass 0 here unless you know what you are
>> doing.
>> *
>> * @return 0 on success, a negative AVERROR on error.
>> + *
>> + *
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 9:52 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Soft Works (2021-11-25 18:53:24)
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Anton
>> Khirnov
>> Sent: Saturday, November 27, 2021 9:45 AM
>> To: FFmpeg development discussions and patches
>> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for
>> subtitle handling
>>
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 10:04 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v16 08/16] fftools/ffmpeg: Replace
> sub2video with subtitle frame filtering
>
> Qu
Quoting Andreas Rheinhardt (2021-11-27 10:06:35)
> Anton Khirnov:
> >
> > Not sure whether this was asked already - why do we need this new
> > function? Seems to me you can accomplish the same thing by just adding
> > the type field to AVFrame. Then
> > - if type is AVMEDIA_TYPE_SUBTITLE -> alloc
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 10:01 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Soft Works (
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Anton
>> Khirnov
>> Sent: Saturday, November 27, 2021 10:04 AM
>> To: FFmpeg development discussions and patches
>> Subject: Re: [FFmpeg-devel] [PATCH v16 08/16] fftools/ffmpeg: Replace
>> sub2video with subtitle f
> -Original Message-
> From: ffmpeg-devel On Behalf Of Andreas
> Rheinhardt
> Sent: Saturday, November 27, 2021 10:29 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 08/16] fftools/ffmpeg: Replace
> sub2video with subtitle frame filtering
>
> Soft Works:
> >
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 10:25 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Andreas Rhei
Anton Khirnov:
> Quoting Andreas Rheinhardt (2021-11-27 10:06:35)
>> Anton Khirnov:
>>>
>>> Not sure whether this was asked already - why do we need this new
>>> function? Seems to me you can accomplish the same thing by just adding
>>> the type field to AVFrame. Then
>>> - if type is AVMEDIA_TYPE_
Andreas Rheinhardt (12021-11-27):
> I actually
> had one more patchset that breaks the avpriv-ABI (i.e. it would not
> force user apps linking to our libs to be rebuilt; rebuilding the ffmpeg
> libs is enough). Will see how that fares.
W
> -Original Message-
> From: ffmpeg-devel On Behalf Of Andreas
> Rheinhardt
> Sent: Friday, November 26, 2021 4:09 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate
> subtitle encoders to frame-based API and provide a compatibili
Nicolas George:
> Andreas Rheinhardt (12021-11-27):
>> I actually
>> had one more patchset that breaks the avpriv-ABI (i.e. it would not
>> force user apps linking to our libs to be rebuilt; rebuilding the ffmpeg
>> libs is enough). Will s
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nicolas
> George
> Sent: Saturday, November 27, 2021 10:55 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Andreas Rheinhardt
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Andreas
>> Rheinhardt
>> Sent: Friday, November 26, 2021 4:09 PM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate
>> subtitle encoders to frame-based API and
> -Original Message-
> From: ffmpeg-devel On Behalf Of Andreas
> Rheinhardt
> Sent: Saturday, November 27, 2021 11:04 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate
> subtitle encoders to frame-based API and provide a compatib
Soft Works:
>
>
>> -Original Message-
>> From: ffmpeg-devel On Behalf Of Andreas
>> Rheinhardt
>> Sent: Saturday, November 27, 2021 11:04 AM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH v16 15/16] avcodec/subtitles: Migrate
>> subtitle encoders to frame-based API
Quoting Andreas Rheinhardt (2021-11-27 10:42:31)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2021-11-27 10:06:35)
> >> Anton Khirnov:
> >>>
> >>> Not sure whether this was asked already - why do we need this new
> >>> function? Seems to me you can accomplish the same thing by just adding
> >>>
Quoting Nicolas George (2021-11-27 10:54:38)
> Andreas Rheinhardt (12021-11-27):
> >I actually
> > had one more patchset that breaks the avpriv-ABI (i.e. it would not
> > force user apps linking to our libs to be rebuilt; rebuilding the ff
Anton Khirnov (12021-11-27):
> > We should lock the library versions together so that we do not have to
> > worry about the internal ABI. This is a problem we force on ourselves
> > that brings very little benefit, probably benefit nobody actually cares
> > about.
> I disagree, as I'm sure you know
> -Original Message-
> From: ffmpeg-devel On Behalf Of Anton
> Khirnov
> Sent: Saturday, November 27, 2021 11:33 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v16 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Quoting Andreas Rhei
> -Original Message-
> From: ffmpeg-devel On Behalf Of Nicolas
> George
> Sent: Saturday, November 27, 2021 11:39 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v15 01/16] global: Prepare AVFrame for
> subtitle handling
>
> Anton Khirnov (1202
It is already set in new_output_stream().
Signed-off-by: Andreas Rheinhardt
---
fftools/ffmpeg_opt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 8a0cad3f62..9fdb2d4967 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -2214,7
Signed-off-by: Andreas Rheinhardt
---
libavcodec/decode.c | 4 +---
libavcodec/dvbsubdec.c | 8 ++--
libavcodec/g723_1enc.c | 3 +--
libavformat/hdsenc.c | 6 ++
libavformat/mpegts.c | 3 +--
libavformat/oggparsevorbis.c | 3 +--
libavformat/rtsp.c
Andreas Rheinhardt (12021-11-27):
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/decode.c | 4 +---
> libavcodec/dvbsubdec.c | 8 ++--
> libavcodec/g723_1enc.c | 3 +--
> libavformat/hdsenc.c | 6 ++
> libavformat/mpegts.c | 3 +--
> libavforma
Anton Khirnov (12021-11-24):
> Maybe. I named it FLAG_METADATA first, but then started wondering
> whether people wouldn't associate it with just AVFrame.metadata rather
> than all other 'meta' fields.
> More opinions on this (and also the exact definition of this flag)
> welcome.
I usually name t
On Sat, Nov 27, 2021 at 12:58:30AM +0100, Michael Niedermayer wrote:
> On Fri, Nov 26, 2021 at 10:01:23PM +, Soft Works wrote:
> >
> >
> > > -Original Message-
> > > From: ffmpeg-devel On Behalf Of Michael
> > > Niedermayer
> > > Sent: Friday, November 26, 2021 10:26 PM
> > > To: FFm
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, November 27, 2021 1:19 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of
> attachment streams (extradata_size)
>
Hi,
On Fri, Nov 26, 2021 at 4:52 PM John-Paul Stewart <
jpstew...@personalprojects.net> wrote:
> There were no single channel examples and no 8 bit
> examples.
>
> I have created four clips with SGI's original 'moviemaker' utility (so
> they are guaranteed to be correctly formatted) to reverse en
Fixes a mistake in dea673d0d548c864ec85f9260d8900d944ef7a2a.
GCC emitted a -Wint-in-bool-context warning because of that.
Reviewed-by: Soft Works
Signed-off-by: Andreas Rheinhardt
---
Will apply this tonight unless there are objections.
libavfilter/vf_paletteuse.c | 2 +-
1 file changed, 1 ins
On Sat, Nov 27, 2021 at 01:12:31PM +, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Michael
> > Niedermayer
> > Sent: Saturday, November 27, 2021 1:19 PM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH v3 1
Currently they are ordered as-written (i.e. by increasing position);
in case av_interleaved_write_frame() is used, this is (mostly)
the same as ordered by increasing dts.
Yet the Matroska specification strongly recommends (SHOULD) that
the CuePoints be sorted by CueTime. mkvalidator warns when they
On Fri, Nov 26, 2021 at 04:52:14PM -0500, John-Paul Stewart wrote:
> Adds support for reading audio sample size from the data instead of
> assuming all audio is 16 bits per sample.
>
> Signed-off-by: John-Paul Stewart
> ---
> libavformat/mvdec.c | 18 +++---
> 1 file changed, 15 inse
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, November 27, 2021 3:13 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v3 1/1] fftools/ffprobe: print size of
> attachment streams (extradata_size)
>
> -Original Message-
> From: Andreas Rheinhardt
> Sent: Saturday, November 27, 2021 3:03 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt ; Soft Works
>
> Subject: [PATCH] avfilter/vf_paletteuse: Add missing parentheses
>
> Fixes a mistake in dea673d0d548c864ec85f9260d8900d94
On Thu, Nov 25, 2021 at 02:30:33PM -0500, Alex Xu (Hello71) wrote:
> The check for m->size >= 0xF000 is intended to avoid skipping too much
> garbage data between JPEG frames in test_roman (thus missing next SOI),
> but it erroneously also skips valid markers between SOI and SOS. Instead
> of this,
On Thu, Nov 25, 2021 at 02:36:46PM -0500, Alex Xu (Hello71) wrote:
> Due to reasons, mpv doesn't pass filename when probing. mpv also sets
> default probescore threshold to 26. Since the current jpeg_probe
> implementation returns 25 until EOI, it means that the whole image needs
> to be probed to
Andreas Rheinhardt:
> Fixes Coverity issue #1493344.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/vqavideo.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/libavcodec/vqavideo.c b/libavcodec/vqavideo.c
> index 5466e25cdf..61f0a2c950 100644
> --- a/lib
New in V17
- Applied almost all suggestions that were made (thanks everybody!)
- Split the initial commit, no longer moving the legacy structs (AVSubtitle..)
- Use the regular encoding API for subtitles
- Updated subtitle encoders to handle packet allocation
- Removed compatibility layer for acces
Signed-off-by: softworkz
---
libavcodec/avcodec.h | 19 +--
libavutil/subfmt.h | 58
2 files changed, 59 insertions(+), 18 deletions(-)
create mode 100644 libavutil/subfmt.h
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index
Root commit for adding subtitle filtering capabilities.
In detail:
- Add type (AVMediaType) field to AVFrame
Replaces previous way of distinction which was based on checking
width and height to determine whether a frame is audio or video
- Add subtitle fields to AVFrame
- Add new struct AVSubt
- Add avcodec_decode_subtitle3 which takes subtitle frames,
serving as compatibility shim to legacy subtitle decoding
- Add additional methods for conversion between old and new API
Signed-off-by: softworkz
---
libavcodec/avcodec.h| 8 +-
libavcodec/codec_desc.c | 11 +++
libavcodec/cod
Signed-off-by: softworkz
---
libavcodec/Makefile | 56 +++
libavcodec/ass.h | 147 ++
libavcodec/assdec.c | 2 +-
libavcodec/assenc.c | 2 +-
libavcodec/ccaption_dec
Signed-off-by: softworkz
---
libavcodec/assenc.c| 90 +
libavcodec/avcodec.h | 5 +-
libavcodec/dvbsubenc.c | 96 +--
libavcodec/dvdsubenc.c | 100 +++-
libavcodec/encode.c| 63 +
Signed-off-by: softworkz
---
fftools/ffplay.c | 102 +-
fftools/ffprobe.c | 48 ++
2 files changed, 78 insertions(+), 72 deletions(-)
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index e7b20be76b..0af32888da 100644
--- a/fftoo
Signed-off-by: softworkz
---
libavfilter/vf_subtitles.c | 54 +-
1 file changed, 42 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c
index 377160c72b..a240cbd415 100644
--- a/libavfilter/vf_subtitles.c
+++ b/l
Analog to avfilter/video.c and avfilter/audio.c
Signed-off-by: softworkz
---
libavfilter/Makefile| 1 +
libavfilter/avfilter.c | 4 +++
libavfilter/internal.h | 1 +
libavfilter/subtitles.c | 63 +
libavfilter/subtitles.h | 44
Signed-off-by: softworkz
---
libavfilter/avfilter.c | 8 +---
libavfilter/avfilter.h | 11 +++
libavfilter/avfiltergraph.c | 5 +
libavfilter/formats.c | 22 ++
libavfilter/formats.h | 3 +++
libavfilter/internal.h | 18 +++
Signed-off-by: softworkz
---
configure| 2 +-
libavfilter/allfilters.c | 2 ++
libavfilter/buffersink.c | 54 ++
libavfilter/buffersink.h | 7
libavfilter/buffersrc.c | 72
libavfilter/buffersrc.h | 1
- overlaygraphicsubs (VS -> V)
Overlay graphic subtitles onto a video stream
- graphicsub2video {S -> V)
Converts graphic subtitles to video frames (with alpha)
Gets auto-inserted for retaining compatibility with
sub2video command lines
Signed-off-by: softworkz
---
doc/filters.texi
This commit actually enables subtitle filtering in ffmpeg by
sending and receiving subtitle frames to and from a filtergraph.
The heartbeat functionality from the previous sub2video implementation
is retained and applied to all subtitle frames (bitmap, text, ..).
The other part of sub2video funct
This fix targets (rare) cases where multiple input pads have a
.filter_frame function. ff_request_frame_to_filter needs
to call ff_request_frame with the correct input pad
instead of the hardcoded first one.
Signed-off-by: softworkz
---
libavfilter/avfilter.c | 18 +-
1 file chan
- overlaytextsubs {VS -> V)
Overlay text subtitles onto a video stream.
- textsubs2video {S -> V)
Converts text subtitles to video frames
Signed-off-by: softworkz
---
configure| 2 +
doc/filters.texi | 113 ++
libavfilter/Makefile |
- textmod {S -> S)
Modify subtitle text in a number of ways
- censor {S -> S)
Censor subtitles using a word list
- show_speaker {S -> S)
Prepend speaker names from ASS subtitles to the visible text lines
Signed-off-by: softworkz
---
doc/filters.texi | 206
libavfilte
- stripstyles {S -> S)
Remove all inline styles from subtitle events
Signed-off-by: softworkz
---
doc/filters.texi | 37 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/sf_stripstyles.c | 196 +++
4 fi
- splitcc {V -> VS)
Extract closed-caption (A53) data from video
frames as subtitle Frames
ffmpeg -y -loglevel verbose -i
"https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts";
-filter_complex
"[0:v]splitcc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs"
outpu
Signed-off-by: softworkz
---
configure| 1 +
doc/filters.texi | 55 +
libavfilter/Makefile | 2 +
libavfilter/allfilters.c | 1 +
libavfilter/sf_graphicsub2text.c | 354 +++
5 files changed, 413 ins
Signed-off-by: softworkz
---
configure | 1 +
doc/filters.texi | 164 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/sf_subscale.c | 883 ++
5 files changed, 1050 insertions(+)
create mode 1
Don't mark all streams as finished, instead make sync_opts keep track of the
stream's duration, and set recording_time to it, same as in transcoding paths.
Fixes tickets #9512 and #9513.
Signed-off-by: James Almer
---
fftools/ffmpeg.c | 11 ---
1 file changed, 4 insertions(+), 7 deletio
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 67 +++
libavfilter/Makefile | 1 +
libavfilter/af_adynamicequalizer.c | 287 +
libavfilter/allfilters.c | 1 +
4 files changed, 356 insertions(+)
create mode 100644
On Sun, Sep 5, 2021 at 8:37 AM Timo Rothenpieler
wrote:
> On 05.09.2021 20:02, Dylan Fernando wrote:
> >
> > Impossible to convert between the formats supported by the filter 'graph
> 0
> > input from stream 0:0' and the filter 'auto_scale_0'
> >
> > Thread 1 "ffmpeg" received signal SIGSEGV, Seg
71 matches
Mail list logo
