Re: [FFmpeg-devel] [PATCH 2/2] swscale/utils: Improve return codes of sws_setColorspaceDetails()

2021-10-23 Thread Michael Niedermayer
On Fri, Oct 22, 2021 at 10:55:25PM -0300, James Almer wrote: > On 10/22/2021 6:45 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libswscale/utils.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libswscale/utils.c b/libswsc

Re: [FFmpeg-devel] [PATCH 1/2] swscale/utils: Set all threads to the same colorspace even on failure

2021-10-23 Thread Michael Niedermayer
On Fri, Oct 22, 2021 at 10:53:07PM -0300, James Almer wrote: > On 10/22/2021 6:45 PM, Michael Niedermayer wrote: > > Fixes: ./ffplay dav.y4m -vf "scale=hd1080:threads=4" > > Found-by: Paul > > Signed-off-by: Michael Niedermayer > > --- > > libswscale/utils.c | 5 +++-- > > 1 file changed, 3 ins

[FFmpeg-devel] [PATCH 2/2] swscale/swscale: Improve *ColorspaceDetails() doxy

2021-10-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libswscale/swscale.h | 8 1 file changed, 8 insertions(+) diff --git a/libswscale/swscale.h b/libswscale/swscale.h index 59610d03426..daa53dc01ee 100644 --- a/libswscale/swscale.h +++ b/libswscale/swscale.h @@ -318,14 +318,22 @@ unsigned int sws_re

[FFmpeg-devel] [PATCH 1/2] swscale/utils: Improve return codes of sws_setColorspaceDetails()

2021-10-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 3752c3ec38c..c726922527b 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -995,7 +995,10 @@ int sws_setColorsp

Re: [FFmpeg-devel] [PATCH] avfilter/vf_guided: support enhanced guided filter

2021-10-23 Thread Xuewei Meng
I would like to explain the supported modes in the guided filter, (1) Basic mode shows better denoising performance compared to bilateral filter and can be applied in many applications such as detail enhancement, dehazing, and so on, which is illustrated in paper http://kaiminghe.com/eccv10/. (2) F

Re: [FFmpeg-devel] [PATCH] avfilter/vf_guided: support enhanced guided filter

2021-10-23 Thread Paul B Mahol
On Sat, Oct 23, 2021 at 4:56 AM Xuewei Meng wrote: > I would like to explain the supported modes in the guided filter, > (1) Basic mode shows better denoising performance compared to bilateral > filter and can be applied in many applications such as detail enhancement, > dehazing, and so on, whic

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread James Almer
On 10/21/2021 10:48 AM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis --- * The NAL reordering approach is a result of discussions with Anton and James a few months ago. * I've put the NAL reordering in ff_h2645_packet_split, rather than a bitstream filter for a few reasons:

[FFmpeg-devel] [PATCH] avfilter/vf_owdenoise: relicense my code

2021-10-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/vf_owdenoise.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_owdenoise.c b/libavfilter/vf_owdenoise.c index f15baf7e084..bb99e8f33c4 100644 --- a/libavfilter/vf_owdenoise.c +++ b/libavfilter/vf_owdenoise.c @@ -19,6 +19,1

[FFmpeg-devel] [PATCH] Fix typo in pixel format warning message

2021-10-23 Thread Zack Bloom
--- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 367b0ea..bc42673 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1287,7 +1287,7 @@ av_cold int sws_init_context(SwsContext *c, SwsFilter *srcFilter

[FFmpeg-devel] [PATCH] swscale/utils: Fix typo in pixel format warning message

2021-10-23 Thread Zack Bloom
--- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 367b0ea..bc42673 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1287,7 +1287,7 @@ av_cold int sws_init_context(SwsContext *c, SwsFilter *srcFilter

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add Dolby Vision RPU side data type

2021-10-23 Thread Derek Buitenhuis
On 10/22/2021 11:02 PM, Jan Ekström wrote: > DoVi Profile 5 and 7 rendering requires the data within these RPU > entities, AFAIK (as it contains various values to correctly configure > the custom color space). So software such as libplacebo where haasn > has made efforts towards implementing the no

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 3:18 PM, James Almer wrote: > 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and > nuh_temporal_id 0. > > forbidden_zero_bit= 0 > nal_unit_type = 10 > nuh_layer_id = 00 > nuh_temporal_id_plus1 =001 > > So the last two checks

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread James Almer
On 10/23/2021 2:52 PM, Derek Buitenhuis wrote: On 10/23/2021 3:18 PM, James Almer wrote: 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and nuh_temporal_id 0. forbidden_zero_bit= 0 nal_unit_type = 10 nuh_layer_id = 00 nuh_temporal_id_plus1 =

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Jan Ekström
On Sat, Oct 23, 2021 at 9:16 PM James Almer wrote: > > On 10/23/2021 2:52 PM, Derek Buitenhuis wrote: > > On 10/23/2021 3:18 PM, James Almer wrote: > >> 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and > >> nuh_temporal_id 0. > >> > >> forbidden_zero_bit= 0 > >> nal_

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 7:15 PM, James Almer wrote: >> Do'h, will fix. > > That being said, would Dolby RPU NALUs like this using other values for > temporal and layer id be valid? Or can we just assume that's never > happening? They also use 63 for an EL, according to other codebases an docs. I didn't i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 7:25 PM, Jan Ekström wrote: > Since effectively D has taken over NAL unit 62 for this stuff, just > call it RPU_BUFFER or so, and take in everything NAL unit 62? Sounds OK to me if others are OK. - Derek ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH v3] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-23 Thread Leo Izen
On Fri, Oct 22, 2021 at 5:38 PM Michael Niedermayer wrote: > its 2 separate libraries they are often shiped by distributions in > separate packages. libavformat can depend on libavcodec but not the > other way around. libavcodec could get upgraded without libavformat > separate patches make it mor