[FFmpeg-devel] [PATCH 1/3] avformat/dashenc: enabling streaming automatically for ldash

2021-10-21 Thread Zhao Zhili
There is a little chance that user specified contradicted options like -streaming 0 -ldash 1, however, it's more likely that user didn't know or forgot to enable streaming for ldash. So enabling streaming automatically to make the feature easier to use, similar like enable FF_MOV_FLAG_FRAGMENT/EMPT

[FFmpeg-devel] [PATCH 2/3] avformat/dashenc: enabling streaming and hls_playlist for lhls

2021-10-21 Thread Zhao Zhili
Try to make the feature easier to use, especially since the user have enabled -strict experimental manually. The user shouldn't be surprised that hls_playlist is enabled for lhls automatically, so change the log level from warning to info for that. --- doc/muxers.texi | 2 +- libavformat/das

[FFmpeg-devel] [PATCH 3/3] doc/muxers: note on Apple's version LHLS for lhls option

2021-10-21 Thread Zhao Zhili
--- doc/muxers.texi | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 67c281d171..a24b09a387 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -362,12 +362,13 @@ Ignore IO errors during open and write. Useful for long-duration r

Re: [FFmpeg-devel] [PATCH v1] libavcodec/flac_parser: Validate subframe zero bit and type

2021-10-21 Thread Mattias Wadman
On Wed, Oct 20, 2021 at 11:07 PM Michael Niedermayer wrote: > On Wed, Oct 13, 2021 at 06:15:26PM +0200, Mattias Wadman wrote: > > Reduces the risk of finding false frames that happens to have valid > values and CRC. > > > > Fixes ticket #9185 ffmpeg flac decoder incorrectly finds junk frame > > h

[FFmpeg-devel] [PATCH] avutil: deprecate AVRational field inside AVOption::default_val

2021-10-21 Thread Zhao Zhili
It's not being used. For backward compatibility, AV_OPT_TYPE_RATIONAL cannot be changed to use it. --- libavutil/opt.h | 2 ++ libavutil/version.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 2820435eec..bf1a8b84fa 100644 --- a/libavutil/opt.h

Re: [FFmpeg-devel] [PATCH v1] libavcodec/flac_parser: Validate subframe zero bit and type

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 10:46:18AM +0200, Mattias Wadman wrote: > On Wed, Oct 20, 2021 at 11:07 PM Michael Niedermayer > wrote: > > > On Wed, Oct 13, 2021 at 06:15:26PM +0200, Mattias Wadman wrote: > > > Reduces the risk of finding false frames that happens to have valid > > values and CRC. > > >

Re: [FFmpeg-devel] [PATCH v1] libavcodec/flac_parser: Validate subframe zero bit and type

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 01:00:20PM +0200, Michael Niedermayer wrote: > On Thu, Oct 21, 2021 at 10:46:18AM +0200, Mattias Wadman wrote: > > On Wed, Oct 20, 2021 at 11:07 PM Michael Niedermayer > > > > wrote: > > > > > On Wed, Oct 13, 2021 at 06:15:26PM +0200, Mattias Wadman wrote: > > > > Reduces

Re: [FFmpeg-devel] [PATCH] avfilter/vf_eq: add support for alpha channel

2021-10-21 Thread Konstantin Mamalakis
Thanks, I'd rather _not_ have my real name on it On Wed, 20 Oct 2021 at 15:19, Michael Niedermayer wrote: > On Mon, Oct 18, 2021 at 02:29:48PM +0300, konstan...@boffins.se wrote: > > From: KM > > > > --- > > libavfilter/vf_eq.c | 15 --- > > 1 file changed, 8 insertions(+), 7 delet

[FFmpeg-devel] [PATCH] avcodec/flac_parser: Consider AV_INPUT_BUFFER_PADDING_SIZE

2021-10-21 Thread Michael Niedermayer
Fixes: out if array read Fixes: 40109/clusterfuzz-testcase-minimized-ffmpeg_dem_FLAC_fuzzer-4805686811295744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg CC: Mattias Wadman Signed-off-by: Michael Niedermayer --- libavcodec/flac_parser.c |

Re: [FFmpeg-devel] [PATCH] avcodec/flac_parser: Consider AV_INPUT_BUFFER_PADDING_SIZE

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 02:00:01PM +0200, Michael Niedermayer wrote: > Fixes: out if array read > Fixes: > 40109/clusterfuzz-testcase-minimized-ffmpeg_dem_FLAC_fuzzer-4805686811295744 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > CC:

Re: [FFmpeg-devel] [PATCH 1/2 v2] avformat/mov: Use av_rescale when calculating bit rate

2021-10-21 Thread Michael Niedermayer
On Wed, Oct 20, 2021 at 07:43:30PM +0100, Derek Buitenhuis wrote: > It is less susceptible to overflows. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/mov.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF212

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Adjust threshold for MXPEG

2021-10-21 Thread Michael Niedermayer
On Tue, Oct 12, 2021 at 03:07:34PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 39813/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MXPEG_fuzzer-6010298067189760 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/ttadsp: Fix integer overflows in tta_filter_process_c()

2021-10-21 Thread Michael Niedermayer
On Fri, Oct 15, 2021 at 12:13:23AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 822841647 + 1647055738 cannot be represented > in type 'int' > Fixes: > 39935/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-4592657142251520 > > Found-by: continuous fuzzing proc

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: Document av_rescale_rnd() behavior on non int64 results

2021-10-21 Thread Michael Niedermayer
On Wed, Oct 20, 2021 at 07:44:52PM +0100, Derek Buitenhuis wrote: > On 10/20/2021 7:24 PM, Michael Niedermayer wrote: > > * The operation is mathematically equivalent to `a * b / c`, but writing > > that > > * directly can overflow, and does not support different rounding methods. > > + * If t

Re: [FFmpeg-devel] [PATCH] avfilter/vf_eq: add support for alpha channel

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 02:23:37PM +0300, Konstantin Mamalakis wrote: > Thanks, I'd rather _not_ have my real name on it ok ill apply the patch as is then thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-21 Thread Brad Hards
On Tuesday, 19 October 2021 9:53:50 AM AEDT James Almer wrote: > > The problem i guess is in the following line: > > > > sei_payload->payload = side_data->data; > > > > Which should be an av_memdup() or similar, because side_data->data is > > the frame's side data, and by the time the encoder tri

[FFmpeg-devel] [PATCH 1/3] avutil: Add Dolby Vision RPU side data type

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- All known encoders, etc. expect RPUs in this format, to my knowledge. (There is no spec for parsing the RPUs, even privately, and not a single piece of software that would benefit from that - and it is a legal minefield which I am not going to touch.) The comme

[FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- * The NAL reordering approach is a result of discussions with Anton and James a few months ago. * I've put the NAL reordering in ff_h2645_packet_split, rather than a bitstream filter for a few reasons: * I don't think having a decoder's behavior rely on

[FFmpeg-devel] [PATCH 3/3] fate: Add test for Dolby Vision RPU side data

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- File: https://www.dropbox.com/s/tjnm3vggdc6s7v3/dv84.mov?dl=0 We generated this file ourselves with an iPhone; there is no copyright issue. --- tests/fate/hevc.mak| 3 + tests/ref/fate/hevc-dv-rpu | 512 + 2 files

[FFmpeg-devel] [PATCH 0/3] Dolby Vision RPU Side Data

2021-10-21 Thread Derek Buitenhuis
This patch set allows exporting Dolby Vision RPUs as side data, allowing them to be used in transcoding, etc. There are notes in each inividual patch. Derek Buitenhuis (3): avutil: Add Dolby Vision RPU side data type avcodec/hevcdec: Export Dolby Vision RPUs as side data fate: Add test for

[FFmpeg-devel] (no subject)

2021-10-21 Thread ekibun
Hi. I'm investigating in custom IO for HLS playing, and got errors while calling segments. I've compiled libav with `--disable-network` configure and tried custom IO by overriding `io_open` and `io_close` for `AVFormatContext`. Everything goes well until open segments urls. In the function `open

[FFmpeg-devel] [PATCH] avformat/hls: Do not check protocol on hls without network.

2021-10-21 Thread ekibun
--- libavformat/hls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 52a031ed..55fa831b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -637,6 +637,7 @@ static int open_url(AVFormatContext *s, AVIOContext **pb, const char *url, int

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Dont include adaptation field in teletext TS packets.

2021-10-21 Thread Alex Shumsky
>From ETSI EN 300 472 V1.3.1 (2003-05) Specification for conveying ITU-R System >B Teletext in DVB bitstreams: 4.1 Transport Stream (TS) packet format The standard TS packet syntax and semantics are followed, noting the following constraint: - adaptation_field_control only the values "01" and "10

[FFmpeg-devel] [PATCH] avformat/demux: preserve AV_PKT_FLAG_CORRUPT in parse_packet

2021-10-21 Thread Alex Shumsky
If original packet is corrupted, then parsed packet is probably corrupted too. Let the application decide what to do. Signed-off-by: Alex Shumsky --- libavformat/demux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index 6a4b687bf1

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Michael Niedermayer
On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > > > Originally added as a private entry in commit > > 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with > > the comment noting its private state was missed during mer

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer wrote: > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > > On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > > > > > Originally added as a private entry in commit > > > 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grou

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtmp: Implements RTMP reconnect feature

2021-10-21 Thread Alex Converse
> Nowadays when you are streaming to a live platform if the RTMP(s) > server needs to restarted for any reason (ex: deploy new version) > the RTMP connection is interrupted (probably after some draining time). > Facebook will publish a proposal to avoid that by sending a > GoAway message in the RTM

Re: [FFmpeg-devel] [PATCH] avcodec/flac_parser: Consider AV_INPUT_BUFFER_PADDING_SIZE

2021-10-21 Thread Paul B Mahol
LGTM for now ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/flac_parser: Consider AV_INPUT_BUFFER_PADDING_SIZE

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 10:17:25PM +0200, Paul B Mahol wrote: > LGTM for now will apply the improved variant below diff --git a/libavcodec/flac_parser.c b/libavcodec/flac_parser.c index 2c550507fc8..3b27b152fc5 100644 --- a/libavcodec/flac_parser.c +++ b/libavcodec/flac_parser.c @@ -55,6 +55,7 @@

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Michael Niedermayer
On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > wrote: > > > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > > > On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > > > > > > > Originally added as a private e

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer wrote: > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > > wrote: > > > > > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > > > > On Mon, Oct 18, 2021 at

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Fri, Oct 22, 2021 at 12:21 AM Jan Ekström wrote: > > On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer > wrote: > > > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > > > wrote: > > > > > > > > On Wed, Oct 20, 2021 a

Re: [FFmpeg-devel] [PATCH] avcodec/flac_parser: Consider AV_INPUT_BUFFER_PADDING_SIZE

2021-10-21 Thread Mattias Wadman
On Thu, Oct 21, 2021 at 10:35 PM Michael Niedermayer wrote: > On Thu, Oct 21, 2021 at 10:17:25PM +0200, Paul B Mahol wrote: > > LGTM for now > > will apply the improved variant below > > diff --git a/libavcodec/flac_parser.c b/libavcodec/flac_parser.c > index 2c550507fc8..3b27b152fc5 100644 > ---

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Michael Niedermayer
On Fri, Oct 22, 2021 at 12:32:18AM +0300, Jan Ekström wrote: > On Fri, Oct 22, 2021 at 12:21 AM Jan Ekström wrote: > > > > On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer > > wrote: > > > > > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > > > On Thu, Oct 21, 2021 at 8:26

[FFmpeg-devel] [PATCH v3] avcodec/libjxl: add JPEG XL decoding via libjxl

2021-10-21 Thread Leo Izen
Use the external libjxl library to add decoding for JPEG XL images, and add the appropriate image2 muxers and demuxers to read/write JPEG XL image files. --- MAINTAINERS | 2 + configure | 5 + doc/general_contents.texi | 7 + libavcodec/Makefile | 1 +