Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amr*dec: add multichannel support

2021-10-04 Thread Sun Zhenliang
在 2021年10月1日 +0800 22:11,Paul B Mahol ,写道: > On Fri, Oct 1, 2021 at 4:03 PM Sun Zhenliang > wrote: > > > 2021年10月1日 +0800 14:41 Paul B Mahol ,写道: > > > On Fri, Oct 1, 2021 at 3:17 AM Sun Zhenliang > > > > > wrote: > > > > > > > > > > > Sent with a Spark > > > > 2021年10月1日 +0800 05:01 Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-10-04 Thread Andreas Rheinhardt
Roman Arzumanyan: > Thanks for the review, Timo. > > Please find revised patch attached. > Docstring was added, trailing spaces removed, commit message brushed up. > Avfilter minor version bump added. This has lots of duplication with the ordinary scale filter: var_names, enum var_name and enum

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-04 Thread Jan Ekström
On Mon, Oct 4, 2021 at 1:06 AM Michael Niedermayer wrote: > > On Mon, Oct 04, 2021 at 12:25:26AM +0300, Jan Ekström wrote: > > On Sat, Oct 2, 2021 at 2:51 PM Michael Niedermayer > > wrote: > > > > > > On Sat, Oct 02, 2021 at 02:42:52PM +0300, Jan Ekström wrote: > > > > On Sat, Oct 2, 2021 at 1:32

Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: Since mkvmerge 19 has fonts types from RFC 8081 and mkvmerge 58 on windows use new file/magic library

2021-10-04 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 109/218] avfilter/vf_signature: Use formats list instead of query function

2021-10-04 Thread Paul B Mahol
whole patchset LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 109/218] avfilter/vf_signature: Use formats list instead of query function

2021-10-04 Thread Andreas Rheinhardt
Paul B Mahol: > whole patchset LGTM > Thanks for the review. I will apply it in two days in case anyone else wants to chime in. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubsc

Re: [FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-10-04 Thread Roman Arzumanyan
Thanks for the review, Timo. Please find revised patch attached. Docstring was added, trailing spaces removed, commit message brushed up. Avfilter minor version bump added. От: Timo Rothenpieler Отправлено: 28 сентября 2021 г. 22:37 Кому: FFmpeg development discu

Re: [FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-10-04 Thread Roman Arzumanyan
Thanks for the review Andreas, that's indeed helpful. Allow me some time, I'll come back bit later with revised patch. От: ffmpeg-devel от имени Andreas Rheinhardt Отправлено: 4 октября 2021 г. 11:59 Кому: ffmpeg-devel@ffmpeg.org Тема: Re: [FFmpeg-devel] [PATCH

[FFmpeg-devel] [PATCH 1/3] avutil/hwcontext_vaapi: Abuse the AVBuffer API a bit less

2021-10-04 Thread Andreas Rheinhardt
In this case there is no underlying data at all; the actual data has been shoe-horned into the pointer, which does not point to any storage owned by us. So use a size of zero as buffer pool size. (This fixes segfaults if one uses vaapi with memory poisoning enabled; but the memset call in pool_rel

[FFmpeg-devel] [PATCH 2/3] avutil/buffer: Never poison returned buffers

2021-10-04 Thread Andreas Rheinhardt
Poisoning returned buffers is based around the implicit assumption that the contents of said buffers are transient. Yet this is not true for the buffer pools used by the various hardware contexts which store important state in there that needs to be preserved. Furthermore, the current code is also

[FFmpeg-devel] [PATCH 3/3] avutil/buffer: Don't use atomics for AVBufferPool.refcount

2021-10-04 Thread Andreas Rheinhardt
The AVBufferPool is already guarded by a mutex, so one can just move use said mutex to also protect modifying the refcount. Doing so yields a minor decrease in complexity. Signed-off-by: Andreas Rheinhardt --- Currently freeing the entries is serialized; the API documentation does not force us to

[FFmpeg-devel] [PATCH] avcodec/rasc: Fix potential use of uninitialized value

2021-10-04 Thread Andreas Rheinhardt
Fixes Coverity issue #1439566. Signed-off-by: Andreas Rheinhardt --- libavcodec/rasc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/rasc.c b/libavcodec/rasc.c index 7fedf73878..b328e219bb 100644 --- a/libavcodec/rasc.c +++ b/libavcodec/rasc.c @@ -721,6 +721,7 @@ static int deco

Re: [FFmpeg-devel] [PATCH v3 0/5] Support for stream dispositions in MP4

2021-10-04 Thread Jan Ekström
On Mon, Sep 27, 2021 at 1:53 PM Jan Ekström wrote: > > On Mon, Sep 20, 2021 at 6:00 PM Jan Ekström wrote: > > > > Compared to v2: > > * aviobuf changes to make a function useful in MP4 null-delimited string > > parsing into AVBPrint. > > ** Extended read_line_to_bprint to be a more generic read

Re: [FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-10-04 Thread Pekka Väänänen
Hello, I've fixed the issues and posted the patch in this same thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285840.html https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285841.html Please let me know if there are additional problems with the patch that b

Re: [FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-10-04 Thread Roman Arzumanyan
Please find revised patch attached. >Use the init-callback instead of the init_dict and remove the unused options >completely. Did that. >This has lots of duplication with the ordinary scale filter There are some leftovers copy-pasted from scale2ref filter to make scale2ref_npp parameters synta

[FFmpeg-devel] [PATCH 0/1] avformat: Add probe_streams option

2021-10-04 Thread Nicolas Gaullier
This is a following to a precedent work which was a too long patch serie: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2593 At the end, s337m will be probed (if the user choose to) in WAV files. But it is important to maintain workfows where typically WAV files are remuxed in MXF with

[FFmpeg-devel] [PATCH 1/1] avformat: Add probe_streams option

2021-10-04 Thread Nicolas Gaullier
Allow user to disable codec probing: - spdif (and s337m incl. s-adm in the future) is not sub-demuxed and may pass-through to a muxer - disable any stream probing in wav files (dts detection). - mpeg-ts files missing PAT/PMT are considered invalid. Signed-off-by: Nicolas Gaullier --- doc/forma

[FFmpeg-devel] [PATCH 2/3] avcodec/h274: Fix signed left shift

2021-10-04 Thread Michael Niedermayer
Fixes: 39463/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5736517629247488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h274.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[FFmpeg-devel] [PATCH 3/3] avformat/wavdec: Check smv_block_size

2021-10-04 Thread Michael Niedermayer
Fixes: Timeout Fixes: 39554/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-4915221701984256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/wavdec.c | 2 ++ 1 file changed, 2 insertions

[FFmpeg-devel] [PATCH 1/3] avcodec/wmaprodec: Do not initialize unused variable to out of array value

2021-10-04 Thread Michael Niedermayer
Fixes: out of array read Fixes: 39452/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-4678745030524928.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmaprodec.c | 5 +++--