lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Please remove '_' from all your filters names. It is not needed
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
On 9/30/2021 3:51 PM, Derek Buitenhuis wrote:
> This is as per:
>* mp4ra: http://mp4ra.org/#/brands
>* Dolby Vision muxing spec (which is public):
>
> https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby_vision_bitstreams_within_the_iso_
Derek Buitenhuis:
> This is as per:
>* mp4ra: http://mp4ra.org/#/brands
>* Dolby Vision muxing spec (which is public):
>
> https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-content-creators/dolby_vision_bitstreams_within_the_iso_base_media_file_format_dec20
2021年10月1日 +0800 14:41 Paul B Mahol ，写道：
> On Fri, Oct 1, 2021 at 3:17 AM Sun Zhenliang
> wrote:
>
> >
> > Sent with a Spark
> > 2021年10月1日 +0800 05:01 Paul B Mahol ，写道：
> > > Signed-off-by: Paul B Mahol
> > > ---
> > > libavcodec/amr_parser.c | 39 ++
> > > libavcodec/amrn
On Fri, Oct 1, 2021 at 4:03 PM Sun Zhenliang
wrote:
> 2021年10月1日 +0800 14:41 Paul B Mahol ，写道：
> > On Fri, Oct 1, 2021 at 3:17 AM Sun Zhenliang >
> > wrote:
> >
> > >
> > > Sent with a Spark
> > > 2021年10月1日 +0800 05:01 Paul B Mahol ，写道：
> > > > Signed-off-by: Paul B Mahol
> > > > ---
> > > > l
Definitions in `imf.h` are intended to be usable by other modules,
whereas definitions within `imf_internal.h` are intended to be used
within the IMF demuxer implementation only.
The two header files can be combined if that distinction is not
useful, or should be made differently.
On Wed, Sep 29,
On Thu, Sep 30, 2021 at 12:11:13PM +, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Michael Niedermayer
> > Sent: Thursday, 30 September 2021 14:04
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-
On Sun, Sep 26, 2021 at 6:48 PM Jan Ekström wrote:
>
> Such a field can be seen as generally useful in cases where the
> API user is not implementing custom AVIO callbacks, but still would
> like to know if data is being read even if AVPackets are not being
> returned.
> ---
Ping.
Jan
__
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Friday, 1 October 2021 10:57
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v11 10/14] avfilter/textmod: Add
> textmod, censor and show_speaker filters
On Fri, Oct 1, 2021 at 9:43 PM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Paul B Mahol
> > Sent: Friday, 1 October 2021 10:57
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v11 10/14
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Friday, 1 October 2021 19:56
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v5 2/7] libavformat/asfdec: Fix
> get_value return type
>
> On Thu,
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
doc/examples/metadata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/examples/metadata.c b/doc/examples/metadata.c
index b6cfa6bd36..7c44009a2
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
fftools/cmdutils.c | 2 +-
fftools/ffmpeg.c| 6 +++---
fftools/ffmpeg_filter.c | 6 +++---
fftools/ffmpeg_opt.c| 8
fftools/ffplay.c| 8
Signed-off-by: Andreas Rheinhardt
---
libpostproc/postprocess_template.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/libpostproc/postprocess_template.c
b/libpostproc/postprocess_template.c
index 411fc41915..9f76b7c587 100644
--- a/libpostproc/postprocess_template.c
++
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
libavcodec/libaomenc.c | 2 +-
libavcodec/libvpxenc.c | 4 ++--
libavcodec/libx264.c | 2 +-
libavcodec/libx265.c | 2 +-
libavcodec/mjpegdec.c | 2 +-
5 files chan
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
libavfilter/avfilter.c | 2 +-
libavfilter/f_bench.c | 2 +-
libavfilter/f_drawgraph.c | 2 +-
libavfilter/f_metadata.c| 2 +-
libavfilter/f_select.c
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
libavformat/aiffenc.c | 2 +-
libavformat/apetag.c| 2 +-
libavformat/asfenc.c| 8 +++
libavformat/au.c| 2 +-
libavformat/avid
Treat values returned from av_dict_get() as const, since they are
internal to AVDictionary.
Signed-off-by: Chad Fraleigh
---
libavutil/hwcontext_qsv.c| 2 +-
libavutil/hwcontext_vulkan.c | 6 +++---
libavutil/opt.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Friday, 1 October 2021 22:32
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v11 10/14] avfilter/textmod: Add
> textmod, censor and show_speaker filters
Unused since 9ab0874ea8b6774c6f5470dba2b5b4615a610d0d.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegaudiodec_template.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/mpegaudiodec_template.c
b/libavcodec/mpegaudiodec_template.c
index 4fd9e3a690..bbb6ff1120 100644
--- a/li
Signed-off-by: Andreas Rheinhardt
---
libavutil/md5.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavutil/md5.c b/libavutil/md5.c
index 88596203c1..0170d8dd3f 100644
--- a/libavutil/md5.c
+++ b/libavutil/md5.c
@@ -100,7 +100,6 @@ static const uint32_t T[64] = { // T[i]
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc1_block.c | 36 ++--
libavcodec/vc1_pred.c | 2 +-
libavcodec/vc1_pred.h | 3 +--
3 files changed, 20 insertions(+), 21 deletions(-)
diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c
index b6ace3765
In most contexts, arrays are automatically converted to a pointer
to their first element; taking the address of the array just yields
a pointer to an array of fixed-size arrays, which is not intended here.
Signed-off-by: Andreas Rheinhardt
---
libavformat/sccdec.c | 2 +-
1 file changed, 1 inser
Up until now, the scc demuxer not only read the line that it intends
to process, but also the next line, in order to be able to calculate
the duration of the current line. This approach leads to unnecessary
complexity and also to bugs: For the last line, the timing of the
next subtitle is not only
Hi,
I wanted to gather some opinions about the naming of subtitle types.
In my patched I have consistently used the terms "Graphic Subtitles"
and "Text Subtitles" everywhere.
I think "Text Subtitles" is out of question, but for the other one,
there are two viable options:
"Bitmap Subt
The av_sscanf() will filter lines like "Scenarist_SCC V1.0" out.
Signed-off-by: Andreas Rheinhardt
---
libavformat/sccdec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index 1861a99aad..efd6024001 100644
--- a/libavformat/sccdec.c
+++ b/libavf
Signed-off-by: Andreas Rheinhardt
---
libavformat/sccdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index efd6024001..0b3e1ab74c 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -82,6 +82,7 @@ static int scc_rea
Signed-off-by: Andreas Rheinhardt
---
libavformat/sccdec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index 0b3e1ab74c..ea9f014cf2 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -51,9 +51,9 @@ static int scc
ff_subtitles_queue_insert() does not require its events to be
zero-terminated as it has a parameter for the length.
Signed-off-by: Andreas Rheinhardt
---
libavformat/sccdec.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index ea9f014cf2..6935
It claims to always zero-terminate its buffer like snprintf(),
yet it does it not on EOF. Because of this the mcc demuxer
used uninitialized values when reading an empty input file.
Signed-off-by: Andreas Rheinhardt
---
libavformat/subtitles.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
Signed-off-by: Andreas Rheinhardt
---
libavformat/lrcenc.c | 2 +-
libavformat/sccenc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c
index 5d107cd49a..0de0bb18f4 100644
--- a/libavformat/lrcenc.c
+++ b/libavformat/lrcenc.c
@@
Up until now setting the input and output devices lists is guarded
by a mutex. This prevents data races emanating from multiple concurrent
calls to avpriv_register_devices() (triggered by multiple concurrent
calls to avdevice_register_all()). Yet reading the lists pointers was
done without any lock
Signed-off-by: Andreas Rheinhardt
---
One could also do this more generically in the ffmpeg function.
tests/fate-run.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index bc1efa22d7..a16ce28a45 100755
--- a/tests/fate-run.sh
+++ b/test
It uses the test-lrc.lrc sample which was added years ago, but never
used until now.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/subtitles.mak | 3 +++
tests/ref/fate/sub-lrc-remux | 49
2 files changed, 52 insertions(+)
create mode 100644 tests/re
Unused since 6b35a83214f1bc3fb38c9ea9c2cd3676f28709fa (the removal of
ffserver).
Signed-off-by: Andreas Rheinhardt
---
fftools/ffmpeg_opt.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 1d6d29cfc9..c46a9343e1 100644
--- a/fftools/ffmp
Provides coverage for the muxer.
Signed-off-by: Andreas Rheinhardt
---
tests/fate/subtitles.mak | 3 ++
tests/ref/fate/sub-scc-remux | 65
2 files changed, 68 insertions(+)
create mode 100644 tests/ref/fate/sub-scc-remux
diff --git a/tests/fate/subtitl
Signed-off-by: Andreas Rheinhardt
---
libavformat/lrcenc.c | 44 ++--
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c
index 0de0bb18f4..21cb3860ab 100644
--- a/libavformat/lrcenc.c
+++ b/libavforma
Signed-off-by: Andreas Rheinhardt
---
libavformat/lrcenc.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c
index 21cb3860ab..4fa14ea427 100644
--- a/libavformat/lrcenc.c
+++ b/libavformat/lrcenc.c
@@ -111,19 +1
Signed-off-by: Andreas Rheinhardt
---
libavformat/lrcenc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c
index 4fa14ea427..5703a95180 100644
--- a/libavformat/lrcenc.c
+++ b/libavformat/lrcenc.c
@@ -27,9 +27,7 @@
#include "internal.h"
#include
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Soft Works
> Sent: Friday, 1 October 2021 23:09
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: [FFmpeg-devel] [RFC] Naming of Subtitle Types
>
> Hi,
>
> I wanted to gather some opinions about the
When SDP specifies a decoder config, there may not be any AU headers
provided by the sender. This can result in rtp_parse_mp4_au failing
and aac_parse_packet reporting "Error parsing AU headers." and no audio
is recovered from the stream.
This commit modifies aac_parse_header to check for an expl
Hi, Thilo
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210826144024.95697-1-cy...@connect.ust.hk/
I hope this email finds you well. I am writing you to discuss whether it is
possible to collaboratively apply CVE IDs for these issues.
Below is my understanding after eyeballing them for a
Unused since the removal of ff_get_ref_perms_string() in
a05a44e205d6ae13d5eb1cd8d4ad2dba6ec940b3.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avfilter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index f325918021..d70db1b283 100644
-
It allows compilers to inline the one and only call to this function
in its callers or even to optimize it away completely (this function
is empty in case TRACE is not defined).
Signed-off-by: Andreas Rheinhardt
---
libavfilter/avfilter.c | 4 ++--
libavfilter/internal.h | 2 --
2 files changed,
45 matches
Mail list logo
