[FFmpeg-devel] [PATCH v1 04/10] return value check for init_get_bits in wmadec.c

--- libavcodec/wmadec.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index d627bbe50e..6ac6221d11 100644 --- a/libavcodec/wmadec.c +++ b/libavcodec/wmadec.c @@ -822,6 +822,7 @@ static int wma_decode_superframe(AVCode

[FFmpeg-devel] [PATCH v1 05/10] return value check for init_get_bits in vorbisdec.c

--- libavcodec/vorbisdec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index dac2b6841c..80358f6359 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -1052,7 +1052,9 @@ static av_cold int vorbis_decod

[FFmpeg-devel] [PATCH v1 06/10] return value check for init_get_bits in vp6.c

--- libavcodec/vp6.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c index 73822a00f9..149daa59f3 100644 --- a/libavcodec/vp6.c +++ b/libavcodec/vp6.c @@ -167,7 +167,9 @@ static int vp6_parse_header(VP56Context *s, const uint8_t *buf, int

[FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

--- libavcodec/vc1dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 1fb1950ade..07d60294f2 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -444,7 +444,9 @@ static av_cold int vc1_decode_init(AVCodecContex

[FFmpeg-devel] [PATCH v1 08/10] return value check for init_get_bits in vble.c

--- libavcodec/vble.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/vble.c b/libavcodec/vble.c index f1400959e0..d3e1804c7b 100644 --- a/libavcodec/vble.c +++ b/libavcodec/vble.c @@ -146,8 +146,9 @@ static int vble_decode_frame(AVCodecContext *avctx, void *da

[FFmpeg-devel] [PATCH v1 09/10] return value check for init_get_bits in vaapi_mpeg2.c

--- libavcodec/vaapi_mpeg2.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_mpeg2.c b/libavcodec/vaapi_mpeg2.c index 26e0cd827c..8e3903212a 100644 --- a/libavcodec/vaapi_mpeg2.c +++ b/libavcodec/vaapi_mpeg2.c @@ -136,9 +136,12 @@ static int vaapi_mpeg2_dec

[FFmpeg-devel] [PATCH v1 10/10] return value check for init_get_bits in utvideodec.c

--- libavcodec/utvideodec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index b39d8a7948..144992ff0d 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideodec.c @@ -153,7 +153,9 @@ static int decode_plane10(Ut

[FFmpeg-devel] [PATCH v2 1/1] return value check for init_get_bits in wmadec.c

sorry for my mistake. previous version faild to make. --- libavcodec/sipr.c| 5 +++-- libavcodec/truemotion2.c | 12 +--- libavcodec/utvideodec.c | 8 ++-- libavcodec/vaapi_mpeg2.c | 5 - libavcodec/vble.c| 5 +++-- libavcodec/vc1dec.c | 8 ++-- libav

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Thu, Aug 12, 2021 at 6:48 AM maryam ebrahimzadeh wrote: > > As the second argument for init_get_bits can be crafted, a return value check > for this function call is necessary so replace init_get_bits with > init_get_bits8. > > --- > libavcodec/wmv2dec.c | 6 -- > 1 file changed, 4 inse

Re: [FFmpeg-devel] [PATCH v1 06/10] return value check for init_get_bits in vp6.c

On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/vp6.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c > index 73822a00f9..149daa59f3 100644 > --- a/libavcodec/vp6.c > +++ b/libavcodec/vp6.c > @@ -167,7

Re: [FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/vc1dec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c > index 1fb1950ade..07d60294f2 100644 > --- a/libavcodec/vc1dec.c > +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Aug 12, 2021, at 10:23 AM, Hendrik Leppkes mailto:h.lepp...@gmail.com>> wrote: On Thu, Aug 12, 2021 at 6:48 AM maryam ebrahimzadeh mailto:me22...@outlook.com>> wrote: As the second argument for init_get_bits can be crafted, a return value check for this function call is necessary so rep

Re: [FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

I choose them because their second argument can be crafted. On Aug 12, 2021, at 10:29 AM, Hendrik Leppkes mailto:h.lepp...@gmail.com>> wrote: On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh mailto:me22...@outlook.com>> wrote: --- libavcodec/vc1dec.c | 8 ++-- 1 file changed, 6 insertion

Re: [FFmpeg-devel] [PATCH v1 04/10] return value check for init_get_bits in wmadec.c

On Thu, Aug 12, 2021 at 6:52 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/wmadec.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c > index d627bbe50e..6ac6221d11 100644 > --- a/libavcodec/wmadec.c > +++ b/li

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Thu, Aug 12, 2021 at 8:01 AM Maryam Ebrahimzadeh wrote: > > Init_get_bits8 checks for overflow and some other conditions (in > init_get_bits_xe ) too. > What overflow? I'm not sure you understand the concept here. 32 can't overflow, neither can 8*4. Please also make sure to quote and respond

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

From the point of view of someone who is currently developing a filter for ffmpeg and will be submitting a patch to the list for the first time, I think this is a great idea.Whilst following simple instructions to prepare and submit a patch should't be outside the ability of anyone who is capable o

<    1   2