Re: [FFmpeg-devel] [PATCH 9/9] avfilter/avfilter: Remove unused partial_buf

2021-08-05 Thread Nicolas George
Andreas Rheinhardt (12021-08-05): > It is unused since 02aa0701ae0dc2def8db640c9e3c06dc1b5de70c. > The corresponding size field is write-only since then. > > Signed-off-by: Andreas Rheinhardt > --- > I was quite surprised to find this. LGTM, good catch. Regards, -- Nicolas George signatur

[FFmpeg-devel] [PATCH v5 00/20] clean-up QSV filters

2021-08-05 Thread Haihao Xiang
This patchset clean up scale_qsv and deinterlace_qsv filters, and take the two filters as the special cases of vpp_qsv, so vf_scale_qsv.c and vf_deinterlace_qsv.c can be deleted from FFmpeg. In addition, a few small features are added in this patchset. --- v5: * Rebased this patchset against the la

[FFmpeg-devel] [PATCH v5 01/20] lavfi/qsv: use QSVVPPContext as base context in vf_vpp_qsv/vf_overlay_qsv

2021-08-05 Thread Haihao Xiang
The same members between QSVVPPContext and VPPContext are removed from VPPContext, and async_depth is moved from QSVVPPParam to QSVVPPContext so that all QSV filters using QSVVPPContext may support async depth. In addition we may use QSVVPPContext as base context in other QSV filters in the future.

[FFmpeg-devel] [PATCH v5 02/20] lavfi/scale_qsv: simplify scale_qsv filter

2021-08-05 Thread Haihao Xiang
Use QSVVPPContext as a base context of QSVScaleContext, hence we may re-use functions defined for QSVVPPContext to manage MFX session for scale_qsv filter too. Because system memory is taken into account in QSVVVPPContext, we may add support for non-QSV pixel formats in the future --- libavfilter/

[FFmpeg-devel] [PATCH v5 03/20] lavfi/scale_qsv: don't need variables for constants in FFmpeg

2021-08-05 Thread Haihao Xiang
PI, PHI and E are defined in FFmpeg --- libavfilter/vf_scale_qsv.c | 9 - 1 file changed, 9 deletions(-) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index 77a782aa58..f8e937e40e 100644 --- a/libavfilter/vf_scale_qsv.c +++ b/libavfilter/vf_scale_qsv.c @@ -44,9 +44,

[FFmpeg-devel] [PATCH v5 04/20] lavfi/vpp_qsv: add "a", "dar" and "sar" variables

2021-08-05 Thread Haihao Xiang
Also fix the coding style for VAR index. This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 5b

[FFmpeg-devel] [PATCH v5 05/20] lavfi/vpp_qsv: handle NULL pointer when evaluating an expression

2021-08-05 Thread Haihao Xiang
This is in preparation for re-using VPPContext but with a different option array for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 5f

[FFmpeg-devel] [PATCH v5 08/20] lavfi/vpp_qsv: allow user to set scale_mode with constant

2021-08-05 Thread Haihao Xiang
In addtion, update the help text for scale_mode $ ffmpeg -hwaccel qsv -c:v h264_qsv -i input.h264 -vf \ "vpp_qsv=scale_mode=hq" -f null - --- libavfilter/vf_vpp_qsv.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv

[FFmpeg-devel] [PATCH v5 09/20] lavfi/vpp_qsv: add vpp_preinit callback

2021-08-05 Thread Haihao Xiang
Set the expected default value for options in this callback, hence we have the right values even if these options are not included in the option arrray. This is in preparation for re-using VPPContext but with a different option array for other QSV filters --- libavfilter/vf_vpp_qsv.c | 14

[FFmpeg-devel] [PATCH v5 06/20] lavfi/vpp_qsv: allow special values for the output dimensions

2021-08-05 Thread Haihao Xiang
Special values are: 0 = original width/height -1 = keep original aspect This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 47 ++-- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_vpp

[FFmpeg-devel] [PATCH v5 10/20] lavfi/scale_qsv: re-use VPPContext for scale_qsv filter

2021-08-05 Thread Haihao Xiang
All features are implemented in vpp_qsv filter, scale_qsv can be taken as a special case of vpp_qsv filter now, we re-use VPPContext with a different option arrary and pixel formats --- libavfilter/Makefile | 2 +- libavfilter/vf_scale_qsv.c | 334 - lib

[FFmpeg-devel] [PATCH v5 12/20] lavfi/scale_qsv: add new options for scale_qsv filter

2021-08-05 Thread Haihao Xiang
Allow user to set crop area and async depth --- libavfilter/vf_vpp_qsv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index e9a802d507..d72ddad517 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -684,6 +684,10

[FFmpeg-devel] [PATCH v5 07/20] lavfi/vpp_qsv: factorize extra MFX configuration

2021-08-05 Thread Haihao Xiang
This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 86 1 file changed, 34 insertions(+), 52 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 5409ecf569..e8cba3c360 100644 --

[FFmpeg-devel] [PATCH v5 11/20] lavfi/vpp_qsv: factor common QSV filter definition

2021-08-05 Thread Haihao Xiang
--- libavfilter/vf_vpp_qsv.c | 223 ++- 1 file changed, 100 insertions(+), 123 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 43465f3276..e9a802d507 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -10

[FFmpeg-devel] [PATCH v5 13/20] lavfi/scale_qsv: add more input / output pixel formats

2021-08-05 Thread Haihao Xiang
NV12 and P010 are added $ ffmpeg -init_hw_device qsv -c:v h264_qsv -i input.h264 -vf "scale_qsv=format=p010" -f null - --- libavfilter/vf_vpp_qsv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index d72ddad517..c642d4e

[FFmpeg-devel] [PATCH v5 14/20] lavfi/qsvvpp: avoid overriding the returned value

2021-08-05 Thread Haihao Xiang
Currently the returned value from MFXVideoVPP_RunFrameVPPAsync() is overridden, so the check of 'ret == MFX_ERR_MORE_SURFACE' is always false when MFX_ERR_MORE_SURFACE is returned from MFXVideoVPP_RunFrameVPPAsync() --- libavfilter/qsvvpp.c | 11 --- 1 file changed, 8 insertions(+), 3 dele

[FFmpeg-devel] [PATCH v5 15/20] lavfi/qsvvpp: set PTS for output frame

2021-08-05 Thread Haihao Xiang
When the SDK returns MFX_ERR_MORE_SURFACE, the PTS is not set for the output frame. We assign a PTS calculated from the input frame to the output frame. After applying this patch, we may avoid the error below: [null @ 0x56395cab4ae0] Application provided invalid, non monotonically increasing dts t

[FFmpeg-devel] [PATCH v5 17/20] lavfi/deinterlace_qsv: simplify deinterlace_qsv filter

2021-08-05 Thread Haihao Xiang
Like what we did for scale_qsv filter, we use QSVVPPContext as a base context to manage MFX session for deinterlace_qsv filter --- libavfilter/vf_deinterlace_qsv.c | 492 ++- 1 file changed, 30 insertions(+), 462 deletions(-) diff --git a/libavfilter/vf_deinterlace_qsv

[FFmpeg-devel] [PATCH v5 19/20] lavfi/deinterlace_qsv: add async_depth option

2021-08-05 Thread Haihao Xiang
Allow user to set async depth for deinterlace_qsv --- libavfilter/vf_vpp_qsv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 518595d91e..edd10f5af6 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -730,6 +730,7

[FFmpeg-devel] [PATCH v5 18/20] lavfi/deinterlace_qsv: re-use VPPContext for deinterlace_qsv filter

2021-08-05 Thread Haihao Xiang
All features are implemented in vpp_qsv filter now, so deinterlace_qsv can be taken as a specical case of vpp_qsv filter, we re-use VPPContext with a different option array and pix formats for deinterlace_qsv filter A new option -rate is used to control the output frame rate, by default it will ou

[FFmpeg-devel] [PATCH v5 16/20] lavfi/vpp_qsv: check output format string against NULL pointer

2021-08-05 Thread Haihao Xiang
This is in preparation for re-using VPPContext but with a different option array for deinterlacing_qsv filter --- libavfilter/vf_vpp_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 3eddefea31..f7854f81bf 100644 ---

[FFmpeg-devel] [PATCH v5 20/20] lavfi/deinterlace_qsv: add more input / output pixel formats

2021-08-05 Thread Haihao Xiang
NV12 is added in system memory and the command below may work now. $ ffmpeg -init_hw_device qsv -c:v h264_qsv -i input.h264 -vf deinterlace_qsv -f null - --- libavfilter/vf_vpp_qsv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_v

[FFmpeg-devel] [PATCH 1/3] checkasm: collapse hevc pel tests

2021-08-05 Thread J. Dekker
Also add to `make fate-checkasm' target. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 11 +-- tests/checkasm/checkasm.h | 11 +-- tests/checkasm/hevc_pel.c | 34 -- tests/fate/checkasm.mak | 1 + 4 files changed, 27 insertions(+), 30

[FFmpeg-devel] [PATCH 2/3] checkasm: add h264 chroma test

2021-08-05 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/h264chroma.c | 109 tests/fate/checkasm.mak | 1 + 5 files changed, 115 insertions(+) create mode

[FFmpeg-devel] [PATCH 3/3] checkasm: add hevc_deblock tests

2021-08-05 Thread J. Dekker
Signed-off-by: J. Dekker --- 0001-checkasm-add-hevc_deblock-tests.patch | 186 + tests/checkasm/Makefile| 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_deblock.c

[FFmpeg-devel] [PATCH] mxf : correct previous commit

2021-08-05 Thread Michael Krebs
* Let older tags on the same place as originally * Add new fate tests for rawvideo and v210 and update checksum for mxf tests --- libavformat/mxfenc.c| 37 +++-- tests/fate/lavf-container.mak | 7 + tests/ref/fate/copy-trac4914| 2

Re: [FFmpeg-devel] [PATCH v3 33/34] avdevice/dshow: prevent NULL access

2021-08-05 Thread Diederick C. Niehorster
On Tue, Aug 3, 2021 at 4:22 PM Andreas Rheinhardt wrote: > > Diederick Niehorster: > > list_options true would crash when both a video and an audio device were > > specified as input. Crash would occur on line 1588 (in this new rev) > > because ctx->device_unique_name[otherDevType] would be NULL >

[FFmpeg-devel] [PATCH] avfilter/avfilter: add sample_count_in and sample_count_out

2021-08-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index b82f72d040..a71745283c 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -584,6 +584,11 @@ struct AVFilterLink {

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: add sample_count_in and sample_count_out

2021-08-05 Thread Nicolas George
Paul B Mahol (12021-08-05): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.h | 5 + > 1 file changed, 5 insertions(+) Ok for the principle, but you seem to have forgotten to update avfilter.c to make these fields useful. Regards, -- Nicolas George signature.asc Description

[FFmpeg-devel] [PATCH v2 2/3] checkasm: add h264 chroma test

2021-08-05 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/h264chroma.c | 109 tests/fate/checkasm.mak | 1 + 5 files changed, 115 insertions(+) create mode

[FFmpeg-devel] [PATCH v2 3/3] checkasm: add hevc_deblock tests

2021-08-05 Thread J. Dekker
Signed-off-by: J. Dekker --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_deblock.c | 126 ++ tests/fate/checkasm.mak | 1 + 5 files changed, 130 insertions(+), 1 d

Re: [FFmpeg-devel] [PATCH v2 1/1] return value check for init_get_bits in adts_decode_extradata

2021-08-05 Thread Maryam Ebrahimzadeh
Ping. > On Aug 5, 2021, at 12:45 AM, maryam ebrahimzadeh wrote: > > version2: > As second argument for init_get_bits (buf) can be crafted, return value check > for this function call is necessary. > 'buf' is part of 'AVPacket pkt'. > replace init_get_bits with init_get_bits8. > --- > libavfor

[FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: add sample_count_in and sample_count_out

2021-08-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index b82f72d040..a71745283c 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -584,6 +584,11 @@ struct AVFilterLink {

[FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: update sample_count_in/out

2021-08-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 24de8ebee3..e0847c724b 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1013,6 +1013,7 @@ int ff_filter_frame(AVFi

[FFmpeg-devel] [PATCH 3/3] avfilter/f_graphmonitor: use sample_count_in/out

2021-08-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 6 ++ libavfilter/f_graphmonitor.c | 14 ++ 2 files changed, 20 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 7a266c2a32..28996a4a64 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -130

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix tfdt out of sync

2021-08-05 Thread Martin Storsjö
Hi, On Tue, 20 Jul 2021, 胡玮文 wrote: After compile and run this code, run this command to inspect the dts (which comes from the out of sync tfdt) ffprobe -show_packets bug.mp4 | grep dts= The output is: dts=0 dts=1 dts=2 dts=2 dts=3 dts=4 With this patch applied, the output is: dts=0 dts=1

[FFmpeg-devel] [PATCH] movenc: Don't try to fix the fragment end duration if none will be written

2021-08-05 Thread Martin Storsjö
If autoflushing on a new packet (e.g. due to the frag_every_frame flag being set), there's no samples to be written in the new fragment, so we can't overwrite the track duration in order to make it line up with the next packet to be written. Signed-off-by: Martin Storsjö --- libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: update sample_count_in/out

2021-08-05 Thread Nicolas George
Paul B Mahol (12021-08-05): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index 24de8ebee3..e0847c724b 100644 > --- a/libavfilter/avfilter.c > +++ b/libavfilter/avfilter.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
Linjie Fu (12021-08-05): > ffmpeg | branch: master | Linjie Fu | Thu Aug 5 > 00:37:29 2021 +0800| [5b0e6b0d82dfcc5c6b999e2678b52b0cff38ae0a] | committer: > Linjie Fu > > fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay > > Signed-off-by: Linjie Fu > > > http://git.videolan.

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Linjie Fu
On Thu, Aug 5, 2021 at 10:32 PM Nicolas George wrote: > Linjie Fu (12021-08-05): > > ffmpeg | branch: master | Linjie Fu | Thu > Aug 5 00:37:29 2021 +0800| [5b0e6b0d82dfcc5c6b999e2678b52b0cff38ae0a] | > committer: Linjie Fu > > > > fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffpl

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
Linjie Fu (12021-08-05): > This initials from your review comments to remove setting defaults in > ffmpeg (etc) and use the default flags in swscale, > and I didn't see objections at least till now. Did I misunderstand? I approved the general principle and the lavfi parts. I do not maintain the ff

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Linjie Fu
On Thu, Aug 5, 2021 at 10:54 PM Nicolas George wrote: > Linjie Fu (12021-08-05): > > This initials from your review comments to remove setting defaults in > > ffmpeg (etc) and use the default flags in swscale, > > and I didn't see objections at least till now. Did I misunderstand? > > I approved

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
Linjie Fu (12021-08-05): > Where is supposed to be the right placement? In the commit that makes the results change. Just do this: checkout the first commit, build, run FATE. Does it pass? Regards, -- Nicolas George signature.asc Description: PGP signature _

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs: add a helper to read extradata within packet side data

2021-08-05 Thread James Almer
Using ff_cbs_read() on the raw buffer will not parse it as extradata, resulting in parsing errors for example when handling ISOBMFF avcC. This helper works around that. Signed-off-by: James Almer --- libavcodec/cbs.c | 13 + libavcodec/cbs.h | 4 2 files changed, 17 insertions(

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_bsf: use ff_cbs_read_packet_side_data() to parse extradata in packet side data

2021-08-05 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_bsf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_bsf.c b/libavcodec/cbs_bsf.c index 86ec3f2a4d..069f6e9918 100644 --- a/libavcodec/cbs_bsf.c +++ b/libavcodec/cbs_bsf.c @@ -25,15 +25,12 @@ static int cbs_b

[FFmpeg-devel] [PATCH 3/3] avcodec/trace_headers_bsf: also parse extradata in packet side data

2021-08-05 Thread James Almer
Certain mov/mp4 files have parameter sets out of band, and when required for a sample it may be propagated within the relevant packet's side data. This fixes parsing said files if the SPS and/or PPS in the side data is different than the one in extradata. Signed-off-by: James Almer --- libavcode

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Linjie Fu
On Thu, Aug 5, 2021 at 11:22 PM Nicolas George wrote: > Linjie Fu (12021-08-05): > > Where is supposed to be the right placement? > > In the commit that makes the results change. > > Just do this: checkout the first commit, build, run FATE. Does it pass? > Double confirmed locally, Yes, and the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs: add a helper to read extradata within packet side data

2021-08-05 Thread Andreas Rheinhardt
James Almer: > Using ff_cbs_read() on the raw buffer will not parse it as extradata, > resulting in parsing errors for example when handling ISOBMFF avcC. > This helper works around that. > > Signed-off-by: James Almer > --- > libavcodec/cbs.c | 13 + > libavcodec/cbs.h | 4 >

Re: [FFmpeg-devel] [PATCH v2 2/3] checkasm: add h264 chroma test

2021-08-05 Thread Andreas Rheinhardt
J. Dekker: > Signed-off-by: J. Dekker > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/h264chroma.c | 109 > tests/fate/checkasm.mak | 1 + > 5 files changed, 115

Re: [FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the stack filters

2021-08-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Thursday, 5 August 2021 04:33 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the > stack filters > > On Wed, 2021-08-04 at 09:17 +, Soft Works wrote:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs: add a helper to read extradata within packet side data

2021-08-05 Thread James Almer
On 8/5/2021 12:43 PM, Andreas Rheinhardt wrote: James Almer: Using ff_cbs_read() on the raw buffer will not parse it as extradata, resulting in parsing errors for example when handling ISOBMFF avcC. This helper works around that. Signed-off-by: James Almer --- libavcodec/cbs.c | 13 +

Re: [FFmpeg-devel] [PATCH] lavfi/qsvvpp: do not mix up FFmpeg and SDK error code

2021-08-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Thursday, 5 August 2021 07:24 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavfi/qsvvpp: do not mix up FFmpeg > and SDK error code > > On Wed, 2021-08-04 at 06:34 +, Soft Works wro

Re: [FFmpeg-devel] [PATCH v5 00/20] clean-up QSV filters

2021-08-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Thursday, 5 August 2021 10:19 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH v5 00/20] clean-up QSV filters > > This patchset clean up scale_qsv and deinterlace_qsv filters

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: Write data generically via AVPixFmtDescriptor

2021-08-05 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/yuv4mpegenc.c | 87 +++ > 1 file changed, 14 insertions(+), 73 deletions(-) > > diff --git a/libavformat/yuv4mpegenc.c b/libavformat/yuv4mpegenc.c > index efa05133d5..fca0ee3120 100644

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
Linjie Fu (12021-08-05): > Double confirmed locally, Yes, and the first commit has passed the > patchwork too: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210804170311.86426-1-fulin...@zju.edu.cn/ Thanks. I find very surprising that the second patch, which changes a default too, does no

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: remove usage of avctx->pkt_timebase

2021-08-05 Thread James Almer
On 8/2/2021 11:07 PM, James Almer wrote: The field is documented to be for decoding only. Signed-off-by: James Almer --- libavcodec/mfenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 26f1c8057f..410ad64d8d 100644 --- a/libavcodec/mfenc.

Re: [FFmpeg-devel] [PATCH 1/3] cbs_h265: add support for Film Grain Characteristics SEI message

2021-08-05 Thread James Almer
On 8/2/2021 9:12 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 6 +++ libavcodec/cbs_h265.h | 21 + libavcodec/cbs_h265_syntax_template.c | 65 +++ 3 files changed, 92 insertions(+) Will apply

[FFmpeg-devel] [PATCH] avcodec/audiotoolbox Support float sample format

2021-08-05 Thread jason
0001-avcodec-audiotoolbox-Support-float-sample-format.patch Description: Binary data 0001-avcodec-audiotoolbox-Support-float-sample-format.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH] avcodec/audiotoolbox Support float sample format

2021-08-05 Thread jason
From 9ee25b6b3002cd4c629caf850b637877b7a3 Mon Sep 17 00:00:00 2001 From: Jason Fry Date: Thu, 5 Aug 2021 15:01:11 +0100 Subject: [PATCH] avcodec/audiotoolbox Support float sample format Signed-off-by: Jason Fry --- libavcodec/audiotoolboxdec.c | 19 +++ libavcodec/audiotoolbox

Re: [FFmpeg-devel] [PATCH] ffprobe: Rename Audio Service Type 'type' field to 'service_type'

2021-08-05 Thread Derek Buitenhuis
On 8/4/2021 4:25 PM, Derek Buitenhuis wrote: >> --- >> fftools/ffprobe.c | 2 +- >> tests/ref/fate/hls-fmp4_ac3 | 2 +- > > Ping. Will push tomorrow if nobody objects. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: add support for TTML muxing

2021-08-05 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') > methods. This initial version also foregoes fragmentation support > in case the built-in sample squashing is to be utilized, as this > eases the initial review. > > Additionally, add basic t

Re: [FFmpeg-devel] [PATCH 1/3] checkasm: collapse hevc pel tests

2021-08-05 Thread Martin Storsjö
On Thu, 5 Aug 2021, J. Dekker wrote: Also add to `make fate-checkasm' target. Signed-off-by: J. Dekker --- tests/checkasm/checkasm.c | 11 +-- tests/checkasm/checkasm.h | 11 +-- tests/checkasm/hevc_pel.c | 34 -- tests/fate/checkasm.mak | 1 + 4

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Michael Niedermayer
On Tue, Aug 03, 2021 at 10:07:34AM -0400, Sergio M. Ammirata, Ph.D. wrote: > PES packet with too much padding trigger unlimited error > messages "PES packet size mismatch" because the code that > corrects the length is wrong. > Here is a sample file: http://99.93.62.129/smpte2038.ts > PID 300 is th

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Michael Niedermayer
On Thu, Aug 05, 2021 at 11:08:30PM +0200, Michael Niedermayer wrote: > On Tue, Aug 03, 2021 at 10:07:34AM -0400, Sergio M. Ammirata, Ph.D. wrote: > > PES packet with too much padding trigger unlimited error > > messages "PES packet size mismatch" because the code that > > corrects the length is wro

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Sergio M. Ammirata, Ph.D.
You are right ... the if statement would have to change as well. On Tue, 2021-08-03 at 14:20 +, ffmpegandmahanstreamer@e.email wrote: > August 3, 2021 10:07 AM, "Sergio M. Ammirata, Ph.D." < > ser...@ammirata.net> wrote: > PES packet with too much padding trigger unlimited > errormessages "PES

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Sergio M. Ammirata, Ph.D.
Can you share the video file you are using to get the segfault? On Thu, 2021-08-05 at 23:10 +0200, Michael Niedermayer wrote: > On Thu, Aug 05, 2021 at 11:08:30PM +0200, Michael > Niedermayer wrote: > On Tue, Aug 03, 2021 at 10:07:34AM -0400, Sergio M. > Ammirata, Ph.D. wrote: > PES packet with too

Re: [FFmpeg-devel] [PATCH 2/3] checkasm: add h264 chroma test

2021-08-05 Thread Martin Storsjö
On Thu, 5 Aug 2021, J. Dekker wrote: Signed-off-by: J. Dekker --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/h264chroma.c | 109 tests/fate/checkasm.mak | 1 + 5 files change

Re: [FFmpeg-devel] [PATCH v2 3/3] checkasm: add hevc_deblock tests

2021-08-05 Thread Martin Storsjö
On Thu, 5 Aug 2021, J. Dekker wrote: Signed-off-by: J. Dekker --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_deblock.c | 126 ++ tests/fate/checkasm.mak | 1 + 5 fil

[FFmpeg-devel] [PATCH v2 1/4] avdevice/decklink: add link configuration

2021-08-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/outdevs.texi| 5 + libavdevice/decklink_common.cpp | 9 + libavdevice/decklink_common.h | 8 libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc.cpp| 2 ++ libavdevice/decklink_enc_c.c|

[FFmpeg-devel] [PATCH v2 2/4] avdevice/decklink: add sqd configure

2021-08-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/outdevs.texi| 4 libavdevice/decklink_common.cpp | 11 +++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc_c.c| 1 + 4 files changed, 17 insertions(+) diff --git a/doc/outdevs.texi b/doc/outd

[FFmpeg-devel] [PATCH v2 3/4] avdevice/decklink: add levelA configure

2021-08-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- just rebase the code to the master branch to fix the first warning. doc/outdevs.texi| 4 libavdevice/decklink_common.cpp | 17 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc_c.c| 1 +

[FFmpeg-devel] [PATCH v2 4/4] avdevice/decklink: support for more duplex mode for Decklink 8K Pro

2021-08-05 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/indevs.texi | 16 +++- doc/outdevs.texi| 16 +++- libavdevice/decklink_common.cpp | 8 libavdevice/decklink_common.h | 11 +++ libavdevice/decklink_dec_c.c| 10

[FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option

2021-08-05 Thread Haihao Xiang
The SDK may insert picture timing SEI for hevc and the code to set mfx parameter has been added in qsvenc, however the corresponding option is missing in the hevc option array --- libavcodec/qsvenc_hevc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsv

Re: [FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the stack filters

2021-08-05 Thread Xiang, Haihao
On Thu, 2021-08-05 at 15:53 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Thursday, 5 August 2021 04:33 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the > > stack f

[FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the stack filters

2021-08-05 Thread Haihao Xiang
Include hstack_qsv, vstack_qsv and xstack_qsv, some code is copy and pasted from other filters Example: $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i input.h265 -filter_complex "[0:v][0:v]hstack_qsv" -f null - --- v2: fix wrong reference in filters.texi configure | 6 + doc/filters.

Re: [FFmpeg-devel] [PATCH v2] avfilter: add QSV variants of the stack filters

2021-08-05 Thread Xiang, Haihao
On Fri, 2021-08-06 at 13:17 +0800, Haihao Xiang wrote: > Include hstack_qsv, vstack_qsv and xstack_qsv, some code is copy and > pasted from other filters > > Example: > $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i input.h265 -filter_complex > "[0:v][0:v]hstack_qsv" -f null - > --- > v2: fix wrong refer