Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread Michael Niedermayer
On Fri, Jul 30, 2021 at 10:31:53AM -0300, James Almer wrote: > On 7/30/2021 8:33 AM, Michael Niedermayer wrote: > > On Thu, Jul 29, 2021 at 03:09:03PM -0300, James Almer wrote: > > > On 7/29/2021 2:58 PM, Michael Niedermayer wrote: > > > > On Tue, Jul 27, 2021 at 10:08:20AM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH] avcodec/argo: Check for end of input in decode_alcd()

2021-07-31 Thread Paul B Mahol
On Fri, Jul 30, 2021 at 1:59 PM Michael Niedermayer wrote: > On Fri, Jul 30, 2021 at 08:44:03AM +0200, Paul B Mahol wrote: > > On Fri, Jul 30, 2021 at 12:16 AM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > > > Andreas Rheinhardt: > > > > Michael Niedermayer: > > > >> Fixes

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread Andreas Rheinhardt
ffmpegandmahanstreamer@e.email: > Overrides previous patch i submitted regarding this as the old patch I > submitted had a bug that is fixed in this one. > This is not an acceptable commit message: You are supposed to actually describe the patch here and not the evolution of your patch. Such a c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread Hendrik Leppkes
On Sat, Jul 31, 2021 at 11:41 AM Michael Niedermayer wrote: > Theres also the 2nd situation where all the information the parser > extracts is already known to the lib user and going over the whole > bitstream is wasting cpu cycles. This can be a situation where for > example all input files where

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread Nicolas George
ffmpegandmahanstreamer@e.email (12021-07-31): > In my next patch how about "This patch adds sprite support to the Duck > TrueMotion1 decoder." Have you considered looking at what other people do, especially regular developers? https://git.ffmpeg.org/ffmpeg.git Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread ffmpegandmahanstreamer
B U M P so i can submit new patches July 22, 2021 4:27 PM, ffmpegandmahanstreamer@e.email wrote: > Overrides previous patch i submitted regarding this as the old patch I > submitted had a bug that is > fixed in this one. > > --- > libavcodec/truemotion1.c | 206 +

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread James Almer
On 7/31/2021 6:41 AM, Michael Niedermayer wrote: On Fri, Jul 30, 2021 at 10:31:53AM -0300, James Almer wrote: On 7/30/2021 8:33 AM, Michael Niedermayer wrote: On Thu, Jul 29, 2021 at 03:09:03PM -0300, James Almer wrote: On 7/29/2021 2:58 PM, Michael Niedermayer wrote: On Tue, Jul 27, 2021 at

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread Michael Niedermayer
On Sat, Jul 31, 2021 at 02:40:11PM +0200, Hendrik Leppkes wrote: > On Sat, Jul 31, 2021 at 11:41 AM Michael Niedermayer > wrote: > > Theres also the 2nd situation where all the information the parser > > extracts is already known to the lib user and going over the whole > > bitstream is wasting cp

Re: [FFmpeg-devel] Hardware purchase request

2021-07-31 Thread Stefano Sabatini
On Thu, Jul 29, 2021 at 8:10 PM Michael Niedermayer wrote: > > On Thu, Jul 29, 2021 at 01:07:39AM +0200, Lynne wrote: [...] > > > Fractal Design Ion+ 860 W > > > Fractal Design Define 7 Compact > > > XFX Speedster MERC 319 Radeon RX 6900 XT > > > Samsung 980 PRO 2TB > > > LG UltraGear 27GN950-B >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread Michael Niedermayer
On Sat, Jul 31, 2021 at 01:10:27PM -0300, James Almer wrote: > On 7/31/2021 6:41 AM, Michael Niedermayer wrote: > > On Fri, Jul 30, 2021 at 10:31:53AM -0300, James Almer wrote: > > > On 7/30/2021 8:33 AM, Michael Niedermayer wrote: > > > > On Thu, Jul 29, 2021 at 03:09:03PM -0300, James Almer wrote

[FFmpeg-devel] [PATCH 2/3] avcodec/vc1dec: Disable error concealment for *IMAGE

2021-07-31 Thread Michael Niedermayer
The existing error concealment makes no sense for the image formats, they use transformed source images which is different from keyframe + MC+difference for which the error concealment is designed. Of course feel free to re-enable this if you have a case where it works and improves vissual results

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread James Almer
On 7/31/2021 2:46 PM, Michael Niedermayer wrote: On Sat, Jul 31, 2021 at 01:10:27PM -0300, James Almer wrote: On 7/31/2021 6:41 AM, Michael Niedermayer wrote: On Fri, Jul 30, 2021 at 10:31:53AM -0300, James Almer wrote: On 7/30/2021 8:33 AM, Michael Niedermayer wrote: On Thu, Jul 29, 2021 at

[FFmpeg-devel] [PATCH 1/3] avcodec/sbrdsp_fixed: Fix negation overflow in sbr_neg_odd_64_c()

2021-07-31 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 35593/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5182217725804544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tr

[FFmpeg-devel] [PATCH 3/3] avcodec/argo: Check for even dimensions

2021-07-31 Thread Michael Niedermayer
Fixes: reading over the end Fixes: 36346/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARGO_fuzzer-5366943107383296 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/argo.c | 5 + 1 file

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread ffmpegandmahanstreamer
July 31, 2021 8:25 AM, "Andreas Rheinhardt" wrote: > ffmpegandmahanstreamer@e.email: > >> Overrides previous patch i submitted regarding this as the old patch I >> submitted had a bug that is >> fixed in this one. > > This is not an acceptable commit message: You are supposed to actually > de

Re: [FFmpeg-devel] Hardware purchase request

2021-07-31 Thread Lynne
31 Jul 2021, 18:24 by stefa...@gmail.com: > On Thu, Jul 29, 2021 at 8:10 PM Michael Niedermayer > wrote: > >> >> On Thu, Jul 29, 2021 at 01:07:39AM +0200, Lynne wrote: >> > [...] > >> > > Fractal Design Ion+ 860 W >> > > Fractal Design Define 7 Compact >> > > XFX Speedster MERC 319 Radeon RX 6900

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread ffmpegandmahanstreamer
Hello GEORGE. "avfilter/avf_showfreqs: switch to TX FFT from avutil" "avfilter/af_silenceremove: make window also depends on input sample format" And from Andreas himself: "postproc/postprocess: Remove legacy cruft" are some examples, so i should be good. Some have a two or three sentences while

Re: [FFmpeg-devel] Hardware purchase request

2021-07-31 Thread Stefano Sabatini
On Sat, Jul 31, 2021 at 8:02 PM Lynne wrote: > > 31 Jul 2021, 18:24 by stefa...@gmail.com: [...] > >> > Ping (I pinged Stefano 2 weeks ago as well, no response). > >> > >> is there something i can do ? > >> > >> just trying to make sure we are not stuck in a misunderstanding, as there > >> was >

[FFmpeg-devel] [PATCH] avcodec/faxcompr: Check for end of input in cmode == 1 in decode_group3_2d_line()

2021-07-31 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 35591/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4503764022198272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/faxcompr.c | 2 ++ 1 file chang

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aaccoder: Add minimal bias in search_for_ms()

2021-07-31 Thread Michael Niedermayer
On Tue, Jun 01, 2021 at 09:33:14AM +0200, Michael Niedermayer wrote: > Fixes: floating point division by 0 > Fixes: Ticket8218 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aaccoder.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) will apply [...] -- Michael G

Re: [FFmpeg-devel] [PATCH 4/4] avformat/wavdec: Use 64bit in new_pos computation

2021-07-31 Thread Michael Niedermayer
On Tue, Apr 27, 2021 at 09:21:35PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 129 * 16711680 cannot be represented in type > 'int' > Fixes: > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_WAV_fuzzer-6742285317439488 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH 3/4] avformat/sbgdec: Check for overflow in timestamp preparation

2021-07-31 Thread Michael Niedermayer
On Tue, Apr 27, 2021 at 09:21:34PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775807 + 864 cannot be > represented in type 'long' > Fixes: > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6731040263634944 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 2/7] avformat/aiffdec: Check for size overflow in header parsing

2021-07-31 Thread Michael Niedermayer
On Fri, Apr 23, 2021 at 07:50:51PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6723467048255488 > > Found-by: continuous fuzzing process > https://

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread Michael Niedermayer
On Sat, Jul 31, 2021 at 02:51:16PM -0300, James Almer wrote: > On 7/31/2021 2:46 PM, Michael Niedermayer wrote: > > On Sat, Jul 31, 2021 at 01:10:27PM -0300, James Almer wrote: > > > On 7/31/2021 6:41 AM, Michael Niedermayer wrote: > > > > On Fri, Jul 30, 2021 at 10:31:53AM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-31 Thread James Almer
On 7/31/2021 5:47 PM, Michael Niedermayer wrote: On Sat, Jul 31, 2021 at 02:51:16PM -0300, James Almer wrote: On 7/31/2021 2:46 PM, Michael Niedermayer wrote: On Sat, Jul 31, 2021 at 01:10:27PM -0300, James Almer wrote: On 7/31/2021 6:41 AM, Michael Niedermayer wrote: On Fri, Jul 30, 2021 at

Re: [FFmpeg-devel] Fwd: Re: [PATCH] mxfdec.c: prefer metadata from Footer

2021-07-31 Thread Marton Balint
On Fri, 30 Jul 2021, Tomas Härdin wrote: tor 2021-07-29 klockan 22:17 +0200 skrev Marton Balint: On Fri, 23 Jul 2021, emco...@ffastrans.com wrote: > Am 2021-07-04 20:31, schrieb emco...@ffastrans.com: > > Am 2021-07-04 20:28, schrieb emco...@ffastrans.com: > > > Am 2021-07-04 17:28, schrieb

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: report error when picture type is unknown and err_detect is EXPLODE

2021-07-31 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mpeg12dec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 858dca660c..129dc1c2aa 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1529,7 +1529,7 @

[FFmpeg-devel] [PATCH] avformat/mxfdec: make MXFMetadataSet part of all metadata sets

2021-07-31 Thread Marton Balint
The code expects every kind of metadata set to start with the generic metadata set attributes. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 66 ++-- 1 file changed, 21 insertions(+), 45 deletions(-) diff --git a/libavformat/mxfdec.c b/libavform

Re: [FFmpeg-devel] [PATCH v3] ffmpeg_opt: restore documented stream selection behaviour

2021-07-31 Thread Gyan Doshi
Pushed as c50f5460d2f059e5be393eac90e4eac55a6034c6 On 2021-07-31 09:32, Gyan Doshi wrote: Plan to push tomorrow. On 2021-07-29 10:14, Gyan Doshi wrote: 11d3b03fcb added consideration of default stream disposition for audio and video when choosing the 'best' stream among all the inputs. This ca

Re: [FFmpeg-devel] [PATCH v2] libavcodec/libx265: add user data unregistered SEI encoding

2021-07-31 Thread Brad Hards
On Tuesday, 13 July 2021 11:10:20 PM AEST Derek Buitenhuis wrote: > On 7/12/2021 9:24 AM, Brad Hards wrote: > > MISB ST 0604 and ST 2101 require user data unregistered SEI messages > > (precision timestamps and sensor identifiers) to be included. That > > currently isn't supported for libx265. This