Re: [FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

On Mon, 26 Jul 2021, James Almer wrote: On 7/26/2021 6:49 PM, Marton Balint wrote: On Mon, 26 Jul 2021, James Almer wrote: Don't attempt to read its contents in place. Fixes invalid reads when run under Valgrind. As far as I remember AVBPrint buffer CAN be read in place by design, zero

[FFmpeg-devel] Looking for AVfoundation developers

I am currently working on a project that uses FFmpeg in a node native addon (NAPI, C++) and we've hit a seemingly dead end concerning Mac (AVfoundation) performance. Specifically, consuming a 4k 30fps webcam stream suffers from a ~3s latency on the Mac, and this happens on every application on the

[FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

From 2ddd2f5e0d9559bbbf46de3d7cfb7ffbbdbefceb Mon Sep 17 00:00:00 2001 From: Dylan Fernando Date: Tue, 27 Jul 2021 19:25:59 + Subject: [PATCH] lavfi: add nlmeans_cuda filter --- compat/cuda/cuda_runtime.h | 1 + configure | 2 + doc/filters.texi |

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

I'm super loaded with work this week already, so I won't have a chance to look at this before some time next week. First glance looks fine though and I'll come back to you with a proper review next week! smime.p7s Description: S/MIME Cryptographic Signature _

[FFmpeg-devel] [PATCH 1/2] avformat/tests/movenc: fill the packets with some valid data

It will be needed in the next commit, where h264 packets will be parsed by the muxer. Signed-off-by: James Almer --- libavformat/tests/movenc.c | 12 --- tests/ref/fate/movenc | 68 +++--- 2 files changed, 42 insertions(+), 38 deletions(-) diff --git a/l

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

Since we can't blindly trust the keyframe flag in packets and assume its contents are a valid Sync Sample, do some basic bitstream parsing to build the Sync Sample table in addition to a Random Access Recovery Point table. Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavformat/mo

[FFmpeg-devel] [PATCH] Support standard file:// URLs

Our file: protocol bears the same name as the standard file: URL scheme, but it is not compatible: when a file: URL contain special characters, they are encoded with the standard %hh of URLs, but our protocol does not take this into account. As a consequence, if a user copy-pastes a file: URL from

[FFmpeg-devel] [PATCH 01/10] lavu/internal: add hex to int functions.

Signed-off-by: Nicolas George --- libavutil/internal.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavutil/internal.h b/libavutil/internal.h index a33e8700c3..ba221438ed 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -291,4 +291,38 @@

[FFmpeg-devel] [PATCH 02/10] lavu/opt: use ff_hexpair2int().

Signed-off-by: Nicolas George --- libavutil/opt.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 41284d4ecd..c7844d6241 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -167,16 +167,6 @@ static int write_number(

[FFmpeg-devel] [PATCH 03/10] lavfi: add fs protocol as synonym for file.

Signed-off-by: Nicolas George --- libavformat/file.c | 47 - libavformat/protocols.c | 1 + 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 8303436be0..2fb93c23fd 100644 --- a/libavformat/f

[FFmpeg-devel] [PATCH 04/10] lavf: add fs to default_whitelist when file present.

Signed-off-by: Nicolas George --- libavformat/concat.c | 2 +- libavformat/subfile.c | 2 +- libavformat/teeproto.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index aec1f52d8e..66ee792b20 100644 --- a/libavformat/concat.c

[FFmpeg-devel] [PATCH 05/10] lavf/avio: treat fs: the same way as file:.

Signed-off-by: Nicolas George --- libavformat/avio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 4846bbd8c6..13bba52e73 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -217,7 +217,9 @@ int ffurl_connect(URLContex

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg_opt: treat fs: the same way as file:.

Signed-off-by: Nicolas George --- fftools/ffmpeg_opt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 1b43bab9fc..23b4e981c7 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1004,7 +1004,9 @@ static void

[FFmpeg-devel] [PATCH 07/10] lavf/hls: treat fs: the same way as file:.

Signed-off-by: Nicolas George --- libavformat/hls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3c1b80f60c..e1928b6db3 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -646,7 +646,7 @@ static int open_url(AVFormatC

[FFmpeg-devel] [PATCH 08/10] lavf/avio: use fs: by default instead of file:.

Signed-off-by: Nicolas George --- libavformat/avio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 13bba52e73..ebfecac893 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -260,7 +260,7 @@ static const struct URLProtoco

[FFmpeg-devel] [PATCH 09/10] lavf/file: handle standard file:// URLs.

Signed-off-by: Nicolas George --- libavformat/file.c | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 2fb93c23fd..82d9e7bab4 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@

[FFmpeg-devel] [PATCH 10/10] doc: document fs: and file: changes.

Signed-off-by: Nicolas George --- doc/protocols.texi | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1c44..d341d93914 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -283,

[FFmpeg-devel] [PATCH] avformat/concat: check the terminating character returned by av_get_token()

Don't attempt to increase the cursor pointer if it was \0. Fixes invalid reads. Signed-off-by: James Almer --- libavformat/concat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index aec1f52d8e..2560811ff9 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH] avformat/concat: check the terminating character returned by av_get_token()

James Almer (12021-07-27): > Don't attempt to increase the cursor pointer if it was \0. > Fixes invalid reads. > > Signed-off-by: James Almer > --- > libavformat/concat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM, but I do not maintain this file. Regards, -- Nicolas Ge

Re: [FFmpeg-devel] [PATCH] avformat/concat: check the terminating character returned by av_get_token()

On 7/27/2021 12:04 PM, Nicolas George wrote: James Almer (12021-07-27): Don't attempt to increase the cursor pointer if it was \0. Fixes invalid reads. Signed-off-by: James Almer --- libavformat/concat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) LGTM, but I do not maintain t

[FFmpeg-devel] [PATCH] avcodec/noise_bsf: add expr support

--- doc/bitstream_filters.texi | 64 +--- libavcodec/noise_bsf.c | 151 + tests/fate/matroska.mak| 2 +- 3 files changed, 189 insertions(+), 28 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index d10842

[FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

Signed-off-by: Paul B Mahol --- libavfilter/avf_concat.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index cb46f52a04..9bbe896444 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c @@ -397,12

Re: [FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

Paul B Mahol (12021-07-27): > Signed-off-by: Paul B Mahol > --- > libavfilter/avf_concat.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c > index cb46f52a04..9bbe896444 100644 > --- a/libavfilter/avf_concat.

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

On Fri, Jul 23, 2021 at 2:13 PM Michael Niedermayer wrote: > On Thu, Jul 22, 2021 at 11:08:51AM -0700, Thierry Foucu wrote: > > --- > > libavcodec/mpeg12dec.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c > > in

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

--- libavcodec/mpeg12dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..858dca660c 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1340,9 +1340,11 @@ static int mpeg1_decode_picture(

Re: [FFmpeg-devel] [PATCH 01/10] lavu/internal: add hex to int functions.

On Tue, 27 Jul 2021, Nicolas George wrote: Signed-off-by: Nicolas George --- libavutil/internal.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavutil/internal.h b/libavutil/internal.h index a33e8700c3..ba221438ed 100644 --- a/libavutil/internal.h

Re: [FFmpeg-devel] [PATCH 09/10] lavf/file: handle standard file:// URLs.

On Tue, 27 Jul 2021, Nicolas George wrote: Signed-off-by: Nicolas George --- libavformat/file.c | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) You should mention the relevant rfc - RFC8089. Also there are a couple of common deviations/e

Re: [FFmpeg-devel] [PATCH v3 1/4] avutil/mips: Use MMI_{L, S}QC1 macro in {SAVE, RECOVER}_REG

> 2021年7月23日 下午1:53，Jiaxun Yang 写道： > > {SAVE,RECOVER}_REG will be available for Loongson2 again, > also comment about the magic. > > Signed-off-by: Jiaxun Yang > Reviewed-by: Shiyou Yin > --- > libavutil/mips/mmiutils.h | 32 +--- > 1 file changed, 17 insertions(+

Re: [FFmpeg-devel] [PATCH v3 2/4] avcodec/mips: Use MMI marcos to replace Loongson3 instructions

> 2021年7月23日 下午1:53，Jiaxun Yang 写道： > > Loongson3's extention instructions (prefixed with gs) are widely used > in our MMI codebase. However, these instructions are not avilable on > Loongson-2E/F while MMI code should work on these processors. > > Previously we introduced mmiutils marcos to pr

Re: [FFmpeg-devel] [PATCH v3 3/4] avutil/mips: Use $at as MMI macro temporary register

> 2021年7月23日 下午1:53，Jiaxun Yang 写道： > > Some function had exceed 30 inline assembly register oprands limiation > when using LOONGSON2 version of MMI macros. We can avoid that by take > $at, which is register reserved for assembler, as temporary register. > > As none of instructions used in thes

Re: [FFmpeg-devel] [PATCH v3 4/4] avcodec/mips: cabac.h provide fallback for wsbh instruction

> 2021年7月23日 下午1:53，Jiaxun Yang 写道： > > wsbh is only avilable for MIPS R2+. > Provide a fallback for older processors. > > Signed-off-by: Jiaxun Yang > Reviewed-by: Shiyou Yin > --- > libavcodec/mips/cabac.h | 24 > 1 file changed, 24 insertions(+) > > diff --git a/li

[FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: add expr support

--- doc/bitstream_filters.texi | 64 --- libavcodec/noise_bsf.c | 161 + tests/fate/matroska.mak| 2 +- 3 files changed, 199 insertions(+), 28 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index d10842a

[FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: add expr support

--- doc/bitstream_filters.texi | 64 --- libavcodec/noise_bsf.c | 161 + tests/fate/matroska.mak| 2 +- 3 files changed, 199 insertions(+), 28 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index d10842a