[FFmpeg-devel] [PATCH] lavc: fix and extend AVCodecContext.get_format doxy

2021-06-17 Thread Anton Khirnov
Remove some incorrect (or at least misleading) statements, such as the formats being ordered by quality, or the first format being the native one. Neither of those are true for hardware acceleration, which is the main use of this callback. --- libavcodec/avcodec.h | 34 +++-

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: Support encryption of H265 stream in AnnexB format

2021-06-17 Thread Вадим Бездушный
Ping. This patch will allow to encrypt streams, which were produced by hevc_mp4toannexb or movenc muxer. Currently, encryption doesn't work for HEVC AnnexB. The resulting mp4 is not written correctly and can't be played. The patch is quite small and it contains tests, which will allow checking encr

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread Nicolas George
James Almer (12021-06-16): > Considering this discussion started about lavd and lavf, and at no point in > your email you said "all libraries" when suggesting version locking anything > (In fact, you mistakenly wrote "only versions from the same version"), i > figured it would be obvious i was comm

Re: [FFmpeg-devel] [RFC] Internal error messages

2021-06-17 Thread Nicolas George
Diederick C. Niehorster (12021-06-12): > One thing to add is this: Errors are often propagated back through > various layers of function calls. Some next level may: > 1. decide something is not an error/should be ignored. It should be > able to unset the current error (if it was set, so something l

Re: [FFmpeg-devel] [PATCH] lavf/rtmp: Add option to set TCP_NODELAY for rtmp

2021-06-17 Thread Nicolas George
Thilo Borgman (12021-06-11): > Am 11.06.21 um 21:07 schrieb Thilo Borgmann: > > Hi, > > > > > $subject seems to be useful depending on the network. > > > > v2 attached with updates to documentation and code. > > Please check if I missed the point of it. > > Follow-up to add the remark also to TC

Re: [FFmpeg-devel] [RFC] Global state into structure

2021-06-17 Thread Nicolas George
Diederick C. Niehorster (12021-06-12): > As an API user, my main benefit would be to keep log for separate jobs > going on in parallel separate. My application allows capturing data > from one or more high-bandwidth machine vision cameras and storing > them to file with ffmpeg. This often means mul

Re: [FFmpeg-devel] [PATCH 1/2] mov: Pick up "com.apple.quicktime.artwork" as cover art

2021-06-17 Thread Martin Storsjö
On Thu, 15 Apr 2021, Martin Storsjö wrote: On Thu, 1 Apr 2021, Martin Storsjö wrote: --- libavformat/mov.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) Ping Ping (see https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210401115107.53832-1-mar...@martin.st

Re: [FFmpeg-devel] [PATCH 2/2] mov: Don't export unknown/unhandled metadata types as if they were UTF8

2021-06-17 Thread Martin Storsjö
On Thu, 15 Apr 2021, Martin Storsjö wrote: On Thu, 1 Apr 2021, Martin Storsjö wrote: They can be other incompatible text encodings (such as UTF-16), or even binary data. --- libavformat/mov.c | 8 1 file changed, 8 insertions(+) Ping Ping (see https://patchwork.ffmpeg.org/project/

Re: [FFmpeg-devel] [PATCH 20/24] sws: add a function for scaling dst slices

2021-06-17 Thread Michael Niedermayer
On Fri, Jun 11, 2021 at 07:16:17PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-06-11 17:01:20) > > On Thu, Jun 10, 2021 at 05:49:48PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-06-01 15:02:27) > > > > On Mon, May 31, 2021 at 09:55:11AM +0200, Anton Khirn

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread James Almer
On 6/17/2021 6:27 AM, Nicolas George wrote: James Almer (12021-06-16): Considering this discussion started about lavd and lavf, and at no point in your email you said "all libraries" when suggesting version locking anything (In fact, you mistakenly wrote "only versions from the same version"), i

Re: [FFmpeg-devel] [PATCH] Avoid using the --preprocessor argument to windres

2021-06-17 Thread Martin Storsjö
On Mon, 14 Jun 2021, Martin Storsjö wrote: Instead use --preprocessor-arg; in binutils 2.36, the --preprocessor flag was changed so that it no longer accepts a string containing multiple arguments, but the whole --preprocessor argument is treated as the path to the preprocessor executable (where

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread Nicolas George
James Almer (12021-06-17): > Countless avpriv_ symbols would not be gone with any kind of locking. No, they would not be gone. But they would no longer be a compatibility and maintenance burden either. That is a huge benefit. > I already gave you the reason why I'm *against* it. I find it insulti

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread James Almer
On 6/17/2021 9:55 AM, Nicolas George wrote: James Almer (12021-06-17): Countless avpriv_ symbols would not be gone with any kind of locking. No, they would not be gone. But they would no longer be a compatibility and maintenance burden either. That is a huge benefit. I already gave you the r

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread Nicolas George
James Almer (12021-06-17): > Start by dropping the condescending and disregardful attitude every single > one of your replies exudes. Stop giving me orders. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] Compatibility of different library versions (was: avformat: Add internal flags for AV(In|Out)putFormat)

2021-06-17 Thread Nicolas George
Nicolas George (12021-06-17): > Stop giving me orders. And, to make things more things more constructive: What you perceive as condescension from me is actually annoyance, because I feel you never actually read my arguments carefully enough to realize what I mean. I have apologized for rubbing y

[FFmpeg-devel] [PATCH V2] lavf/vf_ocr: add subregion support

2021-06-17 Thread Lingjiang Fang
fix bugs of previous patch, ping for review --- doc/filters.texi | 7 +++ libavfilter/vf_ocr.c | 35 ++- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index da8f7d7726..a955cf46e0 100644 --- a/doc/filters

Re: [FFmpeg-devel] [PATCH] lavf/vf_ocr: add subregion support

2021-06-17 Thread Lingjiang Fang
On Thu, 17 Jun 2021 11:57:00 +0530 Gyan Doshi wrote: > On 2021-06-17 11:31, Lingjiang Fang wrote: > > --- > > doc/filters.texi | 7 +++ > > libavfilter/vf_ocr.c | 30 +- > > 2 files changed, 36 insertions(+), 1 deletion(-) > > > > diff --git a/doc/filters.

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/qsvdec: fix pts

2021-06-17 Thread Zhong Li
LGTM, will apply Haihao Xiang 于2021年6月11日周五 上午10:20写道: > > The time base used for compressed bitstream and video frame in the SDK > is { 1, 9 }. [1][2] > > This can avoid the error message below from the muxer. > > $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i input.h265 -f null - > ... > [null @ 0

Re: [FFmpeg-devel] [PATCH V2] lavf/vf_ocr: add subregion support

2021-06-17 Thread Gyan Doshi
On 2021-06-17 20:28, Lingjiang Fang wrote: fix bugs of previous patch, ping for review --- doc/filters.texi | 7 +++ libavfilter/vf_ocr.c | 35 ++- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi ind

[FFmpeg-devel] [PATCH] avcodec/cuviddec: remove unused AVCodec.decode() callback

2021-06-17 Thread James Almer
The AVCodec.receive_frame() callback takes precedence. Signed-off-by: James Almer --- libavcodec/cuviddec.c | 32 1 file changed, 32 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index c3496259dc..d8c7f23a37 100644 --- a/libavcodec/cuvi

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-17 Thread James Zern
On Wed, Jun 16, 2021 at 3:53 PM Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL is

Re: [FFmpeg-devel] [PATCH] lavf/webmdashenc.c: Allow AV1 video in WebM

2021-06-17 Thread James Zern
Hi, On Sun, Jun 13, 2021 at 12:46 PM Thilo Borgmann wrote: > > Hi, > > not sure about the spec backing this up, however the following site lists AV1 > support in WebM: > https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs > This should probably get a version bump. I think th

[FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-17 Thread Timo Rothenpieler
--- doc/filters.texi | 6 ++ libavfilter/f_select.c | 18 ++ libavfilter/version.h | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index da8f7d7726..db6ecd7c2a 100644 --- a/doc/filters.texi +++ b/doc/filters.te

Re: [FFmpeg-devel] [PATCH 1/3] avutil/tx: avoid negative left shifts

2021-06-17 Thread Michael Niedermayer
On Tue, May 04, 2021 at 11:05:02PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 33736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SIREN_fuzzer-6657785795313664 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mccdec: Fix overflows in num/den

2021-06-17 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:04:48PM -0300, James Almer wrote: > On 4/24/2021 12:59 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 6365816 * 1000 cannot be represented in > > type 'int' > > Fixes: > > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_MCC_fuzzer-6737934184218624 >

Re: [FFmpeg-devel] [PATCH 1/4] avformat/dxa: Check fps to be within the supported range more precissely

2021-06-17 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 05:59:23PM +0200, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka > 'int'); cast to an unsigned type to negate this value to itself > Fixes: assertiomnm failure > Fixes: > 29102/clusterfuzz-testcase-minimized-ffmpeg_

Re: [FFmpeg-devel] [PATCH 1/6] avformat/subtitles: Check pts difference before use

2021-06-17 Thread Michael Niedermayer
On Sun, Apr 25, 2021 at 09:40:09PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be > represented in type 'long' > Fixes: > 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_MPL2_fuzzer-6747053545881600 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rmdec: Check old_format len for overflow

2021-06-17 Thread Michael Niedermayer
On Tue, Apr 27, 2021 at 09:21:32PM +0200, Michael Niedermayer wrote: > Maybe such large values could be disallowed earlier and closer to where > they are set. > > Fixes: signed integer overflow: 538976288 * 8224 cannot be represented in > type 'int' > Fixes: > 29102/clusterfuzz-testcase-minimize

[FFmpeg-devel] [PATCH] Update missed irc links

2021-06-17 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- configure | 2 +- doc/writing_filters.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6bfd98b384..ecdcebf21c 100755 --- a/configure +++ b/configure @@ -534,7 +534,7 @@ die(){ If you thin

Re: [FFmpeg-devel] [PATCH] Update missed irc links

2021-06-17 Thread James Almer
On 6/17/2021 6:01 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- configure | 2 +- doc/writing_filters.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6bfd98b384..ecdcebf21c 100755 --- a/configure +++

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc_hevc: allow user set more coding options

2021-06-17 Thread Xiang, Haihao
> The SDK supports NalHrdConformance, RecoveryPointSEI and AUDelimiter for > hevc encoder, so we may allow user to set these coding options like what > we did for h264_qsv encoder. > > '-strict xxx' to turn on / off NalHrdConformance > '-recovery_point_sei xxx' to turn on / off RecoveryPointSEI

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-17 Thread Pavel Koshevoy
On Sun, Jun 13, 2021 at 3:49 PM Pavel Koshevoy wrote: > > > On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy > wrote: > >> Un-hardcode the 200ms minimum latency between emitting subtitle events >> so that those that wish to receive a subtitle event for every screen >> change could do so. >> >> The

Re: [FFmpeg-devel] [PATCH] avfilter/select: evaluate silencedetect metadata

2021-06-17 Thread Gyan Doshi
On 2021-06-18 01:53, Timo Rothenpieler wrote: --- doc/filters.texi | 6 ++ libavfilter/f_select.c | 18 ++ libavfilter/version.h | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index da8f7d7726..db6ecd

[FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-17 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-17 Thread Mohammad Izadi
On Thu, Jun 17, 2021 at 1:04 PM James Zern wrote: > On Wed, Jun 16, 2021 at 3:53 PM Mohammad Izadi > wrote: > > > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > different for VP9 and cannot store the metadata in the bit stream. HDR10+ > should be passed to packet side dat

Re: [FFmpeg-devel] [PATCH V2] lavf/vf_ocr: add subregion support

2021-06-17 Thread Lingjiang Fang
On Thu, 17 Jun 2021 22:08:52 +0530 Gyan Doshi wrote: > On 2021-06-17 20:28, Lingjiang Fang wrote: > > fix bugs of previous patch, ping for review > > --- > > doc/filters.texi | 7 +++ > > libavfilter/vf_ocr.c | 35 ++- > > 2 files changed, 41 insertion