[FFmpeg-devel] [PATCH V5 4/5] lavfi/dnn_backend_native_layer_depth2space.h: Documentation

2021-05-14 Thread Shubhanshu Saxena
Add documentation for Depth to Space Layer Signed-off-by: Shubhanshu Saxena --- .../dnn_backend_native_layer_depth2space.h| 30 +++ 1 file changed, 30 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_depth2space.h b/libavfilter/dnn/dnn_backend_native_laye

[FFmpeg-devel] [PATCH V5 5/5] lavfi/dnn_backend_native_layer_mathunary.h: Documentation

2021-05-14 Thread Shubhanshu Saxena
Add documentation for Unary Math Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_mathunary.h | 30 +++ 1 file changed, 30 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathunary.h b/libavfilter/dnn/dnn_backend_native_layer_math

[FFmpeg-devel] [PATCH V5 2/5] lavfi/dnn_backend_native_layer_conv2d.h: Documentation

2021-05-14 Thread Shubhanshu Saxena
Add documentation for 2D Convolution Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_conv2d.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.h b/libavfilter/dnn/dnn_backend_native_layer_con

Re: [FFmpeg-devel] [PATCH V4 2/5] lavfi/dnn_backend_native_layer_conv2d.h: Documentation

2021-05-14 Thread Shubhanshu Saxena
On Fri, May 14, 2021 at 7:23 AM Guo, Yejun wrote: > > typo for 'average pooling parameters' in patch 2 to patch 5. > > will push patch 1 soon. > > Corrected ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

[FFmpeg-devel] [PATCH V5 3/5] lavfi/dnn_backend_native_layer_dense.h: Documentation

2021-05-14 Thread Shubhanshu Saxena
Add documentation for Dense Layer Signed-off-by: Shubhanshu Saxena --- .../dnn/dnn_backend_native_layer_dense.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native_layer_dense.h b/libavfilter/dnn/dnn_backend_native_layer_dense.h index

Re: [FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

2021-05-14 Thread Marton Balint
On Fri, 14 May 2021, Brad Hards wrote: On Friday, 14 May 2021 1:59:13 AM AEST Marton Balint wrote: On Tue, 11 May 2021, Brad Hards wrote: On Saturday, 1 May 2021 12:23:00 PM AEST Brad Hards wrote: MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps an

[FFmpeg-devel] Segmentation fault when running vulkan

2021-05-14 Thread Dylan Fernando
When running vulkan on arch linux, I get a segmentation fault. Command: ffmpeg -v verbose -init_hw_device vulkan=gpu:0.0 -filter_hw_device gpu -i atm.mp4 -filter_complex hwupload,avgblur_vulkan,hwdownload atmvulk.mp4 -loglevel debug Output: ffmpeg version N-102515-g175f675f7b Copyright (c) 2000-20

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-05-10 16:06:01) > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > > There are no guarantees that all side data types have the same > > representation on all platforms. > > > @@ -65,63 +51,6 @@ static int framecrc_write_packet(struct AVFormatContex

Re: [FFmpeg-devel] [PATCH] lavf/flvdec: normalize exporting date metadata

2021-05-14 Thread Anton Khirnov
Quoting Alexander Strasser (2021-05-12 01:04:28) > From 3fd6c8f81baacace49e0a6cc431295dc56a077bc Mon Sep 17 00:00:00 2001 > From: Alexander Strasser > Date: Wed, 12 May 2021 00:46:54 +0200 > Subject: [PATCH] lavf/flvdec: metadata date: respect timezone information if > present > > If the timezon

Re: [FFmpeg-devel] [PATCH 00/22] clean-up QSV filters

2021-05-14 Thread Anton Khirnov
'lavf' means libavformat, 'lavfi' is used for libavfilter -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-14 Thread Anton Khirnov
Quoting Marton Balint (2021-05-12 20:55:45) > Take into account timezone. Use millisecond precision. Maybe we could also use > nanosecond, but there were some float rounding concerns. > > Signed-off-by: Marton Balint > --- > libavformat/flvdec.c | 13 ++--- > tests/ref/fate/flv-demux

[FFmpeg-devel] [PATCH 1/3] lavfi/drawbox: refine code

2021-05-14 Thread Ting Fu
Extract common code of filter_frame() and drawgrid_filter_frame() to draw_region(). Signed-off-by: Ting Fu --- libavfilter/vf_drawbox.c | 160 ++- 1 file changed, 58 insertions(+), 102 deletions(-) diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawb

[FFmpeg-devel] [PATCH 2/3] libavfilter: vf_drawbox filter support draw box with detection bounding boxes in side_data

2021-05-14 Thread Ting Fu
This feature can be used with dnn detection by setting vf_drawbox's option box_source=side_data_detection_bboxes, for example: ./ffmpeg -i face.jpeg -vf dnn_detect=dnn_backend=openvino:model=face-detection-adas-0001.xml:\ input=data:output=detection_out:labels=face-detection-adas-0001.label,\ draw

[FFmpeg-devel] [PATCH 3/3] libavfilter: vf_drawtext filter support draw text with detection bounding boxes in side_data

2021-05-14 Thread Ting Fu
This feature can be used with dnn detection by setting vf_drawtext's option text_source=side_data_detection_bboxes, for example: ./ffmpeg -i face.jpeg -vf dnn_detect=dnn_backend=openvino:model=face-detection-adas-0001.xml:\ input=data:output=detection_out:labels=face-detection-adas-0001.label,draw

Re: [FFmpeg-devel] [FFmpeg-cvslog] GSoC: Support fast guided filter.

2021-05-14 Thread Anton Khirnov
Quoting Xuewei Meng (2021-05-13 05:59:34) > ffmpeg | branch: master | Xuewei Meng | Mon May 10 > 21:42:31 2021 +0800| [43d70feb788318b124418c5c666f2120ee5ca930] | committer: > Steven Liu > > GSoC: Support fast guided filter. This does not conform to our rules for commit messages. "GSoC" has n

Re: [FFmpeg-devel] [FFmpeg-cvslog] GSoC: Support fast guided filter.

2021-05-14 Thread Steven Liu
> 2021年5月14日 下午5:12,Anton Khirnov 写道: > > Quoting Xuewei Meng (2021-05-13 05:59:34) >> ffmpeg | branch: master | Xuewei Meng | Mon May 10 >> 21:42:31 2021 +0800| [43d70feb788318b124418c5c666f2120ee5ca930] | committer: >> Steven Liu >> >> GSoC: Support fast guided filter. > > This does not

Re: [FFmpeg-devel] [FFmpeg-cvslog] GSoC: Support fast guided filter.

2021-05-14 Thread Anton Khirnov
Quoting Steven Liu (2021-05-14 11:15:23) > > > > 2021年5月14日 下午5:12,Anton Khirnov 写道: > > > > Quoting Xuewei Meng (2021-05-13 05:59:34) > >> ffmpeg | branch: master | Xuewei Meng | Mon May 10 > >> 21:42:31 2021 +0800| [43d70feb788318b124418c5c666f2120ee5ca930] | > >> committer: Steven Liu > >

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Ubaldo Porcheddu
Hi Marton, Il 2021-05-12 19:18 Marton Balint ha scritto: On Wed, 12 May 2021, Ubaldo Porcheddu wrote: Hi Marton, +} + +//private data +desc_len += 6 + 2; +*q++ = 0x5F; +*q++ = 4; +*q++ = 0x00; +*q++ = 0x00; +put16(&q, 40); What are these? I didn't find any

[FFmpeg-devel] [PATCH 0/3] vf_guided patches

2021-05-14 Thread Andreas Rheinhardt
These patches address some issues in this filter; I initially wanted to nuke it after having found out that it runs into the av_assert1() in ff_filter_activate() (it seems that generic timeline support together with .activate is not supported, but I don't know what is wrong with it), but decided ag

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_guided: Don't needlessly copy properties, fix potential NPD

2021-05-14 Thread Andreas Rheinhardt
ref_frame is owned by the framesync structure and should therefore not be modified; furthermore, these properties that are copied don't seem to be used at all, so copying is unnecessary. Finally copying when the destination frame is NULL gives a guaranteed segfault. Signed-off-by: Andreas Rheinhar

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_guided: Don't free frame we don't own

2021-05-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_guided.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c index e7c689e7be..e10d397f2e 100644 --- a/libavfilter/vf_guided.c +++ b/libavfilter/vf_guided.c @@ -329,7 +329,6 @@ static int process

[FFmpeg-devel] [PATCH] avfilter/metadata: add intuitive labels for metadata values

2021-05-14 Thread Gyan Doshi
--- doc/filters.texi | 4 ++-- libavfilter/f_metadata.c | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index ed0ffe91fc..1a8843fe4f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -25296,10 +25296,10 @@ The expressio

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_guided: Fix leak of frames

2021-05-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_guided.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c index e10d397f2e..ce78507eb6 100644 --- a/libavfilter/vf_guided.c +++ b/libavfilter/vf_guided.c @@ -353,6 +353,7 @@ static int proces

Re: [FFmpeg-devel] [PATCH] avfilter/guided: simplify subsampling assignment.

2021-05-14 Thread Gyan Doshi
On 2021-05-14 09:18, Steven Liu wrote: 2021年5月14日 上午11:43,Gyan Doshi 写道: Reduce option ranges to effective values. --- Will reindent after this is applied. libavfilter/vf_guided.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_guided: add null pointer check of ref_frame and main_frame

2021-05-14 Thread Andreas Rheinhardt
Steven Liu: > fix CID: 1484785 > check ref_frame and main_frame before use them > Ignore previous patch please, this should better than that. > > Signed-off-by: Steven Liu > --- > libavfilter/vf_guided.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_gui

[FFmpeg-devel] [PATCH] avcodec/libx264: Fix redundant setting of caps_internal

2021-05-14 Thread Andreas Rheinhardt
Exists since 8a129077cc37202a00dd666bd5365c3f61ea2e80. Fixes a -Winitializer-overrides warning when building with Clang. Signed-off-by: Andreas Rheinhardt --- libavcodec/libx264.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 22c91d8df7..1c2

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Dominguez Bonini, David
Hi, > Hi Marton, > > Il 2021-05-12 19:18 Marton Balint ha scritto: > > On Wed, 12 May 2021, Ubaldo Porcheddu wrote: > > > >> Hi Marton, > >> > +} > + > +//private data > +desc_len += 6 + 2; > +*q++ = 0x5F; > +*q++ = 4; > +*q++ = 0x00; > >

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_guided: Don't free frame we don't own

2021-05-14 Thread Steven Liu
> 2021年5月14日 下午6:18,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_guided.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c > index e7c689e7be..e10d397f2e 100644 > --- a/libavfilter/vf_guided.c > +++

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees that all side data types have the same representation on all platforms. @@ -65,63 +51,6 @@ static int framecrc_w

Re: [FFmpeg-devel] ffprobe as library rather than CLI

2021-05-14 Thread Tobias Rapp
On 12.05.2021 15:52, Timo Rothenpieler wrote: On 12.05.2021 15:19, Samuel Marks wrote: Started hacking around to make it work. So I changed the `main` to a: extern int ffprobe(int argc, char **argv); Then I added a header with a prototype of the same, and started messing with vcpkg + CMake to

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-14 Thread Ubaldo Porcheddu
Hola David, thank you for clarifying it, maybe we leave 0x28 by default and add a "nit_private" option for: none, NorDig, UK ? Here is the function so far: +static void mpegts_write_nit(AVFormatContext *s) +{ +int i, lcn_count=0; +MpegTSWrite *ts = s->priv_data; +uint8_t data[SECT

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Michael Niedermayer
On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: > On 5/14/2021 5:01 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-05-10 16:06:01) > > > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > > > > There are no guarantees that all side data types have the same

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 3:16 PM, Michael Niedermayer wrote: On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees tha

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-14 Thread Marton Balint
On Fri, 14 May 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-05-12 20:55:45) Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13 ++--

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Restore DTS correction for VP9 copies

2021-05-14 Thread James Zern
Hi, On Wed, May 12, 2021 at 8:33 PM Danny Wu wrote: > > > Shouldn't google not produce invalid files? Also, can you link one of > > these videos to test this issue? > I filed a bug for this (b/188197059). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

[FFmpeg-devel] [PATCH v2] avformat/flvdec: use milisecond precision for parsing timestamps

2021-05-14 Thread Marton Balint
Also use helper function to set the timestamp. Maybe we could also use nanosecond precision, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 11 ++- tests/ref/fate/flv-demux | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-

[FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-05-14 Thread Gustav Grusell
Before, seeking in hls streams would always seek to the next keyframe after the given timestamp. With this fix, if AVSEEK_FLAG_BACKWARD is set, seeking will be to the first keyframe of the segment containing the given timestamp. This fixes #6850. --- libavformat/hls.c | 13 + 1 file

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Andreas Rheinhardt
James Almer: > On 5/14/2021 3:16 PM, Michael Niedermayer wrote: >> On Fri, May 14, 2021 at 09:42:10AM -0300, James Almer wrote: >>> On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) > On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote:

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread Anton Khirnov
Quoting James Almer (2021-05-14 14:42:10) > On 5/14/2021 5:01 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-05-10 16:06:01) > >> On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: > >>> There are no guarantees that all side data types have the same > >>> representation

Re: [FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-05-14 Thread James Almer
On 5/14/2021 5:28 PM, Anton Khirnov wrote: Quoting James Almer (2021-05-14 14:42:10) On 5/14/2021 5:01 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-05-10 16:06:01) On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote: There are no guarantees that all side data types hav

[FFmpeg-devel] [PATCH] avformat/framecrcenc: print basic side data information again

2021-05-14 Thread James Almer
This partially reverts c6ae560a18d67b9ddaa25a0338b7fb55e3312e57. Signed-off-by: James Almer --- libavformat/framecrcenc.c | 8 + tests/ref/fate/copy-trac3074 | 2 +- tests/ref/fate/cover-art-mp3-id3v2-remux | 2 +- tests/ref/fate/gapless-mp3

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: Ignore the first two data/subtitle streams.

2021-05-14 Thread Josh Allmann
On Thu, 13 May 2021 at 16:38, Josh Allmann wrote: > > Previously, one or the other would have been ignored, but not both. > Since the probe terminates at three streams, it could exit > prematurely if both data and subtitles are present along with > slightly trailing media, usually video trailing a

[FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

2021-05-14 Thread Brad Hards
MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps and sensor identifiers) to be included. That currently isn't supported. This series adds encoding for libx264, libx265, hevc_nvenc and h264_nvenc. v2 removed the API addition, modifies nvenc to use a dynami

[FFmpeg-devel] [PATCH v3 1/3] libavcodec: write out user data unregistered SEI for x264

2021-05-14 Thread Brad Hards
Signed-off-by: Brad Hards --- libavcodec/libx264.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 1c27f7b441..feee8f8ee6 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -31,

[FFmpeg-devel] [PATCH v3 2/3] libavcodec: write out user data unregistered SEI for x265

2021-05-14 Thread Brad Hards
Signed-off-by: Brad Hards --- libavcodec/libx265.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index a1bd205201..e21eb8828d 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -484,6 +484,7 @@ static int libx2

[FFmpeg-devel] [PATCH v3 3/3] libavcodec: write out user data unregistered SEI for nvenc

2021-05-14 Thread Brad Hards
Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 64 ++ 1 file changed, 53 insertions(+), 11 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99c..9bf2728cba 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -2

[FFmpeg-devel] [PATCH] avfilter/vf_palettegen: add protection against potential divide by zero

2021-05-14 Thread Yiyuan GUO
In libavfilter/vf_palettegen.c, the function get_avg_color requires that box->len greater than zero to avoid dividing by zero. However, the call sequence filter_frame -> get_palette_frame -> get_avg_color may not satisfy this precondition. The bug is detailed in the bug tracker:https://trac.ffmpeg.