Re: [FFmpeg-devel] [PATCH 2/2] avformat/dv: use av_packet_alloc() to allocate packets

2021-05-02 Thread Michael Niedermayer
On Fri, Apr 30, 2021 at 03:07:01PM -0300, James Almer wrote: > As avpriv_dv_get_packet can fail now, make it return < 0 on error, 0 on no > packet found, and > 0 on packet found. > > Signed-off-by: James Almer > --- > libavdevice/iec61883.c | 2 +- > libavformat/avidec.c | 4 +++- > libavfor

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dv: use av_packet_alloc() to allocate packets

2021-05-02 Thread James Almer
On 5/2/2021 1:10 AM, Andreas Rheinhardt wrote: James Almer: As avpriv_dv_get_packet can fail now, make it return < 0 on error, 0 on no packet found, and > 0 on packet found. Signed-off-by: James Almer --- libavdevice/iec61883.c | 2 +- libavformat/avidec.c | 4 +++- libavformat/dv.c

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dv: use av_packet_alloc() to allocate packets

2021-05-02 Thread James Almer
On 5/2/2021 6:21 AM, Michael Niedermayer wrote: On Fri, Apr 30, 2021 at 03:07:01PM -0300, James Almer wrote: As avpriv_dv_get_packet can fail now, make it return < 0 on error, 0 on no packet found, and > 0 on packet found. Signed-off-by: James Almer --- libavdevice/iec61883.c | 2 +- libav

[FFmpeg-devel] [PATCH 1/3] avformat/dv: stop using av_init_packet()

2021-05-02 Thread James Almer
Signed-off-by: James Almer --- libavformat/dv.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/libavformat/dv.c b/libavformat/dv.c index cbb38cbd7d..d7909683c3 100644 --- a/libavformat/dv.c +++ b/libavformat/dv.c @@ -40,12 +40,22 @@ #include "dv.h"

[FFmpeg-devel] [PATCH 2/3] avcodec/avi: don't save a copy of the packet's AVBufferRef on DV streams

2021-05-02 Thread James Almer
It's no longer needed. Signed-off-by: James Almer --- libavformat/avidec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index d5dcab6193..e0d868e074 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -1494,10 +1494,8 @@ resync:

[FFmpeg-devel] [PATCH 3/3] avcodec/mov: don't save a copy of the packet's AVBufferRef on DV streams

2021-05-02 Thread James Almer
It's no longer needed. Signed-off-by: James Almer --- libavformat/mov.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ca8f06c4cd..ca6a0f2db4 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7930,9 +7930,7 @@ static int mov_read_packet(

[FFmpeg-devel] [PATCH 4/4] avcodec/jpeglsdec: Set alpha plane in PAL8 so image is not 100% transparent

2021-05-02 Thread Michael Niedermayer
Fixes: tickets/3933/128.jls Signed-off-by: Michael Niedermayer --- libavcodec/jpeglsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jpeglsdec.c b/libavcodec/jpeglsdec.c index bd9224d97d..c61cb14f49 100644 --- a/libavcodec/jpeglsdec.c +++ b/libavcodec/jpeglsde

[FFmpeg-devel] [PATCH 3/4] avcodec/mjpegdec: Decode to PAL8 independant of the location of LSE

2021-05-02 Thread Michael Niedermayer
This simply performs a 2nd pass if a LSE is encountered with GRAY8 Fixes: tickets/3933/128.jls Signed-off-by: Michael Niedermayer --- libavcodec/jpeglsdec.c | 6 -- libavcodec/mjpegdec.c | 10 +++--- libavcodec/mjpegdec.h | 1 + 3 files changed, 12 insertions(+), 5 deletions(-) dif

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker

2021-05-02 Thread Michael Niedermayer
On Sat, May 01, 2021 at 12:18:02PM -0300, James Almer wrote: > On 5/1/2021 12:06 PM, James Almer wrote: > > On 5/1/2021 11:30 AM, James Almer wrote: > > > On 5/1/2021 11:17 AM, Michael Niedermayer wrote: > > > > On Sat, May 01, 2021 at 09:41:55AM -0300, James Almer wrote: > > > > > On 5/1/2021 4:01

[FFmpeg-devel] [PATCH 2/4] Revert "avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker"

2021-05-02 Thread Michael Niedermayer
This reverts commit c8197f73e684b0edc450f3dc2b2b4b3fb9dedd0d. --- libavcodec/jpeglsdec.c | 6 ++- libavcodec/mjpegbdec.c | 1 - libavcodec/mjpegdec.c | 83 +- libavcodec/mjpegdec.h | 3 -- libavcodec/mxpegdec.c | 2 +- 5 files changed, 39 insertions(+

[FFmpeg-devel] [PATCH 1/4] Revert "avcodec/mjpegdec: fix SOF check in EOI"

2021-05-02 Thread Michael Niedermayer
This reverts commit fb5e2d71127ccae19c3f80ec363bb67d1871cb74. --- libavcodec/mjpegdec.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index c829172200..16aed078f6 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.

Re: [FFmpeg-devel] [PATCH 2/4] Revert "avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker"

2021-05-02 Thread James Almer
On 5/2/2021 10:59 AM, Michael Niedermayer wrote: This reverts commit c8197f73e684b0edc450f3dc2b2b4b3fb9dedd0d. Applying this alone will break fate-jpegls, which is not good for bisectabiliy. Can you merge it with patch 3/4 before pushing? Or temporarily disable the tests in a separate commit

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mjpegdec: Decode to PAL8 independant of the location of LSE

2021-05-02 Thread James Almer
On 5/2/2021 10:59 AM, Michael Niedermayer wrote: This simply performs a 2nd pass if a LSE is encountered with GRAY8 Fixes: tickets/3933/128.jls Signed-off-by: Michael Niedermayer --- libavcodec/jpeglsdec.c | 6 -- libavcodec/mjpegdec.c | 10 +++--- libavcodec/mjpegdec.h | 1 +

[FFmpeg-devel] [PATCH] avcodec/decode: stop trying to initialize palette values in avcodec_default_get_buffer2()

2021-05-02 Thread James Almer
avpriv_set_systematic_pal2() is meant to fill fixed vales for formats that until recently were marked as "pseudo pal". It's not being called for them anymore in here, and it's a no-op when used on real PAL formats. Signed-off-by: James Almer --- libavcodec/decode.c | 2 -- 1 file changed, 2 dele

[FFmpeg-devel] [PATCH] [GSOC] avfilter: added guided filter

2021-05-02 Thread Andrey Moskalenko
Added guided filter with subsampling and multithreading for speedup. --- doc/filters.texi | 25 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_guided.c | 400 +++ 4 files changed, 427 insertions(+) create mode 1

Re: [FFmpeg-devel] [PATCH] Add optional NIT table generation

2021-05-02 Thread Marton Balint
On Tue, 27 Apr 2021, Ubaldo Porcheddu wrote: Signed-off-by: Ubaldo Porcheddu --- libavformat/mpegtsenc.c | 110 ++-- 1 file changed, 106 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a357f3a6aa..

[FFmpeg-devel] [PATCH] avfilter/vf_subtitles: allow using embedded fonts

2021-05-02 Thread Oneric
ASS subtitles can have encoded fonts embedded into the subtitle file itself. Allow libass to load those, to render subs as intended. --- A sample file for ASS with embedded font can be at the following link. If everything works, the 'A' will render as a quad; see image: https://raw.githubusercont

Re: [FFmpeg-devel] [PATCH] ffmpeg: stop accessing private AVStream.codec_info_nb_frames

2021-05-02 Thread James Almer
On 4/29/2021 11:38 AM, James Almer wrote: Use AVSTREAM_EVENT_FLAG_NEW_PACKETS instead, which should provide the same information in this case. Finishes removing all uses of this field as started by 87f0c8280c. Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 3 ++- 1 file changed, 2 ins

[FFmpeg-devel] [PATCH] avutil/imgutils: don't add offsets to NULL pointers

2021-05-02 Thread James Almer
Signed-off-by: James Almer --- libavutil/imgutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 53faad889a..aaee0dfb7a 100644 --- a/libavutil/imgutils.c +++ b/libavutil/imgutils.c @@ -166,7 +166,7 @@ int av_image_fill_point