[FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
It can handle side data cleanly. --- tests/fate/demux.mak | 2 +- tests/ref/fate/ts-small-demux | 229 ++ 2 files changed, 150 insertions(+), 81 deletions(-) diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index c55488fe61..ac224d6bf4 100644 ---

[FFmpeg-devel] [PATCH 01/12] ffprobe: only hash extradata when it is present

2021-04-25 Thread Anton Khirnov
Passing zero-sized/NULL buffers to av_hash_update() is invalid and may crash with certain hashes. --- fftools/ffprobe.c | 7 +-- tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 - tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov |

[FFmpeg-devel] [PATCH 03/12] fate-oggopus-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
It can print side data cleanly. --- tests/fate-run.sh| 9 tests/fate/demux.mak | 2 +- tests/ref/fate/oggopus-demux | 93 +--- 3 files changed, 55 insertions(+), 49 deletions(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index b69

[FFmpeg-devel] [PATCH 02/12] ffprobe: support printing more packet side data types

2021-04-25 Thread Anton Khirnov
Specifically WebVTT subtitle data, CPB properties, audio service type and mpegts stream id. --- fftools/ffprobe.c | 17 +++ tests/ref/fate/concat-demuxer-simple2-lavf-ts | 128 +- tests/ref/fate/mxf-probe-d10 | 5 + 3 files changed, 8

[FFmpeg-devel] [PATCH 11/12] fate: drop the vp8-alpha test

2021-04-25 Thread Anton Khirnov
It is redundant with matroska-vp8-alpha-remux. --- tests/fate/vpx.mak | 3 - tests/ref/fate/vp8-alpha | 125 --- 2 files changed, 128 deletions(-) delete mode 100644 tests/ref/fate/vp8-alpha diff --git a/tests/fate/vpx.mak b/tests/fate/vpx.mak index 85

[FFmpeg-devel] [PATCH 09/12] fate-webm-webvtt-remux: print packet side data in ffprobe output

2021-04-25 Thread Anton Khirnov
--- tests/fate/matroska.mak | 2 +- tests/ref/fate/webm-webvtt-remux | 336 +++ 2 files changed, 337 insertions(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index becca28e1a..ca7193a055 100644 --- a/tests/fate/matroska.mak

[FFmpeg-devel] [PATCH 04/12] fate/gapless: add a test for skip samples side data

2021-04-25 Thread Anton Khirnov
--- tests/fate/gapless.mak | 3 + tests/ref/fate/gapless-mp3-side-data | 600 +++ 2 files changed, 603 insertions(+) create mode 100644 tests/ref/fate/gapless-mp3-side-data diff --git a/tests/fate/gapless.mak b/tests/fate/gapless.mak index 3a82c3ef68..b035

[FFmpeg-devel] [PATCH 07/12] fate-ts-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
It can handle side data cleanly. --- tests/fate/demux.mak| 2 +- tests/ref/fate/ts-demux | 80 - 2 files changed, 49 insertions(+), 33 deletions(-) diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index 66a90a107a..dfc4ee2b4e 100644 --- a/tests

[FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

2021-04-25 Thread Anton Khirnov
There are no guarantees that all side data types have the same representation on all platforms. Tests that change output due to this: id3v2-priv-remux, cover-art-mp3-id3v2-remux, gapless-mp3: SKIP_SAMPLES, which is tested by fate-gapless-mp3-side-data matroska-vp8-alpha-remux: MATROSKA_BLOCKADDI

[FFmpeg-devel] [PATCH 10/12] fate-run.sh: print stream side data in probeaudiostream()

2021-04-25 Thread Anton Khirnov
Adds a test for reading AUDIO_SERVICE_TYPE in fate-hls-fmp4_ac3 --- tests/fate-run.sh | 2 +- tests/ref/fate/hls-fmp4_ac3 | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index dd3f564e18..ba437dfbb8 100755 --- a/tests/fate-run.s

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: set DataRateLimits for hevc

2021-04-25 Thread Zhao Zhili
>From the comment it's not available on old version. It works now by testing on macOS 11.2.1. There is no document about since when. So trying to set the configuration and ignore the error for hevc. --- libavcodec/videotoolboxenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: set DataRateLimits for hevc

2021-04-25 Thread Steven Liu
> 2021年4月25日 下午4:06,Zhao Zhili 写道: > > From the comment it's not available on old version. It works now > by testing on macOS 11.2.1. There is no document about since when. > So trying to set the configuration and ignore the error for hevc. > --- > libavcodec/videotoolboxenc.c | 10 +++--- >

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-25 Thread Paul B Mahol
Please apply. On Fri, Apr 23, 2021 at 4:39 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > James Almer: > > On 4/23/2021 11:18 AM, Andreas Rheinhardt wrote: > >> James Almer: > >>> Should fix ticket #9196 > >>> > >>> Signed-off-by: James Almer > >>> --- > >>> libavfilter/af_ad

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Michael Niedermayer
On Sun, Apr 25, 2021 at 09:03:13AM +0200, Anton Khirnov wrote: > It can handle side data cleanly. [] > +stream|index=0|codec_name=h264|profile=578|codec_type=video|codec_tag_string=[27][0][0][0]|codec_tag=0x001b|width=82|height=144|coded_width=82|coded_height=144|closed_captions=0|has_b_frames=

[FFmpeg-devel] [PATCH 1/2] doc: fix generating doxy with out-of-tree builds

2021-04-25 Thread Anton Khirnov
Broken in 753930bc7300dd595c4bab51c5a70d1da9083da4, as the path to Doxyfile passed to doxy-wrapper.sh is relative to the build dir, while the recipe cd's to the source dir before invoking the wrapper. --- doc/Makefile| 2 +- doc/doxy-wrapper.sh | 9 ++--- 2 files changed, 7 insertions(

[FFmpeg-devel] [PATCH 2/2] lavf: clarify probesize/format_probesize doxy

2021-04-25 Thread Anton Khirnov
probesize is not used for probing the input format, but its documentation claims it does. --- libavformat/avformat.h | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 8600ee1bf7..00e78a4a11 100644 --- a/l

Re: [FFmpeg-devel] [PATCH 01/14] avcodec/ffv1dec: Remove redundant writes, fix races

2021-04-25 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-04-24 12:53:24) > Every modification of the data that is copied in update_thread_context() > is a data race if it happens after ff_thread_finish_setup. ffv1dec's > update_thread_context() simply uses memcpy for updating the new context, > so that every modification

Re: [FFmpeg-devel] [PATCH 02/14] avcodec/ffv1dec: Don't set ThreadFrame properties, fix race

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:34PM +0200, Andreas Rheinhardt wrote: > Each FFV1 slice has its own SAR and picture structure encoded; > when a slice header was parsed, the relevant fields of a ThreadFrame's > AVFrame were directly set based upon the parsed values. This is > a data race in case slice

Re: [FFmpeg-devel] [PATCH 03/14] avcodec/ffv1, ffv1dec: Add const where appropriate

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:35PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1.c| 4 ++-- > libavcodec/ffv1.h| 4 ++-- > libavcodec/ffv1dec.c | 5 +++-- > 3 files changed, 7 insertions(+), 6 deletions(-) LGTM thx [...] -- Michael Gnu

Re: [FFmpeg-devel] [PATCH 05/14] avcodec/ffv1dec: Fix data races emanating from copying whole context

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:37PM +0200, Andreas Rheinhardt wrote: > When using frame threading, the FFV1 decoder's update_thread_context() > function copies the whole context and afterwards restores some allocated > fields with backups made earlier. Among these fields are the > ThreadFrames and t

Re: [FFmpeg-devel] [PATCH 07/14] avcodec/ffv1dec: Don't copy fields unnecessarily

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:39PM +0200, Andreas Rheinhardt wrote: > Copy slice-only fields only for the slicecontexts and not for the main > contexts in update_thread_context(). The converse is true for e.g. > key_frame_ok which is only used with the main context; when not doing > frame-threaded

Re: [FFmpeg-devel] [PATCH 08/14] avcodec/ffv1dec: Check allocations for failure

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:40PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1dec.c | 12 > 1 file changed, 12 insertions(+) LGTM assuming the error path was tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

Re: [FFmpeg-devel] [PATCH 14/14] avcodec/ffv1: Use av_memdup() instead of av_mallocz()+memcpy()

2021-04-25 Thread Michael Niedermayer
On Sat, Apr 24, 2021 at 01:14:46PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ffv1.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerou

[FFmpeg-devel] [PATCH] libavfilter: Add Documentation to SafeQueue

2021-04-25 Thread Shubhanshu Saxena
From: shubhanshu02 Adds documentation to queue.h in libavfilter/dnn Signed-off-by: shubhanshu02 --- libavfilter/dnn/safe_queue.h | 60 1 file changed, 60 insertions(+) diff --git a/libavfilter/dnn/safe_queue.h b/libavfilter/dnn/safe_queue.h index 36d6daaba

Re: [FFmpeg-devel] [PATCH] libavfilter: Spelling Correction in OpenVino Backend

2021-04-25 Thread Shubhanshu Saxena
Thank you On Sun, Apr 25, 2021 at 6:47 AM Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > shubhanshu02 > > Sent: 2021年4月23日 18:57 > > To: ffmpeg-devel@ffmpeg.org > > Cc: shubhanshu02 > > Subject: [FFmpeg-devel] [PATCH] libavfilter: Spelling Correcti

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-04-25 11:29:56) > On Sun, Apr 25, 2021 at 09:03:13AM +0200, Anton Khirnov wrote: > > It can handle side data cleanly. > [] > > +stream|index=0|codec_name=h264|profile=578|codec_type=video|codec_tag_string=[27][0][0][0]|codec_tag=0x001b|width=82|height=144|coded

Re: [FFmpeg-devel] [PATCH 82/87] avformat: remove deprecated AVStream.codec

2021-04-25 Thread James Almer
On 4/24/2021 9:52 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- fftools/ffmpeg_opt.c | 13 --- libavformat/avformat.h| 8 +- libavformat/dump.c| 24 -- libavformat/isom.c| 12 +-- libavformat/mov.c | 17 libavfor

[FFmpeg-devel] [PATCH] libavfilter: Add Documentation to Queue

2021-04-25 Thread Shubhanshu Saxena
From: shubhanshu02 Adds documentation to queue.h in libavfilter/dnn Signed-off-by: shubhanshu02 --- libavfilter/dnn/queue.h | 75 + 1 file changed, 75 insertions(+) diff --git a/libavfilter/dnn/queue.h b/libavfilter/dnn/queue.h index 4d7121366a..2524d5f

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: set DataRateLimits for hevc

2021-04-25 Thread Rick Kern
On Sun, Apr 25, 2021 at 4:06 AM Zhao Zhili wrote: > From the comment it's not available on old version. It works now > by testing on macOS 11.2.1. There is no document about since when. > So trying to set the configuration and ignore the error for hevc. > --- > libavcodec/videotoolboxenc.c | 10

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread James Almer
On 4/25/2021 11:12 AM, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-04-25 11:29:56) It seems something is cuttning long lines The email arrives correctly when I send it directly to myself, so I assume the ML is mangling things. Didn't something similar happen to James recently? Yea

[FFmpeg-devel] [PATCH] libavformat/adtsenc: Increase ADTS_MAX_FRAME_BYTES from 8k to 16k

2021-04-25 Thread Chris Ribble
ADTS frames may contain up to 768 bytes per channel. With 16 channels, this is 12k, which cannot fit into the maximum 8k buffer. Signed-off-by: Chris Ribble --- libavformat/adtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c

Re: [FFmpeg-devel] [PATCH] libavformat/adtsenc: Increase ADTS_MAX_FRAME_BYTES from 8k to 16k

2021-04-25 Thread Lynne
Apr 25, 2021, 18:47 by chris.rib...@resi.io: > ADTS frames may contain up to 768 bytes per channel. With 16 channels, > this is 12k, which cannot fit into the maximum 8k buffer. > Math checked out, pushed, thanks. ___ ffmpeg-devel mailing list ffmpeg-d

[FFmpeg-devel] [PATCH] avformat/dashenc: reopen new http session for http_persistent

2021-04-25 Thread Chris Ribble
Fix ticket: 8693 Based on implementation in hlsenc.c Signed-off-by: Chris Ribble --- libavformat/dashenc.c | 67 ++- 1 file changed, 53 insertions(+), 14 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 81a5c2b452..593c416850

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Michael Niedermayer
On Sun, Apr 25, 2021 at 04:12:41PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-04-25 11:29:56) > > On Sun, Apr 25, 2021 at 09:03:13AM +0200, Anton Khirnov wrote: > > > It can handle side data cleanly. > > [] > > > +stream|index=0|codec_name=h264|profile=578|codec_type=video|

[FFmpeg-devel] [PATCH 1/6] avformat/subtitles: Check pts difference before use

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_MPL2_fuzzer-6747053545881600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] [PATCH 2/6] avformat/msf: Check that channels doesnt overflow during extradata construction

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2048 * 1122336 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_MSF_fuzzer-6726959600107520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 3/6] avformat/nutdec: Check tmp_size

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_NUT_fuzzer-6739990530883584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 5/6] avformat/qcp: Avoid negative nb_rates

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 2 * -1725947872 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_QCP_fuzzer-6726807632084992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH 4/6] avformat/pp_bnk: Use 64bit in bitrate computation

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 1207959552 * 4 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_PP_BNK_fuzzer-6747301169201152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

[FFmpeg-devel] [PATCH 6/6] avformat/realtextdec: Check the pts difference before using it for the duration computation

2021-04-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 540420 - -9223372031709351616 cannot be represented in type 'long' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-6737340551790592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sign

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread James Almer
On 4/25/2021 4:28 PM, Michael Niedermayer wrote: On Sun, Apr 25, 2021 at 04:12:41PM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2021-04-25 11:29:56) It seems something is cuttning long lines The email arrives correctly when I send it directly to myself, so I assume the ML is man

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-04-25 21:28:42) > On Sun, Apr 25, 2021 at 04:12:41PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-04-25 11:29:56) > > > On Sun, Apr 25, 2021 at 09:03:13AM +0200, Anton Khirnov wrote: > > > > It can handle side data cleanly. > > > [] > > > >

[FFmpeg-devel] [PATCH v5 1/3] avcodec/adpcmenc: Adds encoder for Westwood ADPCM.

2021-04-25 Thread Aidan Richmond
Signed-off-by: Aidan Richmond --- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 32 ++-- libavcodec/allcodecs.c | 1 + 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 4a597f727a..fcddde459d 1006

[FFmpeg-devel] [PATCH v5 2/3] avformat/westwoodaudenc: Adds muxer for Westwood AUD format.

2021-04-25 Thread Aidan Richmond
Format is still used by modders of these old games. Signed-off-by: Aidan Richmond --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/westwood_audenc.c | 141 ++ 3 files changed, 143 insertions(+) create mode 1006

[FFmpeg-devel] [PATCH v5 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-25 Thread Aidan Richmond
Fixes bug #9198 Signed-off-by: Aidan Richmond --- libavcodec/adpcm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index be14607eac..5ec9691001 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1400,16 +1400,16 @@ sta

Re: [FFmpeg-devel] [PATCH 05/12] fate-ts-small-demux: convert to ffprobe

2021-04-25 Thread Anton Khirnov
Quoting James Almer (2021-04-25 21:43:31) > > > > the length seems truncated around 1000 and smtp_line_length_limit has a > > default of around that. RFC 5321 also doesnt allow longer lines so iam > > not sure if bumping that limit up is the correct thing to do (if its that > > what truncates it)

[FFmpeg-devel] compile errors ffmpeg git

2021-04-25 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Just ran into compile issues with vpx 20210423-c1c62 1.10.0-40 and the latest ffmpeg git c9fed043f1. libavutil/x86/tx_float.asm:842: error: symbol `ff_cos_32_float' not defined libavutil/x86/tx_float.asm:803: ... from macro `FFT32_FN' defined h

Re: [FFmpeg-devel] compile errors ffmpeg git

2021-04-25 Thread James Almer
On 4/25/2021 5:03 PM, Helmut K. C. Tessarek wrote: Just ran into compile issues with vpx 20210423-c1c62 1.10.0-40 and the latest ffmpeg git c9fed043f1. libavutil/x86/tx_float.asm:842: error: symbol `ff_cos_32_float' not defined libavutil/x86/tx_float.asm:803: ... from macro `FFT32_FN' defin

Re: [FFmpeg-devel] [PATCH 00/87 v2] Major bump

2021-04-25 Thread James Almer
On 4/19/2021 11:08 AM, James Almer wrote: First version, including the bump notes, is here: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-April/278670.html Most patches from the first version were already applied. And as mentioned in the discussion there, this set here removes all the dep

Re: [FFmpeg-devel] compile errors ffmpeg git

2021-04-25 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hey James, On 2021-04-25 16:32, James Almer wrote: > Does the attached patch fix this for you? Yes, thanks. The patch works! Cheers, K. C. - -- regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 Key fingerprint = 8A55 70C1 BD8

[FFmpeg-devel] [PATCH] x86/tx_float: remove ff_ prefix from external constant tables

2021-04-25 Thread James Almer
Fixes compilation with some assemblers. Signed-off-by: James Almer --- libavutil/x86/tx_float.asm | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavutil/x86/tx_float.asm b/libavutil/x86/tx_float.asm index 0eb2bf20d6..b71fb49592 1006

[FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-04-25 Thread Lynne
This is the same patch sent in January, rebased on top of the ABI bump patchset. Two additions mirror exactly what AVFrame has - an opaque field and an opaque_ref for user-side private data. For justification on the void *opaque field, you can read the archives, since the question was brought up i

Re: [FFmpeg-devel] [PATCH] x86/tx_float: remove ff_ prefix from external constant tables

2021-04-25 Thread James Almer
On 4/25/2021 5:59 PM, James Almer wrote: Fixes compilation with some assemblers. Signed-off-by: James Almer --- libavutil/x86/tx_float.asm | 40 +++--- 1 file changed, 20 insertions(+), 20 deletions(-) Approved by Lynne on IRC, so applied. __

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-25 Thread James Almer
On 4/25/2021 6:06 AM, Paul B Mahol wrote: Please apply. Applied it earlier today, but forgot to reply, sorry. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

[FFmpeg-devel] [PATCH 01/34] avcodec/adpcmenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcmenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 9dc7

[FFmpeg-devel] [PATCH 03/34] avcodec/aptxenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/aptxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aptxenc.c b/libavcodec/aptxenc.c index 60de73ec2

[FFmpeg-devel] [PATCH 02/34] avcodec/adxenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/adxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/adxenc.c b/libavcodec/adxenc.c index 93b902b0

[FFmpeg-devel] [PATCH 04/34] avcodec/bmpenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/bmpenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bmpenc.c b/libavcodec/bmpenc.c index e829d68475..

[FFmpeg-devel] [PATCH 05/34] avcodec/dnxhdenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 2461c5

[FFmpeg-devel] [PATCH 10/34] avcodec/g726: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/g726.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/g726.c b/libavcodec/g726.c index 71f5791416..b8df

[FFmpeg-devel] [PATCH 06/34] avcodec/dpxenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/dpxenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c index a5960334d5

[FFmpeg-devel] [PATCH 07/34] avcodec/dvenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/dvenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index e0679c538c..3

[FFmpeg-devel] [PATCH 08/34] avcodec/fitsenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/fitsenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/fitsenc.c b/libavcodec/fitsenc.c index b445

[FFmpeg-devel] [PATCH 11/34] avcodec/nellymoserenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/nellymoserenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymosere

[FFmpeg-devel] [PATCH 09/34] avcodec/g722enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/g722enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g722enc.c b/libavcodec/g722enc.c index 9e2ebf67c

[FFmpeg-devel] [PATCH 12/34] avcodec/pcm-dvdenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c inde

Re: [FFmpeg-devel] [PATCH 01/34] avcodec/adpcmenc: Avoid copying packet data

2021-04-25 Thread James Almer
On 4/25/2021 7:28 PM, Andreas Rheinhardt wrote: When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. With 4.4 released and the bump about happen, we can start porting all (or most) encoders to get_encode_buffer(). And this one here is a

[FFmpeg-devel] [PATCH 13/34] avcodec/r210enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/r210enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/r210enc.c b/libavcodec/r210enc.c index be1943f

[FFmpeg-devel] [PATCH 14/34] avcodec/ra144enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/ra144enc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/ra144enc.c b/libavcodec/ra144enc.c index c696

[FFmpeg-devel] [PATCH 15/34] avcodec/roqaudioenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/roqaudioenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/roqaudioenc.c b/libavcodec/roqaudioenc.c i

[FFmpeg-devel] [PATCH 16/34] avcodec/s302menc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/s302menc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c index b04a54

[FFmpeg-devel] [PATCH 17/34] avcodec/v308enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/v308enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/v308enc.c b/libavcodec/v308enc.c index 0891251

[FFmpeg-devel] [PATCH 18/34] avcodec/v408enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/v408enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/v408enc.c b/libavcodec/v408enc.c index d2d84d9

[FFmpeg-devel] [PATCH 19/34] avcodec/xfaceenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/xfaceenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/xfaceenc.c b/libavcodec/xfaceenc.c index dd5bb6

[FFmpeg-devel] [PATCH 22/34] avcodec/yuv4enc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/yuv4enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/yuv4enc.c b/libavcodec/yuv4enc.c index 63a7fae

[FFmpeg-devel] [PATCH 20/34] avcodec/xwdenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/xwdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/xwdenc.c b/libavcodec/xwdenc.c index 81cca6c963..

[FFmpeg-devel] [PATCH 21/34] avcodec/y41penc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/y41penc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/y41penc.c b/libavcodec/y41penc.c index 4340a3f

[FFmpeg-devel] [PATCH 23/34] avcodec/zmbvenc: Simplify setting keyframe flag

2021-04-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/zmbvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/zmbvenc.c b/libavcodec/zmbvenc.c index 319381dd48..4b3416219b 100644 --- a/libavcodec/zmbvenc.c +++ b/libavcodec/zmbvenc.c @@ -294,10 +294,10 @@ FF_ENABLE_DEPR

[FFmpeg-devel] [PATCH 24/34] avcodec/zmbvenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder itself works with an internal buffer, so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcod

[FFmpeg-devel] [PATCH 25/34] avcodec/libx264: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: And

[FFmpeg-devel] [PATCH 26/34] avcodec/libxavs: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- ff_alloc_packet2() call (for the actual packets, not this end-of-stream packet), yet the size known in advance is not exact. libavcodec/libxavs.c |

[FFmpeg-devel] [PATCH 27/34] avcodec/libcodec2: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- libavcodec/libcodec2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libcodec2.c b/libavcodec/libcodec2.c index 216

[FFmpeg-devel] [PATCH 28/34] avcodec/libmp3lame: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
The libmp3lame encoder already uses an internal buffer, so that the packet size is already known before allocating the packet; therefore one can avoid another (implicit) intermediate buffer by setting the min_size parameter in ff_alloc_packet2(). Signed-off-by: Andreas Rheinhardt --- libavcodec/

[FFmpeg-devel] [PATCH 29/34] avcodec/libvorbisenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: And

[FFmpeg-devel] [PATCH 30/34] avcodec/libvpxenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: And

[FFmpeg-devel] [PATCH 31/34] avcodec/libgsmenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
When the packet size is known in advance like here, one can avoid an intermediate buffer for the packet data. Signed-off-by: Andreas Rheinhardt --- These encoders have the most unorthodox way of using their private data that I have ever seen. Will fix it later. libavcodec/libgsmenc.c | 3 ++- 1

[FFmpeg-devel] [PATCH 32/34] avcodec/libtheoraenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: And

[FFmpeg-devel] [PATCH 33/34] avcodec/libshine: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
The libshine encoder already uses an internal buffer, so that the packet size is already known before allocating the packet; therefore one can avoid another (implicit) intermediate buffer by setting the min_size parameter in ff_alloc_packet2(). Signed-off-by: Andreas Rheinhardt --- libavcodec/li

[FFmpeg-devel] [PATCH 34/34] avcodec/libaomenc: Avoid copying packet data

2021-04-25 Thread Andreas Rheinhardt
Here the packet size is known before allocating the packet because the encoder provides said information (and works with internal buffers itself), so one can pass this information to ff_alloc_packet2() to avoid the implicit use of another intermediate buffer for the packet data. Signed-off-by: And

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-04-25 Thread Marton Balint
On Sun, 25 Apr 2021, Lynne wrote: This is the same patch sent in January, rebased on top of the ABI bump patchset. Two additions mirror exactly what AVFrame has - an opaque field and an opaque_ref for user-side private data. For justification on the void *opaque field, you can read the archi

Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

2021-04-25 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年4月18日 18:08 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for > classification based on detection bounding boxes > > classification is done on every detection boundi

Re: [FFmpeg-devel] [PATCH] avpacket: ABI bump additions

2021-04-25 Thread Andreas Rheinhardt
Lynne: > From 097aed2ac33dda0bb2052d8b0402711ce95079ba Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Sat, 23 Jan 2021 19:56:18 +0100 > Subject: [PATCH] avpacket: ABI bump additions > > --- > libavcodec/avpacket.c | 5 + > libavcodec/packet.h | 21 + > 2 files changed,

Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

2021-04-25 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: Guo, Yejun >> Sent: 2021年4月18日 18:08 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Guo, Yejun >> Subject: [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for >> classification based on detection bounding boxes >> >> classification is done o

Re: [FFmpeg-devel] [PATCH v5 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

2021-04-25 Thread Zane van Iperen
On 26/4/21 6:00 am, Aidan Richmond wrote: Patch 1/3: lgtm Patch 2/3: +static int wsaud_write_init(AVFormatContext *ctx) +{ +AVStream *st = ctx->streams[0]; +AVIOContext *pb = ctx->pb; + +/* Stream must be seekable to correctly write the file. */ +if (!(pb->seekable & AVI

Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

2021-04-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年4月26日 9:34 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter > dnn_classify for classification based on detection bounding boxes > > Guo, Yejun:

Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

2021-04-25 Thread Andreas Rheinhardt
Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2021年4月26日 9:34 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter >> dnn_classify for classification based on detection bounding

Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

2021-04-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2021年4月26日 10:15 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 6/6] lavfi/dnn_classify: add filter > dnn_classify for classification based on detection bounding boxes > > Guo, Yejun:

Re: [FFmpeg-devel] [PATCH] libavfilter: Add Documentation to SafeQueue

2021-04-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: 2021年4月25日 21:19 > To: ffmpeg-devel@ffmpeg.org > Cc: shubhanshu02 > Subject: [FFmpeg-devel] [PATCH] libavfilter: Add Documentation to > SafeQueue > > From: shubhanshu02 > > Adds documentation to queue.

[FFmpeg-devel] [PATCH 1/3] libavcodec/qsvdec: reinit decoder according to decode() return value

2021-04-25 Thread wenbin . chen
From: "Chen,Wenbin" FFmpeg-qsv decoder reinit codec when width and height change, but there are not only resolution change need to reinit codec. I change it to use return value from DecodeFrameAsync() to decide whether decoder need to be reinitialized. Signed-off-by Wenbin Chen Signed-off-by Gu

[FFmpeg-devel] [PATCH 2/3] libavcodec/qsvdec: remove redundant decodeHeader()

2021-04-25 Thread wenbin . chen
From: "Chen,Wenbin" Since ffmpeg-qsv uses return value to reinit decoder, it doesn't need to decode header each time. Move qsv_decode_header's position so that it will be called only if codec needed to be reinitialized. Rearrange the code of flushing decoder and re-init decoder operation. Remove

  1   2   >