Re: [FFmpeg-devel] [PATCH] avformat: Add parityfec and ulpfec protocol

2021-04-21 Thread Camille Gonnet
I did not have any feedback on this patch. Thanks, On April 9, 2021 at 4:08 PM, Camille Gonnet (cami...@sound4.biz) wrote: Parityfec (RFC 2733) and ulpfec (RFC 5109) generic FEC encoding for RTP streams. Signed-off-by: Camille Gonnet ---  Changelog                 |   1 +  doc/general_contents.t

Re: [FFmpeg-devel] [PATCH 4/9] avformat/wtvdec: Improve size overflow checks in parse_chunks()

2021-04-21 Thread Peter Ross
On Mon, Apr 19, 2021 at 08:23:41PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 32 + 2147483647 cannot be represented in type > 'int > Fixes: > 32967/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-5132856218222592 > > Found-by: continuous fuzzing process > https://g

[FFmpeg-devel] [WORK IN PROGRESS] Efficient string and JSON writing API

2021-04-21 Thread Nicolas George
Hi. This patch series is not for review, it is for reference, because I am stashing it before working on something else. The prospect of the uphill battle that would be needed to convince some people here that we need this discouraged me a little, I must say. It is the work in progress for a set

[FFmpeg-devel] [PATCH 2/7] lavu: new AVWriter API.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 2 +- libavutil/writer.c | 443 + libavutil/writer.h | 487 + 3 files changed, 931 insertions(+), 1 deletion(-) create mode 100644 libavutil/writer.c crea

[FFmpeg-devel] [PATCH 1/7] lavu: add macros to help making future-proof structures.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/extendable.h | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 libavutil/extendable.h diff --git a/libavutil/extendable.h b/libavutil/extendable.h new file mode 100644 index 00..79980fa202 ---

[FFmpeg-devel] [PATCH 3/7] lavu/writer: add test.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 1 + libavutil/tests/.gitignore | 1 + libavutil/tests/writer.c | 190 + tests/fate/libavutil.mak | 4 + tests/ref/fate/writer | 36 +++ 5 files changed, 232 insertions(+) creat

[FFmpeg-devel] [PATCH 5/7] WIP: add an intro to AVWriter

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- avwriter_intro.txt | 261 + 1 file changed, 261 insertions(+) create mode 100644 avwriter_intro.txt diff --git a/avwriter_intro.txt b/avwriter_intro.txt new file mode 100644 index 00..b1b54711c9 --- /dev/null

[FFmpeg-devel] [PATCH 4/7] lavf/dump: use a writer.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/avformat.h | 21 +++ libavformat/dump.c | 317 + 2 files changed, 185 insertions(+), 153 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 41482328f6..13e07ee114 100644 --- a/

[FFmpeg-devel] [PATCH 6/7] lavu: add a JSON writer API.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 1 + libavutil/json.c | 368 +++ libavutil/json.h | 467 + 3 files changed, 836 insertions(+) create mode 100644 libavutil/json.c create mode 100644 libavutil

[FFmpeg-devel] [PATCH 7/7] lavu: add JSON writer test.

2021-04-21 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 1 + libavutil/tests/json.c | 139 +++ tests/fate/libavutil.mak | 4 ++ 3 files changed, 144 insertions(+) create mode 100644 libavutil/tests/json.c diff --git a/libavutil/Makefile b/libavutil

[FFmpeg-devel] [PATCH 2/2] avcodec/exr: x/ymax cannot be INT_MAX

2021-04-21 Thread Michael Niedermayer
The code uses x/ymax + 1 so the maximum is INT_MAX-1 Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 33158/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5545462457303040 Found-by: continuous fuzzing process https://github.com/google/oss-

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Avoid undefined overflow in time_offset calculation

2021-04-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 8511838621821575200 - -3954125146725285889 cannot be represented in type 'long' Fixes: 33414/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6610119325515776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 00/11] lavu/tx: FFT improvements, additions and assembly

2021-04-21 Thread Paul B Mahol
I will just test it and reply if everything is ok. On Wed, Apr 21, 2021 at 4:43 AM Lynne wrote: > Apr 19, 2021, 22:19 by d...@lynne.ee: > > > This patchset cleans up and improves the power-of-two C code, > > adds a 7-point and a 9-point FFT, and adds a power-of-two length > > floating-point asse

Re: [FFmpeg-devel] [PATCH 69/87] avutil/pixdesc: Remove deprecated AV_PIX_FMT_FLAG_PSEUDOPAL

2021-04-21 Thread James Almer
On 4/20/2021 10:40 AM, Michael Niedermayer wrote: On Mon, Apr 19, 2021 at 11:10:06AM -0300, James Almer wrote: From: Andreas Rheinhardt Deprecated in d6fc031caf64eed921bbdef86d79d56bfc2633b0. Signed-off-by: Andreas Rheinhardt --- libavcodec/decode.c | 5 + libavcodec/ffv1dec

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker

2021-04-21 Thread James Almer
With JPEG-LS PAL8 samples, the JPEG-LS extension parameters signaled with the LSE marker show up after SOF but before SOS. For those, the pixel format chosen by get_format() in SOF is GRAY8, and then replaced by PAL8 in LSE. This has not been an issue given both pixel formats allocate the second da

[FFmpeg-devel] [PATCH 1/2] fate: add tests for JPEG-LS PAL8

2021-04-21 Thread James Almer
Signed-off-by: James Almer --- The samples are in https://trac.ffmpeg.org/ticket/3933 I'm forcing rgb24 as output because a simple ffmpeg -i 128.jls 128.png results in the alpha channel covering the entire PAL8 output image. I don't know why this happens. Will upload the samples before pushing.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker

2021-04-21 Thread Andreas Rheinhardt
James Almer: > With JPEG-LS PAL8 samples, the JPEG-LS extension parameters signaled with > the LSE marker show up after SOF but before SOS. For those, the pixel format > chosen by get_format() in SOF is GRAY8, and then replaced by PAL8 in LSE. > This has not been an issue given both pixel formats a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: postpone calling ff_get_buffer() until the SOS marker

2021-04-21 Thread James Almer
On 4/21/2021 2:52 PM, Andreas Rheinhardt wrote: James Almer: With JPEG-LS PAL8 samples, the JPEG-LS extension parameters signaled with the LSE marker show up after SOF but before SOS. For those, the pixel format chosen by get_format() in SOF is GRAY8, and then replaced by PAL8 in LSE. This has n

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: add avio_vprintf()

2021-04-21 Thread Stefano Sabatini
On date Sunday 2021-04-18 23:30:57 +0200, Stefano Sabatini wrote: > This new function makes it possible to use avio_printf() functionality from > a function taking a variable list of arguments. > --- > doc/APIchanges| 3 +++ > libavformat/avio.h| 6 ++ > libavformat/aviobuf.c | 1

Re: [FFmpeg-devel] [PATCH 2/2] ffprobe: add -o option

2021-04-21 Thread Stefano Sabatini
On date Monday 2021-04-19 11:26:49 +0200, Michael Niedermayer wrote: > On Sun, Apr 18, 2021 at 11:30:58PM +0200, Stefano Sabatini wrote: > > This enables printing to a resource specified with -o OUTPUT. > > > > Address issue: http://trac.ffmpeg.org/ticket/8024 > > --- > > doc/ffprobe.texi | 7

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add crf and enable_tpl_la options

2021-04-21 Thread Christopher Degawa
ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-21 Thread Mao Hata
On 2021/04/20 13:44, zheng qian wrote: Changes since v1: Separate if-statement and cosmetic changes into different commits According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-21 Thread zheng qian
On Thu, Apr 22, 2021 at 12:11 PM Mao Hata wrote: > > PES_packet_length seems to be inaccurate, because "header_len + 3" has > already been added to the variable "len". I'm sorry for that and I'll submit v3 patch set later. Please tell me if there're any other problems. Regards, zheng >

Re: [FFmpeg-devel] [PATCH 2/2] ffprobe: add -o option

2021-04-21 Thread Gyan Doshi
On 2021-04-22 03:27, Stefano Sabatini wrote: On date Monday 2021-04-19 11:26:49 +0200, Michael Niedermayer wrote: On Sun, Apr 18, 2021 at 11:30:58PM +0200, Stefano Sabatini wrote: This enables printing to a resource specified with -o OUTPUT. Address issue: http://trac.ffmpeg.org/ticket/8024