Re: [FFmpeg-devel] [PATCH v1 1/3] libavformat/rtsp.h : Add member ignore_rtcp to RTSPState

2021-04-20 Thread Minlei Sun
Thanks, Moritz. I will submit a new patch in order to update doc/protocols.texi, this is my oversight. Regarding "ignore_rtcp" flag, it is turned off by default. When some devices (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains rtcp data packets (may be non-standard),

[FFmpeg-devel] [PATCH v1] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread sunml
From: Minlei Sun Signed-off-by: Minlei Sun --- doc/protocols.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index a6e46b99ad..604d42b693 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1188,6 +1188,9 @@ libavformat identifier str

[FFmpeg-devel] [PATCH] libavutil: additional side_data accessor

2021-04-20 Thread Brad Hards
The existing function allows access the first instance of a given type. Mostly that is OK, but some types can occur multiple times (e.g. libx264 can write version info, VANC and UMID related data as user data unregistered SEI. This adds API to access additional instances of a given SEI type. ---

Re: [FFmpeg-devel] [PATCH] libavutil: additional side_data accessor

2021-04-20 Thread Nicolas George
Brad Hards (12021-04-20): > The existing function allows access the first instance of a given > type. Mostly that is OK, but some types can occur multiple times > (e.g. libx264 can write version info, VANC and UMID related data as > user data unregistered SEI. > > This adds API to access additiona

Re: [FFmpeg-devel] [PATCH] Gsoc: add the two fuzzy targets

2021-04-20 Thread Michael Niedermayer
On Tue, Apr 20, 2021 at 12:34:13PM +0800, Heng Zhang wrote: > > > > 在 2021年4月19日,下午5:47,Michael Niedermayer 写道: > > > > On Mon, Apr 19, 2021 at 05:06:10PM +0800, a397341...@163.com > > wrote: > >> From: toseven [...] > >> +if (ret < 0) > >> +{ > >> +

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > > > > On Mon, 19 Apr 2021, zheng qian wrote: > > > > > Is there anyone who could review this patch? > > > > Jan was interested in this, so preferably he should also comment, but

Re: [FFmpeg-devel] [PATCH] libavutil: additional side_data accessor

2021-04-20 Thread James Almer
On 4/20/2021 7:10 AM, Nicolas George wrote: Brad Hards (12021-04-20): The existing function allows access the first instance of a given type. Mostly that is OK, but some types can occur multiple times (e.g. libx264 can write version info, VANC and UMID related data as user data unregistered SEI.

Re: [FFmpeg-devel] [PATCH] libavutil: additional side_data accessor

2021-04-20 Thread Nicolas George
James Almer (12021-04-20): > I recall long ago i tried to make av_frame_new_side_data() replace the > existing element if it found one, effectively limiting side data to one per > type and copying the behavior of packet side data, but it was rejected as it > was argued more than one per type had so

Re: [FFmpeg-devel] [PATCH 69/87] avutil/pixdesc: Remove deprecated AV_PIX_FMT_FLAG_PSEUDOPAL

2021-04-20 Thread Michael Niedermayer
On Mon, Apr 19, 2021 at 11:10:06AM -0300, James Almer wrote: > From: Andreas Rheinhardt > > Deprecated in d6fc031caf64eed921bbdef86d79d56bfc2633b0. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/decode.c | 5 + > libavcodec/ffv1dec.c | 3 +-- > libavcodec/rawde

Re: [FFmpeg-devel] [PATCH v1] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread Gyan Doshi
On 2021-04-20 13:35, su...@epoint.com.cn wrote: From: Minlei Sun Signed-off-by: Minlei Sun --- doc/protocols.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index a6e46b99ad..604d42b693 100644 --- a/doc/protocols.texi +++ b/doc/protocol

[FFmpeg-devel] [PATCH v2 28/90] avcodec: Remove deprecated old aliases for NVENC encoders

2021-04-20 Thread Andreas Rheinhardt
Deprecated in 888a5c794778a2f2aad22e9b4a3952dff92b11fa. Signed-off-by: Andreas Rheinhardt --- Now also removing the configure and Makefile entries for the removed encoders. configure | 3 -- libavcodec/Makefile | 3 -- libavcodec/allcodecs.c | 6 libavcodec/nvenc_h264

Re: [FFmpeg-devel] [PATCH 1/6] avformat/cafdec: Check channels

2021-04-20 Thread Michael Niedermayer
On Sun, Apr 11, 2021 at 12:24:41AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1184429040541376544 * 32 cannot be > represented in type 'long' > Fixes: > 31788/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6236746338664448 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 2/6] Execure whole size check earlier for rv20

2021-04-20 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Timeout > Fixes: > 31380/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5230899257016320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcode

[FFmpeg-devel] [PATCH v2 33/90] avformat: Constify the API wrt AV(In|Out)putFormat

2021-04-20 Thread Andreas Rheinhardt
Also constify AVProbeData. Signed-off-by: Andreas Rheinhardt --- v1 forgot to update doc/examples. doc/APIchanges | 10 doc/examples/muxing.c| 2 +- doc/examples/remuxing.c | 2 +- fftools/ffmpeg_opt.c | 12 + fftools/ffplay.

Re: [FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't allocate+free JPEGLSState for every frame

2021-04-20 Thread Michael Niedermayer
On Wed, Apr 14, 2021 at 11:21:40PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeglsdec.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) [...] > @@ -548,7 +548,7 @@ AVCodec ff_jpegls_decoder = { > .long_name = NULL_I

[FFmpeg-devel] [PATCH v2 74/90] avcodec/codec, allcodecs: Constify the AVCodec API

2021-04-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Now also updating doc/examples and tests/api as well as libavdevice/dshow.c. doc/APIchanges | 5 + doc/examples/demuxing_decoding.c | 2 +- doc/examples/muxing.c| 10 ++ doc/examples/transcode_aac.c | 4 ++--

Re: [FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't allocate+free JPEGLSState for every frame

2021-04-20 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Apr 14, 2021 at 11:21:40PM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/jpeglsdec.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) > [...] >> @@ -548,7 +548,7 @@ AVCodec ff_jpegls_decoder = { >

[FFmpeg-devel] [PATCH v2 75/90] avformat/avformat, utils: Make av_find_best_stream const-correct

2021-04-20 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Now also updating doc/examples. doc/APIchanges | 4 doc/examples/extract_mvs.c | 2 +- doc/examples/filtering_audio.c | 2 +- doc/examples/filtering_video.c | 2 +- doc/examples/hw_decode.c | 2 +- doc/examples/vaapi_transcode.

[FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't presume the context to contain and JLSState

2021-04-20 Thread Andreas Rheinhardt
Before 9b3c46a081a9f01559082bf7a154fc6be1e06c18 every call to ff_jpegls_decode_picture() allocated and freed a JLSState. This commit instead put said structure into the context of the JPEG-LS decoder to avoid said allocation. But said function can also be called from other MJPEG-based decoders and

[FFmpeg-devel] [PATCH v1] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread sunml
From: Minlei Sun Signed-off-by: Minlei Sun --- doc/protocols.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/protocols.texi b/doc/protocols.texi index a6e46b99ad..604d42b693 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1188,6 +1188,9 @@ libavformat identifier str

[FFmpeg-devel] [PATCH v2] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread sunml
From: Minlei Sun Regarding ignore_rtcp flag, it is turned off by default. When some devices (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains rtcp data packets (may be non-standard), there will be a freeze when the output is rtmp stream. So when igore_rtcp is enabled, t

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread Jan Ekström
On Tue, Apr 20, 2021 at 3:03 PM zheng qian wrote: > > On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > > > > > > > > On Mon, 19 Apr 2021, zheng qian wrote: > > > > > > > Is there anyone who could review this patch? > > > >

Re: [FFmpeg-devel] [PATCH v2] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread Gyan Doshi
On 2021-04-20 22:50, su...@epoint.com.cn wrote: From: Minlei Sun Regarding ignore_rtcp flag, it is turned off by default. When some devices (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains rtcp data packets (may be non-standard), there will be a freeze when the out

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: reload packet loss at encode

2021-04-20 Thread Lynne
Mar 3, 2021, 16:50 by philip-dylan.gleo...@savoirfairelinux.com: > Le 16/02/2021 à 15:04, Philip-Dylan Gleonec a écrit : > >> An estimation of packet loss is required by libopus to compute its FEC >> data. Currently, this estimation is constant, and can not be changed >> after configuration. This

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-04-20 Thread Lynne
Mar 3, 2021, 16:51 by philip-dylan.gleo...@savoirfairelinux.com: > Le 18/02/2021 à 17:38, Philip-Dylan Gleonec a écrit : > >> Here is the reworked patch properly attached. >> Sorry about the duplicate mail, I just noticed I had a mishap with my >> mail client and the previous patch was scrubbed. >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't presume the context to contain and JLSState

2021-04-20 Thread Michael Niedermayer
On Tue, Apr 20, 2021 at 06:26:49PM +0200, Andreas Rheinhardt wrote: > Before 9b3c46a081a9f01559082bf7a154fc6be1e06c18 every call to > ff_jpegls_decode_picture() allocated and freed a JLSState. This commit > instead put said structure into the context of the JPEG-LS decoder to > avoid said allocatio

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread Jan Ekström
On Tue, Apr 20, 2021 at 8:16 PM Jan Ekström wrote: > > On Tue, Apr 20, 2021 at 3:03 PM zheng qian wrote: > > > > On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > > > > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > > > > > > > > > > > > On Mon, 19 Apr 2021, zheng qian w

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Wed, Apr 21, 2021 at 7:04 AM Jan Ekström wrote: > > I think in general I am preferring the "follow the TR" way since I > just heard another implementer generally speaking also ignores > everything else than 0x30/0x87. > > Did not yet add the per-program limitation but poked a bit at it with > h

Re: [FFmpeg-devel] [PATCH 00/11] lavu/tx: FFT improvements, additions and assembly

2021-04-20 Thread Lynne
Apr 19, 2021, 22:19 by d...@lynne.ee: > This patchset cleans up and improves the power-of-two C code, > adds a 7-point and a 9-point FFT, and adds a power-of-two length > floating-point assembly. > Ping. There's no one signed up to review the assembly yet, but apart from me, there's unfortunatel

Re: [FFmpeg-devel] Major bump

2021-04-20 Thread Steven Liu
> 2021年4月5日 下午7:09,Anton Khirnov 写道: > > Hi, > this patchset bumps major version of all the libraries and removes many > deprecated APIs, as discussed at length during past months. Patches > 11-16 will be squashed together on push, but are sent separately for > ease of review. FATE passes (here

Re: [FFmpeg-devel] Major bump

2021-04-20 Thread Andreas Rheinhardt
Steven Liu: > > >> 2021年4月5日 下午7:09,Anton Khirnov 写道: >> >> Hi, >> this patchset bumps major version of all the libraries and removes many >> deprecated APIs, as discussed at length during past months. Patches >> 11-16 will be squashed together on push, but are sent separately for >> ease of rev

Re: [FFmpeg-devel] [PATCH v2] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread Minlei Sun
>On 2021-04-20 22:50, su...@epoint.com.cn wrote: >> From: Minlei Sun >> >> Regarding ignore_rtcp flag, it is turned off by default. When some devices >> (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains >> rtcp data packets (may be non-standard), there will be a freeze

Re: [FFmpeg-devel] [PATCH v2] doc/protocols.texi : Add ignore_rtcp option in rtsp section

2021-04-20 Thread Gyan Doshi
On 2021-04-21 08:44, Minlei Sun wrote: On 2021-04-20 22:50, su...@epoint.com.cn wrote: From: Minlei Sun Regarding ignore_rtcp flag, it is turned off by default. When some devices (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains rtcp data packets (may be non-standa

Re: [FFmpeg-devel] [ffmpeg-web][PATCH] Drop my entry from the consulting list

2021-04-20 Thread Gyan Doshi
On 2021-04-19 02:08, Stefano Sabatini wrote: Hi, I've not been really active in the last period and this patch clarifies this condition. Will apply. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Wed, Apr 21, 2021 at 10:00 AM zheng qian wrote: > > ARIB superimpose should utilize Timing(00) since superimpose > uses Asynchronous_PES, but it belongs to another topic. > > In other words, addtitional_arib_caption_info can be generated by > profile information safely and is not necessary to c