Re: [FFmpeg-devel] [PATCH V8 3/3] lavfi: add filter dnn_detect for object detection

2021-04-17 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Guo, Yejun > Sent: 2021年4月16日 8:49 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V8 3/3] lavfi: add filter dnn_detect for > object detection > > > > > -Original Message- > > From: Guo, Yejun > > Sen

[FFmpeg-devel] [PATCH] lavu/video_enc_params: add misssing space

2021-04-17 Thread Guo, Yejun
--- just got to know this style by https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/6c65e499909016ff45c207c149f287ee5b3cf808 libavutil/video_enc_params.c | 2 +- libavutil/video_enc_params.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/video_enc_params.c b/li

[FFmpeg-devel] [PATCH] lavu/detection_bbox.h: use AV_NUM_DETECTION_BBOX_CLASSIFY to replace AV_NUM_BBOX_CLASSIFY

2021-04-17 Thread Guo, Yejun
--- sorry, missed to change the name and just noticed it now, hope it's not too late, will push tomorrow if it is not denied. just want to update it ASAP, and pushed by anyone is welcome. thanks. libavutil/detection_bbox.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_astats: Remove fraction part of integer metadata entries

2021-04-17 Thread Anton Khirnov
Quoting Tobias Rapp (2021-04-16 15:50:44) > On 09.04.2021 09:58, Tobias Rapp wrote: > > On 08.04.2021 11:34, Nicolas George wrote: > >> Anton Khirnov (12021-04-08): > >>> Does this mean that there are no stability guarantees for metadata > >>> exported by filters? > >> > >> We can have stability fo

Re: [FFmpeg-devel] [PATCH 28/39] avcodec/mpeg4video: Making initializing RLTable thread-safe

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:46) > Up until now the RLTable ff_mpeg4_rl_intra was initialized by both mpeg4 > decoder and encoder (except the VLCs that are only used by the decoder). > This is an obstacle to making these codecs init-threadsafe, so move > initializing this to a singl

Re: [FFmpeg-devel] [PATCH 29/39] avcodec/mpeg4videoenc: Make encoder init-threadsafe

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:47) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4videoenc.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > Looks ok -- Anton Khirnov ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 30/39] avcodec/msmpeg4: Make ff_msmpeg4_common_init() thread-safe

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:48) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/msmpeg4.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > LGTM -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH 31/39] avcodec/msmpeg4: Reindentation

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:49) > Forgotten in/after f5957f3fe2b8dfda13a9750acc3e3a03cd5d39c9. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/msmpeg4.c | 91 ++-- > 1 file changed, 45 insertions(+), 46 deletions(-) Trivially ok

Re: [FFmpeg-devel] [PATCH 34/39] avcodec/msmpeg4enc: Make msmpeg4 encoders init-threadsafe

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:52) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo_enc.c | 6 +++--- > libavcodec/msmpeg4enc.c| 33 +++-- > libavcodec/wmv2enc.c | 2 +- > 3 files changed, 23 insertions(+), 18 deletions(-) LGT

Re: [FFmpeg-devel] [PATCH 33/39] avcodec/msmpeg4: Factor out common RLTable initialization code

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:51) > Up until now, both the msmpeg4 decoders and encoders initialized several > RLTables common to them (the decoders also initialized the VLCs of these > RLTables). This is an obstacle to making these codecs init-threadsafe. > So move this initializati

Re: [FFmpeg-devel] [PATCH 35/39] avcodec/msmpeg4enc: Reindent after the last commit

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-10 12:16:53) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/msmpeg4enc.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) Trivially ok -- Anton Khirnov ___ ffmpeg-devel mai

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-17 Thread Mao Hata
According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. From c1663cbdbbd2178cb199e079ec9bb712d1d757d8 Mon Sep 17 00:00:00 2001 From: Mao Hata Date: Sat, 17 Apr 2021 19:55:22 +0900 Subject: [PATCH] avformat/mpegtsenc: private_str

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/exr: increase vlc depth

2021-04-17 Thread Michael Niedermayer
On Tue, Apr 13, 2021 at 05:45:36PM +0200, Michael Niedermayer wrote: > Fixes: shift exponent -4 is negative > Fixes: > 32265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-465133454137753 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/proj

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/dpx: Check bits_per_color earlier

2021-04-17 Thread Michael Niedermayer
On Tue, Apr 13, 2021 at 05:45:35PM +0200, Michael Niedermayer wrote: > Fixes: shift exponent 251 is too large for 32-bit type 'int' > Fixes: > 32147/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DPX_fuzzer-5519111675314176 > > Found-by: continuous fuzzing process > https://github.com/google/

[FFmpeg-devel] [PATCH v1 1/3] libavformat/rtsp.h : Add member ignore_rtcp to RTSPState

2021-04-17 Thread sunml
From: Minlei Sun Signed-off-by: Minlei Sun --- libavformat/rtsp.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h index 1310dd9c08..516391673a 100644 --- a/libavformat/rtsp.h +++ b/libavformat/rtsp.h @@ -416,6 +416,11 @@ typedef struct RTSPState

[FFmpeg-devel] [PATCH v1 3/3] libavformat/rtspdec.c : Implement ignore_rtcp code

2021-04-17 Thread sunml
From: Minlei Sun Signed-off-by: Minlei Sun --- libavformat/rtspdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 113da975e1..1d5e674149 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -817,6 +817,8 @@ redo: }

[FFmpeg-devel] [PATCH v1 2/3] libavformat/rtsp.c : Add ignore_rtcp option to ff_rtsp_options

2021-04-17 Thread sunml
From: Minlei Sun Signed-off-by: Minlei Sun --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 25bdf475b3..32043bfff6 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -105,6 +105,7 @@ const AVOption ff_rtsp_options[

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

2021-04-17 Thread Timo Rothenpieler
I think I'd much prefer to stop relying on the order of this enum entirely. nvenc_map_preset already sets a lossless flag. But it's called way too late for the capability check. I see no reason the call to nvenc_map_preset can't be moved to much earlier. Like, right into ff_nvenc_encode_init. T

[FFmpeg-devel] [PATCH] lavc/libaomdec: fix build without AOM_CTRL_AOMD_GET_FRAME_FLAGS

2021-04-17 Thread Anton Khirnov
--- libavcodec/libaomdec.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 6de3bcc5c3..143c45b620 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@ -161,7 +161,6 @@ static int aom_d

Re: [FFmpeg-devel] [PATCH] lavc/libaomdec: fix build without AOM_CTRL_AOMD_GET_FRAME_FLAGS

2021-04-17 Thread James Almer
On 4/17/2021 2:31 PM, Anton Khirnov wrote: --- libavcodec/libaomdec.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 6de3bcc5c3..143c45b620 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/l

Re: [FFmpeg-devel] [PATCH] lavc/libaomdec: fix build without AOM_CTRL_AOMD_GET_FRAME_FLAGS

2021-04-17 Thread James Almer
On 4/17/2021 3:15 PM, James Almer wrote: On 4/17/2021 2:31 PM, Anton Khirnov wrote: ---   libavcodec/libaomdec.c | 22 --   1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 6de3bcc5c3..143c45b620 100644 --- a

Re: [FFmpeg-devel] [PATCH v2] avformat/wavdec: Fix reading files with id3v2 apic before fmt tag

2021-04-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now the cover images will get the stream index 0 in this case, > violating the hardcoded assumption that this is the index of the audio > stream. Fix this by creating the audio stream first; this is also in > line with the expectations of ff_pcm_read_seek() and > ff_s

[FFmpeg-devel] n4.4 release bug (?) on ffmpeg.c av_fifo_generic_read

2021-04-17 Thread Đông Nguyễn
Hi, Not sure this is the correct place to post this, but I've noticed some recent changes (n.4.4) on ffmpeg.c which seems suspicious to me. https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L532-L535 https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L614-L616 IIRC, before the

Re: [FFmpeg-devel] n4.4 release bug (?) on ffmpeg.c av_fifo_generic_read

2021-04-17 Thread Andreas Rheinhardt
Đông Nguyễn: > Hi, > > Not sure this is the correct place to post this, but I've noticed some > recent changes (n.4.4) on ffmpeg.c which seems suspicious to me. > > https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L532-L535 > https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#

Re: [FFmpeg-devel] n4.4 release bug (?) on ffmpeg.c av_fifo_generic_read

2021-04-17 Thread James Almer
On 4/17/2021 10:16 PM, Đông Nguyễn wrote: Hi, Not sure this is the correct place to post this, but I've noticed some recent changes (n.4.4) on ffmpeg.c which seems suspicious to me. https://github.com/FFmpeg/FFmpeg/blob/n4.4/fftools/ffmpeg.c#L532-L535 This one is in 4.3 too. Not sure why you

Re: [FFmpeg-devel] n4.4 release bug (?) on ffmpeg.c av_fifo_generic_read

2021-04-17 Thread Đông Nguyễn
ah I see, my bad, thanks for make it clear Regards Dong Nguyen On Sun, Apr 18, 2021, 08:47 James Almer wrote: > On 4/17/2021 10:16 PM, Đông Nguyễn wrote: > > Hi, > > > > Not sure this is the correct place to post this, but I've noticed some > > recent changes (n.4.4) on ffmpeg.c which seems su

Re: [FFmpeg-devel] [PATCH] lavu/detection_bbox.h: use AV_NUM_DETECTION_BBOX_CLASSIFY to replace AV_NUM_BBOX_CLASSIFY

2021-04-17 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年4月17日 20:11 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH] lavu/detection_bbox.h: use > AV_NUM_DETECTION_BBOX_CLASSIFY to replace AV_NUM_BBOX_CLASSIFY > > --- > sorry, missed to change the name and just noticed it

[FFmpeg-devel] [PATCH] doc/muxers.texi: fix build issue for unknown command

2021-04-17 Thread Guo, Yejun
The build log: ** Unknown command `@code' (left as is) (in src/doc/muxers.texi l. 2020) *** '{' without macro. Before: -map} option with the ffmpeg CLI tool. (in src/doc/muxers.texi l. 2020) *** '}' without opening '{' before: option with the ffmpeg CLI tool. (in src/doc/muxers.texi l. 2020) ---

Re: [FFmpeg-devel] [PATCH] doc/muxers.texi: fix build issue for unknown command

2021-04-17 Thread Gyan Doshi
On 2021-04-18 10:11, Guo, Yejun wrote: The build log: ** Unknown command `@code' (left as is) (in src/doc/muxers.texi l. 2020) *** '{' without macro. Before: -map} option with the ffmpeg CLI tool. (in src/doc/muxers.texi l. 2020) *** '}' without opening '{' before: option with the ffmpeg CLI

Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Remove redundant freeing of extradata of encoders

2021-04-17 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-04-15 04:02:35) > AVCodecContext.extradata is freed generically by libavformat for you mean libavcodec? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH v2] avformat/wavdec: Fix reading files with id3v2 apic before fmt tag

2021-04-17 Thread Paul B Mahol
Why you put nonsense regression part in log. That is very unfriendly behavior from you. Noted. On Sun, Apr 18, 2021 at 1:50 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > Up until now the cover images will get the stream index 0 in this case, > > violat