[FFmpeg-devel] [PATCH 1/3] lavc/qsv: apply AVCodecContext AVOption -threads to QSV

2021-04-08 Thread Haihao Xiang
By default the SDK creates a thread for each CPU when creating a mfx session for decoding / encoding, which results in CPU overhead on a multi CPU system. Actually creating 2 threads is a better choice for most cases in practice. This patch allows user to specify the number of threads created for

[FFmpeg-devel] [PATCH 2/3] lavu/hwcontext_qsv: limit the number of threads for QSV HW device to 2

2021-04-08 Thread Haihao Xiang
The session created for QSV HW device will be used as parent session only, so we needn't create more threads for this session --- libavutil/hwcontext_qsv.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_

[FFmpeg-devel] [PATCH 3/3] lavu/hwcontext_qsv: limit the number of threads used for hwupload & hwdownload to 2

2021-04-08 Thread Haihao Xiang
The session for hwupload & hwdownload is used to copy data between system and video memory, 2 threads are sufficient for the copy in the SDK. --- libavutil/hwcontext_qsv.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/adpcm_swf: remove memory allocation during trellis encoding

2021-04-08 Thread Zane van Iperen
On 3/4/21 11:19 am, Zane van Iperen wrote: On 1/4/21 9:34 pm, Zane van Iperen wrote: The block size is hardcoded, so the buffer size is always known. Statically allocate the buffer on the stack. Signed-off-by: Zane van Iperen ---   libavcodec/adpcmenc.c | 7 ---   1 file changed, 4 inse

Re: [FFmpeg-devel] [PATCH 1/7] tests/fate: add a test for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Anton Khirnov
Could someone please upload https://philip.html5.org/tests/apng/015.png -> /apng/015.png? Thanks, -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

[FFmpeg-devel] [PATCH] lavc/pngdec: always create a copy for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Anton Khirnov
Calling av_frame_make_writable() from decoders is tricky, especially when frame threading is used. It is much simpler and safer to just make a private copy of the frame. This is not expected to have a major performance impact, since APNG_DISPOSE_OP_BACKGROUND is not used often and av_frame_make_wri

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: always create a copy for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Andreas Rheinhardt
Anton Khirnov: > Calling av_frame_make_writable() from decoders is tricky, especially > when frame threading is used. It is much simpler and safer to just make > a private copy of the frame. > This is not expected to have a major performance impact, since > APNG_DISPOSE_OP_BACKGROUND is not used of

[FFmpeg-devel] Re: [PATCH 01/17] lavu: postpone child_class_next API removal

2021-04-08 Thread Anton Khirnov
Quoting Marton Balint (2021-04-05 14:32:54) > > > On Mon, 5 Apr 2021, Anton Khirnov wrote: > > > It has only been deprecated a year ago. > > Considering that this API has limited public usage, I don't think we have > to be strict about the 2 years here, so IMHO it is fine to remove it > at th

[FFmpeg-devel] [PATCH] lavu/video_enc_params: make sure blocks are properly aligned

2021-04-08 Thread Anton Khirnov
--- libavutil/video_enc_params.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/video_enc_params.c b/libavutil/video_enc_params.c index 635176ab91..1779a8799a 100644 --- a/libavutil/video_enc_params.c +++ b/libavutil/video_enc_params.c @@ -30,9 +30,9 @@ AVVideo

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_astats: Remove fraction part of integer metadata entries

2021-04-08 Thread Anton Khirnov
Quoting Tobias Rapp (2021-03-26 13:58:07) > Using integer format makes the metadata display similar to the log output. > > Fix missing "Overall" metadata key name prefix where necessary. Also > replace whitespace in some metadata key names with underscore character > for consistency. > > Signed-o

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: always create a copy for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-04-08 10:56:42) > Anton Khirnov: > > Calling av_frame_make_writable() from decoders is tricky, especially > > when frame threading is used. It is much simpler and safer to just make > > a private copy of the frame. > > This is not expected to have a major performanc

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_astats: Remove fraction part of integer metadata entries

2021-04-08 Thread Nicolas George
Anton Khirnov (12021-04-08): > Does this mean that there are no stability guarantees for metadata > exported by filters? We can have stability for the components that are good enough to be stable, and no stability yet for components that need enhancing. Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH] lavu/video_enc_params: make sure blocks are properly aligned

2021-04-08 Thread Andreas Rheinhardt
Anton Khirnov: > --- > libavutil/video_enc_params.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/video_enc_params.c b/libavutil/video_enc_params.c > index 635176ab91..1779a8799a 100644 > --- a/libavutil/video_enc_params.c > +++ b/libavutil/video_enc_par

Re: [FFmpeg-devel] [PATCH] lavu/video_enc_params: make sure blocks are properly aligned

2021-04-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-04-08 11:41:41) > Anton Khirnov: > > --- > > libavutil/video_enc_params.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavutil/video_enc_params.c b/libavutil/video_enc_params.c > > index 635176ab91..1779a8799a 100644 > > -

Re: [FFmpeg-devel] [PATCH] lavu/video_enc_params: make sure blocks are properly aligned

2021-04-08 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2021-04-08 11:41:41) >> Anton Khirnov: >>> --- >>> libavutil/video_enc_params.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/libavutil/video_enc_params.c b/libavutil/video_enc_params.c >>> index 635176ab91..1779a8

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Lynne
Apr 8, 2021, 07:35 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月8日 12:14 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data >> AV_FRAME_DATA_BOUNDING_BOXES >> >>

[FFmpeg-devel] [GSoC 2021] about proposal

2021-04-08 Thread kernel.bin
To whom it may concern:      May I ask if my GSoC proposal draft is visible,      the name should be "FFmpeg Windows Screen Record via Desktop Duplication"      Thanks! :) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l

[FFmpeg-devel] [PATCH] avformat/webvttenc: Fix use of uninitialized variable

2021-04-08 Thread Andreas Rheinhardt
Happened in 9168a1c0e67b5c31727b12329b6f52d2bb5e0a14. Signed-off-by: Andreas Rheinhardt --- libavformat/webvttenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webvttenc.c b/libavformat/webvttenc.c index 809fead69f..2bc86041a7 100644 --- a/libavformat/webvtten

Re: [FFmpeg-devel] [PATCH] lavu/video_enc_params: make sure blocks are properly aligned

2021-04-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-04-08 12:27:03) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2021-04-08 11:41:41) > >> Anton Khirnov: > >>> --- > >>> libavutil/video_enc_params.c | 6 +++--- > >>> 1 file changed, 3 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/libavutil/video_enc_par

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-08 Thread Anton Khirnov
Quoting James Almer (2021-04-04 01:12:00) > Signed-off-by: James Almer > --- > Now using the avformat_ prefix as Anton requested. I forgot about it when i > made v3. > > libavformat/avformat.h | 39 +++ > libavformat/utils.c| 27 +++

Re: [FFmpeg-devel] [PATCH 1/7] tests/fate: add a test for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread James Almer
On 4/8/2021 5:44 AM, Anton Khirnov wrote: Could someone please upload https://philip.html5.org/tests/apng/015.png -> /apng/015.png? Thanks, Uploaded. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-08 Thread James Almer
On 4/8/2021 10:09 AM, Anton Khirnov wrote: Quoting James Almer (2021-04-04 01:12:00) Signed-off-by: James Almer --- Now using the avformat_ prefix as Anton requested. I forgot about it when i made v3. libavformat/avformat.h | 39 +++ libavformat/utils.c

Re: [FFmpeg-devel] [PATCH v4] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-04-08 Thread Anton Khirnov
Quoting James Almer (2021-04-08 15:19:02) > On 4/8/2021 10:09 AM, Anton Khirnov wrote: > > Quoting James Almer (2021-04-04 01:12:00) > >> Signed-off-by: James Almer > >> --- > >> Now using the avformat_ prefix as Anton requested. I forgot about it when i > >> made v3. > >> > >> libavformat/avfor

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月8日 19:35 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Apr 8, 2021, 07:35 by yejun@intel.com: > > > >

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Nicolas George
Guo, Yejun (12021-04-08): > I'm afraid that we could not make sure all such filters (including filters in > the > future) to do the rescale. And in the previous discussion, I got to know that > 'many other existing side-data types are invalidated by scaling'. > > So, we need frame_width and frame

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: 2021年4月8日 22:54 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Guo, Yejun (12021-04-08): > > I'm afraid

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-08 Thread Michael Niedermayer
On Thu, Apr 08, 2021 at 01:58:23AM +0200, Tomas Härdin wrote: > fre 2021-04-02 klockan 16:35 +0530 skrev Gyan Doshi: > > > > On 2021-04-02 15:29, Michael Niedermayer wrote: > > > Hi all > > > > > > We still need to choose the name for 4.4 > > > previous unused suggestions where: > > > Von Neumann

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: always create a copy for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Michael Niedermayer
On Thu, Apr 08, 2021 at 10:46:54AM +0200, Anton Khirnov wrote: > Calling av_frame_make_writable() from decoders is tricky, especially > when frame threading is used. It is much simpler and safer to just make > a private copy of the frame. > This is not expected to have a major performance impact, s

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-08 Thread Michael Niedermayer
On Wed, Apr 07, 2021 at 04:59:09PM +0200, Michael Niedermayer wrote: > On Wed, Apr 07, 2021 at 12:42:50AM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: out of array read > > > Fixes: > > > 32968/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSP2_fuzzer-5315296027082752

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Lynne
Apr 8, 2021, 16:51 by yejun@intel.com: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Lynne >> Sent: 2021年4月8日 19:35 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data >> AV_FRAME_DATA_BOUNDING_BOXES >> >>

[FFmpeg-devel] [PATCH] avformat/utils: constrain the guaranteed lifetime of the pointer returned by avformat_index_get_entry()

2021-04-08 Thread James Almer
This will give us more room to improve the implementation later. Suggested-by: Anton Khirnov Signed-off-by: James Almer --- libavformat/avformat.h | 12 ++-- libavformat/utils.c| 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/avformat.h b/libavfo

Re: [FFmpeg-devel] [GSoC 2021] about proposal

2021-04-08 Thread Christopher Degawa
You might want to check your email client as it has added a bunch of ` ` which mangles your message when viewed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or em

[FFmpeg-devel] [PATCH] lavc/aarch64: add pred16x16 10-bit functions

2021-04-08 Thread Mikhail Nitenko
here are the benchmarks https://0x1.st/kX.txt --- libavcodec/aarch64/h264pred_init.c | 75 +++--- libavcodec/aarch64/h264pred_neon.S | 123 + 2 files changed, 168 insertions(+), 30 deletions(-) diff --git a/libavcodec/aarch64/h264pred_init.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add pred16x16 10-bit functions

2021-04-08 Thread Carl Eugen Hoyos
Am Do., 8. Apr. 2021 um 21:10 Uhr schrieb Mikhail Nitenko : > > here are the benchmarks https://0x1.st/kX.txt Instead please add the relevant lines to the commit message. > --- > libavcodec/aarch64/h264pred_init.c | 75 +++--- > libavcodec/aarch64/h264pred_neon.S | 123 +

[FFmpeg-devel] [PATCH 1/7] avcodec/rv34: Move dsp init code to rv30/rv40

2021-04-08 Thread Andreas Rheinhardt
It avoids both runtime and compile-time checks. Signed-off-by: Andreas Rheinhardt --- libavcodec/rv30.c | 1 + libavcodec/rv34.c | 9 - libavcodec/rv40.c | 1 + 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/libavcodec/rv30.c b/libavcodec/rv30.c index 36cd5345fd..e2b75fbe

[FFmpeg-devel] [PATCH 2/7] avcodec/h263dec, mpeg12dec: Remove redundant writes

2021-04-08 Thread Andreas Rheinhardt
ff_mpv_decode_init() already sets MpegEncContext.codec_id. Signed-off-by: Andreas Rheinhardt --- Supersedes http://ffmpeg.org/pipermail/ffmpeg-devel/2021-April/278741.html libavcodec/h263dec.c | 1 - libavcodec/mpeg12dec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/h263de

[FFmpeg-devel] [PATCH 4/7] avcodec/vc1: Don't pretend ff_vc1_init_common() can fail

2021-04-08 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- libavcodec/mss2.c | 3 +-- libavcodec/vc1.c| 4 +--- libavcodec/vc1.h| 2 +- libavcodec/vc1_parser.c | 3 ++- libavcodec/vc1dec.c | 3 +-- 5 files changed, 6 insertions(+), 9 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 5/7] avcodec/mss2: Remove redundant initialization of vc1 dsp

2021-04-08 Thread Andreas Rheinhardt
ff_vc1_init_common() already does it. Signed-off-by: Andreas Rheinhardt --- libavcodec/mss2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mss2.c b/libavcodec/mss2.c index 3e3205ae92..a27fae7559 100644 --- a/libavcodec/mss2.c +++ b/libavcodec/mss2.c @@ -752,7 +752,6 @@ static av

[FFmpeg-devel] [PATCH 6/7] avcodec/vc1: Remove unused hrd fields

2021-04-08 Thread Andreas Rheinhardt
Unused since be3492ec7eb2dbb0748c123af911a06c125c90db. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1.c| 2 -- libavcodec/vc1.h| 2 -- libavcodec/vc1dec.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index 5d854b35d2..b7140c089c 100644 -

[FFmpeg-devel] [PATCH 7/7] avcodec/msmpeg4dec: Avoid duplication of VLC init code

2021-04-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- All the users of these VLCs and of many more only use VLC.table and nothing else (the number of bits is hardcoded). Does someone object to keeping just these pointers in such circumstances? libavcodec/msmpeg4dec.c | 22 ++ 1 file changed,

[FFmpeg-devel] [PATCH 3/7] avcodec/msmpeg4enc: Remove dead code for inexistent VC-1 encoder

2021-04-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/msmpeg4enc.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/libavcodec/msmpeg4enc.c b/libavcodec/msmpeg4enc.c index 59a18532c2..7147015042 100644 --- a/libavcodec/msmpeg4enc.c +++ b/libavcodec/msmpeg4en

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: always create a copy for APNG_DISPOSE_OP_BACKGROUND

2021-04-08 Thread Michael Niedermayer
On Thu, Apr 08, 2021 at 05:34:30PM +0200, Michael Niedermayer wrote: > On Thu, Apr 08, 2021 at 10:46:54AM +0200, Anton Khirnov wrote: > > Calling av_frame_make_writable() from decoders is tricky, especially > > when frame threading is used. It is much simpler and safer to just make > > a private co

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec.c: Fixed indentation overwriting text in the cea608 caption decoder.

2021-04-08 Thread Aman Karmani
On Wed, Jan 27, 2021 at 3:40 PM wrote: > From: Levi Dooley > > There was an assumption in the existing code that indentation would not > occur more than once on the same row. > This was a bad assumption. There are examples of 608 streams which call > handle_pac multiple times on the same row wit

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add pred16x16 10-bit functions

2021-04-08 Thread Martin Storsjö
On Thu, 8 Apr 2021, Mikhail Nitenko wrote: here are the benchmarks https://0x1.st/kX.txt --- libavcodec/aarch64/h264pred_init.c | 75 +++--- libavcodec/aarch64/h264pred_neon.S | 123 + 2 files changed, 168 insertions(+), 30 deletions(-) av_cold void ff_h26

[FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: Remove remnant of inline-timing subtitle packets

2021-04-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 609a588f78..a4ddf1fa6a 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@

[FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: Put subtitles without duration into SimpleBlocks

2021-04-08 Thread Andreas Rheinhardt
The value zero for AVPacket.duration means that the duration is unknown, which in practice means "play this subtitle until overridden by the next subtitle". Yet for Matroska a BlockGroup with duration zero means that the subtitle really has a duration zero. "Display until overridden" is achieved by

Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-04-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: 2021年4月9日 0:57 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V7 4/6] lavu: add side data > AV_FRAME_DATA_BOUNDING_BOXES > First of all, thanks for the quick replies, I see, all