[FFmpeg-devel] [PATCH 1/3] lavfi/dnn_backend_tensorflow.c: fix mem leak in load_tf_model

2021-03-24 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_tf.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 750a476726..e016571304 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++ b/libavfilter/dnn/dnn_backend_

[FFmpeg-devel] [PATCH 2/3] lavfi/dnn_backend_tensorflow.c: fix mem leak in load_native_model

2021-03-24 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_tf.c | 55 ++-- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index e016571304..c18cb4063f 100644 --- a/libavfilter/dnn/dnn_back

[FFmpeg-devel] [PATCH 3/3] lavfi/dnn_backend_tensorflow.c: fix mem leak in execute_model_tf

2021-03-24 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_tf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index c18cb4063f..c0aa510630 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++ b/libavfilter/dnn/dnn_backend_tf.

Re: [FFmpeg-devel] [PATCH v2] lavfi/qsvvpp: support async depth

2021-03-24 Thread Wang, Fei W
On Sun, 2021-03-21 at 18:10 +0800, Linjie Fu wrote: > Hi Fei, > > On Mon, Mar 15, 2021 at 1:13 PM Fei Wang > wrote: > > > > Async depth will allow qsv filter cache few frames, and avoid force > > switch and end filter task frame by frame. This change will improve > > performance for some multi-t

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

2021-03-24 Thread Andreas Rheinhardt
sharp...@gmail.com: > To Andreas Rheinhardt, > >> Why is this not possible? I just told you how you could set >> max_dec_frame_buffering to a lower value. It seems you haven't tried it. > > Ahh...I thought what you care about is the unsafety of directly modifing > num_reorder_frames and num_reord

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

2021-03-24 Thread sharpbai
To Andreas Rheinhardt, > It is unsafe in the sense that it can lead to invalid and broken files. > But it is way safer than actually modifying the slice headers, because > the latter is absolutely irreversible, whereas one just needs to set big > enough values to fix files broken by setting too lo

Re: [FFmpeg-devel] [PATCH] Increase MOV_TIMESCALE for higher precision

2021-03-24 Thread Jan Ekström
On Wed, Mar 24, 2021 at 7:30 AM Gyan Doshi wrote: > > > > On 2021-03-24 03:38, Andrey Rikunov wrote: > > --- > > libavformat/movenc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/movenc.h b/libavformat/movenc.h > > index cdbc407..8a152c0 100644 > >

Re: [FFmpeg-devel] 回复: Possibility to add tonemap filter to ffmpeg 3.2.7

2021-03-24 Thread Li Jinyao
Thanks, I am trying pick tonemap changes back, and I found tonemap relay on single precision planar RGB pixel formats like AV_PIX_FMT_GBRPF32, which means I need to pick these code, too. I am working on it now, but I am not sure if there are a lot work to do to make 3.2.4 support these pixel fo

Re: [FFmpeg-devel] 回复: Possibility to add tonemap filter to ffmpeg 3.2.7

2021-03-24 Thread Nicolas George
Li Jinyao (12021-03-24): > Can you give me some advice? The only advice we can give you is that you post here the changes you have made to the old FFmpeg and start working on making work with current FFmpeg and getting integrated into the official version. I hope you do not expect people here wil

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/vc1dec: Postpone allocating sprite frame to avoid segfault

2021-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, the VC-1 decoders allocated an AVFrame for usage with > sprites during vc1_decode_init(); yet said AVFrame can be freed if > (re)initializing the context (which happens ordinarily during decoding) > fails. The AVFrame does not get allocated again lateron in this

Re: [FFmpeg-devel] [PATCH] Increase MOV_TIMESCALE for higher precision

2021-03-24 Thread Gyan Doshi
On 2021-03-24 15:45, Jan Ekström wrote: On Wed, Mar 24, 2021 at 7:30 AM Gyan Doshi wrote: On 2021-03-24 03:38, Andrey Rikunov wrote: --- libavformat/movenc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.h b/libavformat/movenc.h index cdbc407..

[FFmpeg-devel] 回复: 回复: Possibility to add tonemap filter to ffmpeg 3.2.7

2021-03-24 Thread Li Jinyao
I didn't mean to offend neither expect free work. I only expect to get some quick hit from here. I am new to the old project and it have lot of history debt. The changes are made by previous colleagues through years and it's mainly about custom live infra. I am making search about make the modi

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/adpcm: add comment to has_status field

2021-03-24 Thread Zane van Iperen
On 24/3/21 12:12 am, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) As these are trivial patches, I will apply them tomorrow and backport to 4.4. ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/kmvc: Move commonly used variables to the front of the context

2021-03-24 Thread Tomas Härdin
mån 2021-03-22 klockan 03:06 +0100 skrev Andreas Rheinhardt: > Reduces codesize because the offset in pointer+offset addressing > requires less bytes to encode. Reduces the size of .text from 8871B > to 8146B (GCC 10, -O3, x64). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/kmvc.c | 4

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/kmvc: Move commonly used variables to the front of the context

2021-03-24 Thread Andreas Rheinhardt
Tomas Härdin: > mån 2021-03-22 klockan 03:06 +0100 skrev Andreas Rheinhardt: >> Reduces codesize because the offset in pointer+offset addressing >> requires less bytes to encode. Reduces the size of .text from 8871B >> to 8146B (GCC 10, -O3, x64). >> >> Signed-off-by: Andreas Rheinhardt >> --- >>

Re: [FFmpeg-devel] [PATCH] Increase MOV_TIMESCALE for higher precision

2021-03-24 Thread Andrey Rikunov
Gyan, thanks for clarification! It is all exactly as you described. I thought to set MOV_TIMESCALE to either 60kHz or 90kHz as both are divisible by most common fps values. And x10 increase is for further precision in conversion to seconds. Say it's needed to write segmentDuration=289.4892 sec in e

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/kmvc: Move commonly used variables to the front of the context

2021-03-24 Thread Tomas Härdin
ons 2021-03-24 klockan 14:49 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > mån 2021-03-22 klockan 03:06 +0100 skrev Andreas Rheinhardt: > > > Reduces codesize because the offset in pointer+offset addressing > > > requires less bytes to encode. Reduces the size of .text from 8871B > > > to 814

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/kmvc: Move commonly used variables to the front of the context

2021-03-24 Thread Andreas Rheinhardt
Tomas Härdin: > ons 2021-03-24 klockan 14:49 +0100 skrev Andreas Rheinhardt: >> Tomas Härdin: >>> mån 2021-03-22 klockan 03:06 +0100 skrev Andreas Rheinhardt: Reduces codesize because the offset in pointer+offset addressing requires less bytes to encode. Reduces the size of .text from 887

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/kmvc: Move commonly used variables to the front of the context

2021-03-24 Thread Tomas Härdin
ons 2021-03-24 klockan 15:26 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > ons 2021-03-24 klockan 14:49 +0100 skrev Andreas Rheinhardt: > > > Tomas Härdin: > > > > mån 2021-03-22 klockan 03:06 +0100 skrev Andreas Rheinhardt: > > > > > Reduces codesize because the offset in pointer+offset addr

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-03-24 Thread Nicolas George
James Almer (12021-03-23): > If your creative API invention is better, then i have no problem with it > even if it goes against existing conventions. > > Which for that matter reminds me that i changed my mind regarding your > refcounted proposal, since the alternative of adding an AVRefCount stru

[FFmpeg-devel] [PATCH] avformat/mov: Ignore multiple STSC / STCO

2021-03-24 Thread Michael Niedermayer
Fixes: STSC / STCO inconsistency and assertion failure Fixes: crbug1184666.mp4 Found-by: Chromium ASAN fuzzer Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-03-24 Thread James Almer
On 3/24/2021 12:15 PM, Nicolas George wrote: James Almer (12021-03-23): If your creative API invention is better, then i have no problem with it even if it goes against existing conventions. Which for that matter reminds me that i changed my mind regarding your refcounted proposal, since the al

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans_opencl: making filter independent of bit depth

2021-03-24 Thread Lucas Clemente Vella
Hello. Is there something I should be doing in order to get this patch reviewed for inclusion in master? I couldn't find the proper maintainer for this filter in the MAINTAINERS file. -- Lucas Clemente Vella lve...@gmail.com ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-03-24 Thread Nicolas George
James Almer (12021-03-24): > Because it's not even a pointer that's guaranteed to be valid or point to > valid data until the next call to one specific function or set of functions > (Your example is basically av_dict_get(), where only calls to av_dict_set*() > on a AVDictionary you own will make p

Re: [FFmpeg-devel] [PATCH] avformat/utils: add helper functions to retrieve index entries from an AVStream

2021-03-24 Thread James Almer
On 3/24/2021 4:48 PM, Nicolas George wrote: James Almer (12021-03-24): Because it's not even a pointer that's guaranteed to be valid or point to valid data until the next call to one specific function or set of functions (Your example is basically av_dict_get(), where only calls to av_dict_set*(

Re: [FFmpeg-devel] [PATCH 1/6] avformat/jacosubdec: Fix leak on error

2021-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/jacosubdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/jacosubdec.c b/libavformat/jacosubdec.c > index b44e3b7783..828c33057f 100644 > --- a/libavformat/jacosubdec.c > +++ b/libavformat/jacosub

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/pthread_frame: Factor initializing single thread out

2021-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pthread_frame.c | 127 - > 1 file changed, 68 insertions(+), 59 deletions(-) > > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index 7bcb9a7bcc..311d6ed771 1006

Re: [FFmpeg-devel] [PATCH] avfilter/hwupload_cuda: add YUVA420P format support

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] avfilter/overlay_cuda: fix framesync with embedded PGS subtitle

2021-03-24 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

[FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-24 Thread Alok Priyadarshi
Timestamp difference is available in media timebase (1/90K) where as rtcp time is in the default microseconds timebase. This patch fixes the calculated prft wallclock time by rescaling the timestamp delta to the microseconds timebase. --- libavformat/rtpdec.c | 9 +++-- 1 file changed, 7 inser

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-24 Thread Alok Priyadarshi
Hi James, This patch had a bug in the calculation of prft time. I did not account for the timebase differences between media timestamp and wall clock. I have sent a new patch for review. -Alok On Tue, Mar 23, 2021 at 3:04 PM James Almer wrote: > On 3/23/2021 6:29 PM, Alok Priyadarshi wrote: >