[FFmpeg-devel] [REMINDER] FFmpeg dev meeting

2021-03-13 Thread Jean-Baptiste Kempf
Hello, Reminder, we're doing an FFmpeg dev meeting this afternoon, Berlin Time. On IRC and jitsi. Currently the topics are: - GA update - TC rules - hardware - GSoC - next major bump - next release Any other topic? Please add to the list. Best, -- Jean-Baptiste Kempf - President +33 672 704

Re: [FFmpeg-devel] [PATCH] libavutil/timer: Fix clang reserved-user-defined-literal

2021-03-13 Thread Christopher Degawa
On Sat, Mar 13, 2021 at 01:09 Chris Degawa wrote: > > > > On Mar 13, 2021, at 00:57, Anton Khirnov wrote: > > > > Quoting Christopher Degawa (2021-03-13 05:20:37) > >> clang errors when compiling with C++11 about needing spaces between > >> literal and identifier > > > > Why would you compile i

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: maintainer of "dvvideo" module?

2021-03-13 Thread Mark Plomer
Hello, is there anyone who maintains the "dvvideo" module, who can review this patch and give me some feedback? Greets Mark Am 16.01.21 um 14:40 schrieb Mark Plomer: Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, although

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-13 Thread Michael Niedermayer
On Sat, Jan 16, 2021 at 02:40:03PM +0100, Mark Plomer wrote: > Trying to fix https://trac.ffmpeg.org/ticket/8333 > > Some of my old DV AVI files have the DSF-Flag of frames set to 0, although > it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this > causes ffmpeg/VLC-player t

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-13 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 10:06:49AM -0300, James Almer wrote: > On 3/10/2021 7:37 AM, Michael Niedermayer wrote: > > On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote: > > > On 3/9/2021 5:47 PM, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > I will branch release/4.4 soon > > >

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-13 Thread Paul B Mahol
On Sat, Mar 13, 2021 at 12:29 PM Michael Niedermayer wrote: > On Wed, Mar 10, 2021 at 10:06:49AM -0300, James Almer wrote: > > On 3/10/2021 7:37 AM, Michael Niedermayer wrote: > > > On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote: > > > > On 3/9/2021 5:47 PM, Michael Niedermayer wrote

Re: [FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-13 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 07:33:53PM +0100, Paul B Mahol wrote: > Hi, > > With latest master and with any audio only file, using "ffmpeg -i file -f > null -" reports incorrect duration. ./ffmpeg -i ~/videos/1sec-zero.mp3 -f null - shows durations at 2 points in the output Duration: 00:00:01.03, sta

[FFmpeg-devel] [PATCH v2] avcodec: add a mention about get_encode_buffer in the old encode API doxy

2021-03-13 Thread James Almer
Direct users to the callback that should be used to keep supporting user provided buffers with the new encode API. Signed-off-by: James Almer --- libavcodec/avcodec.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index fbd

Re: [FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-13 Thread Paul B Mahol
On Sat, Mar 13, 2021 at 1:30 PM Michael Niedermayer wrote: > On Thu, Mar 11, 2021 at 07:33:53PM +0100, Paul B Mahol wrote: > > Hi, > > > > With latest master and with any audio only file, using "ffmpeg -i file -f > > null -" reports incorrect duration. > > ./ffmpeg -i ~/videos/1sec-zero.mp3 -f nu

Re: [FFmpeg-devel] [PATCH 2/2] RFC ffmpeg: exit demuxers earlier after signal received

2021-03-13 Thread Andriy Gelman
On Sun, 07. Feb 15:04, Andriy Gelman wrote: > On Sat, 28. Nov 14:46, Andriy Gelman wrote: > > From: Andriy Gelman > > > > We currently use the same interrupt_callback function for both muxers > > and demuxers to break out of potential infinite loops. > > > > The function decode_interrupt_cb() ch

Re: [FFmpeg-devel] [PATCH] libavutil/timer: Fix clang reserved-user-defined-literal

2021-03-13 Thread James Almer
On 3/13/2021 5:11 AM, Christopher Degawa wrote: On Sat, Mar 13, 2021 at 01:09 Chris Degawa wrote: On Mar 13, 2021, at 00:57, Anton Khirnov wrote: Quoting Christopher Degawa (2021-03-13 05:20:37) clang errors when compiling with C++11 about needing spaces between literal and identifier

Re: [FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-13 Thread Michael Niedermayer
On Sat, Mar 13, 2021 at 03:11:34PM +0100, Paul B Mahol wrote: > On Sat, Mar 13, 2021 at 1:30 PM Michael Niedermayer > wrote: > > > On Thu, Mar 11, 2021 at 07:33:53PM +0100, Paul B Mahol wrote: > > > Hi, > > > > > > With latest master and with any audio only file, using "ffmpeg -i file -f > > > nu

Re: [FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-13 Thread Paul B Mahol
On Sat, Mar 13, 2021 at 3:48 PM Michael Niedermayer wrote: > On Sat, Mar 13, 2021 at 03:11:34PM +0100, Paul B Mahol wrote: > > On Sat, Mar 13, 2021 at 1:30 PM Michael Niedermayer > > > wrote: > > > > > On Thu, Mar 11, 2021 at 07:33:53PM +0100, Paul B Mahol wrote: > > > > Hi, > > > > > > > > With

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-03-13 Thread Mark Thompson
On 11/03/2021 08:53, Xu, Guangxin wrote: -Original Message- From: ffmpeg-devel On Behalf Of Guangxin Xu Sent: Friday, March 5, 2021 9:46 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_creat

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/hls: Reset options after open_url_keepalive() fails

2021-03-13 Thread Ed Martin
On 3/10/21 10:16 PM, Steven Liu wrote: 2021年3月11日 上午5:43,li...@edman007.com 写道: From: Ed Martin open_url_keepalive() unsets the options when it uses them, this includes the offsets for the Range: header. When using the HLS tag #EXT-X-BYTERANGE along with multiple files, the range options must

Re: [FFmpeg-devel] [REMINDER] FFmpeg dev meeting

2021-03-13 Thread Paul B Mahol
On Sat, Mar 13, 2021 at 9:10 AM Jean-Baptiste Kempf wrote: > Hello, > > Reminder, we're doing an FFmpeg dev meeting this afternoon, Berlin Time. > On IRC and jitsi. > > Currently the topics are: > - swscale rewrite > - GA update > - TC rules > - hardware > - GSoC > - next major bump > - next rel

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-03-13 Thread Michael Niedermayer
On Fri, Feb 19, 2021 at 10:00:39PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Suggested-by: Andreas Rheinhardt > > Signed-off-by: Michael Niedermayer > > --- > > doc/APIchanges | 3 +++ > > libavutil/common.h | 2 ++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale: Fix adding 0 to NULL (which is UB) in scale_slice()

2021-03-13 Thread Michael Niedermayer
On Fri, Feb 19, 2021 at 09:43:45PM +0100, Michael Niedermayer wrote: > Found-by: Jeremy Leconte > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_scale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730B

Re: [FFmpeg-devel] [PATCH] avcodec/flacdec: Avoid undefined shift in error case

2021-03-13 Thread Michael Niedermayer
On Tue, Mar 09, 2021 at 09:04:45PM +0100, Michael Niedermayer wrote: > Fixes: flac_1040988 > > Reported-by: Thomas Guilbert > Signed-off-by: Michael Niedermayer > --- > libavcodec/flacdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH 1/5] avformat/sbgdec: Use av_sat_add64() in str_to_time()

2021-03-13 Thread Michael Niedermayer
On Sun, Jan 31, 2021 at 10:56:01PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 727999279212000 + 4611686018427387904 > cannot be represented in type 'long long' > Fixes: > 29744/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6434060249464832 > > Found-by: contin

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/exr: Check col/line for integer overflow

2021-03-13 Thread Michael Niedermayer
On Mon, Feb 01, 2021 at 11:31:16PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2272 + -2147483360 cannot be represented in > type 'int' > Fixes: > 30009/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5005660322398208 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-03-13 Thread Lynne
Mar 13, 2021, 16:18 by mich...@niedermayer.cc: > On Fri, Feb 19, 2021 at 10:00:39PM +0100, Andreas Rheinhardt wrote: > >> Michael Niedermayer: >> > Suggested-by: Andreas Rheinhardt >> > Signed-off-by: Michael Niedermayer >> > --- >> > doc/APIchanges | 3 +++ >> > libavutil/common.h | 2 ++ >>

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-03-13 Thread Michael Niedermayer
On Sat, Mar 13, 2021 at 04:41:39PM +0100, Lynne wrote: > Mar 13, 2021, 16:18 by mich...@niedermayer.cc: > > > On Fri, Feb 19, 2021 at 10:00:39PM +0100, Andreas Rheinhardt wrote: > > > >> Michael Niedermayer: > >> > Suggested-by: Andreas Rheinhardt > >> > Signed-off-by: Michael Niedermayer > >> >

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: dv files with wrong dsf flag - detect via buf_size

2021-03-13 Thread Marton Balint
On Sat, 16 Jan 2021, Mark Plomer wrote: Trying to fix https://trac.ffmpeg.org/ticket/8333 Some of my old DV AVI files have the DSF-Flag of frames set to 0, although it is PAL (I think they were rendered with Ulead Media Studio Pro) ... this causes ffmpeg/VLC-player to produce/play corrupted

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, Paul B Mahol wrote: On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: On Sun, 7 Mar 2021, Marton Balint wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint wrote: >> >>> >>> >>> On Sun, 7 Mar 2021, Paul B Mahol

Re: [FFmpeg-devel] [WANTED] Fix incorrect audio duration reporting

2021-03-13 Thread Michael Niedermayer
On Sat, Mar 13, 2021 at 04:04:32PM +0100, Paul B Mahol wrote: > On Sat, Mar 13, 2021 at 3:48 PM Michael Niedermayer > wrote: > > > On Sat, Mar 13, 2021 at 03:11:34PM +0100, Paul B Mahol wrote: > > > On Sat, Mar 13, 2021 at 1:30 PM Michael Niedermayer > > > > > wrote: > > > > > > > On Thu, Mar 11

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Paul B Mahol
On Sat, Mar 13, 2021 at 5:56 PM Marton Balint wrote: > > > On Fri, 12 Mar 2021, Paul B Mahol wrote: > > > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: > > > >> > >> > >> On Sun, 7 Mar 2021, Marton Balint wrote: > >> > >> > > >> > > >> > On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> > > >

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-13 Thread Marton Balint
On Sat, 13 Mar 2021, Paul B Mahol wrote: On Sat, Mar 13, 2021 at 5:56 PM Marton Balint wrote: On Fri, 12 Mar 2021, Paul B Mahol wrote: > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint wrote: > >> >> >> On Sun, 7 Mar 2021, Marton Balint wrote: >> >> > >> > >> > On Sun, 7 Mar 2021, Paul B

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: add av_packet_resize()

2021-03-13 Thread Marton Balint
On Fri, 12 Mar 2021, James Almer wrote: I get a packet from a demuxer. It contains two independent portions (NALUs, OBUs, etc) i want to separate in order to feed them to something like a multi threaded decoder. And so I create a new reference to it, resulting in two packets pointing to th

Re: [FFmpeg-devel] [REMINDER] FFmpeg dev meeting

2021-03-13 Thread Michael Niedermayer
On Sat, Mar 13, 2021 at 04:08:25PM +0100, Paul B Mahol wrote: > On Sat, Mar 13, 2021 at 9:10 AM Jean-Baptiste Kempf wrote: > > > Hello, > > > > Reminder, we're doing an FFmpeg dev meeting this afternoon, Berlin Time. > > On IRC and jitsi. > > > > Currently the topics are: > > > - swscale rewrite

Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation: add buffer fifo and output packets in order they arrive

2021-03-13 Thread Mark Reid
On Sun., Feb. 28, 2021, 8:30 p.m. Mark Reid, wrote: > > > On Sat, Feb 13, 2021 at 10:04 PM wrote: > >> From: Mark Reid >> >> Hi, >> This patch fixes audio issues I've had with some capture devices. The >> audio >> gets really choppy and stops working. This seems to be because >> avf_read_packet

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-03-13 Thread Michael Niedermayer
On Sat, Mar 13, 2021 at 04:41:39PM +0100, Lynne wrote: > Mar 13, 2021, 16:18 by mich...@niedermayer.cc: > > > On Fri, Feb 19, 2021 at 10:00:39PM +0100, Andreas Rheinhardt wrote: > > > >> Michael Niedermayer: > >> > Suggested-by: Andreas Rheinhardt > >> > Signed-off-by: Michael Niedermayer > >> >

[FFmpeg-devel] [PATCH 1/8] avcodec/assdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/assdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/assdec.c b/libavcodec/assdec.c index f0b1069cd2..655fc1365c 100644 --- a/libavcodec/assdec.c +++ b/libavcodec/assdec.c @@ -54,7 +54,7 @@ static int ass_decode_frame(

[FFmpeg-devel] [PATCH 2/8] avcodec/samidec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/samidec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index e32f238c62..f03b5db958 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@ -38,12 +38,12 @@ typedef stru

[FFmpeg-devel] [PATCH 3/8] avcodec/mpl2dec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/mpl2dec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpl2dec.c b/libavcodec/mpl2dec.c index 409e4b3708..efeecb0d64 100644 --- a/libavcodec/mpl2dec.c +++ b/libavcodec/mpl2dec.c @@ -29,15 +29,15 @@ #includ

[FFmpeg-devel] [PATCH 4/8] avcodec/realtextdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/realtextdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/realtextdec.c b/libavcodec/realtextdec.c index 5084781123..bdd9659235 100644 --- a/libavcodec/realtextdec.c +++ b/libavcodec/realtextdec.c @@ -29,11 +29

[FFmpeg-devel] [PATCH 5/8] avcodec/subviewerdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/subviewerdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/subviewerdec.c b/libavcodec/subviewerdec.c index 805c7dd547..1016ac7ada 100644 --- a/libavcodec/subviewerdec.c +++ b/libavcodec/subviewerdec.c @@ -28,1

[FFmpeg-devel] [PATCH 6/8] avcodec/webvttdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/webvttdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/webvttdec.c b/libavcodec/webvttdec.c index 7b2d1750de..43caf3edbd 100644 --- a/libavcodec/webvttdec.c +++ b/libavcodec/webvttdec.c @@ -42,23 +42,23 @@

[FFmpeg-devel] [PATCH 7/8] avcodec/srtdec: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/srtdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/srtdec.c b/libavcodec/srtdec.c index 98f84ac673..37fb0d3173 100644 --- a/libavcodec/srtdec.c +++ b/libavcodec/srtdec.c @@ -62,6 +62,7 @@ static int srt_decode

[FFmpeg-devel] [PATCH 8/8] avformat/assenc: do not overread if zero padding is missing

2021-03-13 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/assenc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index 68c3396e5a..265b5996ac 100644 --- a/libavformat/assenc.c +++ b/libavformat/assenc.c @@ -156,16 +156,23 @@ st

[FFmpeg-devel] FFmpeg Meeting of March 13.

2021-03-13 Thread Jean-Baptiste Kempf
Hello folks, Today, March 13, 2021, was held an FFmpeg developer meeting, to speak about our current developer situation. The meeting started on IRC and on Jitsi, at 17:00 Berlin/Paris time. There were from 10 to 16 people on the Jitsi call, and a few other that were only on IRC. 1. GA updat

[FFmpeg-devel] [PATCH] fftools/ffmpeg: use the correct size value for wrapped_avframe packets

2021-03-13 Thread James Almer
pkt->size on packets wrapping an AVFrame signaled by the wrapped_avframe codec_id are set to the size of the AVFrame structure and not the actual raw data contained in it. ffmpeg.c was using those values to print bogus stats about the resulting output file. Before this patch: frame= 24 fps=0.0 q

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: use the correct size value for wrapped_avframe packets

2021-03-13 Thread James Almer
On 3/13/2021 8:44 PM, James Almer wrote: pkt->size on packets wrapping an AVFrame signaled by the wrapped_avframe codec_id are set to the size of the AVFrame structure and not the actual raw data contained in it. ffmpeg.c was using those values to print bogus stats about the resulting output file

Re: [FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

2021-03-13 Thread Moritz Barsnick
On Sun, Aug 23, 2020 at 22:50:18 +0300, Martin Storsjö wrote: > > On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote: > > > LGTM, with one small nit: > > [...] > > > > {"listen", "Listen for incoming connections", > > > > offsetof(pstruct, options_field . listen),AV_OPT_

[FFmpeg-devel] [PATCH] avcodec/wrapped_avframe: stop using sizeof(AVFrame)

2021-03-13 Thread James Almer
Signed-off-by: James Almer --- Setting pkt->size to 0 but leaving pkt->data pointing to the frame ensures that the packet isn't mistaken for an empty one, and prevents wrong use of the data pointer in case av_packet_make_writable() is called on it (The resulting packet will be the same as if you c

Re: [FFmpeg-devel] [PATCH] avutils/hwcontext_qsv: set the source device in qsv_device_create

2021-03-13 Thread Xu, Guangxin
> You are hacking it to lie to the hwcontext implementation around how the > device was derived, so the test fails because it finds a different derivation > structure to what it created? That seems correct? > > Your command-line was: > > $ ffmpeg -init_hw_device vaapi=intel:/dev/dri/renderD128 -

[FFmpeg-devel] [PATCH] avformat/aviobuf: don't reduce short seek threshold

2021-03-13 Thread Andriy Gelman
From: Andriy Gelman Commit 8c8e5d5286bf598a89ef9993a2cf6ea409d03a32 added a way to reduce seek time by waiting for the windowed tcp packets instead of creating a new socket connection. It implemented this by overwriting s->short_seek_threshold in the avio_seek(). However, s->short_seek_threshold