Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-02 Thread Anton Khirnov
Quoting James Almer (2021-03-01 20:35:55) > On 3/1/2021 12:36 PM, Andreas Rheinhardt wrote: > > James Almer: > >> On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: > >>> Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, > >>> publically deprecated in 9a07c1332cfe092b57b5758f22b686ca

Re: [FFmpeg-devel] [PATCH] avcodec/speedhq: fix decoding 422 subsampling when width is not multiple of 16

2021-03-02 Thread Anton Khirnov
Quoting Paul B Mahol (2021-03-01 15:41:22) > Signed-off-by: Paul B Mahol > --- > libavcodec/speedhq.c | 42 -- > 1 file changed, 40 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c > index 759fc6dfc5..2a2fc42efa 10

[FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-02 Thread Jan Ekström
I've intentionally kept this initial version simple (no styling etc) to focus on the basics. As this goes through review, additional features can be added (I had initial PoC for styling implemented some time around previous VDD), and there is another patch set in my queue which would then add suppo

[FFmpeg-devel] [PATCH v6 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-03-02 Thread Jan Ekström
From: Stefano Sabatini Base escaping only escapes values required for base character data according to part 2.4 of XML, and if additional flags are added single and double quotes can additionally be escaped in order to handle single and double quoted attributes. Co-Authored-By: Jan Ekström Sig

[FFmpeg-devel] [PATCH v6 3/4] avcodec: enable usage of err_recognition for encoders

2021-03-02 Thread Jan Ekström
From: Jan Ekström Enables the usage of such values as AV_EF_EXPLODE in encoders, which can be useful in cases such as subtitle encoders where they have the responsibility to validate the correctness of an incoming ASS dialog line. Signed-off-by: Jan Ekström --- doc/APIchanges | 3

[FFmpeg-devel] [PATCH v6 2/4] ffprobe: switch to av_bprint_escape for XML escaping

2021-03-02 Thread Jan Ekström
From: Jan Ekström Additionally update the result of the ffprobe XML writing test. Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 32 +++- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/fftools/ffprob

[FFmpeg-devel] [PATCH v6 4/4] {avcodec, avformat}: add TTML encoder and muxer

2021-03-02 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML and writing them out as such documents. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcod

[FFmpeg-devel] [PATCH] lavc: clarify thread_safe_callbacks doxy

2021-03-02 Thread Anton Khirnov
State explicitly when this field will be removed and how to access it in a forward compatible way. --- libavcodec/avcodec.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index cd6e6d19bc..5a0904a854 100644 --- a/libavcodec/avco

[FFmpeg-devel] [PATCH 1/2] avformat/aadec: Use smaller scope for variables, remove initializations

2021-03-02 Thread Andreas Rheinhardt
avio_get_str always zero terminates the strings it reads. Signed-off-by: Andreas Rheinhardt --- libavformat/aadec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavformat/aadec.c b/libavformat/aadec.c index 612e66906d..b1e93ea072 100644 --- a/libavformat/aadec.c

[FFmpeg-devel] [PATCH 2/2] avformat/aadec: Replace strncpy by av_strlcpy

2021-03-02 Thread Andreas Rheinhardt
While this usage of strncpy is correct, said function nevertheless has the disadvantage of not automatically ensuring that the destination string is zero-terminated. So av_strlcpy should be preferred. This also removes a -Wstringop-truncation warning from GCC (it doesn't matter whether the buffer i

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/gopher: Add support for Gopher over TLS.

2021-03-02 Thread Ivan J.
Ping for review. Thank you. Best regards, Ivan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Ensure strings are zero-terminated

2021-03-02 Thread Andreas Rheinhardt
strncpy only ensures that one does not write beyond the end of the destination buffer; in case of truncation it does not zero-terminate the destination buffer. This makes using it the way it is now in the DASH demuxer dangerous. So use av_strlcpy instead. Also don't write anything if there is no i

[FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Increase size of id buffer

2021-03-02 Thread Andreas Rheinhardt
The current size is not enough, see e.g. http://ftp.itec.aau.at/datasets/DASHDataset2014/TearsOfSteel/1sec/TearsOfSteel_1s_simple_2014_05_09.mpd Signed-off-by: Andreas Rheinhardt --- I don't know if there is a fixed size limit or not (probably not), but 32 is able to accomodate everything I found

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Ensure strings are zero-terminated

2021-03-02 Thread Steven Liu
> 2021年3月2日 下午6:38,Andreas Rheinhardt 写道: > > strncpy only ensures that one does not write beyond the end of the > destination buffer; in case of truncation it does not zero-terminate > the destination buffer. This makes using it the way it is now in the > DASH demuxer dangerous. So use av_strl

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-02 Thread Andreas Rheinhardt
Hendrik Leppkes: > On Tue, Mar 2, 2021 at 6:14 AM Andreas Rheinhardt > wrote: >> >> James Almer: >>> On 3/1/2021 12:36 PM, Andreas Rheinhardt wrote: James Almer: > On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: >> Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, >>

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-02 Thread James Almer
On 3/2/2021 5:39 AM, Anton Khirnov wrote: Quoting James Almer (2021-03-01 20:35:55) On 3/1/2021 12:36 PM, Andreas Rheinhardt wrote: James Almer: On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36, publically deprecated in 9a07c13

Re: [FFmpeg-devel] [PATCH] lavc: clarify thread_safe_callbacks doxy

2021-03-02 Thread James Almer
On 3/2/2021 6:10 AM, Anton Khirnov wrote: State explicitly when this field will be removed and how to access it in a forward compatible way. --- libavcodec/avcodec.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index cd6e6

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Increase size of id buffer

2021-03-02 Thread James Almer
On 3/2/2021 7:38 AM, Andreas Rheinhardt wrote: The current size is not enough, see e.g. http://ftp.itec.aau.at/datasets/DASHDataset2014/TearsOfSteel/1sec/TearsOfSteel_1s_simple_2014_05_09.mpd Signed-off-by: Andreas Rheinhardt --- I don't know if there is a fixed size limit or not (probably not)

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/parser: Schedule av_parser_change for removal

2021-03-02 Thread Andreas Rheinhardt
James Almer: > On 3/2/2021 5:39 AM, Anton Khirnov wrote: >> Quoting James Almer (2021-03-01 20:35:55) >>> On 3/1/2021 12:36 PM, Andreas Rheinhardt wrote: James Almer: > On 2/26/2021 10:18 AM, Andreas Rheinhardt wrote: >> Originally deprecated in 748c2fca7e4d99357c234936aa71212a6282be36

[FFmpeg-devel] [PATCH] avcodec/speedhq: fix decoding non 444 subsampling when width is not multiple of 16

2021-03-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/speedhq.c | 79 ++-- 1 file changed, 77 insertions(+), 2 deletions(-) diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c index 759fc6dfc5..5861b7f6b5 100644 --- a/libavcodec/speedhq.c +++ b/libavcodec/speedh

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: add DWA decompression support

2021-03-02 Thread Paul B Mahol
will apply this set soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Remove limit on length of id

2021-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- You like this more? (It seems to me that the earlier code would have use a NULL pointer for %s in av_log if there is no id.) libavformat/dashdec.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Don't needlessly strdup metadata

2021-03-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Using separate lists for audio, video and subtitles leads to lots of code duplication in this demuxer; the only place where one gains a bit is in refresh_manifest (which is already buggy in itself because it leaks upon error...). Is it really worth it? libav

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashdec: Remove limit on length of id

2021-03-02 Thread James Almer
On 3/2/2021 11:53 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- You like this more? Yes, otherwise as there's no defined upper limit we'll just be increasing the fixed array every now and then when new manifest files show up with increasingly verbose ids. (It seems t

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: Don't needlessly strdup metadata

2021-03-02 Thread James Almer
On 3/2/2021 11:53 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Using separate lists for audio, video and subtitles leads to lots of code duplication in this demuxer; the only place where one gains a bit is in refresh_manifest (which is already buggy in itself because it le

[FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
--- libavformat/ivfenc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 0951f56..e22625b 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -23,7 +23,7 @@ typedef struct IVFEncContext { unsigned

[FFmpeg-devel] [PATCH] Bugfix for #9135

2021-03-02 Thread Peter White
Hello dear ffmpeg developers, I have just created ticket #9135 on the bug tracker. According to the instructions, I am sending the patch to this list, see attachment. Peter diff --git a/configure b/configure index d11942fced..bcc845668b 100755 --- a/configure +++ b/configure @@ -6490,7 +6490,7

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Andreas Rheinhardt
Ronald S. Bultje: > --- > libavformat/ivfenc.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 0951f56..e22625b 100644 > --- a/libavformat/ivfenc.c > +++ b/libavformat/ivfenc.c > @@ -23,7 +23,7 @@ > > type

Re: [FFmpeg-devel] [PATCH] Bugfix for #9135

2021-03-02 Thread Peter White
Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. Peter diff --git a/configure b/configure index d11942fced..bcc845668b 100755 --- a/configure +++ b/configure @@ -6490,7 +6490,7 @@ enabled mmal && { check_lib mmal interface/mmal/mmal.h

Re: [FFmpeg-devel] [PATCH] Bugfix for #9135

2021-03-02 Thread James Almer
On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although it is preferred. What they need to be is made with git format-patch, which preserves authorship information and commit m

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Peter White
On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although it is preferred. What they need to be is made with git format-patch, which preserv

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
Hi, On Tue, Mar 2, 2021 at 11:20 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Ronald S. Bultje: > > --- > > libavformat/ivfenc.c | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > > index 0951

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Andreas Rheinhardt
Ronald S. Bultje: > Hi, > > On Tue, Mar 2, 2021 at 11:20 AM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> Ronald S. Bultje: >>> --- >>> libavformat/ivfenc.c | 11 --- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/libavformat/ivfenc.c b/libavf

[FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: add forgotten flags to mpeg4_options

2021-03-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/mpeg4videodec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index fd985f0430..43c2cf2dc3 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@ -35

[FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
--- libavformat/ivfenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 0951f56..889c004 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -23,7 +23,7 @@ typedef struct IVFEncContext { unsigned

[FFmpeg-devel] [PATCH 2/2] avcodec/mobiclip: Avoid undefined integer overflow in MV computation

2021-03-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 1 + 2147483647 cannot be represented in type 'int' Fixes: 30877/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-4775601145774080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: M

[FFmpeg-devel] [PATCH 1/2] avcodec/alsdec: Check bitstream input in read_block()

2021-03-02 Thread Michael Niedermayer
Fixes: Timeout Fixes: 28110/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5036338973507584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 4 1 file changed, 4 i

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Andreas Rheinhardt
Ronald S. Bultje: > --- > libavformat/ivfenc.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index 0951f56..889c004 100644 > --- a/libavformat/ivfenc.c > +++ b/libavformat/ivfenc.c > @@ -23,7 +23,7 @@ > > typed

Re: [FFmpeg-devel] [PATCH] mjpegdec: handle lowres with AVID cropping

2021-03-02 Thread James Almer
On 3/1/2021 6:13 AM, Anton Khirnov wrote: --- libavcodec/mjpegdec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 79c7d6e6cf..20f310fd70 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -4

Re: [FFmpeg-devel] [PATCH v3] avcodec/decode: port last_pkt_props to AVFifoBuffer

2021-03-02 Thread James Almer
On 3/1/2021 3:36 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/decode.c | 49 ++- libavcodec/internal.h | 4 ++-- libavcodec/utils.c| 26 +-- 3 files changed, 56 insertions(+), 23 deletions(-) Will apply

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Marton Balint
On Tue, 2 Mar 2021, Peter White wrote: On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although it is preferred. What they need to be i

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Peter White
On 02.03.21 23:15, Marton Balint wrote: On Tue, 2 Mar 2021, Peter White wrote: On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for decryption of HLS streams in MPEG-TS format protected using SAMPLE-AES encryption

2021-03-02 Thread Nachiket Tarate
On Mon, Mar 1, 2021 at 1:05 PM Steven Liu wrote: > > > > > 2021年3月1日 下午3:22,Nachiket Tarate 写道: > > > > On Mon, Mar 1, 2021 at 11:30 AM Steven Liu wrote: > >> > >> > >> > >>> 2021年3月1日 下午12:55,Nachiket Tarate 写道: > >>> > >>> This is an updated version of the patch in which I have added the chec