Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build warning for [-Wdiscarded-qualifiers]

2021-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Paul B > Mahol > Sent: 2021年2月26日 19:37 > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build > warning for [-Wdiscarded-qualifiers] > > l

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-27 Thread Carl Eugen Hoyos
Am Fr., 26. Feb. 2021 um 12:55 Uhr schrieb Paul B Mahol : > +static int decode_palette(GetByteContext *gb, uint32_t *pal) > +{ > +GetBitContext gbit; > + > +if (bytestream2_get_bytes_left(gb) < 18) > +return AVERROR_INVALIDDATA; > + > +memset(pal, 0, 16 * sizeof(*pal)); > +

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-27 Thread Paul B Mahol
On Sat, Feb 27, 2021 at 4:19 AM James Almer wrote: > On 2/26/2021 8:29 AM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 + > > libavcodec/codec_id.h | 1 + > > lib

Re: [FFmpeg-devel] [PATCH V2 1/7] libavdevice/v4l2.c: fix build warning for [-Wformat-truncation=]

2021-02-27 Thread Reimar Döffinger
> On 27 Feb 2021, at 06:37, Guo, Yejun wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Reimar >> D?ffinger >>> > > For the code in this function, max length of file name is fixed, see the code > below. > Anyway, it still increases the on-stack variable size which

[FFmpeg-devel] [PATCH] avcodec/x86: add cfhdenc SIMD

2021-02-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cfhdencdsp.c | 3 + libavcodec/x86/Makefile | 2 + libavcodec/x86/cfhdencdsp.asm| 435 +++ libavcodec/x86/cfhdencdsp_init.c | 48 4 files changed, 488 insertions(+) create mode 100644 libavcode

Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/protocols.c: fix build warning for [-Wdiscarded-qualifiers]

2021-02-27 Thread Reimar Döffinger
> On 27 Feb 2021, at 09:14, Guo, Yejun wrote: > > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Paul B >> Mahol >> Sent: 2021年2月26日 19:37 >> To: FFmpeg development discussions and patches >> Cc: Guo, Yejun >> Subject: Re: [FFmpeg-devel] [PATCH V3 3/5] libavformat/proto

Re: [FFmpeg-devel] [PATCH] avcodec/x86: add cfhdenc SIMD

2021-02-27 Thread James Almer
On 2/27/2021 11:05 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavcodec/cfhdencdsp.c | 3 + libavcodec/x86/Makefile | 2 + libavcodec/x86/cfhdencdsp.asm| 435 +++ libavcodec/x86/cfhdencdsp_init.c | 48 4 files change

Re: [FFmpeg-devel] [PATCH] avcodec/x86: add cfhdenc SIMD

2021-02-27 Thread Paul B Mahol
On Sat, Feb 27, 2021 at 3:33 PM James Almer wrote: > On 2/27/2021 11:05 AM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/cfhdencdsp.c | 3 + > > libavcodec/x86/Makefile | 2 + > > libavcodec/x86/cfhdencdsp.asm| 435 +

Re: [FFmpeg-devel] [PATCH] Handle AVID MJPEG streams directly in the MJPEG decoder.

2021-02-27 Thread Michael Niedermayer
On Wed, Feb 24, 2021 at 11:25:42AM +0100, Anton Khirnov wrote: > AVID streams - currently handled by the AVRN decoder - can be (depending > on extradata contents) either MJPEG or raw video. To decode the MJPEG > variant, the AVRN decoder currently instantiates a MJPEG decoder > internally and forwa

Re: [FFmpeg-devel] [PATCH] Handle AVID MJPEG streams directly in the MJPEG decoder.

2021-02-27 Thread James Almer
On 2/27/2021 1:33 PM, Michael Niedermayer wrote: On Wed, Feb 24, 2021 at 11:25:42AM +0100, Anton Khirnov wrote: AVID streams - currently handled by the AVRN decoder - can be (depending on extradata contents) either MJPEG or raw video. To decode the MJPEG variant, the AVRN decoder currently insta

Re: [FFmpeg-devel] [PATCH] avformat/movenccenc: Fix memory leak for muxing CENC-encrypted files

2021-02-27 Thread Вадим Бездушный
Ping. This patch is very trivial and solves memory leak which makes CENC encryption quite hard to use on high load services. вс, 31 янв. 2021 г. в 16:52, Vadym Bezdushnyi : > Signed-off-by: Vadym Bezdushnyi > --- > Memory for auxillary_info was not freed after usage. > > Leak can be reproduced

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avrndec: remove max_lowres value

2021-02-27 Thread Carl Eugen Hoyos
Am Sa., 27. Feb. 2021 um 15:25 Uhr schrieb James Almer : > > ffmpeg | branch: master | James Almer | Sat Feb 27 > 00:12:18 2021 -0300| [0c902a61471a2f45e1c7159bd77146d2b499abb3] | committer: > James Almer > > avcodec/avrndec: remove max_lowres value > > The decoder does not support lowres since

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/avrndec: remove max_lowres value

2021-02-27 Thread James Almer
On 2/27/2021 3:11 PM, Carl Eugen Hoyos wrote: Am Sa., 27. Feb. 2021 um 15:25 Uhr schrieb James Almer : ffmpeg | branch: master | James Almer | Sat Feb 27 00:12:18 2021 -0300| [0c902a61471a2f45e1c7159bd77146d2b499abb3] | committer: James Almer avcodec/avrndec: remove max_lowres value The dec

Re: [FFmpeg-devel] [PATCH 2/3] avdevice/timefilter: remove obsolete comments from the docs

2021-02-27 Thread Marton Balint
On Sun, 7 Feb 2021, Nicolas George wrote: Marton Balint (12021-02-07): Also rename the parameters of the function to match with the implementation. Signed-off-by: Marton Balint --- libavdevice/timefilter.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) Probably ok,

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avf_showcqt: use av_gettime_relative() instead of av_gettime()

2021-02-27 Thread Marton Balint
On Sun, 7 Feb 2021, Marton Balint wrote: av_gettime_relative() is using the monotonic clock therefore more suitable for relative time calculations. Applied. Regards, Marton Signed-off-by: Marton Balint --- libavfilter/avf_showcqt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: add support for getting product version number metadata

2021-02-27 Thread Marton Balint
On Sat, 20 Feb 2021, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 3 +++ tests/ref/fate/mxf-d10-user-comments | 1 + tests/ref/fate/mxf-probe-dnxhd | 1 + 3 files changed, 5 insertions(+) Ping, will apply soon. Thanks, Marton diff --git

Re: [FFmpeg-devel] [PATCH 1/5] avdevice/alsa_dec: do not set codecpar frame_size

2021-02-27 Thread Marton Balint
On Sun, 21 Feb 2021, Marton Balint wrote: Constant frame size is not guaranteed if the read call interrupted by a signal, or if non-blocking mode is used. Ping for the series. Thanks, Marton Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 1 - 1 file changed, 1 deletion(-) dif

Re: [FFmpeg-devel] [PATCH] avformat/movenccenc: Fix memory leak for muxing CENC-encrypted files

2021-02-27 Thread Marton Balint
On Sat, 27 Feb 2021, Вадим Бездушный wrote: Ping. This patch is very trivial and solves memory leak which makes CENC encryption quite hard to use on high load services. Thanks, applied. Regards, Marton вс, 31 янв. 2021 г. в 16:52, Vadym Bezdushnyi : Signed-off-by: Vadym Bezdushnyi --

[FFmpeg-devel] [PATCH 2/2] avformat/samidec: Deallocate hdr_buf

2021-02-27 Thread Michael Niedermayer
Fixes: memleak Fixes: 30841/clusterfuzz-testcase-minimized-ffmpeg_dem_SAMI_fuzzer-4521799196999680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/samidec.c | 2 ++ 1 file changed, 2 insertio

[FFmpeg-devel] [PATCH 1/2] avformat/mvi: Check audio size for more overflows

2021-02-27 Thread Michael Niedermayer
Fixes: left shift of negative value -352256000 Fixes: 30837/clusterfuzz-testcase-minimized-ffmpeg_dem_MVI_fuzzer-5755626262888448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mvi.c | 4 +++

Re: [FFmpeg-devel] [PATCH] Handle AVID MJPEG streams directly in the MJPEG decoder.

2021-02-27 Thread James Almer
On 2/27/2021 1:37 PM, James Almer wrote: On 2/27/2021 1:33 PM, Michael Niedermayer wrote: On Wed, Feb 24, 2021 at 11:25:42AM +0100, Anton Khirnov wrote: AVID streams - currently handled by the AVRN decoder - can be (depending on extradata contents) either MJPEG or raw video. To decode the MJPEG

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-27 Thread Andriy Gelman
On Mon, 22. Feb 17:53, sgerwk-at-aol@ffmpeg.org wrote: > Hi, > > On Sun, 21 Feb 2021, Andriy Gelman wrote: > > Hi, > > > > Thanks for updating the patch. Sorry for the delay in getting you some > > feedback.. > > > > When I tested with -show_mouse 1 -show_region 1 -window_id xx, the mouse a

[FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-27 Thread Andreas Rheinhardt
The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 and reinterprets it as a double via av_int2double. This does not work on big endian systems. So swap it to native endianness before av_int2double. law-and-order-partial.wtv from the FATE-suite exhibited the problem. Thanks-to: Andri

Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-27 Thread Peter Ross
On Sun, Feb 28, 2021 at 04:01:21AM +0100, Andreas Rheinhardt wrote: > The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 > and reinterprets it as a double via av_int2double. This does not > work on big endian systems. So swap it to native endianness before > av_int2double. > > law-an